[PATCH] Staging: comedi: fix line over 80 charcter issue in cb_pcidda.c

2011-08-16 Thread Ravishankar
From: Ravishankar This is a patch to the ni_labpc.c file that fixes up a line over 80 charcter warning found by the checkpatch.pl tool Signed-off-by: Ravishankar --- drivers/staging/comedi/drivers/cb_pcidda.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/driver

Re: [PATCH 4/9] Staging: Winbond: Convert C99 style comments in Winbond.

2011-08-16 Thread Pekka Enberg
On 8/17/11 12:38 AM, Gábor Stefanik wrote: 2011/8/16 Pekka Enberg: 2011/8/16 Gábor Stefanik: - -// -// Internal variable for module -// +/* +/* wb3

Re: [PATCH 4/9] Staging: Winbond: Convert C99 style comments in Winbond.

2011-08-16 Thread Akshay Joshi
Sorry about that, everyone. I'll roll a fix in the next few hours. Akshay On Tue, Aug 16, 2011 at 5:43 PM, Dan Carpenter wrote: > On Wed, Aug 17, 2011 at 12:24:06AM +0300, Pekka Enberg wrote: >> 2011/8/16 Gábor Stefanik : >> >> - >> >> -// >> >> -// Internal v

Digital Photo Editing Services - Photo Cutout

2011-08-16 Thread Rick
You are receiving this email because we wish you to use our digital photo editing services. Digital Photo Editing Services: We are a China based Imaging Professionals. We offer basic and advanced digital photo Editing services and solutions like photo Cutout, morphological photo Editing, photo

Re: [PATCH 4/9] Staging: Winbond: Convert C99 style comments in Winbond.

2011-08-16 Thread Dan Carpenter
On Wed, Aug 17, 2011 at 12:24:06AM +0300, Pekka Enberg wrote: > 2011/8/16 Gábor Stefanik : > >> - > >> -// > >> -// Internal variable for module > >> -// > >> +/*=

Re: [PATCH 4/9] Staging: Winbond: Convert C99 style comments in Winbond.

2011-08-16 Thread Gábor Stefanik
2011/8/16 Gábor Stefanik : > 2011/8/16 Pekka Enberg : >> 2011/8/16 Gábor Stefanik : - -// -// Internal variable for module -// +/*

Re: [PATCH 4/9] Staging: Winbond: Convert C99 style comments in Winbond.

2011-08-16 Thread Gábor Stefanik
2011/8/16 Pekka Enberg : > 2011/8/16 Gábor Stefanik : >>> - >>> -// >>> -// Internal variable for module >>> -// >>> +/* >>> +/* wb35rx.h -- >>> +/*===

Re: [PATCH 4/9] Staging: Winbond: Convert C99 style comments in Winbond.

2011-08-16 Thread Pekka Enberg
2011/8/16 Gábor Stefanik : >> - >> -// >> -// Internal variable for module >> -// >> +/* >> +/* wb35rx.h -- >> +/*=

Re: [PATCH 01/14] staging: brcm80211: use wait queues instead of semaphores in wl_cfg80211.c

2011-08-16 Thread Rafał Miłecki
2011/8/12 Franky Lin : > On 08/12/2011 09:44 AM, Arend van Spriel wrote: >> >> On 08/12/2011 04:07 PM, Rafał Miłecki wrote: >>> >>> 2011/8/12 Arend van Spriel: @@ -3537,27 +3544,39 @@ static s32 brcmf_event_handler(void *data)                         (struct brcmf_cfg80211_priv *)dat

Re: [PATCH 4/9] Staging: Winbond: Convert C99 style comments in Winbond.

2011-08-16 Thread Gábor Stefanik
On Tue, Aug 16, 2011 at 2:24 AM, Akshay Joshi wrote: > Converted all of the C99 style comments in the Winbond driver to the > kernel-accepted multiline stlye. > > Signed-off-by: Akshay Joshi > --- >  drivers/staging/winbond/wb35rx_f.h |    6 +- >  drivers/staging/winbond/wb35rx_s.h |   51 +++

Re: [PATCHv2 1/3] staging: bcm: fix coding style warnings and errors reported by checkpatch.pl tool

2011-08-16 Thread Kevin McKinney
Dan, On Tue, Aug 16, 2011 at 1:29 PM, Dan Carpenter wrote: > Looks good.  Thanks for redoing these. No problem!! Thanks for your help Dan!! > Reviewed-by: Dan Carpenter > > ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdrive

Re: [PATCHv2 01/14] staging: brcm80211: use wait queues instead of semaphores in wl_cfg80211.c

2011-08-16 Thread Dan Carpenter
On Fri, Aug 12, 2011 at 09:09:31PM +0200, Arend van Spriel wrote: > > Or have people vote which version they prefer. I prefer v2. > It doesn't really matter either way, but I prefer the original one. Checkpatch.pl only cares about if statements. This is fairly idiomatic C. After all we wouldn

Re: [PATCHv2 1/3] staging: bcm: fix coding style warnings and errors reported by checkpatch.pl tool

2011-08-16 Thread Dan Carpenter
Looks good. Thanks for redoing these. Reviewed-by: Dan Carpenter regards, dan carpenter ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Re: mailing list web interface

2011-08-16 Thread Greg KH
On Tue, Aug 16, 2011 at 09:38:26AM -0700, Greg KH wrote: > On Tue, Aug 16, 2011 at 12:58:10PM +0200, Arend van Spriel wrote: > > Hi Greg, > > > > I use a filter in my email reader to limit the messages coming in. > > From time to time I peek at the list on the web using the URL below: > > > > htt

[PATCH 1/9] Staging: Winbond: Fix case statements in wb35reg.c.

2011-08-16 Thread Akshay Joshi
Split the case statement and the code that is executed if the condition is met so that it passes checkpatch.pl and conforms to the kernel code style. Signed-off-by: Akshay Joshi --- drivers/staging/winbond/wb35reg.c | 105 1 files changed, 70 insertions(+),

[PATCH 0/3] Staging: cx25821: fix style issues

2011-08-16 Thread Leonid V. Fedorenchik
This patch series fixes various coding style issues in drivers/staging/cx25821 ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Re: Marvell D2Plug

2011-08-16 Thread Belisko Marek
On Mon, Jun 6, 2011 at 3:08 PM, saeed bishara wrote: >>> cpu specific: >>> - add support for openocd >>> - add support for iperf/oprofile >>> arch specific: >>> - soc clocks >>> - idt clock generator driver >>> - power management (cpuidle, cprufreq, suspend to dram, suspend to disk) >> >> So all o

Re: Hyper-V driver patches

2011-08-16 Thread Greg KH
On Thu, Aug 11, 2011 at 05:09:45PM -0700, K. Y. Srinivasan wrote: > > Greg, > > Some weeks ago, I had sent out a fairly large patch-set for your > consideration. > I know you are very busy; however, I am getting a little nervous since I have > not heard from you. You sent those patches after t

Re: [PATCH 5/9] Staging: Winbond: Fix spacing issues for spaces before tabs.

2011-08-16 Thread Pekka Enberg
On Tue, Aug 16, 2011 at 3:24 AM, Akshay Joshi wrote: > Fix the spaces-before-tabs issues that occur within the Winbond driver > code. > > Signed-off-by: Akshay Joshi Reviewed-by: Pekka Enberg ___ devel mailing list devel@linuxdriverproject.org http://

[PATCH 12/15] staging: brcm80211: remove mips specific include from dma.c

2011-08-16 Thread Arend van Spriel
The include has been removed as it is not needed. None of the definitions from it are used in the source file. Tested on BCM63281. Reviewed-by: Henry Ptasinski Reviewed-by: Pieter-Paul Giesberts Tested-by: Jonas Gorski Signed-off-by: Arend van Spriel --- drivers/staging/brcm80211/brcmsmac/d

Re: Hyper-V driver patches

2011-08-16 Thread Greg KH
On Fri, Aug 12, 2011 at 10:50:50AM -0700, Greg KH wrote: > On Thu, Aug 11, 2011 at 05:09:45PM -0700, K. Y. Srinivasan wrote: > > > > Greg, > > > > Some weeks ago, I had sent out a fairly large patch-set for your > > consideration. > > I know you are very busy; however, I am getting a little ner

[PATCHv2 3/3] staging: bcm: fix memory leak in Bcmchar.c file

2011-08-16 Thread kmckinney2
commit 78cfe85eac64c553278719f691e743969aadf1f2 Author: Kevin McKinney Date: Sun Aug 14 21:11:13 2011 -0400 Staging: bcm: Fix memory leak reported during compile. This patch fixes a potential memory leak were temp_buff buffer is not being freed when a certain condition is true.

Re: [PATCH 01/14] staging: brcm80211: use wait queues instead of semaphores in wl_cfg80211.c

2011-08-16 Thread Rafał Miłecki
2011/8/12 Arend van Spriel : > @@ -3537,27 +3544,39 @@ static s32 brcmf_event_handler(void *data) >                        (struct brcmf_cfg80211_priv *)data; >        struct sched_param param = {.sched_priority = MAX_RT_PRIO - 1 }; >        struct brcmf_cfg80211_event_q *e; > +       DECLARE_WAITQ

[PATCH] staging: ft1000: fix build failure

2011-08-16 Thread Sergei Trofimovich
Found on allmodconfig build (ARCH=alpha) drivers/staging/ft1000/ft1000-pcmcia/ft1000.h: In function 'ft1000_read_reg': drivers/staging/ft1000/ft1000-pcmcia/ft1000.h:80: error: implicit declaration of function 'inw' drivers/staging/ft1000/ft1000-pcmcia/ft1000.h: In function 'ft1000_w

Re: [PATCH 4/9] Staging: Winbond: Convert C99 style comments in Winbond.

2011-08-16 Thread Pekka Enberg
On Tue, Aug 16, 2011 at 3:24 AM, Akshay Joshi wrote: > Converted all of the C99 style comments in the Winbond driver to the > kernel-accepted multiline stlye. > > Signed-off-by: Akshay Joshi Reviewed-by: Pekka Enberg ___ devel mailing list devel@linux

[PATCH v2] Staging: cx25821: fix coding style issues

2011-08-16 Thread Leonid V. Fedorenchik
Fix too long lines in cx25821-audio.h Fix wrong brace placement in cx25821-cards.c, cx25821-core.c, and cx25821-i2c.c Use DEFINE_PCI_DEVICE_TABLE for cx25821_pci_tbl. Move EXPORT_SYMBOL(cx25821_set_gpiopin_direction) to the right place. Delete file cx25821-gpio.h since it is not used. Get rid of ty

RE: Hyper-V driver patches

2011-08-16 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@suse.de] > Sent: Friday, August 12, 2011 5:24 PM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; devel@linuxdriverproject.org; > virtualizat...@lists.osdl.org > Subject: Re: Hyper-V driver patches > > On Fri, Aug 12, 2011 at 10:

[PATCH 03/15] staging: brcm80211: replaced void pointers in otp functions

2011-08-16 Thread Arend van Spriel
From: Roland Vossen Code cleanup. Otp is 'One Time Programmable' functionality. Replaced void pointers by less generic pointer types. Reported-by: Julian Calaby Reviewed-by: Pieter-Paul Giesberts Signed-off-by: Arend van Spriel --- drivers/staging/brcm80211/brcmsmac/otp.c | 90

[PATCH 2/5] staging: vme: keep track of registered buses

2011-08-16 Thread Manohar Vanga
This patch adds a list which keeps track of all registered VME buses. This is required for adding refcounting later to bridge modules, something that is not currently implemented. This is based on the changes introduced by Emilio G. Cota in the patch: https://lkml.org/lkml/2010/10/25/486 Sig

[PATCH 4/9] Staging: Winbond: Convert C99 style comments in Winbond.

2011-08-16 Thread Akshay Joshi
Converted all of the C99 style comments in the Winbond driver to the kernel-accepted multiline stlye. Signed-off-by: Akshay Joshi --- drivers/staging/winbond/wb35rx_f.h |6 +- drivers/staging/winbond/wb35rx_s.h | 51 ++-- drivers/staging/winbond/wb35tx.c | 92 ++

Re: [PATCH 02/14] staging: brcm80211: remove iovar IOV_BLOCKSIZE in brcmfmac

2011-08-16 Thread Rafał Miłecki
2011/8/12 Arend van Spriel : > @@ -273,7 +270,6 @@ extern int brcmf_sdioh_interrupt_deregister(struct > sdioh_info *sd) >  /* IOVar table */ >  enum { >        IOV_MSGLEVEL = 1, > -       IOV_BLOCKSIZE, >        IOV_NUMINTS, >        IOV_DEVREG, >        IOV_HCIREGS, You are forcing IOV_MSGLEVEL

[PATCHv2 2/3] staging: bcm: move extern declaration from Bcmchar.c file into headers.h file reported by checkpatch.pl tool

2011-08-16 Thread kmckinney2
commit 9c474c6d3d993748c07135acf8c4a40e693a56f0 Author: Kevin McKinney Date: Sun Aug 14 21:05:01 2011 -0400 Staging: bcm: Fix a coding style error reported by checkpatch.pl Tool checkpatch.pl reported the following error: extern struct class *bcm_class;" declaration not allowed in

[PATCH 2/2] Staging: comedi: fix printk issue in cb_pcidda.c

2011-08-16 Thread Ravishankar
From: root This is a patch to the cb_pcidda.c file that fixes up a printk warning found by the checkpatch.pl tool Signed-off-by: Ravishankar --- drivers/staging/comedi/drivers/cb_pcidda.c | 29 +--- 1 files changed, 14 insertions(+), 15 deletions(-) diff --git a/dri

[PATCH 07/14] staging: brcm80211: absorb brcmf_sdioh_interrupt_register into brcmf_sdcard_intr_reg

2011-08-16 Thread Arend van Spriel
From: Franky Lin brcmfmac wrapper function cleanup Reviewed-by: Arend van Spriel Signed-off-by: Arend van Spriel --- drivers/staging/brcm80211/brcmfmac/bcmsdh.c | 22 ++- drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c | 43 - drivers/staging/brcm80211/

[PATCH 00/15] staging: brcm80211: big-endian support and cleanup

2011-08-16 Thread Arend van Spriel
This patch series fixes several issues found on big-endian platform (Sparc, PowerPC, and MIPS) and some changes to code specific to broadcom MIPS platforms. Other patches are cleanup items to get rid of void pointer usage in the drivers. This series applies to staging-next and depends on the follo

Re:

2011-08-16 Thread jeffrice
I have a business proposal for you worth 7.5Million Great British Pound Sterling's. If you are interested, please send a response. Best regards, Jeff Rice. ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mail

[PATCH 14/15] staging: brcm80211: restrict MIPS dma bug workaround to BCM47XX

2011-08-16 Thread Arend van Spriel
The inline function dma_spin_for_len() was defined for MIPS platforms but the problem only occurs with dma of the PCI core in bcm47xx chips. This patch restricts the function further to BCM47XX platforms only. Tested on BCM63281. Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Henry Ptasinski R

Re: [PATCH 5/5] staging: vme: make match() driver specific to improve non-VME64x support

2011-08-16 Thread Emilio G. Cota
On Fri, Aug 12, 2011 at 12:30:51 +0200, Manohar Vanga wrote: > +++ b/drivers/staging/vme/vme.c (snip) > +static int __vme_register_driver(struct vme_driver *drv, unsigned int ndevs) > { > - int i; > - struct vme_dev *vdev; > - > + struct vme_bridge *bridge; > + int err = 0; > > -

[PATCHv2 3/3] staging: bcm: fix memory leak in Bcmchar.c file

2011-08-16 Thread Kevin McKinney
commit 78cfe85eac64c553278719f691e743969aadf1f2 Author: Kevin McKinney Date: Sun Aug 14 21:11:13 2011 -0400 Staging: bcm: Fix memory leak reported during compile. This patch fixes a potential memory leak were temp_buff buffer is not being freed when a certain condition is true.

Re: [PATCH 2/3] Staging: cx25821: fix style issues in cx25821-video-upstream-ch2

2011-08-16 Thread Joe Perches
On Sun, 2011-08-14 at 19:42 +0800, Leonid V. Fedorenchik wrote: > Fix long lines in files cx25821-video-upstream-ch2.{c,h} > Change obscure line endings to less obscure ones. > Delete whitespace characters before labels. [] > diff --git a/drivers/staging/cx25821/cx25821-video-upstream-ch2.c > b/dr

[PATCH 01/15] staging: brcm80211: got rid of several void pointers for softmac PCI

2011-08-16 Thread Arend van Spriel
From: Roland Vossen Code cleanup. Replace void * related to PCI functionality by less generic pointer types. Reported-by: Julian Calaby Reviewed-by: Pieter-Paul Giesberts Signed-off-by: Arend van Spriel --- drivers/staging/brcm80211/brcmsmac/aiutils.c | 10 +++-- drivers/staging/brcm80211/

[PATCH 5/9] Staging: Winbond: Fix spacing issues for spaces before tabs.

2011-08-16 Thread Akshay Joshi
Fix the spaces-before-tabs issues that occur within the Winbond driver code. Signed-off-by: Akshay Joshi --- drivers/staging/winbond/wb35reg.c |2 +- drivers/staging/winbond/wb35reg_s.h |2 +- drivers/staging/winbond/wb35rx_f.h |6 +++--- drivers/staging/winbond/wb35rx_s.h |6

[PATCH 9/9] Staging: Winbond: Reposition a curly bracket.

2011-08-16 Thread Akshay Joshi
The curly bracket preceding the body of a conditional statement should be on the same line as the conditional statement according to the kernel's coding style. Signed-off-by: Akshay Joshi --- drivers/staging/winbond/wb35tx.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --gi

[PATCH 10/14] staging: brcm80211: remove dead code from dhd_sdio.c

2011-08-16 Thread Arend van Spriel
From: Franky Lin Code cleanup for brcmfmac Reviewed-by: Arend van Spriel Reviewed-by: Roland Vossen Signed-off-by: Arend van Spriel --- drivers/staging/brcm80211/brcmfmac/dhd_sdio.c | 222 +--- 1 files changed, 47 insertions(+), 175 deletions(-) diff --git a/drivers/sta

Re: [PATCH 1/3] drivers/staging/rtl8187se: Don't pass huge struct by value

2011-08-16 Thread Stephen Rothwell
Hi all, On Sat, 13 Aug 2011 01:04:36 +0200 (CEST) Jesper Juhl wrote: > > From: Jesper Juhl > Date: Sat, 13 Aug 2011 00:51:40 +0200 > > struct ieee80211_network is fairly large (more than half a kilobyte), > so let's pass a pointer instead of passing the entire structure by > value when ieee802

[PATCH] Staging: comedi: fix printk issue in

2011-08-16 Thread Ravishankar
From: Ravishankar This is a patch to the das08_cs.c file that fixes up a printk warning found by the checkpatch.pl tool Signed-off-by: Ravishankar --- drivers/staging/comedi/drivers/das08_cs.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/come

Dysfunctional zcache in 3.0.0 (Re: zcache: rename zcache.c to avoid build problem)

2011-08-16 Thread Milan Plžík
 Hello,  in linux-3.0, zcache doesn't build correctly -- due to error in Makefile, zcache.o is omitted from linking. This results in kernel containing tmem.o but not zcache.o linked, and thus no zcache functionality.  This issue (and also a patch) was previously mentioned at https://patchwork.ker

Re: [PATCH 3/5] staging: vme: add functions for bridge module refcounting

2011-08-16 Thread Emilio G. Cota
On Fri, Aug 12, 2011 at 12:30:49 +0200, Manohar Vanga wrote: > This patch adds functions that allow for reference counting > bridge modules. The patch introduces the functions > 'vme_bridge_get()' and 'vme_bridge_put()'. > > The functions are automatically called during .probe and .remove > for dr

Re: [PATCH 8/9] Staging: Winbond: Use tabs instead of spaces for indents.

2011-08-16 Thread Pekka Enberg
On Tue, Aug 16, 2011 at 3:24 AM, Akshay Joshi wrote: > Replace some space indented lines with tab indented lines to follow the > kernel code style. > > Signed-off-by: Akshay Joshi Reviewed-by: Pekka Enberg ___ devel mailing list devel@linuxdriverproje

Re: [PATCH 2/9] Staging: Winbond: Fix pointer style in wb35tx.c.

2011-08-16 Thread Pekka Enberg
On Tue, Aug 16, 2011 at 3:24 AM, Akshay Joshi wrote: > Pointers should be prefixed with a single space according to the kernel > coding style. > > Signed-off-by: Akshay Joshi Reviewed-by: Pekka Enberg ___ devel mailing list devel@linuxdriverproject.or

Re: [PATCH 00/14] staging: brcm80211: brcmfmac driver cleanup

2011-08-16 Thread Rafał Miłecki
W dniu 13 sierpnia 2011 09:47 użytkownik Arend van Spriel napisał: > On 08/12/2011 10:04 PM, Rafał Miłecki wrote: >> >> W dniu 12 sierpnia 2011 18:32 użytkownik Arend van Spriel >>  napisał: >>> >>> On 08/12/2011 04:02 PM, Rafał Miłecki wrote: 2011/8/12 Arend van Spriel: > > Sev

[PATCH 02/15] staging: brcm80211: replaced void pointers in dma functions

2011-08-16 Thread Arend van Spriel
From: Roland Vossen Code cleanup. Replaced by less generic pointer types. Reported-by: Julian Calaby Reviewed-by: Pieter-Paul Giesberts Signed-off-by: Arend van Spriel --- drivers/staging/brcm80211/brcmsmac/dma.c | 31 +++-- drivers/staging/brcm80211/brcmsmac/dma.h

[PATCH 15/15] staging: brcm80211: removed unused MIPS specific SDRAM swap window

2011-08-16 Thread Arend van Spriel
From: Roland Vossen Certain Mips based, big endian Broadcom products contain a memory window for endianness swap purposes. However, this is too system specific for this driver as there are more big endian platforms to support. Thus, this 'window' functionality is not to be used and can be removed

Hello dear.

2011-08-16 Thread Chris Jefferson
Good Day To You, I am sorry for contacting you through this medium without a previous notice. My name is Attorney Chris Jefferson Advocate and legal consultant, I had a client, a contractor based here in Malaysia, now deceased. a result of a heart-related condition on March 12th 2008, His hea

Re: [PATCH 00/14] staging: brcm80211: brcmfmac driver cleanup

2011-08-16 Thread Arend van Spriel
On 08/12/2011 04:02 PM, Rafał Miłecki wrote: 2011/8/12 Arend van Spriel: Several cleanup patches to reduce code for the brcmfmac driver and get rid of a remaining checkpatch warning. The driver sources should be clear from checkpatch issue now. This series applies to staging-next and depends on

Re: [PATCH 00/14] staging: brcm80211: brcmfmac driver cleanup

2011-08-16 Thread Hauke Mehrtens
On 08/12/2011 04:02 PM, Rafał Miłecki wrote: > 2011/8/12 Arend van Spriel : >> Several cleanup patches to reduce code for the brcmfmac driver and >> get rid of a remaining checkpatch warning. The driver sources should >> be clear from checkpatch issue now. >> >> This series applies to staging-next

Re: [PATCH 01/14] staging: brcm80211: use wait queues instead of semaphores in wl_cfg80211.c

2011-08-16 Thread Larry Finger
On 08/12/2011 01:59 PM, Franky Lin wrote: If you are refering to this line >>> + } while ((e = brcmf_deq_event(cfg_priv))); The extra parentheses are added to fix a compiler warning: drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c: In function ‘brcmf_event_handler’: drivers/staging/brcm80211/b

[PATCH 2/9] Staging: Winbond: Fix pointer style in wb35tx.c.

2011-08-16 Thread Akshay Joshi
Pointers should be prefixed with a single space according to the kernel coding style. Signed-off-by: Akshay Joshi --- drivers/staging/winbond/wb35tx.c | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/winbond/wb35tx.c b/drivers/st

[PATCH 8/8] Staging: hv: vmbus: Get rid of an unnecessary check in vmbus_connect()

2011-08-16 Thread K. Y. Srinivasan
Get rid of an unnecessary check in vmbus_connect(). Since vmbus_connect is only called once, the check being removed is redundant. Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang --- drivers/staging/hv/connection.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff

[PATCH] staging: solo6x10/enc: fix build failure

2011-08-16 Thread Sergei Trofimovich
Found on allmodconfig build (ARCH=alpha) drivers/staging/solo6x10/enc.c: In function 'solo_capture_config': drivers/staging/solo6x10/enc.c:101: error: implicit declaration of function 'kzalloc' Signed-off-by: Sergei Trofimovich Cc: Ben Collins Cc: Greg Kroah-Hartman Cc: "Krzysztof Hał

Re: [patch] rtl8712: don't just return -EFAULT in wpa_supplicant_ioctl()

2011-08-16 Thread Ali Bahar
On Sat, Aug 06, 2011 at 07:27:48AM -0700, Dan Carpenter wrote: > There were some curly braces missing so the original code in > wpa_supplicant_ioctl() pretty much always returned -EFAULT without > doing anything. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/staging/rtl8712/rtl871x_i

[PATCH 06/15] staging: brcm80211: remove W_SM and R_SM macros from dma.c

2011-08-16 Thread Arend van Spriel
The macros W_SM and R_SM are not doing much conversion of the macro parameters and complicate code readability without good cause. It is more clear to remove usage of the macros expanding it in the source code. Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Henry Ptasinski Reviewed-by: Roland V

[PATCH 6/8] Staging: hv: vmbus: Get rid of some dated/redundant comments

2011-08-16 Thread K. Y. Srinivasan
Get rid of some dated/redundant comments. Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang --- drivers/staging/hv/vmbus_drv.c | 12 +--- 1 files changed, 1 insertions(+), 11 deletions(-) diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c index 2

[PATCH 01/14] staging: brcm80211: use wait queues instead of semaphores in wl_cfg80211.c

2011-08-16 Thread Arend van Spriel
In wl_cfg80211.c two semaphores were used to trigger a task to process an event. The wait queues are better suited for that purpose. This also removes checkpatch warning on sema_init() calls in this source file. Reviewed-by: Roland Vossen Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel

[PATCH] staging: rts_pstor: dont cast void* from kmalloc()

2011-08-16 Thread Thomas Meyer
From: Thomas Meyer Casting (void *) value returned by kmalloc is useless as mentioned in Documentation/CodingStyle, Chap 14. The semantic patch that makes this output is available in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci. More information about semantic patching is available

[PATCHv2 01/14] staging: brcm80211: use wait queues instead of semaphores in wl_cfg80211.c

2011-08-16 Thread Arend van Spriel
In wl_cfg80211.c two semaphores were used to trigger a task to process an event. The wait queues are better suited for that purpose. This also removes checkpatch warning on sema_init() calls in this source file. Reviewed-by: Rafal Milecki Reviewed-by: Roland Vossen Reviewed-by: Franky Lin Signe

[PATCH 1/3] drivers/staging/rtl8187se: Don't pass huge struct by value

2011-08-16 Thread Jesper Juhl
From: Jesper Juhl Date: Sat, 13 Aug 2011 00:51:40 +0200 struct ieee80211_network is fairly large (more than half a kilobyte), so let's pass a pointer instead of passing the entire structure by value when ieee80211_is_54g() and ieee80211_is_shortslot() need to look at a few members. Also remove pa

Re: [PATCH 2/3] drivers/staging/rtl8192e: Don't pass huge struct by value

2011-08-16 Thread Larry Finger
On 08/12/2011 06:04 PM, Jesper Juhl wrote: From: Jesper Juhl Date: Sat, 13 Aug 2011 00:52:32 +0200 struct ieee80211_network is fairly large (more than half a kilobyte), so let's pass a pointer instead of passing the entire structure by value when ieee80211_is_54g() and ieee80211_is_shortslot() n

[PATCH] Staging: comedi: fix printk warning issue cb_das16_cs.c

2011-08-16 Thread Ravishankar
From: root This is a patch to the cb_das16_cs.c file that fixes up a printk() warning found by the checkpatch.pl tool Signed-off-by: Ravishankar --- drivers/staging/comedi/drivers/cb_das16_cs.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drive

[PATCH 5/8] Staging: hv: vmbus: Fixup indentation in vmbus_acpi_add()

2011-08-16 Thread K. Y. Srinivasan
Fixup some indentation issues in vmbus_acpi_add(). Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang --- drivers/staging/hv/vmbus_drv.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c index

[PATCH] staging: tidspbridge: dont cast void* from kmalloc()

2011-08-16 Thread Thomas Meyer
From: Thomas Meyer Casting (void *) value returned by kmalloc is useless as mentioned in Documentation/CodingStyle, Chap 14. The semantic patch that makes this output is available in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci. More information about semantic patching is available

[GIT PATCH] STAGING fixes for 3.1

2011-08-16 Thread Greg KH
Here are a number of minor staging driver fixes for your 3.1 tree. Full details are below, nothing really major, but lots of build fixes for stuff people have reported. Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/gregkh/staging-2.6.git/ staging-linus All patches have b

Re: [PATCH 07/14] staging: brcm80211: absorb brcmf_sdioh_interrupt_register into brcmf_sdcard_intr_reg

2011-08-16 Thread Rafał Miłecki
2011/8/12 Arend van Spriel : > +       BRCMF_TRACE(("brcmf: ***IRQHandler\n")); > +       BRCMF_TRACE(("%s: Entering\n", __func__)); I guess I'd be way easier to modify your macro instead of having to remember about double braces every time (assuming there are needed at all). -- Rafał _

Re: [PATCH] staging: ft1000: fix build failure

2011-08-16 Thread Greg KH
On Mon, Aug 15, 2011 at 06:18:33AM +0300, Sergei Trofimovich wrote: > On Sun, 14 Aug 2011 15:23:51 -0700 > Greg KH wrote: > > > On Sun, Aug 14, 2011 at 11:52:53PM +0300, Sergei Trofimovich wrote: > > > Found on allmodconfig build (ARCH=alpha) > > > > > > drivers/staging/ft1000/ft1000-pcmcia/

[PATCH] staging: solo6x10/g723: fix build failure

2011-08-16 Thread Sergei Trofimovich
Found on allmodconfig build (ARCH=alpha) drivers/staging/solo6x10/g723.c: In function 'snd_solo_pcm_open': drivers/staging/solo6x10/g723.c:139: error: implicit declaration of function 'kzalloc' Signed-off-by: Sergei Trofimovich Cc: Ben Collins Cc: Greg Kroah-Hartman Cc: "Krzysztof Hał

Re: [PATCHv2 01/14] staging: brcm80211: use wait queues instead of semaphores in wl_cfg80211.c

2011-08-16 Thread Arend van Spriel
On 08/12/2011 09:05 PM, Arend van Spriel wrote: In wl_cfg80211.c two semaphores were used to trigger a task to process an event. The wait queues are better suited for that purpose. This also removes checkpatch warning on sema_init() calls in this source file. Reviewed-by: Rafal Milecki Reviewed-

[PATCH 12/14] staging: brcm80211: remove unused parameter from data interface in fullmac

2011-08-16 Thread Arend van Spriel
From: Franky Lin Remove redundant complete function pointer in send/recv buffer interface. Reviewed-by: Arend van Spriel Reviewed-by: Roland Vossen Signed-off-by: Arend van Spriel --- drivers/staging/brcm80211/brcmfmac/bcmsdh.c| 10 +-- drivers/staging/brcm80211/brcmfmac/dhd_sdio.c

Re: [PATCH] staging: ft1000: fix build failure

2011-08-16 Thread Greg KH
On Sun, Aug 14, 2011 at 11:52:53PM +0300, Sergei Trofimovich wrote: > Found on allmodconfig build (ARCH=alpha) > > drivers/staging/ft1000/ft1000-pcmcia/ft1000.h: In function > 'ft1000_read_reg': > drivers/staging/ft1000/ft1000-pcmcia/ft1000.h:80: error: implicit > declaration of function

[PATCH 00/14] staging: brcm80211: brcmfmac driver cleanup

2011-08-16 Thread Arend van Spriel
Several cleanup patches to reduce code for the brcmfmac driver and get rid of a remaining checkpatch warning. The driver sources should be clear from checkpatch issue now. This series applies to staging-next and depends on the following patch set: Message-ID: <1312811946-16713-1-git-send-email-ar

mailing list web interface

2011-08-16 Thread Arend van Spriel
Hi Greg, I use a filter in my email reader to limit the messages coming in. From time to time I peek at the list on the web using the URL below: http://driverdev.linuxdriverproject.org/pipermail/devel/2011-August/date.html However, this list does not seem to be updated since last Wednesday. I

Re: [PATCH 01/14] staging: brcm80211: use wait queues instead of semaphores in wl_cfg80211.c

2011-08-16 Thread Arend van Spriel
On 08/12/2011 06:44 PM, Arend van Spriel wrote: On 08/12/2011 04:07 PM, Rafał Miłecki wrote: 2011/8/12 Arend van Spriel: @@ -3537,27 +3544,39 @@ static s32 brcmf_event_handler(void *data) (struct brcmf_cfg80211_priv *)data; struct sched_param param = {.sched_pr

Re: [PATCH 3/9] Staging: Winbond: Fix space issues in wb35tx.c.

2011-08-16 Thread Pekka Enberg
On Tue, Aug 16, 2011 at 3:24 AM, Akshay Joshi wrote: > Issues with spaces (such as not having spaces inside of square brackets, > etc.) were fixed in the wb35tx.c file. > > Signed-off-by: Akshay Joshi Reviewed-by: Pekka Enberg ___ devel mailing list d

[PATCH 3/3] Staging: cx25821: fix style issues in cx25821-video-upstream

2011-08-16 Thread Leonid V. Fedorenchik
Fix too long lines in files cx25821-video-upstream.{c,h} Signed-off-by: Leonid V. Fedorenchik --- drivers/staging/cx25821/cx25821-video-upstream.c | 16 ++--- drivers/staging/cx25821/cx25821-video-upstream.h | 65 ++ 2 files changed, 48 insertions(+), 33 deletions(-) dif

Re: [PATCH 3/5] staging: vme: add functions for bridge module refcounting

2011-08-16 Thread Emilio G. Cota
On Mon, Aug 15, 2011 at 12:05:03 +0200, Manohar Vanga wrote: > > If the driver doesn't provide a .probe, we would still increment > > the refcount of the bridge module. Is that reasonable? I dunno. (snip) > I picked this default behaviour from the PCI driver code > (drivers/pci/pci-driver.c): > >

[PATCH 7/8] Staging: hv: vmbus: Fix a bug in error handling in vmbus_bus_init()

2011-08-16 Thread K. Y. Srinivasan
Fix a bug in error handling in vmbus_bus_init(). Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang --- drivers/staging/hv/vmbus_drv.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c index f2

[PATCH] staging: solo6x10/p2m: fix build failure

2011-08-16 Thread Sergei Trofimovich
Found on allmodconfig build (ARCH=alpha) drivers/staging/solo6x10/p2m.c: In function 'solo_p2m_dma_t': drivers/staging/solo6x10/p2m.c:52: error: implicit declaration of function 'kzalloc' Signed-off-by: Sergei Trofimovich Cc: Ben Collins Cc: Greg Kroah-Hartman Cc: "Krzysztof Hałasa"

Re: [PATCH 1/9] Staging: Winbond: Fix case statements in wb35reg.c.

2011-08-16 Thread Pekka Enberg
On Tue, Aug 16, 2011 at 3:24 AM, Akshay Joshi wrote: > Split the case statement and the code that is executed if the condition > is met so that it passes checkpatch.pl and conforms to the kernel code > style. > > Signed-off-by: Akshay Joshi Reviewed-by: Pekka Enberg

[PATCH 3/5] staging: vme: add functions for bridge module refcounting

2011-08-16 Thread Manohar Vanga
This patch adds functions that allow for reference counting bridge modules. The patch introduces the functions 'vme_bridge_get()' and 'vme_bridge_put()'. The functions are automatically called during .probe and .remove for drivers. This patch is based on the changes introduced by Emilio G. Cota i

Re: [PATCH 00/14] staging: brcm80211: brcmfmac driver cleanup

2011-08-16 Thread Arend van Spriel
On 08/12/2011 10:04 PM, Rafał Miłecki wrote: W dniu 12 sierpnia 2011 18:32 użytkownik Arend van Spriel napisał: On 08/12/2011 04:02 PM, Rafał Miłecki wrote: 2011/8/12 Arend van Spriel: Several cleanup patches to reduce code for the brcmfmac driver and get rid of a remaining checkpatch warnin

[PATCH 3/3] drivers/staging/rtl8192u: Don't pass huge struct by value

2011-08-16 Thread Jesper Juhl
From: Jesper Juhl Date: Sat, 13 Aug 2011 00:53:07 +0200 struct ieee80211_network is fairly large (more than half a kilobyte), so let's pass a pointer instead of passing the entire structure by value when ieee80211_is_54g() and ieee80211_is_shortslot() need to look at a few members. Also remove pa

[PATCH 07/15] staging: brcm80211: remove PHYSADDR macro from dma.c

2011-08-16 Thread Arend van Spriel
Four macros with PHYSADDR name prefix are not doing a lot and complicate code readability. These have been expanded in the source code and consequently removed the definitions. Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Henry Ptasinski Reviewed-by: Roland Vossen Signed-off-by: Arend van Sp

[PATCH v2 1/3] Staging: cx25821: fix style issues in cx25821-audio-upstream

2011-08-16 Thread Leonid V. Fedorenchik
Fix long lines in cx25821-audio-upstream.c and cx25821-audio-upstream.h Change obscure line endings to less obscure ones. Signed-off-by: Leonid V. Fedorenchik --- drivers/staging/cx25821/cx25821-audio-upstream.c | 33 - drivers/staging/cx25821/cx25821-audio-upstream.h |

[PATCH v2 0/3] Staging: cx25821: fix style issues

2011-08-16 Thread Leonid V. Fedorenchik
This patch series fixes various coding style issues in drivers/staging/cx25821 -- drivers/staging/cx25821/cx25821-audio-upstream.c | 33 +++- drivers/staging/cx25821/cx25821-audio-upstream.h |9 ++- .../staging/cx25821/cx25821-video-upstream-ch2.c | 86 --- .../st

Hello dear.

2011-08-16 Thread Chris Jefferson
Good Day To You, I am sorry for contacting you through this medium without a previous notice. My name is Attorney Chris Jefferson Advocate and legal consultant, I had a client, a contractor based here in Malaysia, now deceased. a result of a heart-related condition on March 12th 2008, His hea

[PATCH] staging: rts_pstor: dont cast void* from kmalloc()

2011-08-16 Thread Thomas Meyer
From: Thomas Meyer Casting (void *) value returned by kmalloc is useless as mentioned in Documentation/CodingStyle, Chap 14. The semantic patch that makes this output is available in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci. More information about semantic patching is available

Re: [PATCH 2/8] staging: nvec: coding style fixes / add copyrightnotice

2011-08-16 Thread Marc Dietrich
Hi Joe, On Sunday 07 August 2011 22:15:59 Joe Perches wrote: > On Sun, 2011-08-07 at 18:03 +0200, Marc Dietrich wrote: > > This patch fixes coding style and adds copyright notices. > > Does rather more than that. > > > + /* VK_OEM_102 */ > > + KEY_102ND, > > I think this style of comment is

[PATCH 1/5] staging: vme: make [alloc|free]_consistent bridge specific

2011-08-16 Thread Manohar Vanga
Make PCI dependent functions ([alloc|free]_consistent() in 'vme.c') bridge specific. By removing the dependency of the VME bridge framework on PCI, this patch allows for addition of non-PCI based VME bridges. Signed-off-by: Manohar Vanga --- drivers/staging/vme/bridges/vme_ca91cx42.c | 24

Re: brcmsmac driver only works when sitting next to the AP

2011-08-16 Thread Dan Williams
On Tue, 2011-08-16 at 13:36 +0200, Roland Vossen wrote: > Hello Camaleón, > > So the first problem that you encounter is that scan does not work. Lets > dive into that first. > > I see in the log that you sent: > > 'Aug 14 13:39:02 stt300 NetworkManager[1181]: > supplicant_interface_acquire: a

Re: [PATCH 01/14] staging: brcm80211: use wait queues instead of semaphores in wl_cfg80211.c

2011-08-16 Thread Johannes Berg
On Fri, 2011-08-12 at 20:55 +0200, Arend van Spriel wrote: > >>> + } while ((e = brcmf_deq_event(cfg_priv))); > >> if (care_coding_style) > >> fix(); > >> > >> :-) > >> > > I assume you refer to the indents above. Not sure what exactly happened > > there, but the patch email

[PATCH 7/9] Staging: Winbond: Fix parentheses in returns.

2011-08-16 Thread Akshay Joshi
Removes parentheses when calling return, since return is not a function. Signed-off-by: Akshay Joshi --- drivers/staging/winbond/phy_calibration.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/winbond/phy_calibration.c b/drivers/staging/winbond/phy_

  1   2   >