Stephen,
Can you please fix your e-mail client / system / whatever so that your
patch series are no longer sent duplicated?
On Thu, 1 Sep 2011 16:04:27 -0600, Stephen Warren wrote:
> Some devices use a single pin as both an IRQ and a GPIO. In that case,
> irq_gpio is the GPIO ID for that pin. No
Fix long lines in cx25821-video-upstream-ch2.h
Signed-off-by: Leonid V. Fedorenchik
---
.../staging/cx25821/cx25821-video-upstream-ch2.h | 83 ++--
1 files changed, 60 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-video-upstream-ch2.h
b/drivers
Fix long lines in cx25821-video-upstream.h
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-video-upstream.h | 78 +++---
1 files changed, 54 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-video-upstream.h
b/drivers/staging
Delete whitespace characters before labels.
Signed-off-by: Leonid V. Fedorenchik
---
.../staging/cx25821/cx25821-video-upstream-ch2.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-video-upstream-ch2.c
b/drivers/staging/cx25821/cx
Replace :? operator by if-else equivalent where it improves readability.
Signed-off-by: Leonid V. Fedorenchik
---
.../staging/cx25821/cx25821-video-upstream-ch2.c | 23 ++-
1 files changed, 12 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-video-
Fix long lines in cx25821-audio-upstream.h
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-audio-upstream.h |9 +++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-audio-upstream.h
b/drivers/staging/cx25821/cx2582
Fix long lines in cx25821-video-upstream.c
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-video-upstream.c | 16 ++--
1 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-video-upstream.c
b/drivers/staging/cx2582
Fix long lines in cx25821-video-upstream-ch2.c
Signed-off-by: Leonid V. Fedorenchik
---
.../staging/cx25821/cx25821-video-upstream-ch2.c | 26 +++-
1 files changed, 9 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-video-upstream-ch2.c
b/drivers/
Change obscure line endings to less obscure ones. Rationale: improve
readability.
Signed-off-by: Leonid V. Fedorenchik
---
.../staging/cx25821/cx25821-video-upstream-ch2.c | 24 +++
1 files changed, 9 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/cx25821/cx2582
Fix wrong brace placement and statement indent in cx25821-i2c.c
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-i2c.c | 30 +++---
1 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-i2c.c
b/drivers/
Fix long lines in cx25821-audio-upstream.c
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-audio-upstream.c | 10 +++---
1 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-audio-upstream.c
b/drivers/staging/cx25821/cx258
Fix wrong brace placement and statement indent in cx25821-core.c
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-core.c | 500
1 files changed, 250 insertions(+), 250 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-core.c
b/d
Change obscure line endings to less obscure ones. Rationale: more
readable.
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-audio-upstream.c | 25 --
1 files changed, 9 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-aud
Use DEFINE_PCI_DEVICE_TABLE for cx25821_pci_tbl
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-core.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-core.c
b/drivers/staging/cx25821/cx25821-core.c
index 8e8a56d
Get rid of typedef in cx25821.h
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821.h |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821.h
b/drivers/staging/cx25821/cx25821.h
index 6230243..a282592 100644
--- a/dr
Fix wrong brace placement and statement indent in cx25821-cards.c
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-cards.c | 26 +-
1 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-cards.c
b/driver
Fix too long lines in cx25821-audio.h
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-audio.h |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-audio.h
b/drivers/staging/cx25821/cx25821-audio.h
index 2771725..8
Rename _audio_upstream_channel_select to _audio_upstream_channel in
in struct cx25821_dev in cx25821.h and all usages of that struct member
as well, because _audio_upstream_channel_select is seems to be too long
for a variable name.
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx2582
Move EXPORT_SYMBOL(cx25821_set_gpiopin_direction) to the right place.
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-core.c |1 -
drivers/staging/cx25821/cx25821-gpio.c |1 +
2 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/cx25821/
Delete file cx25821-gpio.h since it is not used.
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-gpio.h |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
delete mode 100644 drivers/staging/cx25821/cx25821-gpio.h
diff --git a/drivers/staging/cx25821/cx25821-gp
This patch series fixes some style issues in drivers/staging/cx25821
I split my previous patches per logical change and combined them into
one patch series.
Changes in v4 based on reviews of v3.
Leonid V. Fedorenchik (19):
Staging: cx25821: Get rid of typedef in cx25821.h
Staging: cx25821: R
Do you need a loan Apply now with rate 3% replay to this email
edithloa...@yahoo.com
Personal Requirements Details:
* Loan Amount Required:
* Loan Purpose:
* Country:
* Name:
* Duration:
* Age:
* Phone Number:*
*Please repaly to this E=mail:edithloa...@yahoo.com
crs.lend@blumail.org
__
Convert all the printk(KERN_) messages in the driver to pr_()
and use pr_fmt to provide the module name.
Signed-off-by: H Hartley Sweeten
Cc: Greg Kroah-Hartman
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
---
diff --git a/drivers/staging/dt3155v4l/dt3155v4l.c
b/drivers/staging/dt3155v4l/dt31
On Thu, 2011-09-01 at 17:01 -0500, Seth Jennings wrote:
> I was seeing n as the number of allocations. Since
> XCF_MAX_BLOCKS_PER_ALLOC and XCF_NUM_FREELISTS are constant (i.e.
> not increasing with the number of allocations) wouldn't it be
> O(1)?
It's the difference between your implementation
On 08/31/2011 02:46 PM, Dan Magenheimer wrote:
>> This patchset introduces a new memory allocator for persistent
>> pages for zcache. The current allocator is xvmalloc. xvmalloc
>> has two notable limitations:
>> * High (up to 50%) external fragmentation on allocation sets > PAGE_SIZE/2
>> * No c
Patches 1 and 2 are hunky dory. This one still needs a bit of work,
but not much really. See below.
All in all this is good stuff, keep it up!
Emilio
On Thu, Sep 01, 2011 at 11:15:26 +0200, Manohar Vanga wrote:
> For jumper based boards (non VME64x), there is no mechanism
> for d
On Thu, Sep 01, 2011 at 03:11:09PM -0700, Mike Sterling wrote:
> If a LUN larger than 2 TB is attached to a Linux VM on Hyper-V, we currently
> report a maximum size of 2 TB. This patch resolves the issue in hv_storvsc.
> Thanks to Robert Scheck for reporting the issue.
>
> Reported-by: Robert
Some devices use a single pin as both an IRQ and a GPIO. In that case,
irq_gpio is the GPIO ID for that pin. Not all drivers use this feature.
Where they do, and the use of this feature is optional, and the system
wishes to disable this feature, this field must be explicitly set to a
defined invali
Fix ak8975_probe() to jump to the appropriate exit labels when an error
occurs. With the previous code, some cleanup actions were being skipped
for some error conditions.
Signed-off-by: Stephen Warren
---
drivers/staging/iio/magnetometer/ak8975.c |2 +-
1 files changed, 1 insertions(+), 1 de
Tegra doesn't have irq_to_gpio() any more, and ak8975 is included in
tegra_defconfig. This causes a build failure.
Instead, obtain the GPIO ID corresponding to the chip's IRQ from the new
i2c_client field irq_gpio.
Signed-off-by: Stephen Warren
---
drivers/staging/iio/magnetometer/ak8975.c |
gpio_is_valid() is the defined mechanism to determine whether a GPIO is
valid. Use this instead of assuming that 0 is an invalid GPIO.
Signed-off-by: Stephen Warren
---
drivers/staging/iio/magnetometer/ak8975.c | 11 +--
1 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/dr
Fix ak8975_probe() to jump to the appropriate exit labels when an error
occurs. With the previous code, some cleanup actions were being skipped
for some error conditions.
Signed-off-by: Stephen Warren
---
drivers/staging/iio/magnetometer/ak8975.c |2 +-
1 files changed, 1 insertions(+), 1 de
Some devices use a single pin as both an IRQ and a GPIO. In that case,
irq_gpio is the GPIO ID for that pin. Not all drivers use this feature.
Where they do, and the use of this feature is optional, and the system
wishes to disable this feature, this field must be explicitly set to a
defined invali
Some devices use a single pin as both an IRQ and a GPIO. In that case,
irq_gpio is the GPIO ID for that pin. Not all drivers use this feature.
Where they do, and the use of this feature is optional, and the system
wishes to disable this feature, this field must be explicitly set to a
defined invali
gpio_is_valid() is the defined mechanism to determine whether a GPIO is
valid. Use this instead of assuming that 0 is an invalid GPIO.
Signed-off-by: Stephen Warren
---
drivers/staging/iio/magnetometer/ak8975.c | 11 +--
1 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/dr
Some devices use a single pin as both an IRQ and a GPIO. In that case,
irq_gpio is the GPIO ID for that pin. Not all drivers use this feature.
Where they do, and the use of this feature is optional, and the system
wishes to disable this feature, this field must be explicitly set to a
defined invali
Tegra doesn't have irq_to_gpio() any more, and ak8975 is included in
tegra_defconfig. This causes a build failure.
Instead, obtain the GPIO ID corresponding to the chip's IRQ from the new
i2c_client field irq_gpio.
Signed-off-by: Stephen Warren
---
drivers/staging/iio/magnetometer/ak8975.c |
On 09/01/2011 11:54 AM, Dave Hansen wrote:
> On Thu, 2011-09-01 at 11:33 -0500, Seth Jennings wrote:
>> xcfmalloc is also 0(1) in that the number of freelists
>> at that have to be checked is constant and not increasing
>> with the number of allocations. The constant hidden
>> in the O(1) for find
On Fri, Sep 02, 2011 at 12:24:13AM +0300, Maxin B. John wrote:
> --- a/drivers/staging/iio/light/tsl2563.c
> +++ b/drivers/staging/iio/light/tsl2563.c
> @@ -225,9 +225,9 @@ static int tsl2563_read_id(struct tsl2563_chip *chip, u8
> *id)
>
> ret = i2c_smbus_read_byte_data(client, TSL2563_CM
If a LUN larger than 2 TB is attached to a Linux VM on Hyper-V, we currently
report a maximum size of 2 TB. This patch resolves the issue in hv_storvsc.
Thanks to Robert Scheck for reporting the issue.
Reported-by: Robert Scheck
Signed-off-by: Mike Sterling
Signed-off-by: K.Y. Srinivasan
Sig
CC [M] drivers/staging/iio/light/tsl2563.o
drivers/staging/iio/light/tsl2563.c: In function 'tsl2563_probe':
drivers/staging/iio/light/tsl2563.c:736: warning: 'id' may be used
uninitialized in this function
Also fixes the tsl2563_read_id().
Signed-off-by: Maxin B. John
---
diff --git a/drive
> -Original Message-
> From: Greg KH [mailto:g...@kroah.com]
> Sent: Thursday, September 01, 2011 4:31 PM
> To: KY Srinivasan
> Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> devel@linuxdriverproject.org; virtualizat...@lists.osdl.org
> Subject: Re: Hyper-V TODO file
>
> On Thu, Sep
On Thu, Sep 01, 2011 at 02:11:52PM -0700, Mike Sterling wrote:
> If a LUN larger than 2 TB is attached to a Linux VM on Hyper-V, we currently
> report a maximum size of 2 TB. This patch resolves the issue in hv_storvsc.
> Thanks to Robert Scheck for reporting the issue.
>
> Signed-off-by: Mike
> -Original Message-
> From: Greg KH [mailto:g...@kroah.com]
> Sent: Thursday, September 01, 2011 4:28 PM
> To: KY Srinivasan
> Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> devel@linuxdriverproject.org; virtualizat...@lists.osdl.org
> Subject: Re: Hyper-V TODO file
>
> On Wed, Aug
If a LUN larger than 2 TB is attached to a Linux VM on Hyper-V, we currently
report a maximum size of 2 TB. This patch resolves the issue in hv_storvsc.
Thanks to Robert Scheck for reporting the issue.
Signed-off-by: Mike Sterling
Signed-off-by: K.Y. Srinivasan
Signed-off-by: Haiyang Zhang
-
On Wed, Aug 31, 2011 at 07:11:39PM -0400, Peter Foley wrote:
> On Wed, 31 Aug 2011, K. Y. Srinivasan wrote:
> > Greg, as I have been pestering you for some time now, we are very
> > interested in
> > exiting staging and we are willing to dedicate the necessary development
> > resources to address
On Thu, Sep 01, 2011 at 01:27:33PM -0700, Greg KH wrote:
> On Wed, Aug 31, 2011 at 03:16:51PM -0700, K. Y. Srinivasan wrote:
> > 2) With your help, we have fixed all of the issues related to these drivers
> > conforming to the Linux Device Driver model. One of the TODO work items is
> > "audit the
On Wed, Aug 31, 2011 at 03:16:51PM -0700, K. Y. Srinivasan wrote:
>
> Greg,
>
> The TODO file for Hyper-V drivers has not been updated in a while and does
> not reflect the current state of these drivers:
>
> 1) There are no more checkpatch warnings/errors in this code. One of the TODO
> work it
Re-order the code in netvsc_probe() to prevent a guest crash caused by
packets possibly received from NetVSP before call to register_netdev().
Signed-off-by: Haiyang Zhang
Signed-off-by: K. Y. Srinivasan
---
drivers/staging/hv/netvsc_drv.c | 32 +---
1 files change
Fix the return status, so the upper layer will retry if transmission
fails.
Signed-off-by: Haiyang Zhang
Signed-off-by: K. Y. Srinivasan
---
drivers/staging/hv/netvsc_drv.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/hv/netvsc_drv.c b/drivers/st
In rndis_filter_receive_data(), we need to drop the 0th page and move the
rest of pages forward if the rndis data go across page boundary, otherwise
the page offset will overflow.
Signed-off-by: Haiyang Zhang
Signed-off-by: K. Y. Srinivasan
---
drivers/staging/hv/rndis_filter.c | 10 +
Signed-off-by: Haiyang Zhang
Signed-off-by: K. Y. Srinivasan
---
drivers/staging/hv/netvsc.c | 58 +-
1 files changed, 29 insertions(+), 29 deletions(-)
diff --git a/drivers/staging/hv/netvsc.c b/drivers/staging/hv/netvsc.c
index 9a9228c..ef764e6 100644
Reported-by: Joe Perches
Signed-off-by: Haiyang Zhang
Signed-off-by: K. Y. Srinivasan
---
drivers/staging/hv/netvsc.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/hv/netvsc.c b/drivers/staging/hv/netvsc.c
index efbc8a0..115629f 100644
--- a/drivers
netif_notify_peers() caused a kernel warning in netvsc_linkstatus_callback(),
because netvsc_linkstatus_callback() is within IRQ context. So we move
the first call to netif_notify_peers() into queued work as well, but with
zero delay.
In addition to "staging-next", this should also be back-ported
If the packet failed to be sent, we shouldn't count it as the
number of outstanding sends.
Signed-off-by: Haiyang Zhang
Signed-off-by: K. Y. Srinivasan
---
drivers/staging/hv/netvsc.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/hv/netvsc.c b/driver
Because the number of available buffer slots doesn't decrease for failed
sends, we should not call netvsc_xmit_completion(), which increase the
count of available slots. In this failed case, just free the memory is
enough.
Signed-off-by: Haiyang Zhang
Signed-off-by: K. Y. Srinivasan
---
drivers
Signed-off-by: Haiyang Zhang
Signed-off-by: K. Y. Srinivasan
---
drivers/staging/hv/netvsc.c | 68 +
drivers/staging/hv/rndis_filter.c | 17 +
2 files changed, 49 insertions(+), 36 deletions(-)
diff --git a/drivers/staging/hv/netvsc.c b/driv
hyperv.h is included by hyperv_net.h already, so no need to include it
again in these C files.
Signed-off-by: Haiyang Zhang
Signed-off-by: K. Y. Srinivasan
---
drivers/staging/hv/netvsc.c |1 -
drivers/staging/hv/netvsc_drv.c |1 -
drivers/staging/hv/rndis_filter.c |1 -
3 f
Fixed a set of bugs in netvsc module, and cleaned up some coding style issues.
Haiyang Zhang (10):
staging: hv: remove unnecessary includes in netvsc
staging: hv: add newline to log messages in netvsc
staging: hv: convert dev_ to netdev_ in netvsc
staging: hv: fix a kernel warning in netvs
On Thursday 01 September 2011 10:52:37 Stephen Warren wrote:
> Some devices use a single pin as both an IRQ and a GPIO. In that case,
> irq_gpio is the GPIO ID for that pin. Not all drivers use this feature.
> Where they do, and the use of this feature is optional, and the system
> wishes to disabl
On Thu, Sep 01, 2011 at 10:52:41AM -0600, Stephen Warren wrote:
> Some devices use a single pin as both an IRQ and a GPIO. In that case,
> irq_gpio is the GPIO ID for that pin. Not all drivers use this feature.
> Where they do, and the use of this feature is optional, and the system
> wishes to dis
Signed-off-by: Larry Finger
---
drivers/staging/rtl8192e/rtl819x_BAProc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c
b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 95b7859..8a5c5ff 100644
--- a/drivers/staging/rtl8192e/r
Smatch reports the following:
CHECK drivers/staging/rtl8192e/r8192E_phy.c
drivers/staging/rtl8192e/r8192E_phy.c +940 rtl8192_phy_SwChnlStepByStep(92)
error: potential null derefence 'CurrentCmd'.
Signed-off-by: Larry Finger
---
V2 - no changes
---
drivers/staging/rtl8192e/r8192E_phy.c |
Smatch outputs the following warning:
CHECK drivers/staging/rtl8192e/rtl819x_BAProc.c
drivers/staging/rtl8192e/rtl819x_BAProc.c +88 rtllib_ADDBA(12) warn: variable
dereferenced before check 'ieee'
As ieee cannot be NULL at this point, remove all such checks.
Signed-off-by: Larry Finger
---
Smatch reports the follwing warnings:
CHECK drivers/staging/rtl8192e/rtllib_rx.c
drivers/staging/rtl8192e/rtllib_rx.c +552 RxReorderIndicatePacket(6) warn:
'prxbIndicateArray' puts 1024 bytes on stack
CHECK drivers/staging/rtl8192e/rtl819x_TSProc.c
drivers/staging/rtl8192e/rtl819x_TSProc
Smatch reports the following problems:
CHECK drivers/staging/rtl8192e/rtllib_softmac.c
drivers/staging/rtl8192e/rtllib_softmac.c +3143 rtllib_softmac_free(4) info:
redundant null check on ieee->pDot11dInfo calling kfree()
CHECK drivers/staging/rtl8192e/rtllib_module.c
drivers/staging/rtl
Smatch reports the following warning:
CHECK drivers/staging/rtl8192e/rtl_wx.c
drivers/staging/rtl8192e/rtl_wx.c +262 r8192se_wx_set_radio(16) warn:
inconsistent returns sem:&priv->wx_sem: locked (258) unlocked (262)
Signed-off-by: Larry Finger
---
V2 - no changes
---
drivers/staging/rtl8
Smatch reports the following informational output:
CHECK drivers/staging/rtl8192e/r8192E_dev.c
drivers/staging/rtl8192e/r8192E_dev.c +2404 ActUpdateChannelAccessSetting(13)
info: ignoring unreachable code.
drivers/staging/rtl8192e/r8192E_dev.c +2404 ActUpdateChannelAccessSetting(13)
info: ig
Smatch outputs the following informational message:
CHECK drivers/staging/rtl8192e/r8192E_cmdpkt.c
drivers/staging/rtl8192e/r8192E_cmdpkt.c +419 cmpk_message_handle_rx(77) info:
ignoring unreachable code.
Signed-off-by: Larry Finger
---
V2 - no changes
---
drivers/staging/rtl8192e/r8192E_
Smatch shows the following errors:
CHECK drivers/staging/rtl8192e/rtl_core.c
drivers/staging/rtl8192e/rtl_core.c +600 rtl8192_qos_activate(7) warn: variable
dereferenced before check 'priv'
drivers/staging/rtl8192e/rtl_core.c +1345 rtl8192_init(40) warn: 'dev->irq' was
not released on error
File rtl_core.c contains the statement "#define MOVE_INTO_HANDLER". As a
result, everything inside an "ifndef MOVE_INTO_HANDLER" is dead code and
can be removed.
Signed-off-by: Larry Finger
---
V2 - no changes
---
drivers/staging/rtl8192e/rtl_core.c | 22 --
1 files change
As stated in the subject, a number of smatch messages are addressed.
V2 addresses the questions raised by Dan Carpenter.
Signed-off-by: Larry Finger
---
Greg,
Once master.kernel.org is back up, I will push these to
git://git.kernel.org/pub/scm/linux/kernel/git/lwfinger/r8192E.git
Larry
---
On Thu, 2011-09-01 at 11:33 -0500, Seth Jennings wrote:
> xcfmalloc is also 0(1) in that the number of freelists
> at that have to be checked is constant and not increasing
> with the number of allocations. The constant hidden
> in the O(1) for finding a suitable block is NUM_FREELISTS.
The algor
gpio_is_valid() is the defined mechanism to determine whether a GPIO is
valid. Use this instead of assuming that 0 is an invalid GPIO.
Signed-off-by: Stephen Warren
---
drivers/staging/iio/magnetometer/ak8975.c | 11 +--
1 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/dr
Fix ak8975_probe() to jump to the appropriate exit labels when an error
occurs. With the previous code, some cleanup actions were being skipped
for some error conditions.
Signed-off-by: Stephen Warren
---
drivers/staging/iio/magnetometer/ak8975.c |2 +-
1 files changed, 1 insertions(+), 1 de
Tegra doesn't have irq_to_gpio() any more, and ak8975 is included in
tegra_defconfig. This causes a build failure.
Instead, obtain the GPIO ID corresponding to the chip's IRQ from the new
i2c_client field irq_gpio.
Signed-off-by: Stephen Warren
---
v2: Obtain eoc_gpio from i2c_client, instead of
Fix ak8975_probe() to jump to the appropriate exit labels when an error
occurs. With the previous code, some cleanup actions were being skipped
for some error conditions.
Signed-off-by: Stephen Warren
---
drivers/staging/iio/magnetometer/ak8975.c |2 +-
1 files changed, 1 insertions(+), 1 de
Tegra doesn't have irq_to_gpio() any more, and ak8975 is included in
tegra_defconfig. This causes a build failure.
Instead, obtain the GPIO ID corresponding to the chip's IRQ from the new
i2c_client field irq_gpio.
Signed-off-by: Stephen Warren
---
v2: Obtain eoc_gpio from i2c_client, instead of
gpio_is_valid() is the defined mechanism to determine whether a GPIO is
valid. Use this instead of assuming that 0 is an invalid GPIO.
Signed-off-by: Stephen Warren
---
drivers/staging/iio/magnetometer/ak8975.c | 11 +--
1 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/dr
Some devices use a single pin as both an IRQ and a GPIO. In that case,
irq_gpio is the GPIO ID for that pin. Not all drivers use this feature.
Where they do, and the use of this feature is optional, and the system
wishes to disable this feature, this field must be explicitly set to a
defined invali
Some devices use a single pin as both an IRQ and a GPIO. In that case,
irq_gpio is the GPIO ID for that pin. Not all drivers use this feature.
Where they do, and the use of this feature is optional, and the system
wishes to disable this feature, this field must be explicitly set to a
defined invali
On 09/01/2011 10:17 AM, Dan Magenheimer wrote:
>>> Do you have any data comparing xcfmalloc vs xvmalloc for
>>> compression ratio and/or performance (cycles to compress
>>> or decompress different pages) on a wide(r) range of data?
>>> Assuming xcfmalloc isn't "always better", maybe it would
>>> be
On Thursday 01 September 2011, Stephen Warren wrote:
> One question: When we add this field, how do drivers tell whether a value
> of 0 is an uninitialized field, or a legitimate GPIO value of 0? Should we
> add a flag to indicate validity, or just work hard to not enable driver-
> side code to use
On Wed, Aug 31, Olaf Hering wrote:
> After some more testing it looks like the hv_blkvsc driver claimed the
> ide major #3, so the ide_core could not bind to the emulated IDE
> hardware. The modprobe.conf rules prevented that ata_piix gets loaded.
> If I force a module load order of 'ata_piix ;hv_
On 08/31/2011 09:40 AM, Seth Jennings wrote:
> +static struct xcf_blkdesc *xcf_find_remove_block(struct xcf_pool *pool,
> + int size, int blocknum)
> +{
> + int flindex, i;
> + struct xcf_blkdesc *desc = NULL;
> +
> + flindex = xcf_size_to_flindex(size + sizeof(struct xcf_blkhdr));
Arnd Bergmann wrote at Thursday, September 01, 2011 5:07 AM:
> On Thursday 01 September 2011, Jonathan Cameron wrote:
> > On 08/31/11 20:45, Andrew Chew wrote:
> > >> Subject: [PATCH 1/3] staging:iio:magnetometer:ak8975 Don't
> > >> use irq_to_gpio()
> > >>
> > >> Tegra doesn't have irq_to_gpio() a
> > Do you have any data comparing xcfmalloc vs xvmalloc for
> > compression ratio and/or performance (cycles to compress
> > or decompress different pages) on a wide(r) range of data?
> > Assuming xcfmalloc isn't "always better", maybe it would
> > be best to allow the algorithm to be selectable?
adding watchdog ping to send ping/heartbeat to the the AMT watchdog client.
in addition removing the heartbeat sending from the driver timers function.
Version 2 - Removed two tab indent
Signed-off-by: Oren Weil
Acked-by: Tomas Winkler
---
drivers/staging/mei/interrupt.c | 27 ---
On Thursday 01 September 2011, Jonathan Cameron wrote:
> On 08/31/11 20:45, Andrew Chew wrote:
> >> Subject: [PATCH 1/3] staging:iio:magnetometer:ak8975 Don't
> >> use irq_to_gpio()
> >>
> >> Tegra doesn't have irq_to_gpio() any more, and ak8975 is included in
> >> tegra_defconfig. This causes a b
For jumper based boards (non VME64x), there is no mechanism
for detecting the card that is plugged into a specific slot. This
leads to issues in non-autodiscovery crates/cards when a card is
plugged into a slot that is "claimed" by a different driver. In
reality, there is no problem, but the driver
Instead of using a vanilla 'struct device' for VME devices, add new
'struct vme_dev'. Modifications have been made to the VME framework
API as well as all in-tree VME drivers.
The new vme_dev structure has the following advantages from the
current model used by the driver:
* Driver functions
Hi Greg, Martyn, Emilio,
This is the resend of the patches with additional code added to patch 3 to
remove devices in the case that a bridge driver is removed. (I don't know how
common it is to keep resending patchsets so I apologize for any noise I may
be causing).
Thanks
Manohar
Manohar Vanga
Change the static array of 'struct device''s in struct vme_bridge
to instead use an array of pointers. This is in accordance with the
requirement that all kobjects be dynamically allocated (see
Documentation/kobject.txt) and never be statically allocated.
Signed-off-by: Manohar Vanga
---
drivers
Macros impacting the code flow are sort of frowned upon. No other macro's
in the source code impact the code flow. Replaced macro by function.
Reported-by: Johannes Berg
Signed-off-by: Roland Vossen
Reviewed-by: Franky Lin
Reviewed-by: Arend van Spriel
Reviewed-by: Pieter-Paul Giesberts
---
Moved, deleted or substituted macro's.
Reported-by: Johannes Berg
Reviewed-by: Arend van Spriel
Reviewed-by: Pieter-Paul Giesberts
Signed-off-by: Roland Vossen
---
drivers/staging/brcm80211/brcmsmac/d11.h |5 ---
drivers/staging/brcm80211/brcmsmac/dma.c |2 -
drivers/s
Reported-by: Johannes Berg
Signed-off-by: Roland Vossen
---
drivers/staging/brcm80211/brcmsmac/antsel.c | 214 +--
1 files changed, 103 insertions(+), 111 deletions(-)
diff --git a/drivers/staging/brcm80211/brcmsmac/antsel.c
b/drivers/staging/brcm80211/brcmsmac/antsel.
From: Arend van Spriel
Some changes have been made to get rid of sparse warnings in the
source file mac80211_if.c.
Reported-by: Aaro Koskinen
Reviewed-by: Roland Vossen
Reviewed-by: Pieter-Paul Giesberts
Signed-off-by: Roland Vossen
---
drivers/staging/brcm80211/brcmsmac/mac80211_if.c |
From: Franky Lin
sdioh data mode is not used in brcmf_sdioh_request_buffer. The patch
removes the related code.
Reviewed-by: Roland Vossen
Reviewed-by: Arend van Spriel
Signed-off-by: Roland Vossen
---
drivers/staging/brcm80211/brcmfmac/bcmsdh.c | 15 ++-
drivers/staging/
From: Franky Lin
Use unify config marco for debug info. Related event debug print out can be
enabled/disabled by the dedicated event message level.
Reported-by: Johannes Berg
Reviewed-by: Roland Vossen
Reviewed-by: Arend van Spriel
Signed-off-by: Roland Vossen
---
drivers/staging/brcm80211/
Moved, deleted or substituted macro's.
Reported-by: Johannes Berg
Reviewed-by: Arend van Spriel
Reviewed-by: Pieter-Paul Giesberts
Signed-off-by: Roland Vossen
---
drivers/staging/brcm80211/brcmsmac/ampdu.c | 12 +-
drivers/staging/brcm80211/brcmsmac/main.c | 283 +
1 - 100 of 130 matches
Mail list logo
