On Fri, 2 Sep 2011 09:05:41 -0700
"Palash Bandyopadhyay" wrote:
> Thanks a lot Leonid. Changes look good to me.
My pleasure. Thank you for the review.
>
> Regards,
> Palash
>
> -Original Message-
> From: Leonid V. Fedorenchik [mailto:leonids...@gmail.com]
> Sent: Thursday, September 0
On Fri, 02 Sep 2011 11:55:28 +0800, "Leonid V. Fedorenchik" said:
> This patch series fixes some style issues in drivers/staging/cx25821
Happened to glance at a "Fix long lines" patch that actually improved
the code. That's sufficiently rare I decided to look at the whole series,
which all looks
> -Original Message-
> From: Greg KH [mailto:g...@kroah.com]
> Sent: Friday, September 02, 2011 3:58 PM
> To: KY Srinivasan
> Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> devel@linuxdriverproject.org; virtualizat...@lists.osdl.org
> Subject: Re: Hyper-V TODO file
>
> On Fri, Sep 0
Hello Joe,
> Please try to make code more readable when converting to functions too.
Good feedback. I will redo this particular patch [12/12] and keep this in mind
for the future. Expect a new patch coming Monday.
Thanks, Roland.
___
devel mailing lis
On Fri, Sep 02, 2011 at 07:47:12PM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Greg KH [mailto:g...@kroah.com]
> > Sent: Thursday, September 01, 2011 4:31 PM
> > To: KY Srinivasan
> > Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> > devel@linuxdriverproject.org;
> -Original Message-
> From: Greg KH [mailto:g...@kroah.com]
> Sent: Thursday, September 01, 2011 4:31 PM
> To: KY Srinivasan
> Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> devel@linuxdriverproject.org; virtualizat...@lists.osdl.org
> Subject: Re: Hyper-V TODO file
>
> On Thu, Sep
Jean Delvare wrote at Friday, September 02, 2011 3:25 AM:
> Hi Jonathan,
>
> On Fri, 02 Sep 2011 10:19:24 +0100, Jonathan Cameron wrote:
> > On 09/02/11 07:56, Jean Delvare wrote:
> > > Stephen,
> > >
> > > Can you please fix your e-mail client / system / whatever so that your
> > > patch series a
On Fri, Sep 02, 2011 at 05:53:37PM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Greg KH [mailto:gre...@suse.de]
> > Sent: Friday, September 02, 2011 12:36 PM
> > To: Olaf Hering
> > Cc: KY Srinivasan; linux-ker...@vger.kernel.org;
> > devel@linuxdriverproject.org;
> >
> -Original Message-
> From: Greg KH [mailto:gre...@suse.de]
> Sent: Friday, September 02, 2011 12:36 PM
> To: Olaf Hering
> Cc: KY Srinivasan; linux-ker...@vger.kernel.org; devel@linuxdriverproject.org;
> virtualizat...@lists.osdl.org
> Subject: Re: [PATCH] Staging: hv: vmbus: Show the m
> -Original Message-
> From: Olaf Hering [mailto:o...@aepfle.de]
> Sent: Friday, September 02, 2011 12:26 PM
> To: KY Srinivasan
> Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> devel@linuxdriverproject.org; virtualizat...@lists.osdl.org
> Subject: [PATCH] Staging: hv: vmbus: Show th
On Fri, Sep 02, Greg KH wrote:
> On Fri, Sep 02, 2011 at 06:25:56PM +0200, Olaf Hering wrote:
> > +#define VMBUS_ALIAS_LEN ((sizeof((struct hv_vmbus_device_id *)0)->guid) *
> > 2)
> > + char alias_name[VMBUS_ALIAS_LEN + 1];
>
> Is that too big to put on the stack? 64 bytes, right? Hm, mayb
On Fri, Sep 02, 2011 at 06:25:56PM +0200, Olaf Hering wrote:
> Show a modalias file in /sys/bus/vmbus/devices/*/
> Add a helper function to print the same content in modalias and uevent.
>
> Signed-off-by: Olaf Hering
Nice idea, thanks for this, one minor nit below:
> ---
> drivers/staging/hv/
Show a modalias file in /sys/bus/vmbus/devices/*/
Add a helper function to print the same content in modalias and uevent.
Signed-off-by: Olaf Hering
---
drivers/staging/hv/vmbus_drv.c | 21 -
1 file changed, 16 insertions(+), 5 deletions(-)
--- a/drivers/staging/hv/vmbus_
Thanks a lot Leonid. Changes look good to me.
Regards,
Palash
-Original Message-
From: Leonid V. Fedorenchik [mailto:leonids...@gmail.com]
Sent: Thursday, September 01, 2011 8:55 PM
To: Greg Kroah-Hartman
Cc: Mauro Carvalho Chehab; Ruslan Pisarev; Ilia Mirkin; Joe Perches; Palash
Bandyo
On Thu, Sep 01, 2011 at 01:30:31PM -0700, Greg KH wrote:
> On Thu, Sep 01, 2011 at 01:27:33PM -0700, Greg KH wrote:
> > On Wed, Aug 31, 2011 at 03:16:51PM -0700, K. Y. Srinivasan wrote:
> > > 2) With your help, we have fixed all of the issues related to these
> > > drivers
> > > conforming to the
On Fri, Sep 02, 2011 at 03:17:19PM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Greg KH [mailto:g...@kroah.com]
> > Sent: Thursday, September 01, 2011 4:31 PM
> > To: Peter Foley
> > Cc: KY Srinivasan; gre...@suse.de; Linux Kernel Mailing List;
> > devel@linuxdriverpro
On Friday 02 September 2011, Stephen Warren wrote:
> The idea was specifically to replace the need to call irq_to_gpio(i2c->irq).
> If we did just rename it plain "gpio" and allow it to be used for anything,
> then that does indeed start looking more like device-specific platform data.
>
> I guess
Hey Matt,
I was going to play with using the USB IP implementation using a Linux
host and a Windows guest. Got everything working right under Linux, but the
moment I tried to use the Windows drivers I got this:
usbipd: info: starting usbipd (usbip-utils 1.1.1)
usbipd: info: listening on 0.0.0.0:3
On Fri, 2011-09-02 at 16:00 +0200, Roland Vossen wrote:
> Substituted macro.
[]
> diff --git a/drivers/staging/brcm80211/brcmsmac/srom.c
> b/drivers/staging/brcm80211/brcmsmac/srom.c
[]
> @@ -792,6 +780,14 @@ static const struct brcms_sromvar perpath_pci_sromvars[]
> = {
>
> static u8 srom_crc
Based on input from Greg, update the TODO file.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
---
drivers/staging/hv/TODO |7 ++-
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/hv/TODO b/drivers/staging/hv/TODO
index 582fd4a..7c9a93f 100644
Jonathan Cameron wrote at Friday, September 02, 2011 2:48 AM:
> On 09/01/11 17:52, Stephen Warren wrote:
> > Some devices use a single pin as both an IRQ and a GPIO. In that case,
> > irq_gpio is the GPIO ID for that pin. Not all drivers use this feature.
> > Where they do, and the use of this feat
> -Original Message-
> From: Greg KH [mailto:g...@kroah.com]
> Sent: Thursday, September 01, 2011 4:31 PM
> To: Peter Foley
> Cc: KY Srinivasan; gre...@suse.de; Linux Kernel Mailing List;
> devel@linuxdriverproject.org; virtualizat...@lists.osdl.org
> Subject: Re: Hyper-V TODO file
>
> O
> -Original Message-
> From: Greg KH [mailto:g...@kroah.com]
> Sent: Thursday, September 01, 2011 4:31 PM
> To: Peter Foley
> Cc: KY Srinivasan; gre...@suse.de; Linux Kernel Mailing List;
> devel@linuxdriverproject.org; virtualizat...@lists.osdl.org
> Subject: Re: Hyper-V TODO file
>
> O
Substituted/removed macro's.
Reported-by: Johannes Berg
Reviewed-by: Pieter-Paul Giesberts
Reviewed-by: Arend van Spriel
Signed-off-by: Roland Vossen
---
drivers/staging/brcm80211/brcmsmac/main.c |8
drivers/staging/brcm80211/brcmsmac/main.h |3 ++-
drivers/staging/brcm80211/
From: Arend van Spriel
Sparse warning was given when using the extern keyword in the function
definition. This patch removes those instances.
Reported-by: Aaro Koskinen
Reviewed-by: Franky (Zhenhui) Lin
Reviewed-by: Roland Vossen
Signed-off-by: Roland Vossen
---
drivers/staging/brcm80211/br
Substituted/removed macro's.
Reported-by: Johannes Berg
Reviewed-by: Pieter-Paul Giesberts
Reviewed-by: Arend van Spriel
Signed-off-by: Roland Vossen
---
drivers/staging/brcm80211/brcmsmac/main.c | 18 ++
drivers/staging/brcm80211/brcmsmac/main.h |1 -
drivers/staging/brcm80211/
From: Arend van Spriel
The source file main.c contained several sparse warnings which
have been cleaned up.
Reported-by: Aaro Koskinen
Reviewed-by: Franky (Zhenhui) Lin
Reviewed-by: Roland Vossen
Signed-off-by: Roland Vossen
---
drivers/staging/brcm80211/brcmsmac/main.c | 19 +
Substituted/removed macro's.
Reported-by: Johannes Berg
Reviewed-by: Pieter-Paul Giesberts
Reviewed-by: Arend van Spriel
Signed-off-by: Roland Vossen
---
drivers/staging/brcm80211/brcmsmac/ampdu.c |2 +-
drivers/staging/brcm80211/brcmsmac/channel.c |6 +-
drivers/staging/brcm80211/b
Substituted macro's.
Reported-by: Johannes Berg
Reviewed-by: Pieter-Paul Giesberts
Reviewed-by: Arend van Spriel
Signed-off-by: Roland Vossen
---
drivers/staging/brcm80211/brcmsmac/phy/phy_cmn.c |6 --
drivers/staging/brcm80211/brcmsmac/types.h |5 -
2 files changed, 4 i
Substituted macro.
Reported-by: Johannes Berg
Reviewed-by: Pieter-Paul Giesberts
Reviewed-by: Arend van Spriel
Signed-off-by: Roland Vossen
---
drivers/staging/brcm80211/brcmsmac/srom.c | 22 +-
1 files changed, 9 insertions(+), 13 deletions(-)
diff --git a/drivers/stag
Substituted macro's.
Reported-by: Johannes Berg
Reviewed-by: Pieter-Paul Giesberts
Reviewed-by: Arend van Spriel
Signed-off-by: Roland Vossen
---
drivers/staging/brcm80211/brcmsmac/nicpci.c | 42 ---
drivers/staging/brcm80211/brcmsmac/nicpci.h | 12 ---
2 files
From: Arend van Spriel
Kconfig options are by default not selected so adding the
statement 'default n' to the option is not needed.
Reported-by: Johannes Berg
Reviewed-by: Roland Vossen
Reviewed-by: Pieter-Paul Giesberts
Signed-off-by: Roland Vossen
---
drivers/staging/brcm80211/Kconfig |
From: Arend van Spriel
Running sparse showed following warning: Using plain integer as NULL
pointer. This has been fixed.
Reported-by: Aaro Koskinen
Reviewed-by: Franky (Zhenhui) Lin
Reviewed-by: Roland Vossen
Signed-off-by: Roland Vossen
---
drivers/staging/brcm80211/brcmfmac/dhd_common.c
AP support was only partially implemented and never invoked.
AP related code sections removed.
Reported-by: Johannes Berg
Reviewed-by: Pieter-Paul Giesberts
Reviewed-by: Arend van Spriel
Signed-off-by: Roland Vossen
---
drivers/staging/brcm80211/brcmsmac/main.c | 64
From: Arend van Spriel
Several sparse warning were issued due to missing __user qualifier
for brcmfmac variables. This patch adds those.
Reported-by: Aaro Koskinen
Reviewed-by: Franky (Zhenhui) Lin
Reviewed-by: Roland Vossen
Signed-off-by: Roland Vossen
---
drivers/staging/brcm80211/brcmfma
Code cleanup and reduction of sparse warnings.
This series applies to staging-next and depends on the following patch set:
Message-ID: <1314868640-9425-31-git-send-email-rvos...@broadcom.com>
Arend van Spriel (5):
staging: brcm80211: remove extern keyword from function definition
staging: br
> -Original Message-
> From: Thomas Gleixner [mailto:t...@linutronix.de]
> Sent: Friday, September 02, 2011 4:14 AM
> To: KY Srinivasan
> Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> devel@linuxdriverproject.org; virtualizat...@lists.osdl.org;
> a...@firstfloor.org;
> a...@linux-f
On Fri, 02 Sep 2011 06:34:55 -0400
valdis.kletni...@vt.edu wrote:
> On Fri, 02 Sep 2011 11:55:28 +0800, "Leonid V. Fedorenchik" said:
> > This patch series fixes some style issues in drivers/staging/cx25821
>
> Happened to glance at a "Fix long lines" patch that actually improved
> the code. Tha
On Fri, 2 Sep 2011 12:16:40 +0300
Dan Carpenter wrote:
> Looks good. Thanks for doing this.
Thank you for review. My pleasure.
>
> Reviewed-by: Dan Carpenter
>
> regards,
> dan carpenter
Leonid V. Fedorenchik
___
devel mailing list
devel@linuxdriv
On Fri, 02 Sep 2011 12:58:07 +0530, Ravishankar K Mallikarjunayya said:
> This is a patch to the s626.c file that fixes up a line over 80 character
Patch looks mostly good - but a question:
> diff --git a/drivers/staging/comedi/drivers/s626.c
> b/drivers/staging/comedi/drivers/s626.c
> @@ -266,
On 09/02/11 10:41, Maxin B. John wrote:
>> Don't overwrite the error code. For example, the lower layers can
>> return -EAGAIN and that's more useful than just returning -EIO every
>> time.
> Ahh.. Thanks a lot for explaining this.
>
>> Your fix works, but it's not very clean. Just add a "*id =
> Don't overwrite the error code. For example, the lower layers can
> return -EAGAIN and that's more useful than just returning -EIO every
> time.
Ahh.. Thanks a lot for explaining this.
> Your fix works, but it's not very clean. Just add a "*id = ret;"
> line before the "return 0;" and that's i
Hi Jonathan,
On Fri, 02 Sep 2011 10:19:24 +0100, Jonathan Cameron wrote:
> On 09/02/11 07:56, Jean Delvare wrote:
> > Stephen,
> >
> > Can you please fix your e-mail client / system / whatever so that your
> > patch series are no longer sent duplicated?
> >
> > On Thu, 1 Sep 2011 16:04:27 -0600
Looks good. Thanks for doing this.
Reviewed-by: Dan Carpenter
regards,
dan carpenter
___
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
On 09/02/11 07:56, Jean Delvare wrote:
> Stephen,
>
> Can you please fix your e-mail client / system / whatever so that your
> patch series are no longer sent duplicated?
>
> On Thu, 1 Sep 2011 16:04:27 -0600, Stephen Warren wrote:
>> Some devices use a single pin as both an IRQ and a GPIO. In t
On 09/01/11 22:55, Dan Carpenter wrote:
> On Fri, Sep 02, 2011 at 12:24:13AM +0300, Maxin B. John wrote:
>> --- a/drivers/staging/iio/light/tsl2563.c
>> +++ b/drivers/staging/iio/light/tsl2563.c
>> @@ -225,9 +225,9 @@ static int tsl2563_read_id(struct tsl2563_chip *chip, u8
>> *id)
>>
>>
On 01/09/11 10:15, Manohar Vanga wrote:
> diff --git a/drivers/staging/vme/vme.h b/drivers/staging/vme/vme.h
> index 4155d8c..d442cce 100644
> --- a/drivers/staging/vme/vme.h
> +++ b/drivers/staging/vme/vme.h
> @@ -91,17 +91,34 @@ extern struct bus_type vme_bus_type;
> #define VME_SLOT_CURRENT
On 09/01/11 17:52, Stephen Warren wrote:
> Fix ak8975_probe() to jump to the appropriate exit labels when an error
> occurs. With the previous code, some cleanup actions were being skipped
> for some error conditions.
>
> Signed-off-by: Stephen Warren
Acked-by: Jonathan Cameron
> ---
> drivers/
On 09/01/11 17:52, Stephen Warren wrote:
> gpio_is_valid() is the defined mechanism to determine whether a GPIO is
> valid. Use this instead of assuming that 0 is an invalid GPIO.
>
This one is unchanged so you should probably have carried acks from v1.
Anyhow,
> Signed-off-by: Stephen Warren
Ack
On 09/02/11 09:48, Jonathan Cameron wrote:
> On 09/01/11 17:52, Stephen Warren wrote:
>> Some devices use a single pin as both an IRQ and a GPIO. In that case,
>> irq_gpio is the GPIO ID for that pin. Not all drivers use this feature.
>> Where they do, and the use of this feature is optional, and t
On 09/01/11 17:52, Stephen Warren wrote:
> Some devices use a single pin as both an IRQ and a GPIO. In that case,
> irq_gpio is the GPIO ID for that pin. Not all drivers use this feature.
> Where they do, and the use of this feature is optional, and the system
> wishes to disable this feature, this
On Tue, 2 Aug 2011, K. Y. Srinivasan wrote:
> The Hyper-V timesource driver is best integrated with Hyper-V detection code
> since: (a) Linux guests running on Hyper-V need this timesource and (b)
> by integrating with Hyper-V detection, we could significantly minimize the
> code in the timesourc
On Fri, Sep 02, 2011 at 12:51:53AM -0700, Gerard Snitselaar wrote:
> #define MAX_LD_SLOT_NUM 10
> -#define KEEP_ALIVE_INTERVAL 20 // in seconds.
> +#define KEEP_ALIVE_INTERVAL 20 // in seconds.
> #define CHECK_FOR_HANG_PERIOD
Fixed whitespace issues found by checkpatch.pl
Signed-off-by: Gerard Snitselaar
---
drivers/staging/rtl8187se/r8180.h | 12 ++--
drivers/staging/rtl8187se/r8180_core.c | 22 +++---
drivers/staging/rtl8187se/r8180_dm.c| 23 +++
drivers/
This is a patch to the unioxx5.c file that fixes up a line over 80 character
warning found by the checkpatch.pl tool
Signed-off-by: Ravishankar K Mallikarjunayya
---
drivers/staging/comedi/drivers/unioxx5.c | 16 +---
1 files changed, 13 insertions(+), 3 deletions(-)
diff --git a
This is a patch to the usbduxfast.c file that fixes up a line 0ver 80 character
warning found by the checkpatch.pl tool
Signed-off-by: Ravishankar K Mallikarjunayya
---
drivers/staging/comedi/drivers/usbduxfast.c | 47 ++
1 files changed, 25 insertions(+), 22 deletions
This is a patch to the s626.c file that fixes up a line over 80 character
warning found by the checkpatch.pl tool
Signed-off-by: Ravishankar K Mallikarjunayya
---
drivers/staging/comedi/drivers/s626.c | 48 ++--
1 files changed, 33 insertions(+), 15 deletions(-)
d
This is a patch to the s626.c file that fixes up a line over 80 character
warning found by the checkpatch.pl tool
Signed-off-by: Ravishankar K Mallikarjunayya
---
drivers/staging/comedi/drivers/s626.c | 89 +---
1 files changed, 58 insertions(+), 31 deletions(-)
d
58 matches
Mail list logo
