Re: [PATCH 25/62] staging: irq: Remove IRQF_DISABLED

On Thu, Sep 08, 2011 at 07:52:10AM -0700, Greg KH wrote: > > I'll try to work it out, Thanks Greg. > and if I have problems, I'll ask for a new > version once linux-next gets back up and running. No problem :) Thanks, Yong ___ devel mailing list deve

Re: [PATCH] Staging: hv: storvsc: Show the modulename in /sys/class/scsi_host/*/proc_name

On Thu, Sep 08, 2011 at 06:26:50PM +0200, Olaf Hering wrote: > > mkinitrd relies on /sys/class/scsi_host/*/proc_name instead of > /sys/block/sd*/device/../../../moalias to get the scsi driver module > name. > As a fallback the sysfs driver name could be used, which does not match > the module name

Re: [PATCH] staging/xgifb: Remove dead code in vb_def.h

Hi, > This has been already deleted from the driver... Oh sorry, my bad. > This tool however seems to be useful, so it would be good idea > to recheck the current code when the staging tree is back online. Will do ! Thanks, Peter ___ devel mailing list

Re: [PATCH] staging/xgifb: Remove dead code in vb_def.h

Hi, On 8.9.2011, at 20.32, Peter Huewe wrote: In xgifb/vb_def.h NewScratch is always defined, due to these lines at the beginning of the file: #ifndef NewScratch #define NewScratch #endif This has been already deleted from the driver... This patch removes the dead defines in vb_def.h Foun

[PATCH 1/1] Staging: comedi: fix printk issue in pcmmio.c

From: Ravishankar K Mallikarjunayya This is a patch to the pcmmio.c file that fixes up a printk warning found by the checkpatch.pl tool Signed-off-by: Ravishankar K Mallikarjunayya --- drivers/staging/comedi/drivers/pcmmio.c | 28 ++-- 1 files changed, 14 insertions(

[PATCH 1/1] Staging: comedi: fix printk issue in serial2002.c

This is a patch to the serial2002.c file that fixes up a printk warning found by the checkpatch.pl tool Signed-off-by: Ravishankar K Mallikarjunayya --- drivers/staging/comedi/drivers/serial2002.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi

[PATCH 2/3] Staging: comedi: fix brace coding style issue in pcmuio.c

This is a patch to the pcmuio.c file that fixes up a brace coding style warning found by the checkpatch.pl tool Signed-off-by: Ravishankar K Mallikarjunayya --- drivers/staging/comedi/drivers/pcmuio.c | 11 +++ 1 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/sta

[PATCH 3/3] Staging: comedi: fix printk issue in pcmuio.c

This is a patch to the pcmuio.c file that fixes up a printk warning found by the checkpatch.pl tool Signed-off-by: Ravishankar K Mallikarjunayya --- drivers/staging/comedi/drivers/pcmuio.c | 28 ++-- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/driv

[PATCH 1/3] Staging: comedi: fix line over 80 character issue in pcmuio.c

This is a patch to the pcmuio.c file that fixes up a line over 80 character warning found by the checkpatch.pl tool Signed-off-by: Ravishankar K Mallikarjunayya --- drivers/staging/comedi/drivers/pcmuio.c | 110 ++- 1 files changed, 79 insertions(+), 31 deletions(-)

[PATCH 2/2] Staging: comedi: fix line over 80 character issue in s626.c

This is a patch to the s626.c file that fixes up a line over 80 character warning found by the checkpatch.pl tool Signed-off-by: Ravishankar K Mallikarjunayya --- drivers/staging/comedi/drivers/s626.c | 115 - 1 files changed, 84 insertions(+), 31 deletions(-)

[PATCH 1/2] Staging: comedi: fix line over 80 character issue in s626.c

This is a patch to the s626.c file that fixes up a line over 80 character warning found by the checkpatch.pl tool Signed-off-by: Ravishankar K Mallikarjunayya --- drivers/staging/comedi/drivers/s626.c | 77 +++- 1 files changed, 46 insertions(+), 31 deletions(-) d

Re: [PATCH 1/5] Fix sparse warnings

On Thu, Sep 8, 2011 at 8:13 AM, Nitin Gupta wrote: > On 09/08/2011 04:17 AM, Jerome Marchand wrote: > > Since it just fixes couple of trivial sparse warnings, > I though no description is necessary? Anyways, here is > the description if needed for patch process: > > Fixed some sparse warnings by m

[PATCH] staging/xgifb: Remove dead code in vb_def.h

In xgifb/vb_def.h NewScratch is always defined, due to these lines at the beginning of the file: #ifndef NewScratch #define NewScratch #endif Thus we can eliminate all #else branches of #ifndef NewScratch and since the NewScratch define isn't used anywhere else we can remove it too. This patch

RE: [PATCH] Staging: hv: storvsc: Show the modulename in /sys/class/scsi_host/*/proc_name

> -Original Message- > From: Olaf Hering [mailto:o...@aepfle.de] > Sent: Thursday, September 08, 2011 12:27 PM > To: KY Srinivasan > Cc: gre...@suse.de; linux-ker...@vger.kernel.org; > devel@linuxdriverproject.org; virtualizat...@lists.osdl.org > Subject: [PATCH] Staging: hv: storvsc: Sho

[PATCH 2/2] drivers/staging/crystalhd/: cleanup typedefs

Cleans the typedef declarations in bc_dts_types.h file. Most of them aren't used. The ones are used are 'uint32_t' and similar ones, but I don't see the point of them since they are declared in stdint.h, unless some sort of embeded systems don't have it (no experience with it). So simply removing t

[PATCH 1/2] drivers/staging/crystalhd/: Fix a coding style issues

crystalhd_fw_if.h: indentation fix (spaces to tabs) The rest are brackets. NOTE: there are quite some 80 character warnings, but they look in place, comments mostly on the right next to the constants and stuff like that. I haven't touched them, since this rule is 'going away', but in case you woul

[PATCH] Staging: hv: storvsc: Show the modulename in /sys/class/scsi_host/*/proc_name

mkinitrd relies on /sys/class/scsi_host/*/proc_name instead of /sys/block/sd*/device/../../../moalias to get the scsi driver module name. As a fallback the sysfs driver name could be used, which does not match the module name either ('storvsc' vs. 'hv_storvsc'). Signed-off-by: Olaf Hering ---

[PATCH] staging: fix comedi build when ISA_DMA_API is enabled but COMEDI_PCI is not enabled

From: Randy Dunlap Fix build when CONFIG_ISA_DMA_API is enabled but CONFIG_COMEDI_PCI[_DRIVERS] is not enabled. Fixes these build errors: drivers/staging/comedi/drivers/ni_labpc.c: In function 'labpc_ai_cmd': drivers/staging/comedi/drivers/ni_labpc.c:1351: error: implicit declaration of functio

Re: [PATCH 1/5] Fix sparse warnings

On 09/08/2011 04:17 AM, Jerome Marchand wrote: On 09/08/2011 03:29 AM, Nitin Gupta wrote: --- I'm afraid this patch is missing a description. Since it just fixes couple of trivial sparse warnings, I though no description is necessary? Anyways, here is the description if needed for patch pro

Re: [PATCH 25/62] staging: irq: Remove IRQF_DISABLED

On Thu, Sep 08, 2011 at 09:58:54PM +0800, Yong Zhang wrote: > On Thu, Sep 08, 2011 at 12:40:48PM +0200, Marc Dietich wrote: > > > This flag is a NOOP and can be removed now. > > > > > > Signed-off-by: Yong Zhang > > > --- > > > drivers/staging/cx25821/cx25821-alsa.c |2 +- > > >

[PATCH 01/25] Staging: hv: vmbus: Rename vmbus_child_device_create

The vmbus devices are NOT child devices; rename vmbus_child_device_create to reflect this. Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang --- drivers/staging/hv/channel_mgmt.c |2 +- drivers/staging/hv/hyperv_vmbus.h |2 +- drivers/staging/hv/vmbus_drv.c|4 ++-- 3

[PATCH 19/25] Staging: hv: netvsc: Get rid of the usage of the ext field in struct hv_device

Now, eliminate the usage of ext field in struct hv_device for netvsc driver. We do this by registering pointer to struct netvsc_device as the driver specific data and eliminating the current usage of driver specific data to save and retrieve the pointer to struct net_device. Additionally, all acce

[PATCH 11/25] Staging: hv: util: Properly handle util services in the util driver

Now properly handle util services in the util driver and eliminate code that will not be necessary. In the current code, util services were all handled not as other vmbus devices (net, block) but rather through special handling (channel setup etc.). In this patch we handle all services using the st

[PATCH 06/25] Staging: hv: storvsc: Use the driver_data to identify ide

Use the driver_data to identify ide devices in storvsc_probe(). Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang --- drivers/staging/hv/storvsc_drv.c | 13 + 1 files changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/staging/hv/storvsc_drv.c b/drivers/stagi

[PATCH 25/25] Staging: hv: netvsc: Rename deviceInfo as device_info

Rename deviceInfo as device_info. Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang --- drivers/staging/hv/rndis_filter.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/hv/rndis_filter.c b/drivers/staging/hv/rndis_filter.c index cb9d4

[PATCH 15/25] Staging: hv: storvsc: Get rid of storvsc_dev_add() by inlining the code

Get rid of storvsc_dev_add() by inlining the code. Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang --- drivers/staging/hv/storvsc_drv.c | 58 + 1 files changed, 14 insertions(+), 44 deletions(-) diff --git a/drivers/staging/hv/storvsc_drv.c b/

[PATCH 17/25] Staging: hv: storvsc: Get rid of some unnecessary state and definitions

Now, get rid of some unnecessary state and definitions. Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang --- drivers/staging/hv/storvsc_drv.c |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/drivers/staging/hv/storvsc_drv.c b/drivers/staging/hv/storvs

[PATCH 16/25] Staging: hv: storvsc: Get rid of alloc_stor_device() by inlining the code

Get rid of alloc_stor_device() by inlining the code. Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang --- drivers/staging/hv/storvsc_drv.c | 24 ++-- 1 files changed, 6 insertions(+), 18 deletions(-) diff --git a/drivers/staging/hv/storvsc_drv.c b/drivers/stag

[PATCH 23/25] Staging: hv: netvsc: Rename netDevice as net_device

Rename netDevice as net_device. Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang --- drivers/staging/hv/netvsc.c |5 - drivers/staging/hv/rndis_filter.c | 20 ++-- 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/staging/hv/net

[PATCH 24/25] Staging: hv: netvsc: Rename rndisDevice to rndis_device

Rename rndisDevice to rndis_device. Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang --- drivers/staging/hv/rndis_filter.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/hv/rndis_filter.c b/drivers/staging/hv/rndis_

[PATCH 04/25] Staging: hv: vmbus: Cleanup dated comments in channel_mgmt.c

Cleanup dated comments in channel_mgmt.c. Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang --- drivers/staging/hv/channel_mgmt.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/staging/hv/channel_mgmt.c b/drivers/staging/hv/channel_mgmt.c index 60

[PATCH 20/25] Staging: hv: mousevsc: Get rid of the usage of the ext field in struct hv_device

Get rid of the usage of the ext field in struct hv_device for the mouse driver. We do this by using the newly introduced functions to set and and get driver specific data. Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang --- drivers/staging/hv/hv_mouse.c | 18 +- 1

[PATCH 18/25] Staging: hv: storvsc: Eliminate the usage of ext field in struct hv_device

Now, eliminate the usage of ext field in struct hv_device for storvsc driver. We do this by registering pointer to struct storvsc_device as the driver specific data and eliminating the current usage of driver specific data to save and retrieve the pointer to struct Scsi_Host. Additionally, all acc

[PATCH 05/25] Staging: hv: vmbus: Change the signature of struct hv_driver probe function

In preparation to leveraging the driver_data field in struct hv_vmbus_device_id, change the signature of struct hv_driver probe function. Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang --- drivers/staging/hv/hv_mouse.c|3 ++- drivers/staging/hv/hv_util.c |3 ++- dr

[PATCH 10/25] Staging: hv: vmbus: Return proper error code in vmbus_remove()

Return proper error code in vmbus_remove(). Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang --- drivers/staging/hv/vmbus_drv.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c index b9aeb76..

[PATCH 14/25] Staging: hv: vmbus: Introduce functions for setting and getting driver data

In preparation for getting rid of the ext field in the struct hv_device, introduce vmbus specific wrapper functions to set/get driver specific data. Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang --- drivers/staging/hv/hyperv.h |9 + 1 files changed, 9 insertions(+),

[PATCH 09/25] Staging: hv: util: Perform some service specific de-initialization in util_remove()

In preparation for modifying the util driver to fully conform to the Linux Driver Model, perform some service specific de-initialization in util_remove() as opposed to in exit_hyperv_utils() as is currently done. Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang --- drivers/staging/

[PATCH 22/25] Staging: hv: vmbus: Do not allocate struct hv_device_info on the stack

struct hv_device_info is about 101 bytes in size. Do not allocate this structure on the stack. Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang --- drivers/staging/hv/vmbus_drv.c | 134 --- 1 files changed, 69 insertions(+), 65 deletions(-) diff

[PATCH 02/25] Staging: hv: vmbus: Rename vmbus_child_device_register

The vmbus devices are NOT child devices; rename vmbus_child_device_register to reflect this. Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang --- drivers/staging/hv/channel_mgmt.c |2 +- drivers/staging/hv/hyperv_vmbus.h |2 +- drivers/staging/hv/vmbus_drv.c|4 ++--

[PATCH 13/25] Staging: hv: vmbus: Get rid of the module dependency

Hyper-V modules can be built as part of the kernel (not just as modules). Get rid of the module dependency in Kconfig. Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang --- drivers/staging/hv/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/st

[PATCH 07/25] Staging: hv: vmbus: Change the signature of struct hv_driver remove() function

In preparation for leveraging the driver_data in struct hv_vmbus_device_id, change the signature of struct hv_driver remove() function. Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang --- drivers/staging/hv/hv_mouse.c|3 ++- drivers/staging/hv/hv_util.c |3 ++- dri

[PATCH 12/25] Staging: hv: vmbus: Get rid of hv_cb_utils[] and other unneeded code

Now that the transformation of the util driver is complete, get rid of hv_cb_utils[] and other unneeded code Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang --- drivers/staging/hv/channel_mgmt.c | 94 - drivers/staging/hv/hyperv.h |8

[PATCH 21/25] Staging: hv: vmbus: Get rid of the ext field in struct hv_device

Now that we have eliminated all uses of the ext field in struct hv_device, get rid of the ext field. Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang --- drivers/staging/hv/hyperv.h |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/staging/hv/hyperv.

[PATCH 08/25] Staging: hv: util: Perform some service specific initialization in util_probe()

In preparation for modifying the util driver to fully conform to the Linux Driver Model, perform some service specific initialization in util_probe() as opposed to in init_hyperv_utils() as is currently done. Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang --- drivers/staging/hv/

[PATCH 03/25] Staging: hv: vmbus: Rename vmbus_child_device_unregister

The vmbus devices are NOT child devices; rename vmbus_child_device_unregister to reflect this. Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang --- drivers/staging/hv/channel_mgmt.c |2 +- drivers/staging/hv/hyperv_vmbus.h |2 +- drivers/staging/hv/vmbus_drv.c|4 ++--

[PATCH 0000/0025] Staging: hv: Driver cleanup

Address Greg's VmBus audit comments: 1) Leverage driver_data field in struct hv_vmbus_device_id to simplify driver code. 2) Make the util driver conform to the Linux Driver Model. 3) Get rid of the ext field in struct hv_device by using the driver sp

Re: [PATCH 25/62] staging: irq: Remove IRQF_DISABLED

On Thu, Sep 08, 2011 at 12:40:48PM +0200, Marc Dietich wrote: > > This flag is a NOOP and can be removed now. > > > > Signed-off-by: Yong Zhang > > --- > > drivers/staging/cx25821/cx25821-alsa.c |2 +- > > drivers/staging/cx25821/cx25821-audio-upstream.c |2 +- > > drivers/

Re: [PATCH 25/62] staging: irq: Remove IRQF_DISABLED

> This flag is a NOOP and can be removed now. > > Signed-off-by: Yong Zhang > --- > drivers/staging/cx25821/cx25821-alsa.c |2 +- > drivers/staging/cx25821/cx25821-audio-upstream.c |2 +- > drivers/staging/cx25821/cx25821-core.c |2 +- > .../staging/cx25821/

[no subject]

I am requesting for your partnership in re-profiling funds I will give the details, but in summary, the funds are coming via Bank Of Taipei Taiwan.Contact me for further details (wen.le...@9.cn) Wen Lee. ___ devel mailing list devel@linuxdriverproje

Re: [PATCH 1/5] Fix sparse warnings

On 09/08/2011 03:29 AM, Nitin Gupta wrote: > --- I'm afraid this patch is missing a description. Jerome > drivers/staging/zram/zram_drv.c |3 ++- > drivers/staging/zram/zram_drv.h |2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/zram/zram_drv.c