Line up constant defines to the same column.
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821.h
b/drivers/staging/cx25821/cx25821.h
index db2615b..0b3e13b 100644
Move operator in complex expression to the end of the line to preserve
consistency.
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-video.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-video.c
b/drivers/stag
Fix indent of statements to improve readability.
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-video.c | 79 +++
1 files changed, 39 insertions(+), 40 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-video.c
b/drivers/staging/cx
Change obscure line endings to less obscure ones. (improve readability)
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-video.c | 47 ++
1 files changed, 22 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-video.c
Change double assignment in one statement into two assignment
statements.
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-video.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-video.c
b/drivers/staging/cx25821
Change multiple definitions in one statement into multiple statements
with one definition per statement.
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-video.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821
Delete unnecessary empty line.
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-video.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-video.c
b/drivers/staging/cx25821/cx25821-video.c
index 084fc08..e5033e7 10064
Change double spaces between lexemes into single spaces.
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-video.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-video.c
b/drivers/staging/cx25821/cx25821-video.c
Change obscure line endings to less obscure ones. (improve readability)
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-video-upstream.c | 87 +
1 files changed, 37 insertions(+), 50 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-video-u
Change indent of statements to use tabs and to improve readability.
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-video-upstream.c | 24 -
1 files changed, 9 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-video-upstre
Change obscure line endings to less obscure ones. (improve readability)
Signed-off-by: Leonid V. Fedorenchik
---
.../staging/cx25821/cx25821-video-upstream-ch2.c | 82 ---
1 files changed, 35 insertions(+), 47 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-video-u
Delete curly braces around single if-else statements.
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-video-upstream.c | 35 +-
1 files changed, 14 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-video-upstream.c
b/driv
Remove unnecessary curly braces around single if statement.
Signed-off-by: Leonid V. Fedorenchik
---
.../staging/cx25821/cx25821-video-upstream-ch2.c |8 +++-
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-video-upstream-ch2.c
b/drivers/
Move operators in complex expressions to the end of the lines to
preserve consistency.
Signed-off-by: Leonid V. Fedorenchik
---
.../staging/cx25821/cx25821-video-upstream-ch2.c | 16 +++-
1 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/cx25821/cx258
Change indent of statements with (less than 8) spaces to indent with
tabs.
Signed-off-by: Leonid V. Fedorenchik
---
.../staging/cx25821/cx25821-video-upstream-ch2.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-video-upstrea
Line up comments to match indent of surrounding statements.
Signed-off-by: Leonid V. Fedorenchik
---
.../staging/cx25821/cx25821-video-upstream-ch2.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-video-upstream-ch2.c
b/drivers/
Change obscure line endings to less obscure ones. (improve readability)
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-medusa-video.c | 400 ++--
1 files changed, 159 insertions(+), 241 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-medu
Plase operators in complex expressions at the end of the lines to
preserve consistency.
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-medusa-video.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-medusa-v
Delete part of the comment that is not checked in code.
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-medusa-video.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-medusa-video.c
b/drivers/staging/cx25821/cx25
Line up constant defines to the same column. (also delete unnecessary
spaces in comments)
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-medusa-reg.h | 518 +-
1 files changed, 259 insertions(+), 259 deletions(-)
diff --git a/drivers/staging/cx
Line up constant defines to the same column.
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-medusa-defines.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-medusa-defines.h
b/drivers/staging/cx25821/cx25821-m
Fix typo in comment in word 'decoder'.
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-medusa-defines.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-medusa-defines.h
b/drivers/staging/cx25821/cx25821-medusa-de
Change obscure line endings to less obscure ones. (improve readability)
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-i2c.c | 10 --
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-i2c.c
b/drivers/staging/cx2582
Change obscure line endings to less obscure ones. (improve readability)
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-core.c | 48 ++--
1 files changed, 21 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-core.c
Delete redundant empty line.
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-core.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-core.c
b/drivers/staging/cx25821/cx25821-core.c
index 3ec58af..5346746 100644
---
Change indent of statements that indented with spaces to indent with
tabs.
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-core.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-core.c
b/drivers/staging/cx2
Change wrong indent (with spaces and less than 7 columns) of statements
to tabs.
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-audio-upstream.c | 42 +++---
1 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/cx25821/cx258
Fix indent of statement to use tab instead of spaces.
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-cards.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-cards.c
b/drivers/staging/cx25821/cx25821-cards.c
inde
Change column of line continuation character ('\') and fix indent of
multiline defines.
Also line up remaining constant defines.
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-audio.h | 31 ---
1 files changed, 16 insertions(+), 15 deletion
Change obscure line endings to less obscure ones. (improve readability)
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-audio-upstream.c | 54 ++
1 files changed, 24 insertions(+), 30 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-audio-
Line up defines to the same column.
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-audio.h |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-audio.h
b/drivers/staging/cx25821/cx25821-audio.h
index 8eb55b7..5
Move operator of complex expression to the end of the lines to preserve
consistency.
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-audio-upstream.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-audio-upstr
Change obscure line endings to less obscure ones. (improve readability)
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-alsa.c | 52 +---
1 files changed, 21 insertions(+), 31 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-alsa.c
Delete unnecessary space before indented statement.
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-alsa.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-alsa.c
b/drivers/staging/cx25821/cx25821-alsa.c
index 41a
Add curly braces around else clause because corresponding if has them.
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-alsa.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-alsa.c
b/drivers/staging/cx25821/cx25
Line up comments to the same column.
Signed-off-by: Leonid V. Fedorenchik
---
drivers/staging/cx25821/cx25821-alsa.c | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/cx25821/cx25821-alsa.c
b/drivers/staging/cx25821/cx25821-alsa.c
index ebdb
This patch series fixes some style issues in drivers/staging/cx25821
Mostly I was hoping to improve readability and fix some issues found by
checkpatch.pl script.
There is one question, however, in patch no. 18:
I deleted part of the comment that contradicts to the code and in this
case maybe I sh
Hi,
On Fri, Sep 2, 2011 at 1:55 PM, Jonathan Cameron wrote:
> On 09/02/11 10:41, Maxin B. John wrote:
>>> Don't overwrite the error code. For example, the lower layers can
>>> return -EAGAIN and that's more useful than just returning -EIO every
>>> time.
>> Ahh.. Thanks a lot for explaining this
38 matches
Mail list logo