Re: [PATCH 2/2] Staging: bcm: hostmibs: Fixed indentation and other minor style issues.

2011-10-30 Thread Dan Carpenter
On Sun, Oct 30, 2011 at 09:37:04PM -0300, dfm wrote: > 2011/10/30 Joe Perches : > > Because of the silly name lengths and to avoid excessive > > dereferences, it's better to use a temporary. > > > >         > > typeof(Adapter->PackInfo[uiSearchRuleIndex].stMibsExtServiceFlowTable) *t = > >        

Re: [PATCH 2/2] Staging: bcm: hostmibs: Fixed indentation and other minor style issues.

2011-10-30 Thread dfm
2011/10/30 Joe Perches : > Because of the silly name lengths and to avoid excessive > dereferences, it's better to use a temporary. > >        typeof(Adapter->PackInfo[uiSearchRuleIndex].stMibsExtServiceFlowTable) > *t = >                 > &Adapter->PackInfo[uiSearchRuleIndex].stMibsExtServiceFlo

Re: [RESEND PATCH 1/14] staging/media/as102: initial import from Abilis

2011-10-30 Thread Stefan Richter
On Oct 30 Piotr Chmura wrote: > > + * Note: > > + * - in AS102 SNR=MER > > + * - the SNR will be returned in linear terms, i.e. not in dB > > + * - the accuracy equals ±2dB for a SNR range from 4dB to 30dB > > + * - the accuracy is>2dB for SNR values outside this range > > + */ > > I found

Re: [RESEND PATCH 11/14] staging/media/as102: fix compile warning about unused function

2011-10-30 Thread Stefan Richter
On Oct 30 Sylwester Nawrocki wrote: > On 10/18/2011 10:03 PM, Piotr Chmura wrote: > > Patch taken from http://kernellabs.com/hg/~dheitmueller/v4l-dvb-as102-2/ [...] > > +#if (LINUX_VERSION_CODE< KERNEL_VERSION(2, 6, 19)) > > I was wondering, could such a conditional compilation be simply skipped

Re: [RESEND PATCH 1/14] staging/media/as102: initial import from Abilis

2011-10-30 Thread Piotr Chmura
W dniu 18.10.2011 21:46, Piotr Chmura pisze: Patch taken from http://kernellabs.com/hg/~dheitmueller/v4l-dvb-as102-2/ Changes made by me: 1. Driver moved from media/dvb to staging/media 2. Removed Makefile/Kconfig - it doesn't compile in current tree (...) + +/* + * Note: + * - in AS102 SNR=ME

Re: [PATCH v2 3/3] staging: nvec: add device tree support

2011-10-30 Thread Marc Dietrich
On Friday 28 October 2011 09:56:41 you wrote: > Marc Dietrich wrote at Friday, October 28, 2011 5:02 AM: > > Am Donnerstag, 27. Oktober 2011, 12:17:25 schrieb Stephen Warren: > > > Marc Dietrich wrote at Wednesday, October 26, 2011 1:59 PM: > > > > This adds device tree support to the nvec driver.

Re: [RESEND PATCH 11/14] staging/media/as102: fix compile warning about unused function

2011-10-30 Thread Sylwester Nawrocki
On 10/18/2011 10:03 PM, Piotr Chmura wrote: > Patch taken from http://kernellabs.com/hg/~dheitmueller/v4l-dvb-as102-2/ > > Original source and comment: > # HG changeset patch > # User Devin Heitmueller > # Date 1267319685 18000 > # Node ID 84b93826c0a19efa114a6808165f91390cb86daa > # Parent 22ef1

Re: [PATCH 2/2] Staging: bcm: hostmibs: Fixed indentation and other minor style issues.

2011-10-30 Thread Joe Perches
On Sun, 2011-10-30 at 16:45 -0300, Diego F. Marfil wrote: > diff --git a/drivers/staging/bcm/hostmibs.c b/drivers/staging/bcm/hostmibs.c trivia... > VOID CopyMIBSExtendedSFParameters(PMINI_ADAPTER Adapter, > - CServiceFlowParamSI *psfLocalSet, UINT uiSearchRuleIndex) > +

[PATCH 2/2] Staging: bcm: hostmibs: Fixed indentation and other minor style issues.

2011-10-30 Thread Diego F. Marfil
Signed-off-by: Diego F. Marfil --- drivers/staging/bcm/hostmibs.c | 283 +++- 1 files changed, 192 insertions(+), 91 deletions(-) diff --git a/drivers/staging/bcm/hostmibs.c b/drivers/staging/bcm/hostmibs.c index c77e273..63d43f2 100644 --- a/drivers/staging

[PATCH 1/2] Staging: bcm: hostmibs: Replace C99 comments.

2011-10-30 Thread Diego F. Marfil
Signed-off-by: Diego F. Marfil --- drivers/staging/bcm/hostmibs.c | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/staging/bcm/hostmibs.c b/drivers/staging/bcm/hostmibs.c index c13ea5c..c77e273 100644 --- a/drivers/staging/bcm/hostmibs.c +++ b/driver

RE: [PATCH 0/3] Staging: hv: mousevsc: cleanup the mouse driver

2011-10-30 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:g...@kroah.com] > Sent: Saturday, October 29, 2011 12:50 AM > To: KY Srinivasan > Cc: gre...@suse.de; linux-ker...@vger.kernel.org; > devel@linuxdriverproject.org; virtualizat...@lists.osdl.org; oher...@suse.com; > j...@perches.com; dmitry.toro

RE: [PATCH 1/1] Staging: hv: Move the mouse driver out of staging

2011-10-30 Thread KY Srinivasan
> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Saturday, October 29, 2011 2:33 AM > To: Jesper Juhl > Cc: KY Srinivasan; dmitry.torok...@gmail.com; jkos...@suse.cz; > gre...@suse.de; oher...@suse.com; linux-ker...@vger.kernel.org; > virtualizat...@lis

RE: [PATCH 1/1] Staging: hv: Move the mouse driver out of staging

2011-10-30 Thread KY Srinivasan
> -Original Message- > From: Jiri Kosina [mailto:jkos...@suse.cz] > Sent: Saturday, October 29, 2011 1:05 PM > To: KY Srinivasan > Cc: Greg KH; linux-ker...@vger.kernel.org; devel@linuxdriverproject.org; > virtualizat...@lists.osdl.org; oher...@suse.com; Dmitry Torokhov > Subject: RE: [PA

[PATCH 2/2] staging: line6: add Pod HD300 support

2011-10-30 Thread Stefan Hajnoczi
The Pod HD device family uses new MIDI SysEx messages and therefore cannot reuse the existing Pod code. Instead of hardcoding Pod HD MIDI messages into the driver, leave MIDI up to userspace. This driver simply presents MIDI and pcm ALSA devices. This device is similar to the Pod except that it

[PATCH 1/2] staging: line6: accept all MIDI channels by default

2011-10-30 Thread Stefan Hajnoczi
MIDI messages can be filtered by channel so that multiple devices can coexist on the same MIDI bus. By default all channels should be accepted; this is important because Line6 devices seem to have different default channels. Accept all MIDI messages by default to avoid confusing users when messag

[PATCH 0/2] staging: line6: add Pod HD300 support

2011-10-30 Thread Stefan Hajnoczi
These patches add Pod HD300 support to the line6usb driver. The Pod HD family is the current generation of devices from Line6. It works along the same lines as the Pod xt but introduces new MIDI SysEx messages and is not compatible with Pod xt messages. These patches make Pod HD300 work out-of-t

[PATCH v3 5/14] staging/media/as102: checkpatch fixes

2011-10-30 Thread Piotr Chmura
From: Devin Heitmueller Reformats as10x_cmd_stream.c to take it closer to linux format code. Signed-off-by: Devin Heitmueller Signed-off-by: Piotr Chmura --- v3: added missing empty lines on end of patch. diff --git linux/drivers/staging/media/as102/as10x_cmd_stream.c linuxb/drivers/stagin

Re: [PATCH v3 4/14] staging/media/as102: checkpatch fixes

2011-10-30 Thread Stefan Richter
On Oct 30 Piotr Chmura wrote: > Patch taken from http://kernellabs.com/hg/~dheitmueller/v4l-dvb-as102-2/ > > Original source and comment: > # HG changeset patch > # User Devin Heitmueller > # Date 1267318701 18000 > # Node ID 69c8f5172790784738bcc18f8301919ef3d5373f > # Parent b91e96a07bee27c1d4

Re: [patch] Staging: iio/dac/ad5360.c: signedness bug in ad5360_read_raw()

2011-10-30 Thread Lars-Peter Clausen
On 10/29/2011 09:21 AM, Dan Carpenter wrote: > ad5360_get_channel_vref() returns an int and scale_uv should be the > same. Making it unsigned here breaks the error handling. > > Signed-off-by: Dan Carpenter > Acked-by: Lars-Peter Clausen Thanks. > diff --git a/drivers/staging/iio/dac/ad5360

Re: [patch] Staging: iio/dac/ad5064.c: signedness bug in ad5064_read_raw()

2011-10-30 Thread Lars-Peter Clausen
On 10/29/2011 09:20 AM, Dan Carpenter wrote: > regulator_get_voltage() returns an int so "scale_uv" should be an > int. Making it unsigned here breaks the error handling. > > Signed-off-by: Dan Carpenter uhm, yes... Acked-by: Lars-Peter Clausen Thanks. > > diff --git a/drivers/staging/iio/

[PATCH v3 4/14] staging/media/as102: checkpatch fixes

2011-10-30 Thread Piotr Chmura
Patch taken from http://kernellabs.com/hg/~dheitmueller/v4l-dvb-as102-2/ Original source and comment: # HG changeset patch # User Devin Heitmueller # Date 1267318701 18000 # Node ID 69c8f5172790784738bcc18f8301919ef3d5373f # Parent b91e96a07bee27c1d421b4c3702e33ee8075de83 as102: checkpatch fixes