[PATCH 2/2] staging: vt6656: integer overflows in private_ioctl()

2011-11-29 Thread Xi Wang
There are two potential integer overflows in private_ioctl() if userspace passes in a large sList.uItem / sNodeList.uItem. The subsequent call to kmalloc() would allocate a small buffer, leading to a memory corruption. Reported-by: Dan Rosenberg Signed-off-by: Xi Wang --- drivers/staging/vt665

[PATCH 1/2] staging: vt6655: integer overflows in private_ioctl()

2011-11-29 Thread Xi Wang
There are two potential integer overflows in private_ioctl() if userspace passes in a large sList.uItem / sNodeList.uItem. The subsequent call to kmalloc() would allocate a small buffer, leading to a memory corruption. Reported-by: Dan Rosenberg Signed-off-by: Xi Wang --- drivers/staging/vt665

[PATCH 4/5] staging: vt6656: baseband.c: Remove commented code

2011-11-29 Thread Marcos Paulo de Souza
This patch removes a lot of commented code, and some return calls of void functions. Signed-off-by: Marcos Paulo de Souza Cc: Greg kroah-Hartman Cc: Forest Bond Cc: de...@driverdev.osuosl.org --- drivers/staging/vt6656/baseband.c |2 - drivers/staging/vt6656/bssdb.c| 100 +---

[PATCH 3/5] staging: vt6656: baseband.c: Removed dead code, and fix coding standards

2011-11-29 Thread Marcos Paulo de Souza
Remved some commented code, and fixed some style issues. was removed too a redundant if statement. Signed-off-by: Marcos Paulo de Souza Cc: Greg kroah-Hartman Cc: Forest Bond Cc: dri...@driverdev.osuosl.org --- drivers/staging/vt6656/baseband.c | 59 + 1

[PATCH 2/5] staging: vt6656: 80211mgr.c: Code cleanup, removed return of void funcs.

2011-11-29 Thread Marcos Paulo de Souza
Removed return call of void functions. Removed some code style issues. Signed-off-by: Marcos Paulo de Souza Cc: Greg kroah-Hartman Cc: Forest Bond Cc: dri...@driverdev.osuosl.org --- drivers/staging/vt6656/80211mgr.c | 35 ++- 1 files changed, 2 insertions(+)

[PATCH 1/5] staging: vt6656: main_usb.c: Use kzalloc instead kmalloc

2011-11-29 Thread Marcos Paulo de Souza
Signed-off-by: Marcos Paulo de Souza Cc: Greg kroah-Hartman Cc: Forest Bond Cc: dri...@driverdev.osuosl.org --- drivers/staging/vt6656/main_usb.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c i

Re: [PATCH] staging:iio: Use kcalloc instead of kzalloc to allocate array

2011-11-29 Thread JohnLM
On Tue, 29 Nov 2011 22:08:00 +0100 Thomas Meyer wrote: > The advantage of kcalloc is, that will prevent integer overflows > which could result from the multiplication of number of elements and > size and it is also a bit nicer to read. I wish to note that in virtually all cases anything that wil

[PATCH] staging:iio: Use kcalloc instead of kzalloc to allocate array

2011-11-29 Thread Thomas Meyer
The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read. The semantic patch that makes this change is available in https://lkml.org/lkml/2011/11/25/107 Signed-off-by: Thomas Meyer

Re: [PATCH] comedi_fops: Replace deprecated strict_strtoul with kstrtoul

2011-11-29 Thread Dan Carpenter
On Tue, Nov 29, 2011 at 03:19:11PM +0100, Florian Schmaus wrote: > As reported by checkpatch.pl strict_strtoul should be replaced with kstrtoul > When we introduce the kstrtoXX functions, we introduced a number of new functions like kstroint() that weren't available in the strict_strtoXX function

How should I update linux-next tree

2011-11-29 Thread Joilnen Leite
Should I to do git pull ? or like said http://linux.f-seidel.de/linux-next/pmwiki/pmwiki.php?n=Linux-next.FAQ $ git remote add linux-next git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git $ git fetch linux-next $ git fetch --tags linux-next ... # later on $ git remote update __

RE: [PATCH] staging: hv: move hv_netvsc out of staging area

2011-11-29 Thread Haiyang Zhang
> -Original Message- > From: Greg KH [mailto:g...@kroah.com] > Sent: Tuesday, November 29, 2011 10:17 AM > To: Haiyang Zhang > Cc: gre...@suse.de; linux-ker...@vger.kernel.org; > devel@linuxdriverproject.org; NetDev > Subject: Re: [PATCH] staging: hv: move hv_netvsc out of staging area > >

Re: [PATCH] staging: hv: move hv_netvsc out of staging area

2011-11-29 Thread Greg KH
On Mon, Nov 28, 2011 at 10:00:35PM +, Haiyang Zhang wrote: > > -Original Message- > > From: Haiyang Zhang [mailto:haiya...@microsoft.com] > > Sent: Monday, November 28, 2011 4:36 PM > > To: Haiyang Zhang; KY Srinivasan; gre...@suse.de; linux- > > ker...@vger.kernel.org; devel@linuxdrive

[PATCH] comedi_fops: Replace deprecated strict_strtoul with kstrtoul

2011-11-29 Thread Florian Schmaus
As reported by checkpatch.pl strict_strtoul should be replaced with kstrtoul Signed-off-by: Florian Schmaus --- drivers/staging/comedi/comedi_fops.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/come

[PATCH] Staging: VME: PIO2: Correct irq reset

2011-11-29 Thread Martyn Welch
From: root The loop used to reset the interrupt masks has faulty logic. There are 4 banks of 8 I/O, however each mask is comprised of 2 bits and thus there are 8 sets of registers to clear. Driver was wrongly equating this with 8 banks leading to a us writing past the end of the "bank" array (use

[PATCH] Staging: iio/adc: strict_strtoul was used with a long type variable

2011-11-29 Thread Andreas Ruprecht
The function ad7280_store_balance_timer() parses data from a char* buffer into a long variable, but uses the the function strict_strtoul which expects a pointer to an unsigned long variable as its third parameter. As Dan Carpenter mentioned, the values are capped a few lines later, but a check if

Błąd Zauważyłem Code 573FKx9‏

2011-11-29 Thread Systemu Administrator
Drodzy użytkownika konto e-mail Ze wzgledu na niedawne sladu przez naszych pracowników administratora, zauwazylismy, ze rózne komputerów zalogowaniu sie do poczty ektronicznej i wielu hasel awariibyly obecne przed zalogowac. Dlatego twoje konto zostalo ograniczone. Dostep do portalu zarzadzania d

Błąd Zauważyłem Code 573FKx9‏

2011-11-29 Thread Systemu Administrator
Drodzy użytkownika konto e-mail Ze wzgledu na niedawne sladu przez naszych pracowników administratora, zauwazylismy, ze rózne komputerów zalogowaniu sie do poczty ektronicznej i wielu hasel awariibyly obecne przed zalogowac. Dlatego twoje konto zostalo ograniczone. Dostep do portalu zarzadzania d

[smatch stuff] vme: memory corruption in pio2_gpio_reset()

2011-11-29 Thread Dan Carpenter
Smatch found a memory corruption bug in pio2_gpio_reset() but I'm not sure what the correct fix is: drivers/staging/vme/devices/vme_pio2_gpio.c +169 pio2_gpio_reset(24) error: buffer overflow 'card->bank' 4 <= 7 161 /* Set input interrupt masks */ 162 for (i = 0; i

re: staging/mei: don't check if list is empty before looping

2011-11-29 Thread Dan Carpenter
Hello Tomas Winkler, This is a semi-automatic email about new static checker warnings. The patch b7cd2d9fdc01: "staging/mei: don't check if list is empty before looping" from Nov 27, 2011, leads to the following Smatch complaint: drivers/staging/mei/init.c +55 mei_io_list_flush() warn

Re: [PATCH 07/20] lttng wrappers

2011-11-29 Thread Mathieu Desnoyers
* Greg KH (g...@kroah.com) wrote: > On Mon, Nov 28, 2011 at 07:42:14AM -0500, Mathieu Desnoyers wrote: > > Implement wrappers for compatibility with older kernel versions and > > kernels with had the libringbuffer (old) patchset applied. > > > > Signed-off-by: Mathieu Desnoyers > > Are these goi