On Thu, Dec 08, 2011 at 08:23:39PM -0500, Devendra Naga wrote:
> From: Dev
Not good.
> Signed-off-by: Devendra Naga
Good.
So, care to try a third time?
greg k-h
___
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject
On Thu, Dec 8, 2011 at 6:07 PM, Greg KH wrote:
>> > Definitely 3.2-fix material IMO :)
>>
>> I believe it was pushed to staging-next... I'm rooting so it can be
>> pushed to staging-linus :)
>
> As it wasn't originally stated that this was a problem that needed to be
> fixed for 3.2, can it wait f
From: Dev
Signed-off-by: Devendra Naga
---
drivers/staging/rts5139/rts51x.h |1 -
drivers/staging/rts5139/rts51x_transport.h |1 -
2 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rts5139/rts51x.h b/drivers/staging/rts5139/rts51x.h
index 9415d5c.
On Thu, 8 Dec 2011, Greg KH wrote:
On Fri, Dec 02, 2011 at 07:55:14PM +, Marcos Paulo de Souza wrote:
This patch removes some useless comments, commented code and blank
lines. Also fix coding style of headers of functions.
Signed-off-by: Marcos Paulo de Souza
Cc: Greg Kroah-Hartman
Cc: d
On Fri, Dec 9, 2011 at 2:07 AM, Greg KH wrote:
> On Thu, Dec 08, 2011 at 02:16:10PM -0600, Ramirez Luna, Omar wrote:
>> On Thu, Dec 8, 2011 at 2:11 PM, Felipe Contreras
>> > Definitely 3.2-fix material IMO :)
>>
>> I believe it was pushed to staging-next... I'm rooting so it can be
>> pushed to st
On Thu, Dec 08, 2011 at 02:16:10PM -0600, Ramirez Luna, Omar wrote:
> On Thu, Dec 8, 2011 at 2:11 PM, Felipe Contreras
> wrote:
> > On Sat, Nov 19, 2011 at 12:18 AM, Omar Ramirez Luna
> > wrote:
> >> Given that dm timer framework doesn't support request of clocks
> >> by soft | hard irqs because
On Thu, Dec 08, 2011 at 06:22:18PM +0530, Ravishankar karkala Mallikarjunayya
wrote:
> This is a patch to the ni_at_a2150.c file that fixes up a brace
> warning found by the checkpatch.pl tool.
No it doesn't.
___
devel mailing list
devel@linuxdriverpro
On Thu, Dec 08, 2011 at 06:22:19PM +0530, Ravishankar karkala Mallikarjunayya
wrote:
> This is a patch to the cb_pcidda.c file that fixes up a brace
> warning found by the checkpatch.pl tool.
No it doesn't.
___
devel mailing list
devel@linuxdriverproje
On Thu, Dec 08, 2011 at 06:22:17PM +0530, Ravishankar karkala Mallikarjunayya
wrote:
> This is a patch to the ni_at_a2150.c file that fixes up a brace
> warning found by the checkpatch.pl tool.
>
> Removed unnecessary printk statement.
Which causes a bug, please don't do that.
greg k-h
On Thu, Dec 08, 2011 at 06:22:01PM +0530, Ravishankar karkala Mallikarjunayya
wrote:
> This is a patch to the daqboard2000.c file that fixes up a
> line over 80 character warning found by the checkpatch.pl tool.
>
Your subject: is incorrect, so I can't apply this.
greg k-h
_
On Thu, Dec 08, 2011 at 06:21:59PM +0530, Ravishankar karkala Mallikarjunayya
wrote:
> This is a patch to the daqboard2000.c file that fixes up a
> printk warning found by the checkpatch.pl tool.
>
> Removed ifdef DEBUG_EEPROM.
Are you sure you can?
> Converted printks to pr_.
Again, please us
On Thu, Dec 08, 2011 at 06:21:58PM +0530, Ravishankar karkala Mallikarjunayya
wrote:
> This is a patch to the daqboard2000.c file that fixes up a
> printk warning found by the checkpatch.pl tool.
>
> Converted printks to pr_.
>
> Signed-off-by: Ravishankar Karkala Mallikarjunayya
>
> ---
> dr
On Thu, Dec 08, 2011 at 12:12:44PM +0100, Florian Schmaus wrote:
> As reported by checkpatch.pl strict_strtoul should be replaced. It was
> replaced with kstrtouint since async->max_bufsize is an unsigned int
> anyway.
>
> Signed-off-by: Florian Schmaus
PLEASE always run your patches through che
On Thu, Dec 08, 2011 at 06:23:54AM +0100, Ingo Molnar wrote:
>
> * Greg KH wrote:
>
> > > Same goes for a whole lot of other crap that distros are
> > > carrying. Would we want to merge a different CPU scheduler
> > > or the 4g:4g patch or a completely new networking stack into
> > > drivers/
On Mon, Dec 05, 2011 at 05:49:57AM -0500, Dev wrote:
>
> Signed-off-by: Dev
Hm, I think I need a bit more "real" name here. Care to resend it with
something "real"?
thanks,
greg k-h
___
devel mailing list
devel@linuxdriverproject.org
http://driverde
On Fri, Dec 02, 2011 at 07:55:14PM +, Marcos Paulo de Souza wrote:
> This patch removes some useless comments, commented code and blank
> lines. Also fix coding style of headers of functions.
>
> Signed-off-by: Marcos Paulo de Souza
> Cc: Greg Kroah-Hartman
> Cc: de...@driverdev.osuosl.org
>
On Tue, Dec 06, 2011 at 05:38:41PM +0100, Johannes Tenschert wrote:
> Hi,
>
> this patch contains coding style fixes (indentation, placing of braces
> and spaces, breaking long lines) in HandleControlPacket.c.
>
> It fixes most warnings and errors of scripts/checkpatch.pl. Those left aren't
> rea
On Wed, Nov 30, 2011 at 07:29:56PM -0500, Sean MacLennan wrote:
> The rtl8192u/ieee80211 contains some unused header and c files. Remove
> them. Also the file ieee80211_crypt.h was in the top level rtl8192u
> directory but was not used.
>
> Signed-off-by: Sean MacLennan
This patch failed to appl
On 12/08/2011 04:45 PM, Lars-Peter Clausen wrote:
> Fix a small typo in the iio_modifer enum.
lol. Clearly not one of our more heavily used elements.
Good to catch it though.
>
> Signed-off-by: Lars-Peter Clausen
Acked-by: Jonathan Cameron
> ---
> drivers/staging/iio/types.h |2 +-
> 1 file
On Thu, Dec 08, 2011 at 06:35:53PM +0100, Lars-Peter Clausen wrote:
> When updating the scan mask we have to check the actual scan mask for if the
> channel is already enabled, not the matching scan mask from the available
> scan masks. The bit will already be set there and as a result the actual
>
On Thu, Dec 08, 2011 at 06:35:52PM +0100, Lars-Peter Clausen wrote:
> n is the number of bytes to read, not the number of samples. So if there is
> enough data available we will write to the userspace buffer beyond its bounds.
> Fix this by copying n bytes maximum. Also round n down to the next mul
On Thu, Dec 8, 2011 at 2:11 PM, Felipe Contreras
wrote:
> On Sat, Nov 19, 2011 at 12:18 AM, Omar Ramirez Luna
> wrote:
>> Given that dm timer framework doesn't support request of clocks
>> by soft | hard irqs because some recent changes, tidspbridge needs
>> to request its clocks on init and ena
On Thu, Dec 8, 2011 at 1:50 PM, Felipe Contreras
wrote:
> On Thu, Dec 8, 2011 at 9:10 PM, Ramirez Luna, Omar
> wrote:
>> On Wed, Dec 7, 2011 at 4:11 PM, Felipe Contreras
>> wrote:
>>> On Sat, Nov 19, 2011 at 12:18 AM, Omar Ramirez Luna
>>> wrote:
Given that dm timer framework doesn't sup
On Sat, Nov 19, 2011 at 12:18 AM, Omar Ramirez Luna wrote:
> Given that dm timer framework doesn't support request of clocks
> by soft | hard irqs because some recent changes, tidspbridge needs
> to request its clocks on init and enable/disable them on demand.
>
> This was first seen on 3.2-rc1.
>
On Sun, Dec 04, 2011 at 08:01:39PM -0200, Marcos Paulo de Souza wrote:
> On Sat, 3 Dec 2011, Dan Carpenter wrote:
> >On Fri, Dec 02, 2011 at 07:58:12PM +, Marcos Paulo de Souza wrote:
> >>This patch removes commented code, useless comments, blank lines and fix
> >>coding style of the headers of
On Thu, Dec 8, 2011 at 9:10 PM, Ramirez Luna, Omar wrote:
> On Wed, Dec 7, 2011 at 4:11 PM, Felipe Contreras
> wrote:
>> On Sat, Nov 19, 2011 at 12:18 AM, Omar Ramirez Luna
>> wrote:
>>> Given that dm timer framework doesn't support request of clocks
>>> by soft | hard irqs because some recent
On Wed, Dec 7, 2011 at 4:11 PM, Felipe Contreras
wrote:
> On Sat, Nov 19, 2011 at 12:18 AM, Omar Ramirez Luna
> wrote:
>> Given that dm timer framework doesn't support request of clocks
>> by soft | hard irqs because some recent changes, tidspbridge needs
>> to request its clocks on init and ena
When updating the scan mask we have to check the actual scan mask for if the
channel is already enabled, not the matching scan mask from the available
scan masks. The bit will already be set there and as a result the actual
scan mask will not get updated and the channel stays disabled.
Also fix th
n is the number of bytes to read, not the number of samples. So if there is
enough data available we will write to the userspace buffer beyond its bounds.
Fix this by copying n bytes maximum. Also round n down to the next multiple of
the sample size, so we will only read complete samples. If the bu
The sw_ring does not properly handle the case where the write pointer already
has wrapped around, the read pointer has not and the remaining buffer space at
the end is enough to fill the read buffer:
+---+
| | |##data##| |
+---
Fix a small typo in the iio_modifer enum.
Signed-off-by: Lars-Peter Clausen
---
Changes since v1:
* Fix up the order of subsystem is the subject line.
---
drivers/staging/iio/types.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/iio/types.h b/
Fix a small typo in the iio_modifer enum.
Signed-off-by: Lars-Peter Clausen
---
drivers/staging/iio/types.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/iio/types.h b/drivers/staging/iio/types.h
index f1f5ca2..b7d2647 100644
--- a/drivers/staging/iio/
On Wed, Dec 07, 2011 at 06:25:05PM +0100, Johannes Tenschert wrote:
> Hi,
>
> this updated patch contains coding style fixes in led_control.c. Its
> broken up into several patches as suggested by Dan Carpenter:
>
> [PATCH v2 1/5] staging: bcm: led_control.c: fix whitespaces
> [PATCH v2 2/5] stagi
On Thu, Dec 08, 2011 at 06:22:04PM +0530, Ravishankar karkala Mallikarjunayya
wrote:
> This is a patch to the pcmuio.c file that fixes up a
> printk warning found by the checkpatch.pl tool.
>
> Added KERN_facility levels for printks.
You shouldn't use printk, use the dev_* macros, e.g. dev_warn,
After much attempts to reach you on phone, I deemed it necessary and urgent to
contact you via your e-mail and to notify you finally about your outstanding
compensation payment.
During our last annual calculation of your banking activities we have realized
that you are eligible to receive a co
This is a patch to the das1800.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Included KERN_facility levels for printk.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/das1800.c |8
1 files changed, 4 insertions(+), 4 d
This is a patch to the cb_pcidas64.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Added KERN_facility levels for printk.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/cb_pcidas64.c |7 ---
1 files changed, 4 insertions(+),
This is a patch to the cb_pcidas64.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Included KERN_facility levels for printk.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 14 +++---
1 files changed, 7 inse
This is a patch to the cb_pcidas.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Removed ifdef CB_PCIDAS_DEBUG.
Included KERN_facility levels for printk.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/cb_pcidas.c |7 +++
1 f
This is a patch to the cb_pcidas.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Removed ifdef CB_PCIDAS_DEBUG.
Included KERN_facility levels for printk.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/cb_pcidas.c | 19 +++-
This is a patch to the cb_pcidas.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Removed ifdef CB_PCIDAS_DEBUG.
Included KERN_facility levels for printk.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/cb_pcidas.c | 12 +++-
This is a patch to the cb_pcidda.c file that fixes up a brace
warning found by the checkpatch.pl tool.
Added KERN_facitity levels for printks.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/cb_pcidda.c | 26 +-
1 files changed, 1
This is a patch to the ni_at_a2150.c file that fixes up a brace
warning found by the checkpatch.pl tool.
Converted printks to pr_.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/ni_at_a2150.c | 27 +
1 files changed, 14 insertion
This is a patch to the ni_at_a2150.c file that fixes up a brace
warning found by the checkpatch.pl tool.
Removed unnecessary printk statement.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/ni_at_a2150.c | 27 ++---
1 files changed,
This is a patch to the jr3_pci.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Added KERN_facility levels for printks.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/jr3_pci.c | 14 +++---
1 files changed, 7 insertions(+),
This is a patch to the jr3_pci.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Converted printks to pr_.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/jr3_pci.c | 46 ++---
1 files changed, 22 insertions(+
This is a patch to the jr3_pci.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Converted printks to pr_.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/jr3_pci.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
d
This is a patch to the jr3_pci.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Converted printks to pr_.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/jr3_pci.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
d
This is a patch to the dt3000.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Converted printks to pr_.
Removed if DEBUG.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/dt3000.c | 12 +---
1 files changed, 5 insertions(+),
This is a patch to the dt3000.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Converted printks to pr_.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/dt3000.c | 18 +-
1 files changed, 9 insertions(+), 9 deletions
This is a patch to the dt3000.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Removed ifdef DEBUG.
Converted printks to pr_.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/dt3000.c | 11 ---
1 files changed, 4 insertions(+
This is a patch to the dt3000.c file that fixes up a initialise
statics to 0 or NULL warning found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/dt3000.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/
This is a patch to the contec_pci_dio.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Converted printks to pr_.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/contec_pci_dio.c | 14 +++---
1 files changed, 7 insertions(+),
This is a patch to the contec_pci_dio.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Added KERN_facility levels to printks.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/contec_pci_dio.c | 10 --
1 files changed, 4 inser
This is a patch to the cb_pcimdas.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/cb_pcimdas.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/c
This is a patch to the pcmuio.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Removed ifdef DAMMIT_ITS_BROKEN.
Converted printks to pr_.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/pcmuio.c | 13 +++--
1 files changed,
This is a patch to the pcmuio.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Added KERN_facility levels for printks.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/pcmuio.c | 23 +++
1 files changed, 11 insert
This is a patch to the cb_pcimdda.c file that fixes up a
line over 80 character warning found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/cb_pcimdda.c | 24 +---
1 files changed, 17 insertions(+), 7 delet
This is a patch to the cb_pcimdda.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Removed unnecessary printk statements.
Included KERN_facility levels.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/cb_pcimdda.c | 17 ++---
This is a patch to the daqboard2000.c file that fixes up a
line over 80 character warning found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/daqboard2000.c | 10 +++---
1 files changed, 7 insertions(+), 3 deletions(-)
di
This is a patch to the daqboard2000.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Removed unnecessary printk statement.
Included KERN_facility level.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/daqboard2000.c | 15 +--
This is a patch to the daqboard2000.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Removed ifdef DEBUG_EEPROM.
Converted printks to pr_.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/daqboard2000.c | 17 -
1 file
This is a patch to the daqboard2000.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Converted printks to pr_.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/daqboard2000.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions
This is a patch to the daqboard2000.c file that fixes up a brace
warning found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/daqboard2000.c | 15 +--
1 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/
This is a patch to the cb_das16_cs.c file that fixes up a initialise
statics to 0 or NULL warning found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/cb_das16_cs.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
dif
Signed-off-by: Florian Schmaus
---
drivers/staging/comedi/comedi_fops.c | 30 +++---
1 files changed, 11 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/comedi/comedi_fops.c
b/drivers/staging/comedi/comedi_fops.c
index 220f24f..d7f7feb 100644
--- a/drivers/
As reported by checkpatch.pl strict_strtoul should be replaced. It was replaced
with kstrtouint since async->max_bufsize is an unsigned int anyway.
Signed-off-by: Florian Schmaus
---
drivers/staging/comedi/comedi_fops.c | 34 +-
1 files changed, 21 insertions(+
> The storage driver (storvsc_drv.c) handles all block storage devices
> assigned to Linux guests hosted on Hyper-V. This driver has been in the
> staging tree for a while and this patch moves it out of the staging area.
> As per Greg's recommendation, this patch makes no changes to the
> staging/h
On Wed, Dec 07, 2011 at 07:28:07PM +, Marcos Paulo de Souza wrote:
> So, I agree with you. So, we can make some chnages and ask for
> people to test it? I don't have other hardware than my x86.
>
> So, I think we can remove the typedefs of unsigned char to BYTE.
>
> When I submit some patches
* Mathieu Desnoyers wrote:
> Hi Ingo,
>
> * Ingo Molnar (mi...@elte.hu) wrote:
> [...]
> > Mathieu, please work with the tracing folks who DO care about
> > this stuff. It's not like there's a lack of interest in this
> > area, nor is there a lack of willingness to take patches. What
> > the
70 matches
Mail list logo
