On Mon, Dec 12, 2011 at 11:09:05AM +0100, Lars-Peter Clausen wrote:
> Setup the buffer access functions in the buffer allocate function. There is no
> need to let each driver handle this on its own.
This patch breaks the build, so I can't take it.
Please be more careful in the future, breakages l
On Mon, Dec 12, 2011 at 11:08:46AM +0100, Lars-Peter Clausen wrote:
> Add some convenience wrapper functions around the buffer access operations.
> This
> makes the resulting code both a bit easier to read and to write.
Yeah, but why are you abstracting this away?
>
> Signed-off-by: Lars-Peter
On Mon, Dec 12, 2011 at 11:09:05AM +0100, Lars-Peter Clausen wrote:
> Setup the buffer access functions in the buffer allocate function. There is no
> need to let each driver handle this on its own.
That's nicer.
So, you have different ways to have "buffers" and the driver doesn't
know what type
> -Original Message-
> From: Greg KH [mailto:gre...@suse.de]
> Sent: Monday, December 12, 2011 6:49 PM
> To: KY Srinivasan
> Cc: Greg KH; linux-ker...@vger.kernel.org; devel@linuxdriverproject.org;
> virtualizat...@lists.osdl.org; oher...@suse.com; Haiyang Zhang
> Subject: Re: [PATCH 4/4]
On Mon, Dec 12, 2011 at 11:44:30PM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Greg KH [mailto:g...@kroah.com]
> > Sent: Monday, December 12, 2011 5:27 PM
> > To: KY Srinivasan
> > Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> > devel@linuxdriverproject.org; vir
> -Original Message-
> From: Greg KH [mailto:g...@kroah.com]
> Sent: Monday, December 12, 2011 5:28 PM
> To: KY Srinivasan
> Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> devel@linuxdriverproject.org; virtualizat...@lists.osdl.org; oher...@suse.com
> Subject: Re: [PATCH /0004] D
> -Original Message-
> From: Greg KH [mailto:g...@kroah.com]
> Sent: Monday, December 12, 2011 5:27 PM
> To: KY Srinivasan
> Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> devel@linuxdriverproject.org; virtualizat...@lists.osdl.org; oher...@suse.com;
> Haiyang Zhang
> Subject: Re: [P
The function strict_strtoul is obsolete and replaced by kstrtouint
and kstrtoint.
If kstrto* fails its return code is returned instead of -EINVAL.
Signed-off-by: Johannes Tenschert
---
drivers/staging/iio/light/tsl2583.c | 48 +-
1 files changed, 30 insertions
The function strict_strtoul is obsolete and replaced by kstrtoul
and kstrtoint.
If kstrto* fails its return code is returned instead of -EINVAL.
Signed-off-by: Johannes Tenschert
---
drivers/staging/iio/light/isl29018.c | 24 +++-
1 files changed, 15 insertions(+), 9 dele
Hi,
I changed the patch to use the right kstrto* as Dan Carpenter suggested, but
I'm not familiar enough with the code to fix the divide by zero bug in a good
way.
I also didn't change taos_settings because I don't know it well enough and don't
want to introduce new bugs. So kstrtoint was used pr
On Mon, Dec 12, 2011 at 09:29:19AM -0800, K. Y. Srinivasan wrote:
> Support building the vmbus driver as part of the kernel.
>
> Signed-off-by: K. Y. Srinivasan
> Signed-off-by: Haiyang Zhang
This was already applied to my tree, I don't know why you missed it...
greg k-h
_
On Mon, Dec 12, 2011 at 09:28:51AM -0800, K. Y. Srinivasan wrote:
> Some fixes to the vmbus driver:
>
> 1. Fix a memory leak in a failure path.
>
> 2. Make vmbus driver unloadable.
>
> 3. Get rid of an unnecessary check in hv_init()
> in preparation for supporting kexe
On Mon, Dec 12, 2011 at 04:40:59PM +0100, Stefan Hengelein wrote:
> As scripts/checkpatch.pl suggested, there has been a call of the
> obsolete function strict_strtoul which should be replaced with a
> kstrtox-function.
>
> Signed-off-by: Stefan Hengelein
>
> ---
This doesn't apply to linux-nex
These patches need to be CC'd to the iio mailing list, and Jonathan
Cameron as well. Use the ./scripts/get_maintainer.pl script for
hints who should be CC'd.
On Mon, Dec 12, 2011 at 03:35:03PM +0100, Johannes Tenschert wrote:
> @@ -621,7 +621,7 @@ static ssize_t taos_als_trim_store(struct device
Some fixes to the vmbus driver:
1. Fix a memory leak in a failure path.
2. Make vmbus driver unloadable.
3. Get rid of an unnecessary check in hv_init()
in preparation for supporting kexec().
4. Make it possible to build the vmbus driver as part of the
Support building the vmbus driver as part of the kernel.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
---
drivers/hv/vmbus_drv.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index aafee6b..1d3d809 1006
On 12/12/2011 09:04 AM, Martyn Welch wrote:
> The PIO2 driver errors when GPIOLIB, on which it depends, is not enabled.
>
> Add dependancy when selecting the PIO2.
>
> Reported-by: Randy Dunlap
> Signed-off-by: Martyn Welch
Acked-by: Randy Dunlap
Thanks.
> ---
>
> Sorry, missed the email o
In preparation for eventually supporting kexec in Linux VMs on Hyper-V,
get rid of an unnecessary check in hv_init().
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
---
drivers/hv/hv.c |5 -
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/hv/hv.c b/d
It turns out that the vmbus driver can be made unloadable. Make it
unloadable.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
---
drivers/hv/channel_mgmt.c | 11 +++
drivers/hv/hv.c |3 +++
drivers/hv/hyperv_vmbus.h |1 +
drivers/hv/vmbus_drv.c| 1
There was a memory leak in a failure path in vmbus_process_offer().
Fix it.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
---
drivers/hv/channel_mgmt.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c
i
The PIO2 driver errors when GPIOLIB, on which it depends, is not enabled.
Add dependancy when selecting the PIO2.
Reported-by: Randy Dunlap
Signed-off-by: Martyn Welch
---
Sorry, missed the email on the 6th.
drivers/staging/vme/devices/Kconfig |1 +
1 files changed, 1 insertions(+), 0 de
as
> incomplete type
This error is still in linux-next of 20111212.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
___
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
As scripts/checkpatch.pl suggested, there has been a call of the
obsolete function strict_strtoul which should be replaced with a
kstrtox-function.
Signed-off-by: Stefan Hengelein
---
drivers/staging/iio/industrialio-core.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --g
The function strict_strtoul is obsolete and replaced by kstrtoul.
Signed-off-by: Johannes Tenschert
---
drivers/staging/iio/light/tsl2583.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/iio/light/tsl2583.c
b/drivers/staging/iio/light/tsl258
The function strict_strtoul is obsolete and replaced by kstrtoul.
Signed-off-by: Johannes Tenschert
---
drivers/staging/iio/light/isl29018.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/iio/light/isl29018.c
b/drivers/staging/iio/light/isl29018.c
Wir sind auf dem XAMS Kredit Angebot mit so viel Bonus, bitte
kontaktieren Sie mich, wenn Sie tun müssen, jede Form von Darlehen von
unserer Firma.
Grüße
We are on our xams loan special offer with so much bonus, please do
contact me if you do need any form of loan from our firm.
Regards
_
Setup the buffer access functions in the buffer allocate function. There is no
need to let each driver handle this on its own.
Signed-off-by: Lars-Peter Clausen
Acked-by: Jonathan Cameron
---
drivers/staging/iio/accel/adis16201_ring.c |2 --
drivers/staging/iio/accel/adis16203_ring.c
Add some convenience wrapper functions around the buffer access operations. This
makes the resulting code both a bit easier to read and to write.
Signed-off-by: Lars-Peter Clausen
Acked-by: Jonathan Cameron
---
drivers/staging/iio/buffer.h | 68 +
driv
n is the number of bytes to read, not the number of samples. So if there is
enough data available we will write to the userspace buffer beyond its bounds.
Fix this by copying n bytes maximum. Also round n down to the next multiple of
the sample size, so we will only read complete samples. If the bu
Signed-off-by: Devendra Naga
---
drivers/staging/rts5139/rts51x.h |1 -
drivers/staging/rts5139/rts51x_transport.h |1 -
2 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rts5139/rts51x.h b/drivers/staging/rts5139/rts51x.h
index 9415d5c..b2c5839 100
Signed-off-by: Devendra Naga
---
drivers/staging/rts5139/rts51x.h |1 -
drivers/staging/rts5139/rts51x_transport.h |1 -
2 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rts5139/rts51x.h b/drivers/staging/rts5139/rts51x.h
index 9415d5c..b2c5839 100
This is a patch to the jr3_pci.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Added KERN_facility levels for printks.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/jr3_pci.c | 28 ++--
1 files changed, 14
This is a patch to the contec_pci_dio.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Converted printks to dev_ and Removed unnecessary
printk statements.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/contec_pci_dio.c |8 ++
This is a patch to the contec_pci_dio.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Converted printks to dev_dbg().
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/contec_pci_dio.c | 12 ++--
1 files changed, 6 insertions
This is a patch to the das1800.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Converted printk to dev_.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/das1800.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
This is a patch to the das1800.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Included KERN_facility levels for printk.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/das1800.c | 12 ++--
1 files changed, 6 insertions(+),
This is a patch to the cb_pcidda.c file that fixes up a brace
warning found by the checkpatch.pl tool.
Converted printks to dev_dbg().
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/cb_pcidda.c | 26 +-
1 files changed, 13 insert
This is a patch to the cb_pcidas64.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Converted printks to dev_ and Removed unnecessary
printk statements.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/cb_pcidas64.c |7 +++
1 f
This is a patch to the cb_pcidas64.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Converted printks to dev_ and Removed unnecessary
printk statements.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 19 +---
This is a patch to the cb_pcidas.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Converted printks to dev_..
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/cb_pcidas.c | 14 +-
1 files changed, 9 insertions(+), 5 delet
This is a patch to the cb_pcidas.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Converted printks to dev_dbg()..
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/cb_pcidas.c | 11 ++-
1 files changed, 6 insertions(+), 5 del
This is a patch to the das1800.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Converted printks to dev_dbg().
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/das1800.c | 27 ++-
1 files changed, 14 insertio
This is a patch to the das1800.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Coverted printks to dev_.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/das1800.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff
This is a patch to the daqboard2000.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Converted printks to dev_dbg().
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/daqboard2000.c |9 +
1 files changed, 5 insertions(+), 4
This is a patch to the das1800.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Converted printks to dev_.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/das1800.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
dif
This is a patch to the ni_at_a2150.c file that fixes up a brace
warning found by the checkpatch.pl tool.
Converted printks to dev_.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/ni_at_a2150.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
This is a patch to the ni_at_a2150.c file that fixes up a brace
warning found by the checkpatch.pl tool.
Converted printks to dev_.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/ni_at_a2150.c |9 +
1 files changed, 5 insertions(+), 4 deletion
This is a patch to the ni_at_a2150.c file that fixes up a brace
warning found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/ni_at_a2150.c |8 +++-
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/st
48 matches
Mail list logo
