On Sat, 2012-01-21 at 11:22 -0800, sam hansen wrote:
> > One other thing. It would be better to add
> > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > before any #include and convert all the
> > printks(KERN_ to pr_(
> > stripping all the leading XGIfb: too.
>
> So, an administrative question.
> One other thing. It would be better to add
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> before any #include and convert all the
> printks(KERN_ to pr_(
> stripping all the leading XGIfb: too.
So, an administrative question. Sorry for my noob-ishness but... I
will be 1) modifying the patch r
> These last two should be KERN_CONT
> though the block could be rewritten as
>
> if (XGIInitNew(pdev))
> printk(KERN_INFO "XGIfb: XGIInitNew() ... OK\n");
> else
> printk(KERN_ERR "XGIfb: XGIInitNew() ... Fail\n");
>
> Emitting any dmesg output like "XGI
> It doesn't make sense to do this. KERN_ERR puts a "<3>" in front of
> the line so we know how important it is, but it's a blank line
> because of the "\n" at the start.
>
> Also the should probably be using pr_err() or dev_err().
>
> ...
>
> These put a "<3>" in the middle of the line which does
On Sat, 2012-01-21 at 02:10 -0800, Sam Hansen wrote:
> Added KERN_ facility levels in XGI_main_26.c and vb_init.c in a few different
> printk() statements.
[]
> @@ -2018,12 +2018,12 @@ static int __devinit xgifb_probe(struct pci_dev *pdev,
> printk(KERN_INFO "XGIfb: MMIO at 0x%lx, mapped to 0
On Sat, Jan 21, 2012 at 02:10:12AM -0800, Sam Hansen wrote:
> if (reg1 != 0xa1) { /*I/O error */
> - printk("\nXGIfb: I/O error!!!");
> + printk(KERN_ERR "\nXGIfb: I/O error!!!");
It doesn't make sense to do this. KERN_ERR puts a "<3>" in front of
the line so we know
On Sat, Jan 21, 2012 at 03:54:13PM +0100, Németh Márton wrote:
> Hi Greg,
>
> thanks for your response and your questions, I think it will help my
> work very much.
>
> Greg KH wrote:
> > On Sat, Jan 21, 2012 at 11:52:37AM +0100, Németh Márton wrote:
> >> From: Márton Németh
> >>
> >> This drive
Hi Greg,
thanks for your response and your questions, I think it will help my
work very much.
Greg KH wrote:
> On Sat, Jan 21, 2012 at 11:52:37AM +0100, Németh Márton wrote:
>> From: Márton Németh
>>
>> This driver version of Winbond WB528SD can detect mechanical card
>> presence only. The infor
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Sat, Jan 21, 2012 at 01:19:51PM +, Kashyap Gada wrote:
> Greg Im just following your tutorials and when i check the mail im sending in
> terminal it comes proper but when i see the mail what was
On Sat, Jan 21, 2012 at 11:08:38AM +0300, Dan Carpenter wrote:
> On Sat, Jan 21, 2012 at 02:17:49AM +, Kashyap Gada wrote:
> > ---
> > drivers/staging/android/ashmem.c |2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/staging/android/ashmem.c
> > b/
On Sat, Jan 21, 2012 at 11:52:37AM +0100, Németh Márton wrote:
> From: Márton Németh
>
> This driver version of Winbond WB528SD can detect mechanical card
> presence only. The information is provided through sysfs.
How is it provided through sysfs? Is this done in a standard way? If
not, why n
From: Márton Németh
This driver version of Winbond WB528SD can detect mechanical card
presence only. The information is provided through sysfs.
Signed-off-by: Márton Németh
Cc: techeng
---
drivers/staging/Kconfig |2 +
drivers/staging/Makefile |1 +
drivers/staging/
Added KERN_ facility levels in XGI_main_26.c and vb_init.c in a few different
printk() statements.
Signed-off-by: Sam Hansen
---
drivers/staging/xgifb/XGI_main_26.c | 16
drivers/staging/xgifb/vb_init.c |2 +-
2 files changed, 9 insertions(+), 9 deletions(-)
diff --gi
Cleaned up XGI_main_26.c and removed some unneeded braces to keep with code
conventions.
Signed-off-by: Sam Hansen
---
drivers/staging/xgifb/XGI_main_26.c | 10 +++---
1 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c
b/drivers/staging/xgif
Replaced an instance of __FUNCTION__ with __func__ in XGI_main_26.c.
Signed-off-by: Sam Hansen
---
drivers/staging/xgifb/XGI_main_26.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c
b/drivers/staging/xgifb/XGI_main_26.c
index dd97b7
On Sat, Jan 21, 2012 at 04:23:32AM +, Kashyap Gada wrote:
> -#define PMEM_IS_FREE(id, index) !(pmem[id].bitmap[index].allocated)
> -#define PMEM_ORDER(id, index) pmem[id].bitmap[index].order
> +#define PMEM_IS_FREE(id, index) (!(pmem[id].bitmap[index].allocated))
> +#define PMEM_ORDER(id, index
On Fri, Jan 20, 2012 at 07:56:20PM -0800, Arve Hjønnevåg wrote:
> - Add a mutex to protect against two processes mmapping the
> same binder_proc.
> - After locking mmap_sem, check that the vma we want to access
> (still) points to the same mm_struct.
> - Use proc->tsk instead of current to get
On Sat, Jan 21, 2012 at 02:17:49AM +, Kashyap Gada wrote:
> ---
> drivers/staging/android/ashmem.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/android/ashmem.c
> b/drivers/staging/android/ashmem.c
> index 4a00174a5..9f1f27e 100644
> --- a/dr
18 matches
Mail list logo
