[PATCH V2 3/3] xgifb: checkpatch cleanup printk() -> pr_lvl()

2012-01-22 Thread Sam Hansen
Rewrote code to use pr_lvl() instead of printk(). There are still a few instances of printk(), mainly in the debug code which looks like it's going to be dropped/rewrote (most of it is blocked out). Signed-off-by: Sam Hansen --- drivers/staging/xgifb/XGI_main_26.c | 88 +--

[PATCH V2 2/3] xgifb: checkpatch cleanup __func__

2012-01-22 Thread Sam Hansen
Replaced an instance of __FUNCTION__ with __func__ in XGI_main_26.c. Signed-off-by: Sam Hansen --- drivers/staging/xgifb/XGI_main_26.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c index dd97b7

[PATCH V2 1/3] xgifb: checkpatch cleanup braces

2012-01-22 Thread Sam Hansen
Cleaned up XGI_main_26.c and removed some unneeded braces to keep with code conventions. Signed-off-by: Sam Hansen --- drivers/staging/xgifb/XGI_main_26.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgif

[PATCH V2 0/3] xgifb: patch set

2012-01-22 Thread Sam Hansen
There is still some cleanup to do for printk, but mainly in the debug code. I noticed the bulk of it is commented out and suspect the rest will follow suit. $ make modules make[1]: Nothing to be done for `all'. CHK include/linux/version.h CHK include/generated/utsrelease.h CALLs

[PATCH] rts5139: fix pointer coding style

2012-01-22 Thread Németh Márton
From: Márton Németh This will remove the following checkpatch.pl error: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Márton Németh --- drivers/staging/rts5139/ms.h |4 ++-- drivers/staging/rts5139/rts51x_chip.c | 14 +++--- drivers/staging/rts5139/rts

[PATCH] Staging: android: ram_console: Use resource_size function

2012-01-22 Thread Thomas Meyer
The semantic patch that makes this change is available in scripts/coccinelle/api/resource_size.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/staging/android/ram_console.c b/drivers/staging/android

[PATCH] drm/omap: Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(..

2012-01-22 Thread Thomas Meyer
The semantic patch that makes this change is available in scripts/coccinelle/api/err_cast.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/staging/omapdrm/omap_gem_helpers.c b/drivers/staging/omapdrm

[PATCH] Staging: bcm: Use memdup_user rather than duplicating its implementation

2012-01-22 Thread Thomas Meyer
This is a little bit restricted to reduce false positives The semantic patch that makes this change is available in scripts/coccinelle/api/memdup_user.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Thomas Meyer --- diff -u -p a/drivers

Re: [PATCH v2 15/17] Staging: quickstart: Use pr_err and pr_info for logs

2012-01-22 Thread Szymon Janc
Hi, > Add a space please between KBUILD_MODNAME and the quoted string. > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > Please try not to break format strings into multiple bits. > It's very error prone and can make it harder to grep. > It's OK to have the line with the format exceed 80 chars.

[PATCH v3 15/17] Staging: quickstart: Use pr_err and pr_info for logs

2012-01-22 Thread Szymon Janc
Signed-off-by: Szymon Janc --- drivers/staging/quickstart/quickstart.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/quickstart/quickstart.c b/drivers/staging/quickstart/quickstart.c index a67b03a..88f8ff3 100644 --- a/drivers/staging/qui

[PATCH] xgifb: pr_fmt kbuild macro

2012-01-22 Thread Sam Hansen
Added the kbuild macro pr_fmt() to XGI_main_26.c Signed-off-by: Sam Hansen --- drivers/staging/xgifb/XGI_main_26.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c index 2502c49..edd7de7 100644 --