Re: [PATCH v2 00/17] Some work on quickstart driver in staging

2012-02-10 Thread Dan Carpenter
On Thu, Feb 09, 2012 at 09:14:18PM +0100, Szymon Janc wrote: Also, you just created the following build warning, please send me a patch fixing it up: drivers/staging/quickstart/quickstart.c: In function ‘quickstart_acpi_ghid’: drivers/staging/quickstart/quickstart.c:212:5: warning:

Re: [RFC/RFT] p54spi: Convert driver to use asynchronous firmware loading

2012-02-10 Thread Michael Büsch
On Thu, 09 Feb 2012 19:05:37 -0600 Larry Finger larry.fin...@lwfinger.net wrote: Index: wireless-testing-new/drivers/net/wireless/p54/p54spi.c === --- wireless-testing-new.orig/drivers/net/wireless/p54/p54spi.c +++

RE: [PATCH 1/1] Staging: hv: storvsc: Move the storage driver out of the staging area

2012-02-10 Thread KY Srinivasan
-Original Message- From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] Sent: Thursday, February 09, 2012 3:46 PM To: KY Srinivasan Cc: Greg KH; linux-ker...@vger.kernel.org; devel@linuxdriverproject.org; virtualizat...@lists.osdl.org; oher...@suse.com;

Re: [PATCH 3/4] staging: comedi: ni_pcidio: Add comedi_poll support

2012-02-10 Thread Ian Abbott
On 2012-02-09 18:02, Greg KH wrote: On Mon, Jan 09, 2012 at 03:47:32PM +, Ian Abbott wrote: This patch is ported over by me (Ian Abbott) from the out-of-tree Comedi git repository at git://comedi.org/git/comedi/comedi.git. The original patch is by Nicholas Nell. The patch adds support for

Re: [PATCH 3/4] staging: comedi: ni_pcidio: Add comedi_poll support

2012-02-10 Thread Greg KH
On Fri, Feb 10, 2012 at 01:33:49PM +, Ian Abbott wrote: On 2012-02-09 18:02, Greg KH wrote: On Mon, Jan 09, 2012 at 03:47:32PM +, Ian Abbott wrote: This patch is ported over by me (Ian Abbott) from the out-of-tree Comedi git repository at git://comedi.org/git/comedi/comedi.git. The

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-10 Thread Justin P. Mattock
On Thu, 9 Feb 2012 21:18:49 -0800 Greg KH gre...@linuxfoundation.org wrote: On Thu, Feb 09, 2012 at 04:45:00PM -0800, Ramirez Luna, Omar wrote: Hi, On Thu, Feb 9, 2012 at 3:30 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Again, I'm totally confused as to _WHY_ this needs to

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-10 Thread Felipe Contreras
On Fri, Feb 10, 2012 at 5:35 PM, Justin P. Mattock justinmatt...@gmail.com wrote: On Thu, 9 Feb 2012 21:18:49 -0800 Greg KH gre...@linuxfoundation.org wrote: On Thu, Feb 09, 2012 at 04:45:00PM -0800, Ramirez Luna, Omar wrote: Hi, On Thu, Feb 9, 2012 at 3:30 PM, Felipe Contreras

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-10 Thread Justin P. Mattock
On Fri, 10 Feb 2012 18:05:59 +0200 Felipe Contreras felipe.contre...@gmail.com wrote: On Fri, Feb 10, 2012 at 5:35 PM, Justin P. Mattock justinmatt...@gmail.com wrote: On Thu, 9 Feb 2012 21:18:49 -0800 Greg KH gre...@linuxfoundation.org wrote: On Thu, Feb 09, 2012 at 04:45:00PM -0800,

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-10 Thread Felipe Contreras
On Fri, Feb 10, 2012 at 7:18 AM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Feb 09, 2012 at 04:45:00PM -0800, Ramirez Luna, Omar wrote: Hi, On Thu, Feb 9, 2012 at 3:30 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Again, I'm totally confused as to _WHY_ this needs to be y.  

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-10 Thread Greg KH
On Fri, Feb 10, 2012 at 06:05:59PM +0200, Felipe Contreras wrote: From 5c7ad6c00d051d574007cdbecdf14bf3d0cb Mon Sep 17 00:00:00 2001 From: Justin P. Mattock justinmatt...@gmail.com Date: Fri, 10 Feb 2012 07:19:45 -0800 Subject: [PATCH] Add dependency TIDSBRIDGE_WDT3 to TIDSBRIDGE.

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-10 Thread Felipe Contreras
On Fri, Feb 10, 2012 at 6:16 PM, Greg KH gre...@linuxfoundation.org wrote: On Fri, Feb 10, 2012 at 06:05:59PM +0200, Felipe Contreras wrote: From 5c7ad6c00d051d574007cdbecdf14bf3d0cb Mon Sep 17 00:00:00 2001 From: Justin P. Mattock justinmatt...@gmail.com Date: Fri, 10 Feb 2012 07:19:45

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-10 Thread Greg KH
On Fri, Feb 10, 2012 at 06:16:19PM +0200, Felipe Contreras wrote: On Fri, Feb 10, 2012 at 7:18 AM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Feb 09, 2012 at 04:45:00PM -0800, Ramirez Luna, Omar wrote: Hi, On Thu, Feb 9, 2012 at 3:30 PM, Felipe Contreras

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-10 Thread Dan Carpenter
On Fri, Feb 10, 2012 at 01:30:48AM +0200, Felipe Contreras wrote: It's not an oops, it's a warning, and again, it depends on the firmware being used. We don't have control over that, and we have no way to detect if this feature is there. It's up to the user. Perhaps just remove the warning

Re: Staging: bcm: Don't leak 'pstAddIndication' in CmHost.c::StoreCmControlResponseMessage()

2012-02-10 Thread Greg KH
On Thu, Feb 09, 2012 at 11:33:25PM +0100, Jesper Juhl wrote: From: Jesper Juhl j...@codesealer.com We allocate memory for 'pstAddIndication' with kmalloc() in drivers/staging/bcm/CmHost.c::StoreCmControlResponseMessage() and then neglect to free it on a number of exit paths from that

Re: [PATCH 1/1] Staging: hv: storvsc: Move the storage driver out of the staging area

2012-02-10 Thread Greg KH
On Thu, Feb 09, 2012 at 02:14:48PM -0800, K. Y. Srinivasan wrote: The storage driver (storvsc_drv.c) handles all block storage devices assigned to Linux guests hosted on Hyper-V. This driver has been in the staging tree for a while and this patch moves it out of the staging area. James was

[PATCH 2/4] staging:iio: Rename IIO_EVENT_CODE_EXTRACT_NUM to IIO_EVENT_CODE_EXTRACT_CHAN

2012-02-10 Thread Lars-Peter Clausen
We call this field chan throughout IIO with the exception of this one macro. Rename it to be more consistent. Signed-off-by: Lars-Peter Clausen l...@metafoo.de Acked-by: Jonathan Cameron ji...@kernel.org --- drivers/staging/iio/events.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

[PATCH 3/4] staging:iio: Add missing event code extract macros

2012-02-10 Thread Lars-Peter Clausen
Add macros for extracting whether the event is for a differential channel and the second channel number from the event code. These were the only two fields which did not have such an macro yet. Signed-off-by: Lars-Peter Clausen l...@metafoo.de Acked-by: Jonathan Cameron ji...@kernel.org ---

[PATCH 1/4] staging:iio:events: Remove obsolete documentation

2012-02-10 Thread Lars-Peter Clausen
Commit 43ba1100 (staging:iio:events: Use waitqueue lock to protect event queue) removed the event_list_lock field from the iio_event_interface struct, but missed to remove the same field from the documentation for that function. Signed-off-by: Lars-Peter Clausen l...@metafoo.de ---

[PATCH 4/4] staging:iio: Add event monitor example application

2012-02-10 Thread Lars-Peter Clausen
Add a small evtest like application to monitor events generated by an IIO device. The application can be used as an example on how to listen for IIO events and also is usful for testing and debugging device drivers which generate IIO events. Signed-off-by: Lars-Peter Clausen l...@metafoo.de

Re: [PATCH 2/4] staging:iio: Rename IIO_EVENT_CODE_EXTRACT_NUM to IIO_EVENT_CODE_EXTRACT_CHAN

2012-02-10 Thread Greg Kroah-Hartman
On Fri, Feb 10, 2012 at 07:14:59PM +0100, Lars-Peter Clausen wrote: We call this field chan throughout IIO with the exception of this one macro. Rename it to be more consistent. Signed-off-by: Lars-Peter Clausen l...@metafoo.de Acked-by: Jonathan Cameron ji...@kernel.org ---

Re: [PATCH v2 02/17] Staging: quickstart: Prefix remaining functions names with quickstart_

2012-02-10 Thread Szymon Janc
Hi, I'll take this, but you do know there is no reason for this, as these are static functions. I'd recommend keeping them as short as possible, but hey, it's not my code... thanks, greg k-h I agree with Greg on this one. At the time I didn't prefix these functions with the

Re: [PATCH v2 00/17] Some work on quickstart driver in staging

2012-02-10 Thread Szymon Janc
On Thursday 09 February 2012 21:23:02 Greg KH wrote: Those 2 (minor) are still not applied Staging: quickstart: Use scnprintf in quickstart_pressed_button_show Staging: quickstart: Bump driver version to 1.04 I thought you told me not to apply them? Anyway, care to resend them so I

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-10 Thread Felipe Contreras
On Fri, Feb 10, 2012 at 8:00 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Fri, Feb 10, 2012 at 01:30:48AM +0200, Felipe Contreras wrote: It's not an oops, it's a warning, and again, it depends on the firmware being used. We don't have control over that, and we have no way to detect if

[PATCH 3/3] Staging: quickstart: Bump driver version to 1.04

2012-02-10 Thread Szymon Janc
Signed-off-by: Szymon Janc szy...@janc.net.pl --- drivers/staging/quickstart/quickstart.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/quickstart/quickstart.c b/drivers/staging/quickstart/quickstart.c index 2c8c12b..cac3207 100644 ---

[PATCH 2/3] Staging: quickstart: Fix compilation warning on 64 bit arch

2012-02-10 Thread Szymon Janc
acpi_size is u32 or u64 depending on architecture. Cast it to unsigned long and use %lu for printing. This fix following build warning: drivers/staging/quickstart/quickstart.c: In function ‘quickstart_acpi_ghid’: drivers/staging/quickstart/quickstart.c:212:5: warning: format ‘%u’ expects

[PATCH 1/3] Staging: quickstart: Use scnprintf in quickstart_pressed_button_show

2012-02-10 Thread Szymon Janc
Use scnprintf instead of snprintf in quickstart_pressed_button_show as suggested in Documentation/filesystems/sysfs.txt. Signed-off-by: Szymon Janc szy...@janc.net.pl --- drivers/staging/quickstart/quickstart.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH 2/3] Staging: quickstart: Fix compilation warning on 64 bit arch

2012-02-10 Thread Szymon Janc
acpi_size is u32 or u64 depending on architecture. Cast it to unsigned long and use %lu for printing. This fix following build warning: drivers/staging/quickstart/quickstart.c: In function ‘quickstart_acpi_ghid’: drivers/staging/quickstart/quickstart.c:212:5: warning: format ‘%u’ expects

[PATCH 1/3] Staging: quickstart: Use scnprintf in quickstart_pressed_button_show

2012-02-10 Thread Szymon Janc
Use scnprintf instead of snprintf in quickstart_pressed_button_show as suggested in Documentation/filesystems/sysfs.txt. Signed-off-by: Szymon Janc szy...@janc.net.pl --- drivers/staging/quickstart/quickstart.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH 3/3] Staging: quickstart: Bump driver version to 1.04

2012-02-10 Thread Szymon Janc
Signed-off-by: Szymon Janc szy...@janc.net.pl --- drivers/staging/quickstart/quickstart.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/quickstart/quickstart.c b/drivers/staging/quickstart/quickstart.c index 2c8c12b..cac3207 100644 ---

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-10 Thread Dan Carpenter
On Fri, Feb 10, 2012 at 09:42:32PM +0200, Felipe Contreras wrote: On Fri, Feb 10, 2012 at 8:00 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Fri, Feb 10, 2012 at 01:30:48AM +0200, Felipe Contreras wrote: It's not an oops, it's a warning, and again, it depends on the firmware being

Re: [PATCH 2/4] staging:iio: Rename IIO_EVENT_CODE_EXTRACT_NUM to IIO_EVENT_CODE_EXTRACT_CHAN

2012-02-10 Thread Dan Carpenter
On Fri, Feb 10, 2012 at 07:14:59PM +0100, Lars-Peter Clausen wrote: We call this field chan throughout IIO with the exception of this one macro. Rename it to be more consistent. Signed-off-by: Lars-Peter Clausen l...@metafoo.de Acked-by: Jonathan Cameron ji...@kernel.org ---

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-10 Thread Felipe Contreras
On Fri, Feb 10, 2012 at 10:35 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Fri, Feb 10, 2012 at 09:42:32PM +0200, Felipe Contreras wrote: On Fri, Feb 10, 2012 at 8:00 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Fri, Feb 10, 2012 at 01:30:48AM +0200, Felipe Contreras wrote:

Re: [PATCH 3/4] staging:iio: Add missing event code extract macros

2012-02-10 Thread Dan Carpenter
On Fri, Feb 10, 2012 at 07:15:00PM +0100, Lars-Peter Clausen wrote: Add macros for extracting whether the event is for a differential channel and the second channel number from the event code. These were the only two fields which did not have such an macro yet. Signed-off-by: Lars-Peter

Re: [PATCH 3/4] staging:iio: Add missing event code extract macros

2012-02-10 Thread Dan Carpenter
On Fri, Feb 10, 2012 at 11:45:31PM +0300, Dan Carpenter wrote: On Fri, Feb 10, 2012 at 07:15:00PM +0100, Lars-Peter Clausen wrote: Add macros for extracting whether the event is for a differential channel and the second channel number from the event code. These were the only two fields

[PATCH] staging:iio:dac: Fix kcalloc parameters swapped

2012-02-10 Thread Axel Lin
The first parameter should be number of elements and the second parameter should be element size. Signed-off-by: Axel Lin axel@gmail.com --- drivers/staging/iio/dac/ad5360.c |4 ++-- drivers/staging/iio/dac/ad5380.c |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff

Re: [PATCH v2 02/17] Staging: quickstart: Prefix remaining functions names with quickstart_

2012-02-10 Thread miknix
On Fri, 10 Feb 2012 19:58:23 +0100 Szymon Janc szy...@janc.net.pl wrote: Hi, I'll take this, but you do know there is no reason for this, as these are static functions. I'd recommend keeping them as short as possible, but hey, it's not my code... thanks, greg k-h I

Re: [PATCH] staging: r8712u: Remove configuration parameter CONFIG_R8712_AP

2012-02-10 Thread siva
Greg KH gregkh at linuxfoundation.org writes: On Sat, Feb 04, 2012 at 03:28:06PM -0600, Larry Finger wrote: The configuration parameter R8712_AP is misleading as the driver cannot function as an AP without a heavily hacked version of hostapd. Thus, it makes sense to remove the parameter;