[PATCH REVIEW] Drivers for Si700x Evaluation Module

2012-02-18 Thread Prashant P Shah
Signed-off-by: Prashant P Shah --- Makefile | 24 +++ si700x.c | 504 ++ si700x.h | 102 + 3 files changed, 630 insertions(+), 0 deletions(-) create mode 100644 Makefile create mode 100644 si700x.c create mode 100644 s

Re: need feedback on si700x usb driver

2012-02-18 Thread Prashant Shah
Hi Greg, On Sat, Feb 18, 2012 at 9:52 PM, Greg KH wrote: > > Why not post a patch so we can properly review and provide comments in a > much easier manner?  Please see the file Documentation/SubmittingDrivers > for why pointing people at a url is not useful. > > thanks, > > greg k-h I am sending

[PATCH linux-firmware 2/2] usbdux: Rebuild firmware in the correct directory

2012-02-18 Thread Ben Hutchings
The source for usbdux firmware is in a subdirectory but the binaries are not. This is weird but not worth changing. Adjust the makefile to rebuild the binaries at the top-level. Signed-off-by: Ben Hutchings --- This is not quite right; the clean rule needs to be updated too. Ben. usbdux/Make

[PATCH linux-firmware 1/2] usbdux: Assume as31 is already installed

2012-02-18 Thread Ben Hutchings
Don't try to build the as31 assembler in a subdirectory. A suitable version may be installed separately; for example it is packaged in Debian. Update the README accordingly. Signed-off-by: Ben Hutchings --- usbdux/Makefile_dux | 18 -- usbdux/README.dux | 12 +---

[PATCH linux-firmware 0/2] Clean up usbdux makefile

2012-02-18 Thread Ben Hutchings
I've been trying to ensure we have simple working makefiles for building all the free firmware in the linux-firmware repository. These changes would make usbdux more consistent with the others. Ben. Ben Hutchings (2): usbdux: Assume as31 is already installed usbdux: Rebuild firmware in the c

Re: [PATCH 3/3 v2] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr_err

2012-02-18 Thread Joe Perches
On Sat, 2012-02-18 at 21:34 -0200, Jorgyano vieira wrote: > this is the output after the patch: > $ grep -rP --include=*.[ch] -m1 "^[ \t]*#[ \t]*include" [] > drivers/staging/crystalhd/crystalhd_lnx.c:#include "crystalhd_lnx.h" So this is still 2 layers indirected. It might make more sense to hav

Re: [PATCH 3/3 v2] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr_err

2012-02-18 Thread Jorgyano vieira
On Sat, Feb 18, 2012 at 9:14 PM, Joe Perches wrote: > On Sat, 2012-02-18 at 21:08 -0200, Jorgyano vieira wrote: >> > o pr_fmt needs to be #defined before any #include that might >> >  directly or indirectly #include kernel.h/printk.h >> >  use 'strings /built-in.o | grep "^<.>"' to verify. >> yes,

Re: [PATCH 3/3 v2] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr_err

2012-02-18 Thread Joe Perches
On Sat, 2012-02-18 at 21:08 -0200, Jorgyano vieira wrote: > > o pr_fmt needs to be #defined before any #include that might > > directly or indirectly #include kernel.h/printk.h > > use 'strings /built-in.o | grep "^<.>"' to verify. > yes, I take care of this:--- a/drivers/staging/crystalhd/crysta

Re: [PATCH 3/3 v2] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr_err

2012-02-18 Thread Jorgyano vieira
On Sat, Feb 18, 2012 at 8:31 PM, Joe Perches wrote: > On Sat, 2012-02-18 at 20:10 -0200, Jorgyano Vieira wrote: >> Replace the usage of BCMLOG_ERR with pr_err and remove the macro definition. >> Also added pr_fmt to identify the driver error messages. > > Hi Jorgyano. Hi Joe, > > Couple of generic

Re: [PATCH 3/3 v2] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr_err

2012-02-18 Thread Joe Perches
On Sat, 2012-02-18 at 20:10 -0200, Jorgyano Vieira wrote: > Replace the usage of BCMLOG_ERR with pr_err and remove the macro definition. > Also added pr_fmt to identify the driver error messages. Hi Jorgyano. Couple of generic comments. o Please look for and fix spelling errors at the same time.

[PATCH 3/3 v2] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr_err

2012-02-18 Thread Jorgyano Vieira
Replace the usage of BCMLOG_ERR with pr_err and remove the macro definition. Also added pr_fmt to identify the driver error messages. Signed-ff-by: Jorgyano Vieira --- drivers/staging/crystalhd/crystalhd_cmds.c | 68 drivers/staging/crystalhd/crystalhd_hw.c | 119 ++

Re: [PATCH 1/2] staging: easycap: Clean comment style in easycap_usb_probe()

2012-02-18 Thread Dan Carpenter
The first line of the comment here should be a blank line. /* * blah blah blah * blah blah blah */ > + /* A new struct easycap is always allocated when interface 0 is probed. > + * It is not possible here to free any existing struct easycap. > + *

[PATCH 2/2] staging: easycap: Fix incorrect comment

2012-02-18 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia --- drivers/staging/media/easycap/easycap_main.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/easycap/easycap_main.c b/drivers/staging/media/easycap/easycap_main.c index 70ebaae..9f9c287 100644 --- a/drivers/sta

[PATCH 1/2] staging: easycap: Clean comment style in easycap_usb_probe()

2012-02-18 Thread Ezequiel Garcia
Some of these comments may still need to be reviewed. This patch only cleans the comment style. Signed-off-by: Ezequiel Garcia --- drivers/staging/media/easycap/easycap_main.c | 236 -- 1 files changed, 71 insertions(+), 165 deletions(-) diff --git a/drivers/staging/med

Re: need feedback on si700x usb driver

2012-02-18 Thread Greg KH
On Sat, Feb 18, 2012 at 12:23:16PM +0530, Prashant Shah wrote: > Hi, > > I have been working on connecting a USB to I2C communication module > from Silicon Labs - Si700x. > > It consists of a temperature and humidity sensor which connects > through I2C bus. Si700x is a evaluation module that conv

Re: [PATCH 3/3] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr_err

2012-02-18 Thread Jorgyano vieira
> It's possible to add "%s...", __func__ to > the necessary uses.  Adding it to the generic > is likely overkill. I agree with that. > But is it really necessary anyway? > > Aren't those called via some specific notifier > such that the output would make sense given > some specific invalid input?