Re: [PATCH] Staging: usbip: Remove commented code.

2012-02-19 Thread Dan Carpenter
On Mon, Feb 20, 2012 at 08:44:05AM +0530, santosh nayak wrote: > From: Santosh Nayak > > Remove commented code of old style lock initilization > Looks good. Thanks for doing that. regards, dan carpenter signature.asc Description: Digital signature _

Re: [PATCH 1/2] staging: easycap: Clean comment style in easycap_usb_probe()

2012-02-19 Thread Dan Carpenter
On Sun, Feb 19, 2012 at 07:56:22PM -0300, Ezequiel García wrote: > Hi, > > 2012/2/18 Dan Carpenter : > > The first line of the comment here should be a blank line. > > Ok. > > > > >        /* > >         * blah blah blah > >         * blah blah blah > >         */ > > > >> +     /* A new struct

Re: [PATCH 1/2] staging: easycap: Clean comment style in easycap_usb_probe()

2012-02-19 Thread Dan Carpenter
On Sun, Feb 19, 2012 at 08:00:27PM -0300, Ezequiel García wrote: > Hi, > > El día 19 de febrero de 2012 17:49, Dan Carpenter > escribió: > > > > You've dropped Greg and driver devel from the CC list.  It's all up > > to Greg whether to merge your patch or not, so it doesn't matter > > what I say

[PATCH] Staging: usbip: Remove commented code.

2012-02-19 Thread santosh nayak
From: Santosh Nayak Remove commented code of old style lock initilization Signed-off-by: Santosh Nayak --- drivers/staging/usbip/stub_dev.c |2 -- drivers/staging/usbip/vhci_hcd.c |2 -- 2 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/staging/usbip/stub_dev.c b/

Re: [PATCH 1/2] staging: easycap: Clean comment style in easycap_usb_probe()

2012-02-19 Thread Ezequiel García
Hi, El día 19 de febrero de 2012 17:49, Dan Carpenter escribió: > > You've dropped Greg and driver devel from the CC list.  It's all up > to Greg whether to merge your patch or not, so it doesn't matter > what I say if he isn't on the CC list. Sorry for that. I've just forwarded my previous mail

Re: [PATCH 1/2] staging: easycap: Clean comment style in easycap_usb_probe()

2012-02-19 Thread Ezequiel García
Hi, 2012/2/18 Dan Carpenter : > The first line of the comment here should be a blank line. Ok. > >        /* >         * blah blah blah >         * blah blah blah >         */ > >> +     /* A new struct easycap is always allocated when interface 0 is probed. >> +      * It is not possible here t

Re: [PATCH] Staging: driver usbip: Code cleanup

2012-02-19 Thread Ezequiel García
2012/2/19 Dan Carpenter : > > 1) The patch is line wrapped so it doesn't apply.  To test, save > your email as raw text.  `cat raw_email.txt | git am` > Read Documentation/email-clients.txt. > I have found it's very easy to send patches with git-send-email as explained in Greg's excellent FOSDEM t

Re: [PATCH] Staging: driver usbip: Code cleanup

2012-02-19 Thread Dan Carpenter
On Sun, Feb 19, 2012 at 05:48:39PM +0530, santosh prasad nayak wrote: > Code cleanup: removed commented code of old style lock initilization > 1) The patch is line wrapped so it doesn't apply. To test, save your email as raw text. `cat raw_email.txt | git am` Read Documentation/email-clients.t

will these methods work with firmware loading?

2012-02-19 Thread Larry Finger
I sent a previous messages to most of these lists, but got no answer, thus a second try. When a driver loads firmware synchronously in the module_init() path using request_firmware(), then there is trouble with timeouts when booting. I know that changing the request_firmware() call to request

Re: [PATCH REVIEW] Drivers for Si700x Evaluation Module

2012-02-19 Thread Greg KH
On Sun, Feb 19, 2012 at 11:04:32AM +0530, Prashant P Shah wrote: > Signed-off-by: Prashant P Shah Why does this need to be a kernel driver at all? It looks like this device can be controlled by userspace using libusb/usbfs, so no kernel driver would be needed. thanks, greg k-h

Re: [PATCH linux-firmware 1/2] usbdux: Assume as31 is already installed

2012-02-19 Thread Ben Hutchings
On Sun, 2012-02-19 at 10:17 +, Bernd Porr wrote: > Hi, > > thanks! > > Here is a patch for the README. There is no debian package. My web page > is still the only place where it resides and nobody has ever made a > DEBIAN package out of it. [...] Yes, there is:

[PATCH] Staging: driver usbip: Code cleanup

2012-02-19 Thread santosh prasad nayak
Code cleanup: removed commented code of old style lock initilization Signed-off-by: Santosh --- drivers/staging/usbip/stub_dev.c |2 -- drivers/staging/usbip/vhci_hcd.c |2 -- 2 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/staging/usbip/stub_dev.c b/drivers/stagi

Re: [PATCH linux-firmware 1/2] usbdux: Assume as31 is already installed

2012-02-19 Thread Bernd Porr
Hi, thanks! Here is a patch for the README. There is no debian package. My web page is still the only place where it resides and nobody has ever made a DEBIAN package out of it. For the 5+ people using 8051 assembler that's probably not really needed. /Bernd Ben Hutchings wrote: Don't try