On Thu, Mar 08, 2012 at 07:51:07PM -0800, Grant Grundler wrote:
> Hi Jonathan!
>
> On Wed, Mar 7, 2012 at 3:28 AM, Jonathan Cameron wrote:
> > Fundamentally an excellent patch fixing some real issues,
>
> Thank you! :)
>
> > but just
> > because I'm in that sort of mood I'll be fussy about the
Hi Jonathan!
On Wed, Mar 7, 2012 at 3:28 AM, Jonathan Cameron wrote:
> Fundamentally an excellent patch fixing some real issues,
Thank you! :)
> but just
> because I'm in that sort of mood I'll be fussy about the fact it is
> one patch.
>
> To nitpick, I'd have prefered this to be two patches.
The dmm module has a dmm_init() and a dmm_exit() whose only purpose is
to keep a reference counting which is not used at all.
This patch removes these functions and the reference count variable.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal
---
.../staging/tidspbridg
The io module has a io_init() and a io_exit() whose only purpose is to
keep a reference counting which is not used at all.
This patch removes these functions and the reference count variable.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal
---
drivers/staging/tidspbrid
The cmm module has a cmm_init() and a cmm_exit() whose only purpose is
to keep a reference counting which is not used at all.
This patch removes these functions and the reference count variable.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal
---
.../staging/tidspbridg
The dev module has a dev_init() and a dev_exit() whose only purpose is
to keep a reference counting which is not used at all.
This patch removes these functions and the reference count variable.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal
---
.../staging/tidspbridg
No functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal
---
drivers/staging/tidspbridge/rmgr/mgr.c |9 ++---
1 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/tidspbridge/rmgr/mgr.c
b/drivers/staging/tidspbridge/rmgr/mgr.c
index 938eea5..8a1e928 1006
The gh module has a gh_init() and a gh_exit(), but they don't do
anything, they are just noops.
This patch removes these functions.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal
---
drivers/staging/tidspbridge/gen/gh.c | 18 --
drivers
The dynamic loader was called by node.c with an interface. This interface was
also modified to avoid the use of nldr_init() and nldr_exit().
There is not functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal
---
.../staging/tidspbridge/include/dspbridge/nldr.h |2 -
.../tidspbridge
The nldr module has a nldr_init() and a nldr_exit() whose only purpose
is to keep a reference counting which is not used at all.
This patch only removes the reference count variable, but not the
functions, because they are used through an interface.
There is no functional changes.
Signed-off-by:
The chnl module has a chnl_init() and a chnl_exit() whose only purpose
is to keep a reference counting which is not used at all.
This patch removes these functions and the reference count variable.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal
---
.../staging/tidspbr
The strm module has a strm_init() and a strm_exit() whose only purpose
is to keep a reference counting which is not used at all.
This patch removes these functions and the reference count variable.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal
---
.../staging/tidspbr
The msg module has a msg_mod_init() and a msg_exit() whose only
purpose is to keep a reference counting which is not used at all.
This patch removes these functions and the reference count variable.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal
---
.../staging/tidspb
The rmm module has a rmm_init() and a rmm_exit() whose only purpose is
to keep a reference counting which is not used at all.
This patch removes these functions and the reference count variable.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal
---
.../staging/tidspbridg
The disp module has a disp_init() and a disp_exit() whose only purpose
is to keep a reference counting which is not used at all.
This patch removes these functions and the reference count variable.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal
---
.../staging/tidspbr
The node module has a node_init() and a node_exit() whose only purpose
is to keep a reference counting which is not used at all.
This patch removes these functions and the reference count variable.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal
---
.../staging/tidspbr
The cod module has a cod_init() and a cod_exit() whose only purpose is
to keep a reference counting which is not used at all.
This patch removes these functions and the reference count variable.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal
---
.../staging/tidspbridg
Almos all the modules in tidspbridge have a _init() and a _exit()
functions, whose only purpose is to keep a reference counting. But that
reference counting, in most of the cases, is utterly useless.
This patch series removes most of the _init() and _exit() function in
the tidspbridge modules, whe
The proc module has a proc_init() and a proc_exit() whose only purpose
is to keep a reference counting which is not used at all.
This patch removes these functions and the reference count variable.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal
---
.../staging/tidspbr
The drv module has a drv_init() and a drv_exit() whose only purpose is
to keep a reference counting which is not used at all.
This patch removes these functions and the reference count variable.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal
---
.../staging/tidspbridg
From: Haiyang Zhang
Date: Wed, 7 Mar 2012 12:02:00 -0800
> Signed-off-by: Haiyang Zhang
> Signed-off-by: K. Y. Srinivasan
> Cc: Olaf Hering
Applied.
___
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman
On Thu, Mar 08, 2012 at 07:38:20PM +0100, Olaf Hering wrote:
> On Thu, Mar 08, Greg KH wrote:
>
> > On Thu, Mar 08, 2012 at 05:12:21PM +0100, Olaf Hering wrote:
> > > On Thu, Mar 08, Greg KH wrote:
> > >
> > > > > hwinfo uses it to recognize a network interface (storage in case of
> > > > > hv_st
On Thu, Mar 08, Greg KH wrote:
> On Thu, Mar 08, 2012 at 05:12:21PM +0100, Olaf Hering wrote:
> > On Thu, Mar 08, Greg KH wrote:
> >
> > > > hwinfo uses it to recognize a network interface (storage in case of
> > > > hv_storvsc).
> > >
> > > That tool should report the real module name, not rely
On Wed, Mar 07, 2012 at 02:17:09PM -0600, Jonathan Nieder wrote:
> Greg Kroah-Hartman wrote:
> > On Fri, Mar 02, 2012 at 02:39:13PM -0600, Jonathan Nieder wrote:
> >> Ben Hutchings wrote:
> >>> On Thu, 2012-03-01 at 21:45 -0600, Jonathan Nieder wrote:
>
> Would some of these patches (e.g., at
On Thu, Mar 08, 2012 at 05:12:21PM +0100, Olaf Hering wrote:
> On Thu, Mar 08, Greg KH wrote:
>
> > > hwinfo uses it to recognize a network interface (storage in case of
> > > hv_storvsc).
> >
> > That tool should report the real module name, not rely on the name to
> > match based on the structu
> From: Andor Daam [mailto:andor.d...@googlemail.com]
> Subject: Re: (un)loadable module support for zcache
>
> 2012/3/8 Dan Magenheimer
> >
> > > From: Florian Schmaus [mailto:fschm...@gmail.com]
> > > Subject: Re: (un)loadable module support for zcache
> > >
> > > This should allow backends to
2012/3/8 Dan Magenheimer
>
> > From: Florian Schmaus [mailto:fschm...@gmail.com]
> > Subject: Re: (un)loadable module support for zcache
> >
> > On 03/05/12 17:57, Dan Magenheimer wrote:
> > > I think the answer here is for cleancache (and frontswap) to
> > > support "lazy pool creation". If a ba
On Thu, Mar 08, Greg KH wrote:
> > hwinfo uses it to recognize a network interface (storage in case of
> > hv_storvsc).
>
> That tool should report the real module name, not rely on the name to
> match based on the structure, if you really care about the real module
> name.
Its about the driver
> From: Florian Schmaus [mailto:fschm...@gmail.com]
> Subject: Re: (un)loadable module support for zcache
>
> On 03/05/12 17:57, Dan Magenheimer wrote:
> > I think the answer here is for cleancache (and frontswap) to
> > support "lazy pool creation". If a backend has not yet
> > registered when a
On Thu, Mar 08, 2012 at 07:16:16AM +0100, Olaf Hering wrote:
> On Wed, Mar 07, Greg KH wrote:
>
> > On Wed, Mar 07, 2012 at 09:17:46PM +0100, Olaf Hering wrote:
> > > On Wed, Mar 07, Haiyang Zhang wrote:
> > >
> > >
> > > > @@ -482,7 +484,7 @@ MODULE_DEVICE_TABLE(vmbus, id_table);
> > > >
> >
On 03/05/12 17:57, Dan Magenheimer wrote:
I think the answer here is for cleancache (and frontswap) to
support "lazy pool creation". If a backend has not yet
registered when an init_fs/init call is made, cleancache
(or frontswap) must record the attempt and generate a valid
"fake poolid" to retu
31 matches
Mail list logo
