Re: [PATCH] Fix bug where kfree is called twice.

2012-04-26 Thread Rupesh Gujare
Is it possible to queue it up for 3.4 as well ? Yes, now done so. Thanks a lot Greg. :-) -- Regards, Rupesh Gujare ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

[PATCH RESEND v5] iio: lpc32xx-adc: Remove driver conflict due to device tree

2012-04-26 Thread Roland Stigge
Previously, the touchscreen and ADC drivers of the LPC32xx SoC had a Kconfig conflict declared because they use the same hardware. Upon the introduction of device tree support in both drivers, the conflict must be removed to enable the same kernel to support different hardware (configured via the d

Re: [PATCH] Fix bug where kfree is called twice.

2012-04-26 Thread Greg KH
On Thu, Apr 26, 2012 at 06:09:15PM +0100, Rupesh Gujare wrote: > Hi Greg, > > >Everything goes into linux-next first. That should have been put > >in the changelog. "We are seeing occasional crashes under load" or > >whatever... It's Greg's call and all, but generally it can't hurt > >to ask nicel

Re: VME and the staging tree

2012-04-26 Thread Greg KH
On Thu, Apr 26, 2012 at 01:55:59PM -0400, Emilio G. Cota wrote: > On Thu, Apr 26, 2012 at 08:17:33 -0700, Greg KH wrote: > > On Thu, Apr 26, 2012 at 09:40:24AM +0100, Martyn Welch wrote: > > > I'm fairly sure that there are people using the vme_user module to access > > > the > > > VME bus to do s

[PATCH RESEND 6/7] staging: sm7xx: remove driver version support

2012-04-26 Thread Javier M. Mellid
This patch removes non used version support. Code won't show version message almost 4 years old. Tested with SM712 Signed-off-by: Javier M. Mellid --- drivers/staging/sm7xx/smtcfb.c |3 +-- drivers/staging/sm7xx/smtcfb.h |2 -- 2 files changed, 1 insertions(+), 4 deletions(-) diff --gi

[PATCH RESEND 4/7] staging: sm7xx: use dynamic debug support to show info and errors

2012-04-26 Thread Javier M. Mellid
This patch makes happy checkpatch script. It uses dynamic debug support to show info and errors. It unifies the way to report messages in the same way that debug messages. Tested with SM712 Signed-off-by: Javier M. Mellid --- drivers/staging/sm7xx/smtcfb.c | 41 ---

[PATCH RESEND 1/7] staging: sm7xx: remove old references and non updated comments

2012-04-26 Thread Javier M. Mellid
This patch removes obsolete references to previous code and non updated comments. Tested with SM712 Signed-off-by: Javier M. Mellid --- drivers/staging/sm7xx/smtcfb.c | 44 +++ 1 files changed, 8 insertions(+), 36 deletions(-) diff --git a/drivers/staging/

[PATCH RESEND 5/7] staging: sm7xx: merge hardware information in smtcfb_info struct

2012-04-26 Thread Javier M. Mellid
With this patch smtcfb_info becomes the main structure to reach/handle state. fb_info struct links this struct via its private data field. This change improves encapsulation in functions. It reduces the number of arguments used in signatures too. Tested with SM712 Signed-off-by: Javier M. Mellid

[PATCH RESEND 3/7] staging: sm7xx: use dynamic debug support

2012-04-26 Thread Javier M. Mellid
This patch uses dynamic debug support. Tested with SM712 Signed-off-by: Javier M. Mellid --- drivers/staging/sm7xx/smtcfb.c | 30 -- 1 files changed, 12 insertions(+), 18 deletions(-) diff --git a/drivers/staging/sm7xx/smtcfb.c b/drivers/staging/sm7xx/smtcfb.c ind

[PATCH RESEND 7/7] staging: sm7xx: rename function

2012-04-26 Thread Javier M. Mellid
This patch changes the name of function cfb_blank to smtc_blank. This function is not implemented like a generic function for frame buffer. Having the old prefix becomes confused when reading fb_ops structs. Tested with SM712 Signed-off-by: Javier M. Mellid --- drivers/staging/sm7xx/smtcfb.c |

[PATCH RESEND 2/7] staging: sm7xx: dead code removal

2012-04-26 Thread Javier M. Mellid
This patch remove dead code. Tested with SM712. Signed-off-by: Javier M. Mellid --- drivers/staging/sm7xx/smtcfb.c |8 drivers/staging/sm7xx/smtcfb.h |6 -- 2 files changed, 0 insertions(+), 14 deletions(-) diff --git a/drivers/staging/sm7xx/smtcfb.c b/drivers/staging/sm7x

[PATCH RESEND 0/7] staging: sm7xx: code improvements and cleanup

2012-04-26 Thread Javier M. Mellid
This set of patches implement some code improvements, dead code removal and cleanup. New code uses dynamic debug support. The patches address new checkpatch warnings. Patches tested with SM712. Javier M. Mellid (7): staging: sm7xx: remove old references and non updated comments staging: sm7x

Re: VME and the staging tree

2012-04-26 Thread Emilio G. Cota
On Thu, Apr 26, 2012 at 08:17:33 -0700, Greg KH wrote: > On Thu, Apr 26, 2012 at 09:40:24AM +0100, Martyn Welch wrote: > > I'm fairly sure that there are people using the vme_user module to access > > the > > VME bus to do simple things, however I also agree that it isn't really in a > > mergeable

Re: [PATCH] Fix bug where kfree is called twice.

2012-04-26 Thread Rupesh Gujare
Hi Greg, Everything goes into linux-next first. That should have been put in the changelog. "We are seeing occasional crashes under load" or whatever... It's Greg's call and all, but generally it can't hurt to ask nicely if you want stuff merged it into 3.4 as well. ;) Is it possible to que

Re: VME and the staging tree

2012-04-26 Thread Greg KH
On Thu, Apr 26, 2012 at 09:40:24AM +0100, Martyn Welch wrote: > On 25/04/12 21:56, Greg KH wrote: > > On Wed, Apr 25, 2012 at 04:03:22PM -0400, Emilio G. Cota wrote: > >> On Wed, Apr 25, 2012 at 11:25:32 -0700, Greg KH wrote: > >>> I have reviewed the code, and only have one major comment at this p

Re: [PATCH] MAINTAINERS: Add new Industrial I/O subsystem location

2012-04-26 Thread Lars-Peter Clausen
On 04/26/2012 03:06 PM, Jonathan Cameron wrote: > On 4/26/2012 12:46 PM, Lars-Peter Clausen wrote: >> Add the new out-of-staging IIO directory to the IIO MAINTAINERS file entry. > *laughs* That was on my todo list but you beat me to it. There is still your E-mail address in that entry that wants

Re: [PATCH] MAINTAINERS: Add new Industrial I/O subsystem location

2012-04-26 Thread Jonathan Cameron
On 4/26/2012 12:46 PM, Lars-Peter Clausen wrote: Add the new out-of-staging IIO directory to the IIO MAINTAINERS file entry. *laughs* That was on my todo list but you beat me to it. Signed-off-by: Lars-Peter Clausen Acked-by: Jonathan Cameron --- MAINTAINERS |1 + 1 file changed, 1

Re: [PATCH] Fix bug where kfree is called twice.

2012-04-26 Thread Dan Carpenter
On Thu, Apr 26, 2012 at 09:44:16AM +0100, Rupesh Gujare wrote: > Hi Dan, > >It's a good patch and it fixes a bug, but could you resend with > >the subject: > > > >[PATCH] Staging: ozwpan: Fix bug where kfree is called twice. > Sorry about subject line. I should have spend a bit more time in > forma

[PATCH] MAINTAINERS: Add new Industrial I/O subsystem location

2012-04-26 Thread Lars-Peter Clausen
Add the new out-of-staging IIO directory to the IIO MAINTAINERS file entry. Signed-off-by: Lars-Peter Clausen --- MAINTAINERS |1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2dcfca8..4893026 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3384,6 +3384,7 @@ I

[PATCH 4/4] Staging: comedi: fix line over 80 character issue in ni_at_a2150.c

2012-04-26 Thread Ravishankar Karkala Mallikarjunayya
This is a patch to the ni_at_a2150.c file that fixes up a line over 80 character warning found by the checkpatch.pl tool. Signed-off-by: Ravishankar Karkala Mallikarjunayya --- drivers/staging/comedi/drivers/ni_at_a2150.c | 16 1 files changed, 12 insertions(+), 4 deletions(-

[PATCH 3/4] Staging: comedi: fix line over 80 character issue in cb_pcimdas.c.

2012-04-26 Thread Ravishankar Karkala Mallikarjunayya
This is a patch to the cb_pcimdas.c file that fixes up a line over 80 character warning found by the checkpatch.pl tool. Signed-off-by: Ravishankar Karkala Mallikarjunayya --- drivers/staging/comedi/drivers/cb_pcimdas.c | 17 - 1 files changed, 12 insertions(+), 5 deletions(-)

[PATCH 2/4] Staging: comedi: fix line over 80 character issue in daqboard2000.c

2012-04-26 Thread Ravishankar Karkala Mallikarjunayya
This is a patch to the daqboard2000.c file that fixes up a line over 80 character warning found by the checkpatch.pl tool. Signed-off-by: Ravishankar Karkala Mallikarjunayya --- drivers/staging/comedi/drivers/daqboard2000.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) dif

[PATCH 1/4] Staging: comedi: fix line over 80 character issue in cb_pcidda.c

2012-04-26 Thread Ravishankar Karkala Mallikarjunayya
This is a patch to the cb_pcidda.c file that fixes up a line over 80 character warning found by the checkpatch.pl tool Signed-off-by: Ravishankar Karkala Mallikarjunayya --- drivers/staging/comedi/drivers/cb_pcidda.c | 72 +++ 1 files changed, 50 insertions(+), 22 dele

Staging: comedi: fix code clean up issues.

2012-04-26 Thread Ravishankar Karkala Mallikarjunayya
This patch series fixes some coding style issues found by checkpatch.pl script. Ravishankar Karkala Mallikarjunayya (4): Staging: comedi: fix line over 80 character issue in cb_pcidda.c Staging: comedi: fix line over 80 character issue in daqboard2000.c Staging: comedi: fix line

Re: [PATCH 2/3] staging: vt6656: remove redundant parentheses from ioctl.c

2012-04-26 Thread Jesper Juhl
On Tue, 24 Apr 2012, Greg Kroah-Hartman wrote: > On Sat, Apr 21, 2012 at 10:04:37PM +0200, Jesper Juhl wrote: > > I seriously doubt that anyone is confused about the precedence rules > > for "*" and "+" - remove redundant extra parentheses. > > You never really know, and as such, I'd prefer to ju

Re: [PATCH] Fix bug where kfree is called twice.

2012-04-26 Thread Rupesh Gujare
Hi Dan, It's a good patch and it fixes a bug, but could you resend with the subject: [PATCH] Staging: ozwpan: Fix bug where kfree is called twice. Sorry about subject line. I should have spend a bit more time in formatting subject line. However it looks like Greg have already pulled this patch

Re: VME and the staging tree

2012-04-26 Thread Martyn Welch
On 25/04/12 21:56, Greg KH wrote: > On Wed, Apr 25, 2012 at 04:03:22PM -0400, Emilio G. Cota wrote: >> On Wed, Apr 25, 2012 at 11:25:32 -0700, Greg KH wrote: >>> I have reviewed the code, and only have one major comment at this point >>> in time: >>> >>> What's up with the device ioctl in >>> drive