This is now straightforward: just introduce a module parameter and pass
the needed value to persistent_ram_new().
Signed-off-by: Anton Vorontsov
---
fs/pstore/ram.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index cf0ad92.
The patch switches pstore RAM backend to use persistent_ram routines,
one step closer to the ECC support.
Signed-off-by: Anton Vorontsov
---
fs/pstore/ram.c | 109 ++-
1 file changed, 60 insertions(+), 49 deletions(-)
diff --git a/fs/pstore/r
This is a first step for adding ECC support for pstore RAM backend: we
will use the persistent_ram routines, kindly provided by Google.
Basically, persistent_ram is a set of helper routines to deal with the
[optionally] ECC-protected persistent ram regions.
A bit of Makefile, Kconfig and header f
Since ramoops was converted to pstore, it has nothing to do with character
devices nowadays. Instead, today it is just a RAM backend for pstore.
The patch just moves things around. There are a few changes were needed
because of the move:
1. Kconfig and Makefiles fixups, of course.
2. In pstore/r
A corresponding function to persistent_ram_new().
Signed-off-by: Anton Vorontsov
---
drivers/staging/android/persistent_ram.c | 15 +++
drivers/staging/android/persistent_ram.h |3 +++
2 files changed, 18 insertions(+)
diff --git a/drivers/staging/android/persistent_ram.c
b/d
This includes devices' memory (e.g. framebuffers or memory mapped
EEPROMs on a local bus), as well as the normal RAM that we don't use
for the main memory.
For the normal (but unused) ram we could use kmaps, but this assumes
highmem support, so we don't bother and just use the memory via
ioremap.
Factor out vmap logic out of persistent_ram_buffer_map(), this will
make the code a bit more understandable when we'll add support for
non-bootmem memory.
Signed-off-by: Anton Vorontsov
---
drivers/staging/android/persistent_ram.c | 19 ++-
1 file changed, 14 insertions(+), 5 d
The routine just creates a persistent ram zone at a specified address.
For persistent_ram_init_ringbuffer() we'd need to add a
'struct persistent_ram' to the global list, and associate it with a
device. We don't need all this complexity in pstore_ram, so we introduce
the simple function.
Signed-o
Factor post init logic out of __persistent_ram_init(), we'll need
it for the new persistent_ram_new() routine.
Signed-off-by: Anton Vorontsov
---
drivers/staging/android/persistent_ram.c | 44 ++
1 file changed, 27 insertions(+), 17 deletions(-)
diff --git a/driver
This is a longstanding bug, almost unnoticeable when calling
persistent_ram_write() for small buffers.
But when called for large data buffers, the write routine behaves
incorrectly, as the size may never update: instead of clamping
the size to the maximum buffer size, buffer_size_add_clamp() retur
The 'node' struct member is unused, so remove it.
Signed-off-by: Anton Vorontsov
---
drivers/staging/android/persistent_ram.c |2 --
drivers/staging/android/persistent_ram.h |1 -
2 files changed, 3 deletions(-)
diff --git a/drivers/staging/android/persistent_ram.c
b/drivers/staging/an
Hi all,
There are currently two competing debug facilities to store kernel
messages in a persistent storage: a generic pstore and Google's
persistent_ram. Not so long ago (https://lkml.org/lkml/2012/3/8/252),
it was decided that we should fix this situation.
Recently ramoops has switched to pstor
Move the module_init/module_exit routines and the associated
struct comedi_drive and struct pci_driver to the end of the
source. This is more typical of how other drivers are written and
removes the need for the forward declarations.
Convert the driver to use the module_comedi_pci_driver() macro
w
Convert the refactored comedi pci drivers to use the
module_comedi_pci_driver() macro which makes the code
smaller and a bit simpler.
In the process, rename some of the symbols in the driver
to standardize the comedi pci drivers.
Based on the driver {name}:
1) Rename the comedi_driver to {nam
Introduce the module_comedi_pci_driver macro, and the
associated register/unregister functions, which is a
convenience macro for comedi pci driver modules similar
to module_platform_driver. It is intended to be used by
drivers where the init/exit section does nothing but
register/unregister the com
On Fri, May 11, 2012 at 01:26:37PM -0500, H Hartley Sweeten wrote:
> On Friday, May 11, 2012 11:14 AM, Ian Abbott wrote:
> > Okay, but I don't think it's worth doing three patches for each driver
> > where one would do. Adding a one-line .name = "foo", to the single
> > patch for each driver you
On Friday, May 11, 2012 11:14 AM, Ian Abbott wrote:
> Okay, but I don't think it's worth doing three patches for each driver
> where one would do. Adding a one-line .name = "foo", to the single
> patch for each driver you were planning to do anyway seems like a
> trivial addition that could be
On Friday, May 11, 2012 11:15 AM, Ian Abbott wrote:
> On 2012-05-11 19:04, H Hartley Sweeten wrote:
>> On Friday, May 11, 2012 11:00 AM, Greg KH wrote:
>>> On Fri, May 11, 2012 at 10:07:43AM -0700, H Hartley Sweeten wrote:
+EXPORT_SYMBOL(comedi_pci_driver_unregister);
>>>
>>> EXPORT_SYMBOL_GPL
On Fri, May 11, 2012 at 02:14:02PM +0100, Ian Abbott wrote:
> On 2012-05-11 07:16, Dan Carpenter wrote:
> >On Thu, May 10, 2012 at 06:05:28PM -0700, H Hartley Sweeten wrote:
> >>-static const struct attribute_group comedi_sysfs_files = {
> >>- .attrs = comedi_attrs,
> >>+static struct device_att
On 2012-05-11 19:04, H Hartley Sweeten wrote:
On Friday, May 11, 2012 11:00 AM, Greg KH wrote:
On Fri, May 11, 2012 at 10:07:43AM -0700, H Hartley Sweeten wrote:
+EXPORT_SYMBOL(comedi_pci_driver_unregister);
EXPORT_SYMBOL_GPL() for these two functions?
I wasn't sure about that...
Question.
On 2012-05-11 18:50, H Hartley Sweeten wrote:
On Friday, May 11, 2012 10:42 AM, Ian Abbott wrote:
On 2012-05-11 18:34, H Hartley Sweeten wrote:
On Friday, May 11, 2012 10:32 AM, Ian Abbott wrote:
On 2012-05-11 18:07, H Hartley Sweeten wrote:
+int comedi_pci_driver_register(struct comedi_drive
On Friday, May 11, 2012 11:00 AM, Greg KH wrote:
> On Fri, May 11, 2012 at 10:07:43AM -0700, H Hartley Sweeten wrote:
>> --- a/drivers/staging/comedi/drivers.c
>> +++ b/drivers/staging/comedi/drivers.c
>> +EXPORT_SYMBOL(comedi_pci_driver_register);
>> +EXPORT_SYMBOL(comedi_pci_driver_unregist
On Fri, May 11, 2012 at 09:23:12AM -0700, Dan Magenheimer wrote:
> > From: Julian Andres Klode [mailto:j...@jak-linux.org]
> > Sent: Thursday, May 10, 2012 1:29 PM
> > To: Dan Magenheimer
> > Cc: de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org;
> > gre...@linuxfoundation.org; linux-
> > m
On Fri, May 11, 2012 at 10:07:43AM -0700, H Hartley Sweeten wrote:
> --- a/drivers/staging/comedi/drivers.c
> +++ b/drivers/staging/comedi/drivers.c
> @@ -950,6 +950,34 @@ void comedi_pci_auto_unconfig(struct pci_dev *pcidev)
> }
> EXPORT_SYMBOL_GPL(comedi_pci_auto_unconfig);
>
> +int comedi_pc
On Friday, May 11, 2012 10:42 AM, Ian Abbott wrote:
> On 2012-05-11 18:34, H Hartley Sweeten wrote:
>> On Friday, May 11, 2012 10:32 AM, Ian Abbott wrote:
>>> On 2012-05-11 18:07, H Hartley Sweeten wrote:
+int comedi_pci_driver_register(struct comedi_driver *comedi_driver,
+ stru
On 2012-05-11 18:34, H Hartley Sweeten wrote:
On Friday, May 11, 2012 10:32 AM, Ian Abbott wrote:
On 2012-05-11 18:07, H Hartley Sweeten wrote:
+int comedi_pci_driver_register(struct comedi_driver *comedi_driver,
+ struct pci_driver *pci_driver)
+{
+ int ret;
+
+ ret =
On Friday, May 11, 2012 10:32 AM, Ian Abbott wrote:
> On 2012-05-11 18:07, H Hartley Sweeten wrote:
>> +int comedi_pci_driver_register(struct comedi_driver *comedi_driver,
>> +struct pci_driver *pci_driver)
>> +{
>> +int ret;
>> +
>> +ret = comedi_driver_register(comedi_driver);
On 2012-05-11 18:07, H Hartley Sweeten wrote:
+int comedi_pci_driver_register(struct comedi_driver *comedi_driver,
+ struct pci_driver *pci_driver)
+{
+ int ret;
+
+ ret = comedi_driver_register(comedi_driver);
+ if (ret< 0)
+ return ret;
+
+ p
Introduce the module_comedi_pci_driver macro, and the
associated register/unregister functions, which is a
convenience macro for comedi pci driver modules similar
to module_platform_driver. It is intended to be used by
drivers where the init/exit section does nothing but
register/unregister the com
In commit ee6aeff, a swatch warning was fixed by moving some code inside
an if block that is executed only when the pointer padapter is not NULL.
In fact, padapter can never be NULL and the corect fix should have been
the removal of the test of padapter.
Reported-by: Ben Hutchings
Signed-off-by:
> From: Julian Andres Klode [mailto:j...@jak-linux.org]
> Sent: Thursday, May 10, 2012 1:29 PM
> To: Dan Magenheimer
> Cc: de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org;
> gre...@linuxfoundation.org; linux-
> m...@kvack.org; ngu...@vflare.org; Konrad Wilk; sjenn...@linux.vnet.ibm.com
>
On Fri, May 11, 2012 at 12:04:12PM +0100, Martyn Welch wrote:
> On 11/05/12 09:17, Samuel Iglesias Gonsalvez wrote:
> > Maintain the proper order of definitions in Kconfig following the time
> > order of
> > the commits.
> >
>
> This could probably be rolled up into patch 1.
It could, but this
On Fri, May 11, 2012 at 12:05:09PM +0100, Martyn Welch wrote:
> On 11/05/12 09:17, Samuel Iglesias Gonsalvez wrote:
> > Change the licence to explicitly GPLv2 to avoid possible conflicts in the
> > future.
> >
>
> This could also probably be rolled up into patch 4.
That's ok, one patch per drive
Hi Johan,
On Thu, May 10, 2012 at 02:07:42PM +0200, Johan Hovold wrote:
> On Wed, May 09, 2012 at 04:42:18PM +0200, Samuel Ortiz wrote:
> > Hi Johan
> >
> > On Thu, May 03, 2012 at 12:26:36PM +0200, Johan Hovold wrote:
> > > Add support for National Semiconductor / TI LM3533 lighting power chips.
On 2012-05-11 07:16, Dan Carpenter wrote:
On Thu, May 10, 2012 at 06:05:28PM -0700, H Hartley Sweeten wrote:
-static const struct attribute_group comedi_sysfs_files = {
- .attrs = comedi_attrs,
+static struct device_attribute comedi_dev_attrs[] = {
+ __ATTR(max_read_buffer_kb, S_IRU
This function is currently unused and we do not have a matching iio_device_get()
function either, so just remove it.
Signed-off-by: Lars-Peter Clausen
Acked-by: Jonathan Cameron
---
include/linux/iio/iio.h | 10 --
1 file changed, 10 deletions(-)
diff --git a/include/linux/iio/iio.h
iio_device_free has to be called regardless of whether the device has been
registered or not when freeing it.
Signed-off-by: Lars-Peter Clausen
Acked-by: Jonathan Cameron
---
drivers/staging/iio/iio_simple_dummy.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/iio/iio_s
On 11/05/12 09:17, Samuel Iglesias Gonsalvez wrote:
> Change the licence to explicitly GPLv2 to avoid possible conflicts in the
> future.
>
This could also probably be rolled up into patch 4.
Martyn
> Signed-off-by: Samuel Iglesias Gonsalvez
> ---
> drivers/staging/ipack/devices/ipoctal.c |
On 11/05/12 09:17, Samuel Iglesias Gonsalvez wrote:
> Change the licence to explicitly GPLv2 to avoid possible conflicts in the
> future.
>
This could probably be rolled up into patch 4.
Martyn
> Signed-off-by: Samuel Iglesias Gonsalvez
> ---
> drivers/staging/ipack/bridges/tpci200.c |3 +
On 11/05/12 09:17, Samuel Iglesias Gonsalvez wrote:
> Maintain the proper order of definitions in Kconfig following the time order
> of
> the commits.
>
This could probably be rolled up into patch 1.
Martyn
> Signed-off-by: Samuel Iglesias Gonsalvez
> ---
> drivers/staging/ipack/Kconfig |
This is a patch to the ni_660x.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Converted printks to pr_ and dev_
function wherver possible.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/ni_660x.c | 12 ++--
1 files change
This is a patch to the pcimio.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Converted printks to dev_ function.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/ni_pcimio.c | 16
1 files changed, 8 insertions(+),
This is a patch to the poc.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Converted printks to dev_ function.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/poc.c | 13 +++--
1 files changed, 7 insertions(+), 6 deletions(
This is a patch to the pcmad.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Converted printks to dev_ function.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/pcmad.c |7 +++
1 files changed, 3 insertions(+), 4 deletions(-)
drivers/staging/comedi/drivers/usbduxsigma.c:1085: WARNING: quoted string split
across lines
drivers/staging/comedi/drivers/usbduxsigma.c:1105: WARNING: quoted string split
across lines
drivers/staging/comedi/drivers/usbduxsigma.c:1117: WARNING: quoted string split
across lines
drivers/staging/c
This is a patch to the pcmmio.c that fixes up printk warning
found by the checkpatch.pl tool.
Used dev_ function instead of printks.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/pcmmio.c | 34 --
1 files changed, 18 inserti
This is a patch to the unioxx5.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Converted printks to dev_ functions.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/unioxx5.c | 19 ---
1 files changed, 8 insertions(+
drivers/staging/comedi/drivers/usbdux.c:2425: WARNING: quoted string split
across lines
drivers/staging/comedi/drivers/usbdux.c:2450: WARNING: quoted string split
across lines
drivers/staging/comedi/drivers/usbdux.c:2466: WARNING: quoted string split
across lines
drivers/staging/comedi/drivers/u
drivers/staging/comedi/drivers/usbdux.c:1119: WARNING: quoted string split
across lines
drivers/staging/comedi/drivers/usbdux.c:1139: WARNING: quoted string split
across lines
drivers/staging/comedi/drivers/usbdux.c:1149: WARNING: quoted string split
across lines
drivers/staging/comedi/drivers/u
This is a patch to the unioxx5.c file that fixes up a line
over 80 character warning found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/unioxx5.c | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a
This is a patch to the unioxx5.c file that fixes up a
printk warning found by the checkpatch.pl tool.
i.e. WARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ...
WARNING: Prefer pr_err(... to printk(KERN_ERR, ...
WARNING: Prefer pr_info(... to printk(KERN_INFO, ...
Signed-off-by: Ravish
This is a patch to the serial2002.c file that fixes up a
printk warning found by the checkpatch.pl tool.
This patch converts a printks to pr_ and used dev_
function wherver possible.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/serial2002.c |4 ++--
drivers/staging/comedi/drivers/das6402.c:244: ERROR: "foo * bar" should be "foo
*bar"
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/das6402.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das6402
drivers/staging/comedi/drivers/s626.c:1422: ERROR: "foo * bar" should be "foo
*bar"
drivers/staging/comedi/drivers/s626.c:1422: ERROR: "foo * bar" should be "foo
*bar"
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/s626.c |4 ++--
1 files changed, 2
This is a patch to the s626.c file that fixes up a printk found
by the checkpatch.pl tool.
Used dev_ functions instead of printks wherver possible.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/s626.c | 14 +++---
1 files changed, 7 insertions(
This is a patch to the s526.c file that fixes up a printk found
by the checkpatch.pl tool.
Used dev_ functions instead of printks wherver possible.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/s526.c | 50
1 files chan
This is a patch to the rti802.c file that fixes up a printk found
by the checkpatch.pl tool.
Used dev_*() functions instead of printks.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/rti802.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
This is a patch to the rti800.c file that fixes up a printk found
by the checkpatch.pl tool.
Used dev_*() functions instead of printks wherver possible.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/rti800.c | 26 +-
1 files cha
This is a patch to the usbduxfast.c file that fixes up a printk found
by the checkpatch.pl tool.
Used dev_*() functions instead of printks wherver possible and fixed
a quoted string split across lines warnings.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drive
This is a patch to the usbduxfast.c file that fixes up a printk found
by the checkpatch.pl tool.
Used dev_*() functions instead of printks wherver possible and fixed
a quoted string split across line warnings.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/driver
This is a patch to the usbduxfast.c file that fixes up a printk found
by checkpatch.pl tool.
i.e. WARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ...
WARNING: Prefer pr_err(... to printk(KERN_ERR, ...
WARNING: quoted string split across lines.
WARNING: Prefer pr_info(... to print
This is a patch to the usbduxfast.c file that fixes up a printk found
by the checkpatch.pl tool.
Used dev_*() functions instead of printks wherver possible and fixed
a quoted string split across line warnings.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/driver
This is a patch to the usbduxfast.c file that fixes up a printk found
by the checkpatch.pl tool.
Used dev_*() functions instead of printks wherver possible and fixed
a quoted string split across line warnings.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/driver
This is a patch to the usbduxfast.c file that fixes up a printk found
by checkpatch.pl tool.
i.e. WARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ...
WARNING: Prefer pr_err(... to printk(KERN_ERR, ...
WARNING: quoted string split across lines.
WARNING: Prefer pr_info(... to print
This is a patch to the usbduxfast.c file that fixes up a printk found
by the checkpatch.pl tool.
i.e. WARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ...
WARNING: Prefer pr_err(... to printk(KERN_ERR, ...and
WARNING: quoted string split across lines.
Signed-off-by: Ravishankar Karkal
This patch series fixes some style issues in drivers/staging/comedi/drivers
and fix some issues found by checkpatch.pl script.
Ravishankar Karkala Mallikarjunayya (25):
Staging: comedi: fix printk issue in usbduxfast.c
Staging: comedi: fix printk issues in usbduxfast.c
Staging: c
Change the licence to explicitly GPLv2 to avoid possible conflicts in the
future.
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/devices/ipoctal.c |3 +--
drivers/staging/ipack/devices/ipoctal.h |3 +--
drivers/staging/ipack/devices/scc2698.h |3 +--
3 files chang
Change the licence to explicitly GPLv2 to avoid possible conflicts in the
future.
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/bridges/tpci200.c |3 +--
drivers/staging/ipack/bridges/tpci200.h |3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/dr
Change the licence to explicitly GPLv2 to avoid possible conflicts in the
future.
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/ipack.c |3 +--
drivers/staging/ipack/ipack.h |3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ipack/
Moved the ipack source line to the proper place, at the end of the list in the
staging's Kconfig file.
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/Kconfig |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/Kconfig |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ipack/Kconfig b/drivers/staging/ipack/Kconfig
index 4f4b9d6..af32178 100644
--- a/drivers/staging/ipack/Kconfig
+++ b/drivers/stag
Added myself in the TODO file.
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/TODO |6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/staging/ipack/TODO b/drivers/staging/ipack/TODO
index 11828ed..3a45a53 100644
--- a/drivers/staging/ipack/TODO
+++ b/drivers
Maintain the proper order of definitions in Kconfig following the time order of
the commits.
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/Kconfig |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ipack/Kconfig b/drivers/staging/ipack
73 matches
Mail list logo
