On 17/05/12 07:15, H Hartley Sweeten wrote:
Wednesday, May 16, 2012 7:18 PM, Greg KH wrote:
On Wed, May 16, 2012 at 05:51:56PM -0700, H Hartley Sweeten wrote:
Convert the struct addi_board initialization to C99 format and remove
all the NULL or 0 initializers. This makes maintaining and editing
Wednesday, May 16, 2012 7:18 PM, Greg KH wrote:
> On Wed, May 16, 2012 at 05:51:56PM -0700, H Hartley Sweeten wrote:
>> Convert the struct addi_board initialization to C99 format and remove
>> all the NULL or 0 initializers. This makes maintaining and editing the
>> code simpler and less error pron
On Wed, May 16, 2012 at 05:51:56PM -0700, H Hartley Sweeten wrote:
> Convert the struct addi_board initialization to C99 format and remove
> all the NULL or 0 initializers. This makes maintaining and editing the
> code simpler and less error prone.
>
> Signed-off-by: H Hartley Sweeten
> Cc: Ian A
Introduce the module_comedi_usb_driver macro, and the
associated register/unregister functions, which is a
convenience macro for comedi usb driver modules similar
to module_platform_driver. It is intended to be used by
drivers where the init/exit section does nothing but
register/unregister the com
On Wed, May 16, 2012 at 08:05:50AM -0700, Greg Kroah-Hartman wrote:
[...]
> After applying this patch, and building things, I get the following
> errors:
>
> drivers/built-in.o: In function `ram_console_write':
> ram_console.c:(.text+0x1690b9): undefined reference to `persistent_ram_write'
> drive
On Wed, May 16, 2012 at 03:33:45PM -0700, Anton Vorontsov wrote:
> On Wed, May 16, 2012 at 09:49:11AM -0700, Kees Cook wrote:
> [...]
> > > +#ifdef CONFIG_PSTORE_CONSOLE
> > > +static void pstore_console_write(struct console *con, const char *s,
> > > unsigned c)
> > > +{
> > > + strncpy(psi
On Wed, May 16, 2012 at 5:43 AM, Anton Vorontsov
wrote:
> This is a first step for adding ECC support for pstore RAM backend: we
> will use the persistent_ram routines, kindly provided by Google.
>
> Basically, persistent_ram is a set of helper routines to deal with the
> [optionally] ECC-protecte
On Wed, May 16, 2012 at 09:49:11AM -0700, Kees Cook wrote:
[...]
> > +#ifdef CONFIG_PSTORE_CONSOLE
> > +static void pstore_console_write(struct console *con, const char *s,
> > unsigned c)
> > +{
> > + strncpy(psinfo->buf, s, c);
>
> The size of psinfo->buf needs to be the length argument t
On Wed, May 16, 2012 at 09:45:35AM -0700, Kees Cook wrote:
> On Wed, May 16, 2012 at 5:56 AM, Anton Vorontsov
> wrote:
> > This is all straightforward: we just use the last region for
> > console logging. If there's just one region, we fall-back to
> > the old behaviour: just a oops/dumps logging.
On Wed, May 16, 2012 at 3:11 PM, Anton Vorontsov wrote:
> On Wed, May 16, 2012 at 10:56:09AM -0700, Colin Cross wrote:
> [...]
>> > +You can specify either RAM memory or peripheral devices' memory. However,
>> > when
>> > +specifying RAM, be sure to reserve the memory by issuing
>> > memblock_re
On Wed, May 16, 2012 at 09:30:52AM -0600, Shuah Khan wrote:
> On Wed, 2012-05-16 at 05:56 -0700, Anton Vorontsov wrote:
> > This is all straightforward: we just use the last region for
> > console logging. If there's just one region, we fall-back to
> > the old behaviour: just a oops/dumps logging.
On Wed, May 16, 2012 at 10:56:09AM -0700, Colin Cross wrote:
[...]
> > +You can specify either RAM memory or peripheral devices' memory. However,
> > when
> > +specifying RAM, be sure to reserve the memory by issuing memblock_reserve()
> > +very early in the architecture code, just before platform
On Wed, May 16, 2012 at 4:24 PM, Greg KH wrote:
> On Tue, May 15, 2012 at 11:05:57PM -0400, Kevin McKinney wrote:
>> This patch fixes all whitespace and brace issues
>> reported by checkpatch.pl.
>
> Ugh, this is a huge patch, how about doing one and then the other, that
> should make it easier to
Set the hid drvdata prior to invoking hid_add_device() as hid_add_device()
expects this state to be set. This bug was introduced in the recent hid
changes that were made in:
commit 07d9ab4f0e52cb2a383596e5ebbbd20232501393
HID: hid-hyperv: Do not use hid_parse_report() directly
Signed-off-by: K. Y
On Wed, May 16, 2012 at 09:47:40PM +0200, Geert Uytterhoeven wrote:
> Use Kconfig logic instead of a rude #error in the driver source,
> which breaks m68k-allmodconfig.
> Also remove the "default n", as that's the default.
>
> Signed-off-by: Geert Uytterhoeven
> ---
> http://kisskb.ellerman.id.au
On Tue, May 15, 2012 at 11:05:57PM -0400, Kevin McKinney wrote:
> This patch fixes all whitespace and brace issues
> reported by checkpatch.pl.
Ugh, this is a huge patch, how about doing one and then the other, that
should make it easier to review, right?
thanks,
greg k-h
___
On Wed, May 16, 2012 at 01:19:57PM +0300, Dan Carpenter wrote:
> On Wed, May 16, 2012 at 05:08:25PM +0800, edwin_rong wrote:
> > On 05/16/2012 03:20 PM, Dan Carpenter wrote:
> > > When is the new driver going to be released? How can we tell if
> > > it's better than the cleaned up staging driver w
Use Kconfig logic instead of a rude #error in the driver source,
which breaks m68k-allmodconfig.
Also remove the "default n", as that's the default.
Signed-off-by: Geert Uytterhoeven
---
http://kisskb.ellerman.id.au/kisskb/buildresult/6335693/
drivers/staging/gdm72xx/Kconfig |2 +-
driver
On Wed, May 16, 2012 at 5:56 AM, Anton Vorontsov
wrote:
> Suggested-by: Shuah Khan
> Signed-off-by: Anton Vorontsov
> ---
> Documentation/ramoops.txt | 15 +++
> 1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/ramoops.txt b/Documentation/ramoops.txt
> index 4ba7db2
On Wed, May 16, 2012 at 10:29:46AM -0600, Shuah Khan wrote:
> On Wed, 2012-05-16 at 08:05 -0700, Greg Kroah-Hartman wrote:
>
> >
> > After applying this patch, and building things, I get the following
> > errors:
>
> Greg,
>
> > What went wrong?
> >
> > I've now applied the first 3 patches in
On Wed, May 16, 2012 at 5:56 AM, Anton Vorontsov
wrote:
> Pstore doesn't support logging kernel messages in run-time, it only
> dumps dmesg when kernel oopses/panics. This makes pstore useless for
> debugging hangs caused by HW issues or improper use of HW (e.g.
> weird device inserted -> driver t
On Wed, May 16, 2012 at 5:56 AM, Anton Vorontsov
wrote:
> This is all straightforward: we just use the last region for
> console logging. If there's just one region, we fall-back to
> the old behaviour: just a oops/dumps logging.
>
> Signed-off-by: Anton Vorontsov
> ---
> fs/pstore/ram.c | 39
On Wed, 2012-05-16 at 08:05 -0700, Greg Kroah-Hartman wrote:
>
> After applying this patch, and building things, I get the following
> errors:
Greg,
> What went wrong?
>
> I've now applied the first 3 patches in this series to my tree, plus the
> 2 others from the linux-next tree, so care to j
On Wed, 2012-05-16 at 05:56 -0700, Anton Vorontsov wrote:
> This is all straightforward: we just use the last region for
> console logging. If there's just one region, we fall-back to
> the old behaviour: just a oops/dumps logging.
What about the saving /proc/last_kmsg? Are you not bringing that f
Hi Anton,
Ignore my previous email. I am still getting caught up with your
patches.
On Wed, 2012-05-16 at 05:56 -0700, Anton Vorontsov wrote:
> Suggested-by: Shuah Khan
> Signed-off-by: Anton Vorontsov
> ---
> Documentation/ramoops.txt | 15 +++
> 1 file changed, 15 insertions(+)
On Wed, 2012-05-16 at 00:30 -0700, Anton Vorontsov wrote:
> Hi Shuah,
>
> On Tue, May 15, 2012 at 09:12:59AM -0600, Shuah Khan wrote:
> > On Fri, 2012-05-11 at 17:18 -0700, Anton Vorontsov wrote:
> > > Since ramoops was converted to pstore, it has nothing to do with character
> > > devices nowaday
On Wed, May 16, 2012 at 05:43:38AM -0700, Anton Vorontsov wrote:
> This is a first step for adding ECC support for pstore RAM backend: we
> will use the persistent_ram routines, kindly provided by Google.
>
> Basically, persistent_ram is a set of helper routines to deal with the
> [optionally] ECC
On 5/16/2012 2:05 PM, Johan Hovold wrote:
On Tue, May 15, 2012 at 09:00:46PM +0100, Jonathan Cameron wrote:
On 05/15/2012 05:44 PM, Johan Hovold wrote:
On Tue, May 08, 2012 at 02:47:19PM +0100, Jonathan Cameron wrote:
On 5/3/2012 5:36 PM, Johan Hovold wrote:
On Thu, May 03, 2012 at 12:40:10PM
On Wed, May 16, 2012 at 06:57:49AM -0700, Anton Vorontsov wrote:
> On Wed, May 16, 2012 at 06:17:51AM -0700, Greg Kroah-Hartman wrote:
> [...]
> > > --- a/drivers/char/Kconfig
> > > +++ b/drivers/char/Kconfig
> > > @@ -585,15 +585,6 @@ config DEVPORT
> > >
> > > source "drivers/s390/char/Kconfig
On Wed, May 16, 2012 at 06:17:51AM -0700, Greg Kroah-Hartman wrote:
[...]
> > --- a/drivers/char/Kconfig
> > +++ b/drivers/char/Kconfig
> > @@ -585,15 +585,6 @@ config DEVPORT
> >
> > source "drivers/s390/char/Kconfig"
> >
> > -config RAMOOPS
> > - tristate "Log panic/oops to a RAM buffer"
>
On Wed, May 16, 2012 at 05:41:09AM -0700, Anton Vorontsov wrote:
> Hi all,
>
> Here is v2 of the previous patch set. The series do not include
> patches that were already merged.
>
> I believe I addressed all the previous comments, plus now the
> series include another small cleanup patch.
I've
On Wed, May 16, 2012 at 05:43:08AM -0700, Anton Vorontsov wrote:
> Since ramoops was converted to pstore, it has nothing to do with character
> devices nowadays. Instead, today it is just a RAM backend for pstore.
>
> The patch just moves things around. There are a few changes were needed
> becaus
On Tue, May 15, 2012 at 09:00:46PM +0100, Jonathan Cameron wrote:
> On 05/15/2012 05:44 PM, Johan Hovold wrote:
> > On Tue, May 08, 2012 at 02:47:19PM +0100, Jonathan Cameron wrote:
> >> On 5/3/2012 5:36 PM, Johan Hovold wrote:
> >>> On Thu, May 03, 2012 at 12:40:10PM +0100, Jonathan Cameron wrote:
The code tried to maintain the global list of persistent ram zones,
which isn't a great idea overall, plus since Android's ram_console
is no longer there, we can remove some unused functions.
Signed-off-by: Anton Vorontsov
---
fs/pstore/ram_core.c | 77 ---
All the functionality is now supported by pstore and pstore_ram drivers.
Signed-off-by: Anton Vorontsov
---
drivers/staging/android/Kconfig |5 -
drivers/staging/android/Makefile |1 -
drivers/staging/android/ram_console.c | 179 -
3 files chan
Suggested-by: Shuah Khan
Signed-off-by: Anton Vorontsov
---
Documentation/ramoops.txt | 15 +++
1 file changed, 15 insertions(+)
diff --git a/Documentation/ramoops.txt b/Documentation/ramoops.txt
index 4ba7db2..138823b 100644
--- a/Documentation/ramoops.txt
+++ b/Documentation/ram
Since we use multiple regions, the messages are somewhat annoying.
We do print total mapped memory already, so no need to print the
information for each region in the library routines.
Signed-off-by: Anton Vorontsov
---
fs/pstore/ram_core.c |4 ++--
1 file changed, 2 insertions(+), 2 deletio
This is all straightforward: we just use the last region for
console logging. If there's just one region, we fall-back to
the old behaviour: just a oops/dumps logging.
Signed-off-by: Anton Vorontsov
---
fs/pstore/ram.c | 39 ++-
1 file changed, 30 insertions
Pstore doesn't support logging kernel messages in run-time, it only
dumps dmesg when kernel oopses/panics. This makes pstore useless for
debugging hangs caused by HW issues or improper use of HW (e.g.
weird device inserted -> driver tried to write a reserved bits ->
SoC hanged. In that case we don'
Hi all,
Currently pstore doesn't support logging kernel messages in run-time,
it only dumps dmesg when kernel oopses/panics. This makes pstore
useless for debugging hangs caused by HW issues or improper use of HW
(e.g. weird device inserted -> driver tried to write reserved bits ->
SoC hanged. In
On Wed, May 16, 2012 at 5:43 AM, Anton Vorontsov
wrote:
> Since ramoops was converted to pstore, it has nothing to do with character
> devices nowadays. Instead, today it is just a RAM backend for pstore.
>
> The patch just moves things around. There are a few changes were needed
> because of the
This is now straightforward: just introduce a module parameter and pass
the needed value to persistent_ram_new().
Signed-off-by: Anton Vorontsov
Acked-by: Marco Stornelli
Acked-by: Kees Cook
---
Documentation/ramoops.txt |6 ++
fs/pstore/ram.c| 15 ---
includ
The patch switches pstore RAM backend to use persistent_ram routines,
one step closer to the ECC support.
Signed-off-by: Anton Vorontsov
Acked-by: Marco Stornelli
---
fs/pstore/ram.c | 106 +++
1 file changed, 59 insertions(+), 47 deletions(-
This is a first step for adding ECC support for pstore RAM backend: we
will use the persistent_ram routines, kindly provided by Google.
Basically, persistent_ram is a set of helper routines to deal with the
[optionally] ECC-protected persistent ram regions.
A bit of Makefile, Kconfig and header f
This is a transition patch to keep things bisectable, just moves
some routines under '#ifndef MODULE'. The code inside the #ifndef
will go away soon, but so far we must support pstore and ram_console.
So, we are about to use persistent_ram with pstore, with the ability
to compile persistent_ram ro
Since ramoops was converted to pstore, it has nothing to do with character
devices nowadays. Instead, today it is just a RAM backend for pstore.
The patch just moves things around. There are a few changes were needed
because of the move:
1. Kconfig and Makefiles fixups, of course.
2. In pstore/r
Remove 'old_log_footer_size' and 'early' members of struct
persistent_ram_zone, as these were never used at all.
Signed-off-by: Anton Vorontsov
---
drivers/staging/android/persistent_ram.h |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/android/persistent_ram.h
b/drivers
On Tue, May 15, 2012 at 11:14 PM, Anton Vorontsov
wrote:
> Hello Kees,
>
> On Mon, May 14, 2012 at 03:21:17PM -0700, Kees Cook wrote:
> [...]
>> > - buf = cxt->virt_addr + (id * cxt->record_size);
>> > - memset(buf, '\0', cxt->record_size);
>> > + persistent_ram_free_old(cxt->prz
Hi all,
Here is v2 of the previous patch set. The series do not include
patches that were already merged.
I believe I addressed all the previous comments, plus now the
series include another small cleanup patch.
Here's some background for the series:
There are currently two competing debug faci
On Wed, May 16, 2012 at 05:08:25PM +0800, edwin_rong wrote:
> On 05/16/2012 03:20 PM, Dan Carpenter wrote:
> > When is the new driver going to be released? How can we tell if
> > it's better than the cleaned up staging driver without seeing it?
> >
> > regards,
> > dan carpenter
> Hi Dan carpenter
On 05/16/2012 03:20 PM, Dan Carpenter wrote:
> When is the new driver going to be released? How can we tell if
> it's better than the cleaned up staging driver without seeing it?
>
> regards,
> dan carpenter
Hi Dan carpenter,
> When is the new driver going to be released?
I'm afraid it will take
On 05/16/2012 04:02 PM, Oleksij Rempel wrote:
Am 16.05.2012 04:16, schrieb edwin_rong:
On 05/15/2012 11:39 PM, Greg KH wrote:
On Tue, May 15, 2012 at 10:36:32AM +0800, edwin_r...@realsil.com.cn wrote:
From: edwin_rong
Recently we find that many warm-hearted people are helping improving the
co
Am 16.05.2012 04:16, schrieb edwin_rong:
> On 05/15/2012 11:39 PM, Greg KH wrote:
>> On Tue, May 15, 2012 at 10:36:32AM +0800, edwin_r...@realsil.com.cn wrote:
>>> From: edwin_rong
>>>
>>> Recently we find that many warm-hearted people are helping improving the
>>> coding style and something else
Hi Shuah,
On Tue, May 15, 2012 at 09:12:59AM -0600, Shuah Khan wrote:
> On Fri, 2012-05-11 at 17:18 -0700, Anton Vorontsov wrote:
> > Since ramoops was converted to pstore, it has nothing to do with character
> > devices nowadays. Instead, today it is just a RAM backend for pstore.
> >
> > The pa
When is the new driver going to be released? How can we tell if
it's better than the cleaned up staging driver without seeing it?
regards,
dan carpenter
___
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/
55 matches
Mail list logo
