[PATCH] staging: comedi: remove all 'default N' in Kconfig

2012-05-17 Thread H Hartley Sweeten
Remove all the 'default N' lines in the comedi Kconfig. They should all be 'default n' but that is the default anyway. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Mori Hess Cc: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig index a

RE: [PATCH] staging: comedi: Convert struct addi_board initialization to C99 format

2012-05-17 Thread H Hartley Sweeten
On Thursday, May 17, 2012 11:29 AM, Ian Abbott wrote: > On 17/05/2012 17:38, H Hartley Sweeten wrote: >> BTW, what actual hardware do you have available to test with? > > Not a lot. Just the Amplicon cards (amplc_* drivers). Speaking of the amplc_* drivers... What's up with them? The dio200, pc2

Re: [PATCH v2 0/6] Merge ram_console into pstore

2012-05-17 Thread Colin Cross
On Thu, May 17, 2012 at 1:37 AM, Anton Vorontsov wrote: > Hi all, > > In v2: > > - Updated documentation per Colin Cross' comments; > - Corrected return value in ramoops_pstore_write() (noticed by Kees Cook); > - Fixed large writes handling in pstore_console_write(), i.e. when >  log_buf write is

Re: [PATCH] staging: comedi: Convert struct addi_board initialization to C99 format

2012-05-17 Thread Ian Abbott
On 17/05/2012 17:38, H Hartley Sweeten wrote: On Thursday, May 17, 2012 8:58 AM, Ian Abbott wrote: On 2012/05/17 02:32 PM, Greg KH wrote: I thought a few years ago, either you, or someone else, said it would be good to just delete them entirely. Or am I making that up and just wish it would be

Re: [PATCH 2/6] pstore/ram: Add console messages handling

2012-05-17 Thread Colin Cross
On Thu, May 17, 2012 at 1:40 AM, Anton Vorontsov wrote: > This is all straightforward: we just use the last region for > console logging. If there's just one region, we fall-back to > the old behaviour: just a oops/dumps logging. > > Signed-off-by: Anton Vorontsov I don't think using the last re

[PATCH] staging: gdm72xx: Set up parent link in sysfs for gdm72xx devices

2012-05-17 Thread Ben Chan
From: Paul Stewart This patch uses SET_NETDEV_DEV to set up a 'device' parent link in sysfs (e.g. /sys/class/net/wm0/device) for a gdm72xx device. Signed-off-by: Paul Stewart Signed-off-by: Ben Chan Cc: Sage Ahn --- drivers/staging/gdm72xx/gdm_sdio.c |2 +- drivers/staging/gdm72xx/gdm_u

Re: [PATCH 6/6] pstore/ram_core: Remove now unused code

2012-05-17 Thread Kees Cook
On Thu, May 17, 2012 at 1:41 AM, Anton Vorontsov wrote: > The code tried to maintain the global list of persistent ram zones, > which isn't a great idea overall, plus since Android's ram_console > is no longer there, we can remove some unused functions. > > Signed-off-by: Anton Vorontsov Acked-b

Re: [PATCH 3/6] pstore/ram_core: Silence some printks

2012-05-17 Thread Kees Cook
On Thu, May 17, 2012 at 1:40 AM, Anton Vorontsov wrote: > Since we use multiple regions, the messages are somewhat annoying. > We do print total mapped memory already, so no need to print the > information for each region in the library routines. > > Signed-off-by: Anton Vorontsov Acked-by: Kees

RE: [PATCH] staging: comedi: Convert struct addi_board initialization to C99 format

2012-05-17 Thread H Hartley Sweeten
On Thursday, May 17, 2012 8:58 AM, Ian Abbott wrote: > On 2012/05/17 02:32 PM, Greg KH wrote: >> I thought a few years ago, either you, or someone else, said it would be >> good to just delete them entirely. Or am I making that up and just wish >> it would be so? :) > > I can't remember at my age

Re: [PATCH 2/6] pstore/ram: Add console messages handling

2012-05-17 Thread Kees Cook
On Thu, May 17, 2012 at 1:40 AM, Anton Vorontsov wrote: > This is all straightforward: we just use the last region for > console logging. If there's just one region, we fall-back to > the old behaviour: just a oops/dumps logging. > > Signed-off-by: Anton Vorontsov Acked-by: Kees Cook -Kees --

Re: [PATCH 2/3] pstore/ram: Switch to persistent_ram routines

2012-05-17 Thread Kees Cook
On Thu, May 17, 2012 at 12:15 AM, Anton Vorontsov wrote: > The patch switches pstore RAM backend to use persistent_ram routines, > one step closer to the ECC support. > > Signed-off-by: Anton Vorontsov > Acked-by: Marco Stornelli > --- >  fs/pstore/ram.c |  106 > +++

Re: [PATCH 1/6] pstore: Add console log messages support

2012-05-17 Thread Kees Cook
On Thu, May 17, 2012 at 1:40 AM, Anton Vorontsov wrote: > Pstore doesn't support logging kernel messages in run-time, it only > dumps dmesg when kernel oopses/panics. This makes pstore useless for > debugging hangs caused by HW issues or improper use of HW (e.g. > weird device inserted -> driver t

[PATCH -next] staging: gdm72xx depends on NET

2012-05-17 Thread Randy Dunlap
_schedule" [drivers/staging/gdm72xx/gdmwm.ko] undefined! ERROR: "skb_put" [drivers/staging/gdm72xx/gdmwm.ko] undefined! ERROR: "sock_wfree" [drivers/staging/gdm72xx/gdmwm.ko] undefined! ERROR: "__nlmsg_put" [drivers/staging/gdm72xx/gdmwm.ko] undefined! Signed-

Re: [PATCH] staging: comedi: Convert struct addi_board initialization to C99 format

2012-05-17 Thread Ian Abbott
On 2012/05/17 02:32 PM, Greg KH wrote: > On Thu, May 17, 2012 at 07:45:08AM +0100, Ian Abbott wrote: >> On 17/05/12 07:15, H Hartley Sweeten wrote: >>> Wednesday, May 16, 2012 7:18 PM, Greg KH wrote: On Wed, May 16, 2012 at 05:51:56PM -0700, H Hartley Sweeten wrote: > Convert the struct ad

Re: [PATCH v3 0/3] Merge ramoops and persistent_ram, generic pstore RAM backend

2012-05-17 Thread Greg Kroah-Hartman
On Thu, May 17, 2012 at 12:11:48AM -0700, Anton Vorontsov wrote: > Hi all, > > Here comes v3: > > - Rebased on current staging-next tree, so only 3 patches left; > - Fixed ram_console dependency in Kconfig (issue noticed by Greg KH). Nice, thanks for reworking this, now applied. greg k-h __

Re: [PATCH] staging: comedi: Convert struct addi_board initialization to C99 format

2012-05-17 Thread Greg KH
On Thu, May 17, 2012 at 07:45:08AM +0100, Ian Abbott wrote: > On 17/05/12 07:15, H Hartley Sweeten wrote: > >Wednesday, May 16, 2012 7:18 PM, Greg KH wrote: > >>On Wed, May 16, 2012 at 05:51:56PM -0700, H Hartley Sweeten wrote: > >>>Convert the struct addi_board initialization to C99 format and rem

[PATCH 6/6] pstore/ram_core: Remove now unused code

2012-05-17 Thread Anton Vorontsov
The code tried to maintain the global list of persistent ram zones, which isn't a great idea overall, plus since Android's ram_console is no longer there, we can remove some unused functions. Signed-off-by: Anton Vorontsov --- fs/pstore/ram_core.c | 77 ---

[PATCH 5/6] staging/android: Remove ram_console driver

2012-05-17 Thread Anton Vorontsov
All the functionality is now supported by pstore and pstore_ram drivers. Signed-off-by: Anton Vorontsov --- drivers/staging/android/Kconfig |5 - drivers/staging/android/Makefile |1 - drivers/staging/android/ram_console.c | 179 - 3 files chan

[PATCH 4/6] pstore/ram: Add some more documentation and examples

2012-05-17 Thread Anton Vorontsov
Suggested-by: Shuah Khan Signed-off-by: Anton Vorontsov --- Documentation/ramoops.txt | 14 ++ 1 file changed, 14 insertions(+) diff --git a/Documentation/ramoops.txt b/Documentation/ramoops.txt index 4ba7db2..59a74a8 100644 --- a/Documentation/ramoops.txt +++ b/Documentation/ramo

[PATCH 2/6] pstore/ram: Add console messages handling

2012-05-17 Thread Anton Vorontsov
This is all straightforward: we just use the last region for console logging. If there's just one region, we fall-back to the old behaviour: just a oops/dumps logging. Signed-off-by: Anton Vorontsov --- fs/pstore/ram.c | 40 +++- 1 file changed, 31 insertion

[PATCH 3/6] pstore/ram_core: Silence some printks

2012-05-17 Thread Anton Vorontsov
Since we use multiple regions, the messages are somewhat annoying. We do print total mapped memory already, so no need to print the information for each region in the library routines. Signed-off-by: Anton Vorontsov --- fs/pstore/ram_core.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletio

[PATCH 1/6] pstore: Add console log messages support

2012-05-17 Thread Anton Vorontsov
Pstore doesn't support logging kernel messages in run-time, it only dumps dmesg when kernel oopses/panics. This makes pstore useless for debugging hangs caused by HW issues or improper use of HW (e.g. weird device inserted -> driver tried to write a reserved bits -> SoC hanged. In that case we don'

[PATCH v2 0/6] Merge ram_console into pstore

2012-05-17 Thread Anton Vorontsov
Hi all, In v2: - Updated documentation per Colin Cross' comments; - Corrected return value in ramoops_pstore_write() (noticed by Kees Cook); - Fixed large writes handling in pstore_console_write(), i.e. when log_buf write is larger than pstore bufsize. Also Noticed by Kees Cook. These patches

Re: [PATCH 1/1] Drivers: hid: hid-hyperv.c: Set the hid drvdata correctly

2012-05-17 Thread Jiri Kosina
On Wed, 16 May 2012, K. Y. Srinivasan wrote: > Set the hid drvdata prior to invoking hid_add_device() as hid_add_device() > expects this state to be set. This bug was introduced in the recent hid > changes that were made in: > > commit 07d9ab4f0e52cb2a383596e5ebbbd20232501393 > HID: hid-hyperv: D

[PATCH 2/3] pstore/ram: Switch to persistent_ram routines

2012-05-17 Thread Anton Vorontsov
The patch switches pstore RAM backend to use persistent_ram routines, one step closer to the ECC support. Signed-off-by: Anton Vorontsov Acked-by: Marco Stornelli --- fs/pstore/ram.c | 106 +++ 1 file changed, 59 insertions(+), 47 deletions(-

[PATCH 3/3] pstore/ram: Add ECC support

2012-05-17 Thread Anton Vorontsov
This is now straightforward: just introduce a module parameter and pass the needed value to persistent_ram_new(). Signed-off-by: Anton Vorontsov Acked-by: Marco Stornelli Acked-by: Kees Cook --- Documentation/ramoops.txt |6 ++ fs/pstore/ram.c| 15 --- includ

[PATCH 1/3] persistent_ram: Move to fs/pstore/ram_core.c

2012-05-17 Thread Anton Vorontsov
This is a first step for adding ECC support for pstore RAM backend: we will use the persistent_ram routines, kindly provided by Google. Basically, persistent_ram is a set of helper routines to deal with the [optionally] ECC-protected persistent ram regions. A bit of Makefile, Kconfig and header f

[PATCH v3 0/3] Merge ramoops and persistent_ram, generic pstore RAM backend

2012-05-17 Thread Anton Vorontsov
Hi all, Here comes v3: - Rebased on current staging-next tree, so only 3 patches left; - Fixed ram_console dependency in Kconfig (issue noticed by Greg KH). And the boilerplate, background for the series: There are currently two competing debug facilities to store kernel messages in a persiste