Use the newly introduced NVEC_CALL to cleanup the various nvec
command strings in the nvec driver.
Signed-off-by: Marc Dietrich
---
drivers/staging/nvec/nvec.c | 39 +++--
drivers/staging/nvec/nvec.h | 49 -
drivers/stag
The led driver used OEM commands which are not part of the nvec protocol
definition. Therefore it is renamed to nvec_paz00 to reflect that it only
applies to PAZ00 board based devices.
Signed-off-by: Marc Dietrich
---
drivers/staging/nvec/Kconfig |9
drivers/st
Add a helper macro to wrap nvec_{a}sync_writes and to get rid of
the various strings distributed all over the nvec code.
Signed-off-by: Marc Dietrich
---
drivers/staging/nvec/nvec.h | 38 ++
1 file changed, 38 insertions(+)
diff --git a/drivers/staging/nvec
This patch simplifies code by using the module_platform_driver
and SIMPLE_DEV_PM_OPS macros.
Signed-off-by: Marc Dietrich
---
drivers/staging/nvec/nvec.c | 27 +++
drivers/staging/nvec/nvec_kbd.c |7 +--
drivers/staging/nvec/nvec_leds.c | 14 +---
This series cleanups the nvec code a bit. The LED driver is renamed to
paz00 because it only makes sense on this device.
Some plan for the future:
- add device tree init for the mfd childs and remove the hard coded
(device dependent) init from the core driver
- add a gpio and event dri
This patch cleanups the nvec and its childs by replacing calls to
resource allocations by their devm_* equivalents.
Signed-off-by: Marc Dietrich
---
drivers/staging/nvec/nvec.c | 43 -
drivers/staging/nvec/nvec_leds.c | 10 +++--
drivers/staging
dont sent any more email to me..
-Özgün İleti- From: devel-requ...@linuxdriverproject.org Sent:
Thursday, May 24, 2012 10:00 PM To: devel@linuxdriverproject.org Subject:
devel Digest, Vol 57, Issue 179
Send devel mailing list submissions to
devel@linuxdriverproject.org
To subscribe
On 2012-05-24 17:36, H Hartley Sweeten wrote:
On Thursday, May 24, 2012 9:27 AM, Ian Abbott wrote:
If PCI boards are supported, use the module_comedi_pci_driver() macro to
register the module as a comedi driver and a PCI driver. Otherwise, if
ISA (or PC/104) boards are supported, use the module
On Thursday, May 24, 2012 9:27 AM, Ian Abbott wrote:
> If PCI boards are supported, use the module_comedi_pci_driver() macro to
> register the module as a comedi driver and a PCI driver. Otherwise, if
> ISA (or PC/104) boards are supported, use the module_comedi_driver()
> macro to register the mo
Implement the attach_pci() hook. This is called by
comedi_pci_auto_config() in preference to the old attach() hook and
avoids searching for the probed PCI device. Factor out some common code
used by both the attach() and attach_pci() hooks into a couple of new
functions, das08_pci_attach_common()
Don't deal with allocation and deallocation of I/O resources and PCI
enabling/disabling in the exported functions das08_common_attach() and
das08_common_detach(). Do it in das08_attach() and new function
das08_detach() (which is now the comedi detach() hook for this driver).
This keeps things mor
If PCI boards are supported, use the module_comedi_pci_driver() macro to
register the module as a comedi driver and a PCI driver. Otherwise, if
ISA (or PC/104) boards are supported, use the module_comedi_driver()
macro to register the module as a comedi driver. Otherwise, this is
only a helper mo
Rename the existing board entry named "das08" for the PCI-DAS08 board to
"pci-das08". Add a new wildcard board entry called "das08" that will
match any supported PCI board. If 'dev->board_ptr' points to the
wildcard board entry in the ->attach() routine, it will be replaced with
a supported PCI b
Moved some functions to avoid forward declarations. Moved a few other
bits at the same time to keep EXPORT_SYMBOL{,_GPL}() close to the symbol
being exported, and PCI table close to the code that refers to it.
Changed whitespace in das08_board[] and das08_cs_board[] initializers.
Signed-off-by:
The 'thisboard' and 'devpriv' macros rely on a local variable having a
specific name and yield pointers derived from that local variable.
Replace the macros with local variables wherever they occur.
Signed-off-by: Ian Abbott
---
v2: Removed some variables unused in original patch. (Was PATCH 7/9
Replace the printk calls with dev_info, dev_err, etc. Some of the
printk strings were missing newlines on the end.
Signed-off-by: Ian Abbott
---
v2: Fixed compiler error.
Removed commented out printk calls instead of converting them.
(Was PATCH 6/9.)
---
drivers/staging/comedi/drivers/d
On Thursday, May 24, 2012 8:16 AM, Ian Abbott wrote:
> On 2012-05-23 21:22, Dan Carpenter wrote:
>> On Wed, May 23, 2012 at 05:50:28PM +0100, Ian Abbott wrote:
>>> +
>>> +#if IS_ENABLED(CONFIG_COMEDI_DAS08_PCI)
>>> +static const struct das08_board_struct
>>> +*das08_find_pci_board(struct pci_dev *p
This replaces the set of 9 patches posted earlier to fix various
problems highlighted by Dan Carpenter and H Hartley Sweeten.
The original PATCH 2/9 ("Check bus type is supported") has been changed to
one that moves I/O resource (de)allocation and PCI (en,dis)abling around
so das08_common_attach()
Change conditional compilation on kernel config options to use the
IS_ENABLED() macro.
Signed-off-by: Ian Abbott
---
v2: No change.
---
drivers/staging/comedi/drivers/das08.c | 50 +---
1 files changed, 20 insertions(+), 30 deletions(-)
diff --git a/drivers/staging
On Thu, May 24, 2012 at 04:15:38PM +0100, Ian Abbott wrote:
> On 2012-05-23 21:22, Dan Carpenter wrote:
> >On Wed, May 23, 2012 at 05:50:28PM +0100, Ian Abbott wrote:
> >>+
> >>+#if IS_ENABLED(CONFIG_COMEDI_DAS08_PCI)
> >>+static const struct das08_board_struct
> >>+*das08_find_pci_board(struct pci
On 2012-05-23 21:22, Dan Carpenter wrote:
On Wed, May 23, 2012 at 05:50:28PM +0100, Ian Abbott wrote:
+
+#if IS_ENABLED(CONFIG_COMEDI_DAS08_PCI)
+static const struct das08_board_struct
+*das08_find_pci_board(struct pci_dev *pdev)
Normally the * would go on the first line.
static const struct
yollama e mailini yeter...
Send devel mailing list submissions to
devel@linuxdriverproject.org
To subscribe or unsubscribe via the World Wide Web, visit
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
or, via email, send a message with subject or body 'help' to
devel-requ...@linuxdr
On Thu, May 24, 2012 at 2:17 AM, Dan Carpenter wrote:
> On Wed, May 23, 2012 at 11:16:29PM -0400, klmckinn...@gmail.com wrote:
>> From: Kevin McKinney
>>
>> This patch adds typedef back for bcm_ip_address
>> and convert the struct back to union. All calls
>> to the struct are changed to call the
Please ignore this set of 9 patches. I'll post a new set addressing the
various concerns.
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
___
devel mailing list
devel@linuxdriverp
On 2012-05-24 12:16, Dan Carpenter wrote:
On Thu, May 24, 2012 at 11:57:44AM +0100, Ian Abbott wrote:
On 2012-05-24 11:28, Dan Carpenter wrote:
This function is more complicated than it needs to be because of the
consts. It's not worth saving them because we drop the consts anyway
when we retu
On Thu, May 24, 2012 at 11:57:44AM +0100, Ian Abbott wrote:
> On 2012-05-24 11:28, Dan Carpenter wrote:
> >This function is more complicated than it needs to be because of the
> >consts. It's not worth saving them because we drop the consts anyway
> >when we return (void *)name_ptr.
> >
> >Signed-
On 2012-05-24 11:28, Dan Carpenter wrote:
This function is more complicated than it needs to be because of the
consts. It's not worth saving them because we drop the consts anyway
when we return (void *)name_ptr.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/comedi/drivers.c b/driv
This function is more complicated than it needs to be because of the
consts. It's not worth saving them because we drop the consts anyway
when we return (void *)name_ptr.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
index 1c3d638.
On Sat 2012-05-19 21:25:08, vamsi prasanth wrote:
> ---
> drivers/staging/winbond/wb35tx.c | 63
> +++---
> 1 file changed, 31 insertions(+), 32 deletions(-)
ACK.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.c
On 2012-05-23 20:58, Dan Carpenter wrote:
On Wed, May 23, 2012 at 12:58:13PM -0500, H Hartley Sweeten wrote:
On Wednesday, May 23, 2012 9:50 AM, Ian Abbott wrote:
@@ -839,10 +838,10 @@ int das08_common_attach(struct comedi_device *dev,
unsigned long iobase)
case isa:
case pc1
On 2012-05-23 20:07, Dan Carpenter wrote:
On Wed, May 23, 2012 at 11:28:32AM -0500, H Hartley Sweeten wrote:
This would allow comedi_recognize() to walk the boardinfo
to find the match without all the ugly casts.
That function wouldn't be so bad if we just removed all the consts.
There is no p
31 matches
Mail list logo
