On Tue, Jun 12, 2012 at 03:20:32PM -0500, H Hartley Sweeten wrote:
> On Tuesday, June 12, 2012 12:50 PM, Dan Carpenter wrote:
> > On Tue, Jun 12, 2012 at 11:59:55AM -0700, H Hartley Sweeten wrote:
> >>for (i = 0; i < num_subdevices; ++i) {
> >> - dev->subdevices[i].device = dev;
> >> -
Added a do ... while (0) to a multi statement macro and reformatted a similar
macro.
Signed-off-by: William Blair
---
drivers/staging/keucr/scsiglue.c | 11 ---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/keucr/scsiglue.c b/drivers/staging/keucr/scsi
On 12/06/2012, Greg KH wrote:
> On Tue, Jun 05, 2012 at 04:40:10PM +0530, Sachin Kamat wrote:
>
> Meta-note: You sent patches 1/1 and 2/2. I'm guessing you ment to send
> 1/2 and 2/2, right? Please fix your scripts you use to send patches,
> otherwise you are going to confuse anyone you ever se
All of the config options for comedi depend on COMEDI being
selected. Wrap everything in an 'if COMEDI/endif' block and
remove all the individual 'depends on COMEDI' in the Kconfig.
Also, remove the redundant && ISA/PCI/PCMCIA/USB for the if
blocks with those driver types.
Signed-off-by: H Hartle
This symbol is not defined in the kernel. It appears to be left
over from the 2.4 kernel.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Frank Mori Hess
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/addi_amcc_s5933.h |4
.../comedi/drivers/addi-data/amcc_s5933_58.h
On Tue, Jun 12, 2012 at 11:57:27AM -0700, H Hartley Sweeten wrote:
> From 606739d47df00ac9767e3256ab8f6eb1572bd429 Mon Sep 17 00:00:00 2001
> From: H Hartley Sweeten
> Date: Tue, 12 Jun 2012 09:45:17 -0700
> Subject: [PATCH 2/8] staging: comedi: change type of num_subdevices parameter
> to comedi
On Tue, Jun 12, 2012 at 04:47:33PM -0400, Steven Rostedt wrote:
> "staging: comedi"
>
> Now I'm expecting to have a stand up comic to appear ;-)
Really? Cool.
Who's on tonight?
--
Regards/Gruss,
Boris.
___
devel mailing list
devel@linuxdriverproj
"staging: comedi"
Now I'm expecting to have a stand up comic to appear ;-)
-- Steve
___
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
On Tuesday, June 12, 2012 12:50 PM, Dan Carpenter wrote:
> On Tue, Jun 12, 2012 at 11:59:55AM -0700, H Hartley Sweeten wrote:
>> for (i = 0; i < num_subdevices; ++i) {
>> -dev->subdevices[i].device = dev;
>> -dev->subdevices[i].async_dma_dir = DMA_NONE;
>> -
On Tue, Jun 12, 2012 at 11:59:55AM -0700, H Hartley Sweeten wrote:
> for (i = 0; i < num_subdevices; ++i) {
> - dev->subdevices[i].device = dev;
> - dev->subdevices[i].async_dma_dir = DMA_NONE;
> - spin_lock_init(&dev->subdevices[i].spin_lock);
> -
On Wed, Jun 06, 2012 at 11:01:26PM -0700, Ben Chan wrote:
> This patch fixes a spinlock recursion bug on several call sites of
> gdm_usb_send_complete by not calling spin_lock_irqsave on
> urb->context->tx_cxt->lock when the lock has already been acquired.
>
> Signed-off-by: Ben Chan
> Cc: Sage A
On Tuesday, June 12, 2012 11:46 AM, Greg KH wrote:
> On Tue, Jun 12, 2012 at 01:31:38PM -0500, H Hartley Sweeten wrote:
>> I did as you described above and have the 7 patches ready but I just
>> noticed you have already applied the first one.
>>
>> Should I post the entire series and note that the
>From 65db79e570481b04bfc13663fd40de18560f0aa4 Mon Sep 17 00:00:00 2001
From: H Hartley Sweeten
Date: Tue, 12 Jun 2012 11:37:09 -0700
Subject: [PATCH 8/8] staging: comedi: cleanup comedi_alloc_subdevices
Access the individual comedi_subdevices using a pointer instead
of directly accessing as an a
>From 8d64162758d994937590c97f8f1e926af3e349f1 Mon Sep 17 00:00:00 2001
From: H Hartley Sweeten
Date: Tue, 12 Jun 2012 10:46:36 -0700
Subject: [PATCH 6/8] staging: comedi: remove the "Allocate the subdevice..."
comments
These comments are redundant. The function name 'comedi_alloc_subdevices'
pr
>From 62e9ab7262b4a5dc522dcb861d813cde4a718214 Mon Sep 17 00:00:00 2001
From: H Hartley Sweeten
Date: Tue, 12 Jun 2012 10:33:08 -0700
Subject: [PATCH 5/8] staging: comedi: remove the comed_alloc_subdevices
"allocation failed" messages
Remove all the "allocation failed" debug messages that are di
>From 4a741286f60e27ac7dd59eeb36ef49c5937d7fa2 Mon Sep 17 00:00:00 2001
From: H Hartley Sweeten
Date: Tue, 12 Jun 2012 10:07:03 -0700
Subject: [PATCH 4/8] staging: comedi: only set dev->n_subdevices when kcalloc
succeedes
It's possible for the kcalloc in comedi_alloc_subdevices to fail.
Only set
>From 952298d9ff21bc8fba3ece36a634a7abad89d912 Mon Sep 17 00:00:00 2001
From: H Hartley Sweeten
Date: Tue, 12 Jun 2012 09:53:02 -0700
Subject: [PATCH 3/8] staging: comedi: sanity check num_subdevices parameter
in comedi_alloc_subdevices
It's possible for a couple of the comedi drivers to incorre
>From 606739d47df00ac9767e3256ab8f6eb1572bd429 Mon Sep 17 00:00:00 2001
From: H Hartley Sweeten
Date: Tue, 12 Jun 2012 09:45:17 -0700
Subject: [PATCH 2/8] staging: comedi: change type of num_subdevices parameter
to comedi_alloc_subdevices
The n_subdevices variable of struct comedi_device is an i
Cleanup the comedi core "alloc_subdevices" function and it's use
in the comedi drivers.
staging: comedi: add namespace to comedi's alloc_subdevices() function
staging: comedi: change type of num_subdevices parameter to
comedi_alloc_subdevices
staging: comedi: sanity check num_subdevices parameter
On Tue, Jun 12, 2012 at 01:31:38PM -0500, H Hartley Sweeten wrote:
> On Monday, June 11, 2012 6:43 PM, Greg KH wrote:
> > On Mon, Jun 11, 2012 at 07:49:46PM -0500, H Hartley Sweeten wrote:
> >> Also, I have never done local commits to my Linux-next tree so I'm not
> >> sure how to proceed with the
On Monday, June 11, 2012 6:43 PM, Greg KH wrote:
> On Mon, Jun 11, 2012 at 07:49:46PM -0500, H Hartley Sweeten wrote:
>> Also, I have never done local commits to my Linux-next tree so I'm not
>> sure how to proceed with the incremental patches. If it's ok with you
>> I'll just wait for each patch t
This patch simplifies the previous patch (commit
dd13c86b0dae86efdde98119ffd7348e80719ade) for fixing the spinlock
recursion issue on several call sites of gdm_usb_send_complete.
Signed-off-by: Ben Chan
Cc: Sage Ahn
---
drivers/staging/gdm72xx/gdm_usb.c | 26 ++
1 file
On Tue, Jun 05, 2012 at 04:40:10PM +0530, Sachin Kamat wrote:
Meta-note: You sent patches 1/1 and 2/2. I'm guessing you ment to send
1/2 and 2/2, right? Please fix your scripts you use to send patches,
otherwise you are going to confuse anyone you ever send patches to, as I
would be searching f
On Tue, Jun 12, 2012 at 09:16:22AM -0400, Bart Westgeest wrote:
>
>
> On 06/12/2012 02:43 AM, Dan Carpenter wrote:
>
> >Obviously, we need to update the cast, but shouldn't we care about
> >endianness here as well?
> >
>
> Sorry Dan (and others) for wasting your time on this. I had already
> re
On Tue, Jun 12, 2012 at 10:40:52AM -0700, Ben Chan wrote:
> This patch fixes a spinlock recursion bug on several call sites of
> gdm_usb_send_complete by not calling spin_lock_irqsave on
> urb->context->tx_cxt->lock when the lock has already been acquired.
>
> Signed-off-by: Ben Chan
> Cc: Sage A
On Sun, Jun 10, 2012 at 01:25:51PM +0200, Javier Muñoz wrote:
> On 06/10/2012 01:12 PM, Javier M. Mellid wrote:
> > From: "Javier M. Mellid"
> >
> > Rename sm7xx driver to sm7xxfb. Fix Kconfig and Makefile to fit the new
> > change.
> >
> > Changes are coherent with the rest of stable framebuffe
This patch fixes a spinlock recursion bug on several call sites of
gdm_usb_send_complete by not calling spin_lock_irqsave on
urb->context->tx_cxt->lock when the lock has already been acquired.
Signed-off-by: Ben Chan
Cc: Sage Ahn
---
This revised patch simplifies the previous patch.
drivers/st
On Tue, Jun 05, 2012 at 09:52:08AM +0530, Sachin Kamat wrote:
> version.h header file inclusion is no longer needed.
>
> Signed-off-by: Sachin Kamat
Sorry, someone else already beat you to this change.
greg k-h
___
devel mailing list
devel@linuxdriver
On Thu, May 31, 2012 at 10:39:59PM +0200, Marcus Karlsson wrote:
> Fixed some code styling errors in the following files:
>
> drivers/staging/rts_pstor/rtsx_scsi.c:
> * multiple statements on single line
>
> drivers/staging/rts_pstor/trace.h:
> * trailing whitespace
> * non-enclosed macro
>
> dr
On 06/11/2012 02:11 AM, Andrzej Pietrasiewicz wrote:
> Signed-off-by: Andrzej Pietrasiewicz
> Signed-off-by: Kyungmin Park
Acked-by: Randy Dunlap
Thanks.
> ---
> drivers/staging/ccg/Kconfig |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/ccg/
On 06/11/2012 02:13 AM, Andrzej Pietrasiewicz wrote:
> If f_fs.c and u_serial.c are combined together using #include, which has
> been a common practice so far, the pr_vdebug macro is defined multiple
> times. Define it only once.
>
> Signed-off-by: Andrzej Pietrasiewicz
> Signed-off-by: Kyungmi
On 06/12/2012 02:43 AM, Dan Carpenter wrote:
Obviously, we need to update the cast, but shouldn't we care about
endianness here as well?
Sorry Dan (and others) for wasting your time on this. I had already
resubmitted a corrected version of this patch - however I wasn't sure
what the prope
On Tue, Jun 12, 2012 at 12:39:17PM +0200, Marc Dietrich wrote:
> This patch cleanups the nvec and its childs by replacing calls to
> resource allocations by their devm_* equivalents.
>
> Signed-off-by: Marc Dietrich
> ---
>
> Ok, this is directly against 3.5-rc2. All other patches in this series
This patch cleanups the nvec and its childs by replacing calls to
resource allocations by their devm_* equivalents.
Signed-off-by: Marc Dietrich
---
Ok, this is directly against 3.5-rc2. All other patches in this series apply
cleanly and can be reused.
To speed things up, I'm going to rebase A
This patch cleanups the nvec and its childs by replacing calls to
resource allocations by their devm_* equivalents.
Signed-off-by: Marc Dietrich
---
Ok, this is directly against 3.5-rc2. All other patches in this series apply
cleanly and can be reused.
To speed things up, I'm going to rebase A
As we have already got rid of sysfs files in the tpci200 driver, it is needed
to delete that mention in the TODO file.
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/TODO |4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/ipack/TODO b/drivers/staging/ip
36 matches
Mail list logo