On Thu, Jun 14, 2012 at 03:09:38PM -0700, Greg KH wrote:
> On Thu, Jun 14, 2012 at 11:57:38PM +0200, Marc Dietrich wrote:
> > Add a helper macro to wrap nvec_{a}sync_writes and to get rid of
> > the various strings distributed all over the nvec code.
>
> Why can't these be inline functions instead
On Thu, Jun 14, 2012 at 12:21:52AM +0200, Peter Huewe wrote:
> @@ -1565,15 +1548,15 @@ unsigned char XGIInitNew(struct pci_dev *pdev)
> /* Not DDR */
> xgifb_reg_set(pVBInfo->P3c4,
> 0x31,
> - (*pVBInfo->pSR31 & 0x3F)
On Thu, Jun 14, 2012 at 11:57:38PM +0200, Marc Dietrich wrote:
> Add a helper macro to wrap nvec_{a}sync_writes and to get rid of
> the various strings distributed all over the nvec code.
Why can't these be inline functions instead? That will catch errors
easier, and make it a bit more "obvious"
This patch simplifies code by using the module_platform_driver
and SIMPLE_DEV_PM_OPS macros.
Signed-off-by: Marc Dietrich
---
drivers/staging/nvec/nvec.c | 27 +++
drivers/staging/nvec/nvec_kbd.c |7 +--
drivers/staging/nvec/nvec_leds.c | 14 +
This patch cleanups registered devices on remove.
Signed-off-by: Marc Dietrich
---
drivers/staging/nvec/nvec_kbd.c |9 +
drivers/staging/nvec/nvec_power.c | 16
drivers/staging/nvec/nvec_ps2.c |8
3 files changed, 33 insertions(+)
diff --git a/dri
Replace a printk in nvec core driver with dev_warn.
Signed-off-by: Marc Dietrich
---
drivers/staging/nvec/nvec.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 4245206..8f57b62 100644
--- a/drivers/staging
This patch cleanups the nvec and its childs by replacing calls to
resource allocations by their devm_* equivalents.
Signed-off-by: Marc Dietrich
---
drivers/staging/nvec/nvec.c | 44 +
drivers/staging/nvec/nvec_leds.c | 10 +++--
drivers/staging
This series cleanups the nvec code a bit. The LED driver is renamed to
paz00 because it only makes sense on this device.
Some plan for the future:
- add device tree init for the mfd childs and remove the hard coded
(device dependent) init from the core driver
- add a gpio
Add a helper macro to wrap nvec_{a}sync_writes and to get rid of
the various strings distributed all over the nvec code.
Signed-off-by: Marc Dietrich
---
drivers/staging/nvec/nvec.h | 38 ++
1 file changed, 38 insertions(+)
diff --git a/drivers/staging/nvec
Use the newly introduced NVEC_CALL to cleanup the various nvec
command strings in the nvec driver.
Signed-off-by: Marc Dietrich
---
drivers/staging/nvec/nvec.c | 39 +++--
drivers/staging/nvec/nvec.h | 49 -
drivers/stag
The led driver used OEM commands which are not part of the nvec protocol
definition. Therefore it is renamed to nvec_paz00 to reflect that it only
applies to PAZ00 board based devices.
Signed-off-by: Marc Dietrich
---
drivers/staging/nvec/Kconfig |9
drivers/st
On Wednesday 13 June 2012 12:19:47 Greg KH wrote:
> On Wed, Jun 13, 2012 at 11:16:29AM +0200, Marc Dietrich wrote:
> > This patch cleanups the nvec and its childs by replacing calls to
> > resource allocations by their devm_* equivalents.
> >
> > Signed-off-by: Marc Dietrich
> > ---
> >
> > fixe
This patch modifies the gdm72xx driver to properly release a netlink
socket using netlink_kernel_release. It fixes the following kernel
crash, which occurs after repeatedly suspending and resuming a system.
kernel BUG at
/home/benchan/trunk/src/third_party/kernel/files/mm/slub.c:3471!
inval
On Wed, Jun 13, 2012 at 04:03:42PM -0500, Seth Jennings wrote:
> This patch fixes an uninitialized variable warning in
> alloc_zspage(). It also fixes the secondary issue of
> prev_page leaving scope on each loop iteration. The only
> reason this ever worked was because prev_page was occupying
>
On 06/13/2012 08:35 PM, Minchan Kim wrote:
> Nice catch!
by Andrew!
> Nitpick:
> I can't see the warning.
> My gcc version is gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3.
I couldn't either but Andrew could and he verified the fix.
Not sure what gcc version he is running.
> Please, Cced linux-m
There are a lot of problems with this patch... :/
The subject is messed up. Hint put a blank line between the subject
and the body of the changelog. Send it to yourself first and try
applying it with git am. Only make one kind of change per patch.
There is no signed off by line. That's not ho
From: andy zaugg
---
drivers/staging/comedi/drivers/ni_labpc.c | 37 +++--
1 file changed, 19 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_labpc.c
b/drivers/staging/comedi/drivers/ni_labpc.c
index 5334977..807a774 100644
--- a/drivers/
On Thu, Jun 14, 2012 at 01:07:47PM +0200, Peter Huewe wrote:
> Hi Dan,
> Thanks for the feedback.
> I agree somewhat with you that the patch is quite big and complex, that's why
> I added the seperators in the commit message, but when I created the patch it
> seemed logical enough (to me :) to k
This is a complicated patch to review. It feels like each of the
=== sections could be submitted as a separate patch.
regards,
dan carpenter
___
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/dev
On 2012/06/13 11:42 PM, H Hartley Sweeten wrote:
> Refactor the subdev_8255_insn function to follow what the user
> space library is doing.
>
> 1) This function requires 'data' to contain 2 parameters. Add a
> sanity check for this (insn->n != 2).
Actually, the comedi core will have already check
20 matches
Mail list logo
