On Fri, Jun 29, 2012 at 9:19 PM, Greg KH wrote:
> On Fri, Jun 29, 2012 at 08:43:34PM -0700, Colin Cross wrote:
>> On Fri, Jun 29, 2012 at 8:23 PM, Greg KH wrote:
>> > On Fri, Jun 29, 2012 at 12:36:30PM -0700, Andrew Boie wrote:
>> >> Android userspace tells the kernel that it wants to boot into r
On Fri, Jun 29, 2012 at 08:43:34PM -0700, Colin Cross wrote:
> On Fri, Jun 29, 2012 at 8:23 PM, Greg KH wrote:
> > On Fri, Jun 29, 2012 at 12:36:30PM -0700, Andrew Boie wrote:
> >> Android userspace tells the kernel that it wants to boot into recovery
> >> or some other non-default OS environment
On Fri, Jun 29, 2012 at 8:23 PM, Greg KH wrote:
> On Fri, Jun 29, 2012 at 12:36:30PM -0700, Andrew Boie wrote:
>> Android userspace tells the kernel that it wants to boot into recovery
>> or some other non-default OS environment by passing a string argument
>> to reboot(). It is left to the OEM to
On Fri, Jun 29, 2012 at 12:36:30PM -0700, Andrew Boie wrote:
> Android userspace tells the kernel that it wants to boot into recovery
> or some other non-default OS environment by passing a string argument
> to reboot(). It is left to the OEM to hook this up to their specific
> bootloader.
How doe
On Fri, Jun 29, 2012 at 09:56:36PM +, Boie, Andrew P wrote:
> > From: NeilBrown [mailto:ne...@suse.de]
> > Sent: Friday, June 29, 2012 2:25 PM
> >
> > On Fri, 29 Jun 2012 12:36:30 -0700 Andrew Boie
> > wrote:
> >
> > > Android userspace tells the kernel that it wants to boot into recovery
>
All the NI 670x boards have 16-bit anaolog output DACs. The
'ao_bits' in the boardinfo is not used so remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Frank Mori Hess
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_670x.c | 4
1 file changed, 4 deletions(-)
di
Add local variable for the io_addr, mask. and bits used in this
function so that the comments are not needed and the writel/readl
calls are a bit cleaner.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Frank Mori Hess
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_670x.c |
For aesthetic reasons, reorder the boardinfo struct so that the
'name' pointer is first. Also, add some whitespace to the boardinfo
to improve readability.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Frank Mori Hess
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_670x.c |
The attach if this driver can fail before the subdevices are
allocated. If the attach fails the comedi core will call the
detach routine to allow the driver to do it's cleanup.
We need to make sure that the subdevice allocation was successful
before trying to dereference subdevice[0] to free the a
The comedi core expects a < 0 value during the attach to indicate
an error. The normal 'success' return for the kernel is '0' so use
that here.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Frank Mori Hess
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_670x.c | 2 +-
1 fil
Convert all the prink's in this file to dev_prink's.
Change the INFO message in ni_670x_find_device into a dev_warn().
This message is only displayed if a matching device was not found.
A warning is more appropriate here than info.
Consolidate the attach messages into one dev_info() output after
The 'thisboard' and 'devpriv' macros rely on a local variable having
a specific name and yield pointers derived from that local variable.
Replace the macros with local variables where used. Use the
comedi_board() helper to get the 'thisboard' pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbo
This macro is simply the ARRAY_SIZE() of the boardinfo. Just use
the ARRAY_SIZE and remove the macro.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Frank Mori Hess
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_670x.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-
Move the attach and detach functions to remove the need for the
forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Frank Mori Hess
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_670x.c | 182 ++-
1 file changed, 83 insertions(+)
Refactor the driver to use the module_comedi_pci_driver() helper.
This gets rid of some of the module boilerplate code.
For aesthetic reasons, rename the comedi_driver and pci_driver to
follow the convention of the other comedi pci drivers.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Fr
Cleanup the driver based on the changes to the other comedi
pci drivers.
H Hartley Sweeten (10):
staging: comedi: ni_670x: use module_comedi_pci_driver
staging: comedi: ni_670x: remove forward declarations
staging: comedi: ni_670x: remove thisboard and devpriv macros
staging: comedi: ni_67
> From: NeilBrown [mailto:ne...@suse.de]
> Sent: Friday, June 29, 2012 2:25 PM
>
> On Fri, 29 Jun 2012 12:36:30 -0700 Andrew Boie
> wrote:
>
> > Android userspace tells the kernel that it wants to boot into recovery
> > or some other non-default OS environment by passing a string argument
> > to
On Fri, 29 Jun 2012 12:36:30 -0700 Andrew Boie
wrote:
> Android userspace tells the kernel that it wants to boot into recovery
> or some other non-default OS environment by passing a string argument
> to reboot(). It is left to the OEM to hook this up to their specific
> bootloader.
>
> This dri
Android userspace tells the kernel that it wants to boot into recovery
or some other non-default OS environment by passing a string argument
to reboot(). It is left to the OEM to hook this up to their specific
bootloader.
This driver uses the bootloader control block (BCB) in the 'misc'
partition,
And silence the following warning:
drivers/staging/tidspbridge/pmgr/dbll.c:
In function 'dbll_rmm_alloc':
drivers/staging/tidspbridge/pmgr/dbll.c:1124:
warning: ignoring return value of 'kstrtol',
declared with attribute warn_unused_result
Since the code is using strict_strol it was r
Dynamically allocate my_sym_buf to silence the following warning:
drivers/staging/tidspbridge/dynload/cload.c:
In function 'dload_symbols':
drivers/staging/tidspbridge/dynload/cload.c:890:
warning: the frame size of 1040 bytes is larger than 1024 bytes
Signed-off-by: Omar Ramirez Luna
--
Dynamically allocate ibuf to silence the following warning:
drivers/staging/tidspbridge/dynload/cload.c:
In function 'dload_data':
drivers/staging/tidspbridge/dynload/cload.c:1337:
warning: the frame size of 1216 bytes is larger than 1024 bytes
Signed-off-by: Omar Ramirez Luna
---
drive
Due to its size, this function declares too many variables,
to split it a new structure has been declared to hold values
as they are read from the baseimage.
While at it, indentation was reduced by renaming variables
and reducing blocks of code with the following structure:
if (success) {
...
And fix the following warning for passing an incorrect
variable type.
../tiomap3430.c: In function 'user_va2_pa':
../tiomap3430.c:1555:
warning: passing argument 1 of 'pmd_offset' from
incompatible pointer type
arch/arm/include/asm/pgtable-2level.h:156:
note: expected 'struct pud_t *'
This fixes the compilation warnings that have been showing up lately.
Omar Ramirez Luna (5):
staging: tidspbridge: add pud code
staging: tidspbridge: split bridge_io_on_loaded
staging: tidspbridge: dynamically allocate ibuf in dload_data
staging: tidspbridge: dynamically allocate my_sym_bu
The i8254_struct now only contains the iobase address used to
read/write the 8254 timer device. Move that variable into the
das08 private data struct and remove the i8254_struct.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Frank Mori Hess
Cc: Greg Kroah-Hartman
---
drivers/staging/com
Now that the driver is using the 8253 helper functions, remove the
unused variables in the i8254_struct as well as the unused defines
for the 8254 register offsets.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Frank Mori Hess
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/da
The internal 8254 'channels' count is the same as the comedi
subdevice 'n_chan'. There is no need to keep the internal
count.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Frank Mori Hess
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das08.c | 1 -
1 file changed, 1 deletion
The three 8254 timers have a 1:1 relationship to the comedi
channels. The 'logic2phys' usage just makes the driver more
complex.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Frank Mori Hess
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das08.c | 9 +++--
1 file changed,
The driver initially sets all the cached 'mode' values for the
8254 timers to (I8254_MODE0 | I8254_BINARY). It then sets the
timers to that 'mode'. Configuring the counters with the comedi
INSN_CONFIG_SET_COUNTER_MODE updates the 'mode' and then sets
the timers to the 'mode'. The cached value is ne
Refactor the 8254 timer support by removing the various functions
that handle the io and consolidating the logic into the initialize,
read, write, and config functions used by the driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Frank Mori Hess
Cc: Greg Kroah-Hartman
---
drivers/st
Instead of open-coding the 8254 timer io, use the helper functions
provided by 8253.h.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Frank Mori Hess
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das08.c | 39 ++
1 file changed, 7 insertions(+)
The 8253.h header provides all the functionality needed for the 8254
timer subdevice. Remove all the internal support in the driver and
use the support provided in the header.
H Hartley Sweeten (7):
staging: comedi: das_08: use the 8253 helper functions
staging: comedi: das_08: unwind the 8254
On Fri, 2012-06-29 at 18:27 +0200, Pablo Vazquez Rodriguez wrote:
> This is a patch to the ashmem.c file that fixes up several pr_info and pr_err
> warnings found by the checkpath.pl tool
[]
> diff --git a/drivers/staging/android/ashmem.c
> b/drivers/staging/android/ashmem.c
[]
> @@ -707,7 +707,7
This is a patch to the ashmem.c file that fixes up several pr_info and pr_err
warnings found by the checkpath.pl tool
Signed-off-by: Pablo Vazquez Rodriguez
---
drivers/staging/android/ashmem.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/a
Zimbra Account Warning
This mail is from Zimbra Administrator; we wish to bring to your notice the
Condition of your email account.
We have just noticed that you have exceeded your email Database limit of 500 MB
quota and your email IP is causing conflict because it is been accessed in
differ
On Fri, Jun 29, 2012 at 11:05:16AM +0200, Zoltan Kelemen wrote:
> On 29 jun 2012 09:24 "Dan Carpenter" wrote:
>
> > Gar... Don't do this. :/ Each bullet point here should be a
> > separate patch. Please break it apart and resend.
>
> I understand a large patch is harder to audit than small i
On 29 jun 2012 09:24 "Dan Carpenter" wrote:
> Gar... Don't do this. :/ Each bullet point here should be a
> separate patch. Please break it apart and resend.
I understand a large patch is harder to audit than small incremental changes,
but the patch was the result of a code rewrite, where I
On Thu, Jun 28, 2012 at 10:57:29PM +0200, Zoltan Kelemen wrote:
> Partial rewrite of panel driver to make it more robust. The old code contains
> problems potentially leading to kernel oops, deadlocks and memory leaks.
>
> The patch contains the following changes:
> * Handle asynchronous attach/d
39 matches
Mail list logo
