Re: [PATCH 1/4] staging: OMAP4+: thermal: introduce bandgap temperature sensor

Hello Greg, On Sat, Jul 7, 2012 at 2:27 AM, Greg Kroah-Hartman wrote: > On Wed, Jul 04, 2012 at 01:37:07AM +0300, Eduardo Valentin wrote: >> In the System Control Module, OMAP supplies a voltage reference >> and a temperature sensor feature that are gathered in the band >> gap voltage and tempera

[PATCH 2/2] staging/rts_pstor: fix single statements block warning

The following warning is fixed up. drivers/staging/rts_pstor/sd.c:190: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Devendra Naga --- drivers/staging/rts_pstor/sd.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rts_

[PATCH 1/2] staging/rts_pstor: fix the no brace needed warning

for if else statements having single block no braces are needed fixed the following checkpatch warning drivers/staging/rts_pstor/sd.c:140: WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Devendra Naga --- drivers/staging/rts_pstor/sd.c |5 ++--- 1 file cha

[PATCH] Staging: android: fix pr_info and pr_err coding style issues in ashmem.c

This is a patch to the ashmem.c file that fixes up several pr_info and pr_err warnings found by the checkpath.pl tool Signed-off-by: Pablo Vazquez Rodriguez --- drivers/staging/android/ashmem.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/

Re: [PATCH] staging: vt6656: iwctl: mop up a few remaining obvious style issues

On Fri, 6 Jul 2012, Greg Kroah-Hartman wrote: > On Wed, Jun 27, 2012 at 09:19:15PM +0200, Jesper Juhl wrote: > > My previous 14 patch series to vt6656 missed a few bits and > > pieces. This mops up the last few obvious style issues. > > It is quite short and completely trivial - simply deletes a f

Re: [PATCH net,1/1] hyperv: Add support for setting MAC from within guests

On Fri, 2012-07-06 at 14:25 -0700, Haiyang Zhang wrote: > This adds support for setting synthetic NIC MAC address from within Linux > guests. Before using this feature, the option "spoofing of MAC address" > should be enabled at the Hyper-V manager / Settings of the synthetic > NIC. [...] > +int rn

Re: [PATCH 1/4] staging: OMAP4+: thermal: introduce bandgap temperature sensor

On Wed, Jul 04, 2012 at 01:37:07AM +0300, Eduardo Valentin wrote: > In the System Control Module, OMAP supplies a voltage reference > and a temperature sensor feature that are gathered in the band > gap voltage and temperature sensor (VBGAPTS) module. The band > gap provides current and voltage ref

Re: [PATCH 0/5] staging: tidspbridge: fix various compilation warnings

On Fri, Jun 29, 2012 at 01:49:16PM -0500, Omar Ramirez Luna wrote: > This fixes the compilation warnings that have been showing up lately. > > Omar Ramirez Luna (5): > staging: tidspbridge: add pud code > staging: tidspbridge: split bridge_io_on_loaded > staging: tidspbridge: dynamically all

Re: [PATCH] Staging: android: fix pr_info and pr_err coding style issues in ashmem.c

On Fri, Jun 29, 2012 at 07:48:45PM +0200, Pablo Vázquez wrote: > Ok, added the #define pr_fmt(fmt) ... You sent this in HTML format, makeing it impossible to apply :( Care to try it again? thanks, greg k-h ___ devel mailing list devel@linuxdriverproje

Re: [PATCH] staging: vt6656: iwctl: mop up a few remaining obvious style issues

On Wed, Jun 27, 2012 at 09:19:15PM +0200, Jesper Juhl wrote: > My previous 14 patch series to vt6656 missed a few bits and > pieces. This mops up the last few obvious style issues. > It is quite short and completely trivial - simply deletes a few blank > lines, does some whitespace cleanup around o

Re: [PATCH 2/2] staging: sm7xxfb: erase hardcode cast between smtcfb_info and fb_info

On Wed, Jun 27, 2012 at 02:10:15PM +0200, Javier M. Mellid wrote: > From: "Javier M. Mellid" > > This patch erases hardcode cast between smtcfb_info and fb_info in order > to get a more robust and less rigid smtcfb_info structure. fb_info > doesn't need to be the first field in smtcfb_info after

[PATCH net, 1/1] hyperv: Add support for setting MAC from within guests

This adds support for setting synthetic NIC MAC address from within Linux guests. Before using this feature, the option "spoofing of MAC address" should be enabled at the Hyper-V manager / Settings of the synthetic NIC. Thanks to Kin Cho for the initial implementation and tests. And, thanks to Lo

Re: [PATCH 6/6] staging: ccg: print MAC addresses via %pM

On Fri, Jul 6, 2012 at 6:54 PM, Daniel Hazelton wrote: >>> --- a/drivers/staging/ccg/ccg.c >>> +++ b/drivers/staging/ccg/ccg.c >>> @@ -564,9 +564,7 @@ static int rndis_function_bind_config(struct >>> ccg_usb_function *f, >>>                 return -1; >>>         } >>> >>> -       pr_info("%s MAC

Re: [PATCH 6/6] staging: ccg: print MAC addresses via %pM

On 07/06/2012 11:32 AM, Kyungmin Park wrote: > Acked-by: Kyungmin Park > > On Sat, Jul 7, 2012 at 12:28 AM, Andy Shevchenko > wrote: >> Signed-off-by: Andy Shevchenko >> Cc: Kyungmin Park >> --- >> drivers/staging/ccg/ccg.c |8 ++-- >> 1 file changed, 2 insertions(+), 6 deletions(-) >>

[Patch v2] staging: ccg: print MAC addresses via %pM

Signed-off-by: Andy Shevchenko Acked-by: Kyungmin Park Cc: Andrzej Pietrasiewicz --- drivers/staging/ccg/ccg.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/ccg/ccg.c b/drivers/staging/ccg/ccg.c index a5b36a9..c77c465 100644 --- a/drivers/staging

Re: [PATCH 6/6] staging: ccg: print MAC addresses via %pM

Acked-by: Kyungmin Park On Sat, Jul 7, 2012 at 12:28 AM, Andy Shevchenko wrote: > Signed-off-by: Andy Shevchenko > Cc: Kyungmin Park > --- > drivers/staging/ccg/ccg.c |8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/ccg/ccg.c b/drivers/stagin

[PATCH 6/6] staging: ccg: print MAC addresses via %pM

Signed-off-by: Andy Shevchenko Cc: Kyungmin Park --- drivers/staging/ccg/ccg.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/ccg/ccg.c b/drivers/staging/ccg/ccg.c index a5b36a9..62f5d92 100644 --- a/drivers/staging/ccg/ccg.c +++ b/drivers/staging/

[PATCH 4/6] staging: vt6655: use %pM for BSSID

Signed-off-by: Andy Shevchenko Cc: Forest Bond Cc: Masanari Iida --- drivers/staging/vt6655/bssdb.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vt6655/bssdb.c b/drivers/staging/vt6655/bssdb.c index 1368e8c..f4f108f 100644 --- a/drivers/staging/vt6

[PATCH 1/6] staging: bcm: use %pM to print MAC addresses

Signed-off-by: Andy Shevchenko Cc: Kevin McKinney --- drivers/staging/bcm/CmHost.c | 44 +++--- 1 file changed, 16 insertions(+), 28 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 189d243..9c8c9b1 100644 --- a/dr

[PATCH 3/6] staging: gdm72xx: use %pM for MAC

Signed-off-by: Andy Shevchenko Cc: Ben Chan --- drivers/staging/gdm72xx/gdm_wimax.c |9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging/gdm72xx/gdm_wimax.c index 110bdbc..e616de1 100644 --- a/drivers/staging/gdm72

[PATCH 5/6] staging: vt6656: use %pM for the BSSID

Signed-off-by: Andy Shevchenko Cc: Marcos Paulo de Souza --- drivers/staging/vt6656/bssdb.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vt6656/bssdb.c b/drivers/staging/vt6656/bssdb.c index 619c257..0999367 100644 --- a/drivers/staging/vt6656/b

[PATCH 2/6] staging: csr: print MAC addresses via %pM

Signed-off-by: Andy Shevchenko Cc: Lauri Hintsala --- drivers/staging/csr/sme_mgt.c | 10 ++ drivers/staging/csr/sme_sys.c | 29 drivers/staging/csr/sme_wext.c | 27 ++ drivers/staging/csr/un

Re: [PATCH 0/4] zsmalloc improvements

On 07/04/2012 03:43 PM, Konrad Rzeszutek Wilk wrote: > On Mon, Jul 02, 2012 at 04:15:48PM -0500, Seth Jennings wrote: >> This exposed an interesting and unexpected result: in all >> cases that I tried, copying the objects that span pages instead >> of using the page table to map them, was _always_

[PATCH] Drivers: Staging: ccg: Made checkpatch.pl clean

From: David Murray Fixed a tiny checkpatch.pl warning. Signed-off-by: David Murray --- drivers/staging/ccg/ccg.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccg/ccg.c b/drivers/staging/ccg/ccg.c index a5b36a9..c50fa02 100644 --- a/drivers/staging/ccg/

Re: [patch 1/2] Staging: vme: remove an unused array

On Fri, Jul 06, 2012 at 11:32:51AM +0100, Martyn Welch wrote: > On 06/07/12 09:15, Dan Carpenter wrote: > > We don't use the "bus" array or the "bus_num" variable which store the > > number of elements in the array. The only user was removed in > > 5d6abf379d ('staging: vme: make match() driver sp

[PATCH 18/19 v2] Staging: xgifb: Fix coding style.

Fix small coding style warnings in several files. Signed-off-by: Miguel Gómez --- drivers/staging/xgifb/XGI_main_26.c |3 +- drivers/staging/xgifb/vb_init.c |3 +- drivers/staging/xgifb/vb_setmode.c | 59 +-- drivers/staging/xgifb/vb_table.h|

[PATCH 16/19 v2] Staging: xgifb: Rework conditions in XGI_EnableBridge().

Rework some conditions to reduce indentation and fix style warnings. Signed-off-by: Miguel Gómez --- drivers/staging/xgifb/vb_setmode.c | 44 +++- 1 file changed, 18 insertions(+), 26 deletions(-) diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/stagi

[PATCH 17/19 v2] Staging: xgifb: Rework some conditions in XGI_SetCRT2ModeRegs().

Rework some conditions to reduce indentation and fix style warnings. Signed-off-by: Miguel Gómez --- drivers/staging/xgifb/vb_setmode.c | 83 1 file changed, 36 insertions(+), 47 deletions(-) diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/stagi

[PATCH 12/19 v2] Staging: xgifb: Refactor XGI_GetVBType().

Refactor XGI_GetVBType() to reduce indentation and fix style warnings. Signed-off-by: Miguel Gómez --- drivers/staging/xgifb/vb_setmode.c | 69 +++- 1 file changed, 36 insertions(+), 33 deletions(-) diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/sta

[PATCH 19/19 v2] Staging: xgifb: Remove useless condition.

Remove last if branch in XGIfb_do_set_var(), as it has no action assigned. Signed-off-by: Miguel Gómez --- drivers/staging/xgifb/XGI_main_26.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c index 0f49a21..64ffd70

[PATCH 13/19 v2] Staging: xgifb: Rework conditions in XGI_GetVBInfo().

Rework some conditions to reduce indentation and fix style warnings. Signed-off-by: Miguel Gómez --- drivers/staging/xgifb/vb_setmode.c | 287 ++-- 1 file changed, 142 insertions(+), 145 deletions(-) diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/sta

[PATCH 11/19 v2] Staging: xgifb: Refactor XGI_AjustCRT2Rate().

Refactor some conditions to reduce indentation and fix style warnings. Signed-off-by: Miguel Gómez --- drivers/staging/xgifb/vb_setmode.c | 73 1 file changed, 25 insertions(+), 48 deletions(-) diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/sta

[PATCH 15/19 v2] Staging: xgifb: Rework conditions in XGI_SetLockRegs().

Rework some conditions to reduce indentation and fix style warnings. Signed-off-by: Miguel Gómez --- drivers/staging/xgifb/vb_setmode.c | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb

[PATCH 05/19 v2] Staging: xgifb: Improve debug strings.

Signed-off-by: Miguel Gómez --- drivers/staging/xgifb/XGI_main_26.c | 34 +- drivers/staging/xgifb/vb_init.c |4 ++-- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26

[PATCH 09/19 v2] Staging: xgifb: Remove useless always true condition.

Signed-off-by: Miguel Gómez --- drivers/staging/xgifb/vb_init.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c index 64935fa..ae10153 100644 --- a/drivers/staging/xgifb/vb_init.c +++ b/drivers/staging/xgifb/vb_init.c @@

[PATCH 14/19 v2] Staging: xgifb: Refactor XGI_GetCRT2ResInfo().

Use a goto to remove one level of indentation, fixing style warnings. Signed-off-by: Miguel Gómez --- drivers/staging/xgifb/vb_setmode.c | 61 ++-- 1 file changed, 31 insertions(+), 30 deletions(-) diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/stag

[PATCH 10/19 v2] Staging: xgifb: Rework conditions in XGI_SetATTRegs().

Rework some conditions to reduce indentation and fix style warnings. Signed-off-by: Miguel Gómez --- drivers/staging/xgifb/vb_setmode.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmod

[PATCH 08/19 v2] Staging: xgifb: Remove unneeded var and condition in XGIfb_search_vesamode().

Signed-off-by: Miguel Gómez --- drivers/staging/xgifb/XGI_main_26.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c index c1aa037..e5657ff 100644 --- a/drivers/staging/xgifb/XGI_main_26.c +++

[PATCH 07/19 v2] Staging: xgifb: Simplify XGIfb_GetXG21DefaultLVDSModeIdx().

Simplify the code and make it more readable. Signed-off-by: Miguel Gómez --- drivers/staging/xgifb/XGI_main_26.c | 27 +-- 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c index 788

[PATCH 03/19 v2] Staging: xgifb: Remove LCDA detection in xgifb_probe().

The piece of code that checks for LCDA in xgifb_probe() just checks for some register values but doesn't really do anything in response to them (the actions that should be executed are commented). As nothing is really being done, the code can be safely removed. Signed-off-by: Miguel Gómez --- dr

[PATCH 02/19 v2] Staging: xgifb: Remove unneeded XGI_LCD_TYPE enumeration.

LCD_TYPEs are taken from drivers/video/sis/sis.h, so this enumeration is not needed. Signed-off-by: Miguel Gómez --- drivers/staging/xgifb/vgatypes.h | 34 -- 1 file changed, 34 deletions(-) diff --git a/drivers/staging/xgifb/vgatypes.h b/drivers/staging/xgifb/

[PATCH 06/19 v2] Staging: xgifb: Remove useless switch in XGIfb_detect_VB().

The switch performs no action so it can be removed. Signed-off-by: Miguel Gómez --- drivers/staging/xgifb/XGI_main_26.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c index d5c87ea..788d141 100644 --- a/

[PATCH 04/19 v2] Staging: xgifb: Remove unused struct _chswtable.

Struct _chswtable and the variable mychswtable are not used anywhere, so remove them. Signed-off-by: Miguel Gómez --- drivers/staging/xgifb/XGI_main.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main.h b/drivers/staging/xgifb/XGI_main.h index 1686c5

[PATCH 01/19 v2] Staging: xgifb: Comment cleaning.

Remove commented code and useless comments. Leave only those with relevant hints to the code. Signed-off-by: Miguel Gómez --- drivers/staging/xgifb/XGI_main.h|4 - drivers/staging/xgifb/XGI_main_26.c | 133 -- drivers/staging/xgifb/XGIfb.h |8 +- dr

[PATCH 00/19 v2] Several cleanings and style fixes

Hi! Second version of the patches round containing suggestions made to the first version: * patch 0001: ** keep some useful comments. ** format a couple of multiline comments ** don't remove empty lines in vb_util.h and vb_init.h * patch 0005: ** remove exclamation marks from a string * patch 0

Re: [patch 2/2] Staging: vme: silence a Sparse warning

On 06/07/12 09:21, Dan Carpenter wrote: > Sparse complains that "arg" is not a __user pointer. The "argp" and > "arg" variables are equivalent but argp is declared as a __user pointer. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/staging/vme/devices/vme_user.c > b/drivers/staging/

Re: [patch 1/2] Staging: vme: remove an unused array

On 06/07/12 09:15, Dan Carpenter wrote: > We don't use the "bus" array or the "bus_num" variable which store the > number of elements in the array. The only user was removed in > 5d6abf379d ('staging: vme: make match() driver specific to improve > non-VME64x support'). > Hmm, without a parameter

Re: [PATCH 15/19] Staging: xgifb: Rework conditions in XGI_SetLockRegs().

On Fri, Jul 06, 2012 at 11:04:15AM +0200, Miguel Gómez wrote: > >On Thu, Jul 05, 2012 at 04:45:58PM +0200, Miguel Gómez wrote: > >>Rework some conditions to reduce indentation and fix style warnings. > >> > >>Signed-off-by: Miguel Gómez > >>--- > >> drivers/staging/xgifb/vb_setmode.c | 29 +

Re: [PATCH 15/19] Staging: xgifb: Rework conditions in XGI_SetLockRegs().

On Thu, Jul 05, 2012 at 04:45:58PM +0200, Miguel Gómez wrote: Rework some conditions to reduce indentation and fix style warnings. Signed-off-by: Miguel Gómez --- drivers/staging/xgifb/vb_setmode.c | 29 - 1 file changed, 12 insertions(+), 17 deletions(-) diff

[patch 2/2] Staging: vme: silence a Sparse warning

Sparse complains that "arg" is not a __user pointer. The "argp" and "arg" variables are equivalent but argp is declared as a __user pointer. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index be198c0..4363ed5 100644 -

Re: [PATCH 17/19] Staging: xgifb: Rework some conditions in XGI_SetCRT2ModeRegs().

On Fri, Jul 06, 2012 at 10:16:36AM +0200, Miguel Gómez wrote: > >On Thu, Jul 05, 2012 at 04:46:00PM +0200, Miguel Gómez wrote: > >>Rework some conditions to reduce indentation and fix style warnings. > >> > > > >Instead of a do { } while(0); it would be better to just use gotos. > > Point taken. I

Re: [PATCH 17/19] Staging: xgifb: Rework some conditions in XGI_SetCRT2ModeRegs().

On Thu, Jul 05, 2012 at 04:46:00PM +0200, Miguel Gómez wrote: Rework some conditions to reduce indentation and fix style warnings. Instead of a do { } while(0); it would be better to just use gotos. Point taken. I used the do-while because I didn't want to abuse gotos, but if there's no pro

[patch 1/2] Staging: vme: remove an unused array

We don't use the "bus" array or the "bus_num" variable which store the number of elements in the array. The only user was removed in 5d6abf379d ('staging: vme: make match() driver specific to improve non-VME64x support'). Signed-off-by: Dan Carpenter diff --git a/drivers/staging/vme/devices/vme

Re: [PATCH 01/19] Staging: xgifb: Comment cleaning.

This is sent as: Content-Transfer-Encoding: base64 Which sucks... ... weird... not sure why send-email decided to use base64 instead of 8bit... when I finish with the proposed changes I'll send the whole round again removing that base64. Regards! :) -- Miguel Gómez Igalia - http://www.iga

Re: [PATCH 15/19] Staging: xgifb: Rework conditions in XGI_SetLockRegs().

Hi! On Thu, Jul 05, 2012 at 04:45:58PM +0200, Miguel Gómez wrote: + if ((pVBInfo->VBType & VB_SIS301LV) && + !(pVBInfo->TVInfo & TVSetHiVision)) { + if ((pVBInfo->TVInfo & TVSimuMode) && + (pVBInfo->TVInfo & TVSetPA

Re: [PATCH 05/19] Staging: xgifb: Improve debug strings.

Hi! On Thu, Jul 05, 2012 at 04:45:48PM +0200, Miguel Gómez wrote: if (!htotal || !vtotal) { - pr_debug("XGIfb: Invalid 'var' information\n"); + pr_debug("Invalid 'var' information\n"); [...] - pr_err("xgifb: invalid value for option: %s\n", fu

Re: [PATCH 01/19] Staging: xgifb: Comment cleaning.

Hi! diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c [] @@ -1,9 +1,3 @@ -/* - * XG20, XG21, XG40, XG42 frame buffer device - * for Linux kernels 2.5.x, 2.6.x - * Base on TW's sis fbdev code. - */ Maybe the comment removal is a bit aggressive. Perhaps t

Re: [PATCH 01/19] Staging: xgifb: Comment cleaning.

Hi! Some minor comments below: -/* - * XG20, XG21, XG40, XG42 frame buffer device - * for Linux kernels 2.5.x, 2.6.x - * Base on TW's sis fbdev code. A lot of code was copy-pasted from Thomas Winischhofer's sisfb driver, I'm not sure if it's OK to remove the credit...? You're right. I'll

Re: [PATCH 18/19] Staging: xgifb: Fix coding style.

On Thu, Jul 05, 2012 at 04:46:01PM +0200, Miguel Gómez wrote: > diff --git a/drivers/staging/xgifb/vb_table.h > b/drivers/staging/xgifb/vb_table.h > index ca8c68d..e8467ca 100644 > --- a/drivers/staging/xgifb/vb_table.h > +++ b/drivers/staging/xgifb/vb_table.h > @@ -1838,9 +1838,9 @@ static struct