On Thu, Jul 19, 2012 at 04:20:32PM -0700, Anton Vorontsov wrote:
> Hi Dan,
>
> On Thu, Jul 19, 2012 at 05:28:56PM +0300, Dan Carpenter wrote:
> > The patch a694d1b5916a: "pstore/ram: Add ftrace messages handling"
> > from Jul 9, 2012, leads to the following Smatch complaint:
>
> A nice tool. The
Hi Oliver:
I will fix it. Should I resend all three patches, or just this one?
BR,
Wei WANG
于 2012年07月19日 20:26, Oliver Neukum 写道:
> On Thursday 19 July 2012 17:55:18 wei_w...@realsil.com.cn wrote:
>
>> +static void sd_normal_rw(struct realtek_sdmmc *host, struct mmc_request
>> *mrq)
>> +{
>> +
> -Original Message-
> From: Greg KH (gre...@linuxfoundation.org)
> [mailto:gre...@linuxfoundation.org]
> Sent: Thursday, July 19, 2012 7:29 PM
> To: KY Srinivasan
> Cc: Paolo Bonzini; devel@linuxdriverproject.org; linux-ker...@vger.kernel.org;
> virtualizat...@lists.osdl.org
> Subject: R
> -Original Message-
> From: Anthony Liguori [mailto:anth...@codemonkey.ws]
> Sent: Thursday, July 19, 2012 7:18 PM
> To: KY Srinivasan
> Cc: Greg KH (gre...@linuxfoundation.org); Paolo Bonzini;
> devel@linuxdriverproject.org; linux-ker...@vger.kernel.org;
> virtualizat...@lists.osdl.org
On Thu, Jul 19, 2012 at 06:58:38PM -0500, H Hartley Sweeten wrote:
> On Thursday, July 19, 2012 4:35 PM, gregkh wrote:
> > On Thu, Jul 19, 2012 at 06:31:23PM -0500, H Hartley Sweeten wrote:
> >> If the comedi pci drivers have the "attach_pci" callback defined, the
> >> PCI api does correctly probe
On Thursday, July 19, 2012 4:53 PM, Greg KH wrote:
> On Wed, Jul 18, 2012 at 06:23:20PM -0700, H Hartley Sweeten wrote:
>> All the comedi pci drivers currently store a pointer to the pci_dev
>> in their private data. We can use the 'struct device *hw_dev' variable
>> in the comedi_device struct ins
On Thursday, July 19, 2012 4:35 PM, gregkh wrote:
> On Thu, Jul 19, 2012 at 06:31:23PM -0500, H Hartley Sweeten wrote:
>> If the comedi pci drivers have the "attach_pci" callback defined, the
>> PCI api does correctly probe the driver. The comedi_pci_auto_config()
>> then passes the pci_dev directl
On Wed, Jul 18, 2012 at 06:23:20PM -0700, H Hartley Sweeten wrote:
> All the comedi pci drivers currently store a pointer to the pci_dev
> in their private data. We can use the 'struct device *hw_dev' variable
> in the comedi_device struct instead and introduce a wrapper for
> to_pci_dev() to allow
We can dereference 'cxt->cprz' if console and dump logging are disabled
(which is unlikely, but still possible to do). This patch fixes the issue
by changing the code so that we don't dereference przs at all, we can
just calculate bufsize from console_size and record_size values.
Plus, while at it
On 07/19/2012 05:30 PM, KY Srinivasan wrote:
-Original Message-
From: Greg KH (gre...@linuxfoundation.org)
[mailto:gre...@linuxfoundation.org]
Sent: Thursday, July 19, 2012 6:02 PM
To: KY Srinivasan
Cc: Paolo Bonzini; devel@linuxdriverproject.org; linux-ker...@vger.kernel.org;
virtuali
On Thu, Jul 19, 2012 at 06:31:23PM -0500, H Hartley Sweeten wrote:
> On Thursday, July 19, 2012 4:17 PM, gregkh wrote:
> > On Thu, Jul 19, 2012 at 12:12:02PM -0500, H Hartley Sweeten wrote:
> >> I was planning on making a comedi_find_pci_dev() function that the
> >> drivers could call with a "match
On Thursday, July 19, 2012 4:17 PM, gregkh wrote:
> On Thu, Jul 19, 2012 at 12:12:02PM -0500, H Hartley Sweeten wrote:
>> I was planning on making a comedi_find_pci_dev() function that the
>> drivers could call with a "match" callback. This would allow a common
>> function for most of the boilerpla
On Thu, Jul 19, 2012 at 10:30:38PM +, KY Srinivasan wrote:
> > > As you know, this ID has been in use for a long time now. While the
> > > hypervisor
> > > does not interpret the guest ID that is registered, I am not sure what
> > dependencies
> > > there might be on this value.
> >
> > Could
Hi Dan,
On Thu, Jul 19, 2012 at 05:28:56PM +0300, Dan Carpenter wrote:
> The patch a694d1b5916a: "pstore/ram: Add ftrace messages handling"
> from Jul 9, 2012, leads to the following Smatch complaint:
A nice tool. The homepage of Smatch doesn't explicitly say that, so
I have to ask: is it a comp
On Thu, Jul 19, 2012 at 12:12:02PM -0500, H Hartley Sweeten wrote:
> On Thursday, July 19, 2012 2:38 AM, Ian Abbott wrote:
> > On 2012-07-19 02:30, H Hartley Sweeten wrote:
> >> Use pci_is_enabled() in the "find pci device" function to determine if
> >> the found pci device is not in use and move t
On Thu, Jul 19, 2012 at 08:08:50PM +0100, Martyn Welch wrote:
> The match function for vme_user is completely wrong. It will blindly bind
> against the first VME slot on each bus (at this point that would be just the
> first bus as the driver can only handle one bus).
>
> The original intention (b
> -Original Message-
> From: Greg KH (gre...@linuxfoundation.org)
> [mailto:gre...@linuxfoundation.org]
> Sent: Thursday, July 19, 2012 6:02 PM
> To: KY Srinivasan
> Cc: Paolo Bonzini; devel@linuxdriverproject.org; linux-ker...@vger.kernel.org;
> virtualizat...@lists.osdl.org
> Subject: R
On Thu, Jul 19, 2012 at 09:22:53PM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Greg KH (gre...@linuxfoundation.org)
> > [mailto:gre...@linuxfoundation.org]
> > Sent: Thursday, July 19, 2012 5:07 PM
> > To: KY Srinivasan
> > Cc: Paolo Bonzini; devel@linuxdriverproject.
On Thursday, July 19, 2012 12:31 PM, Robert Berger wrote:
> On 07/19/2012 09:41 PM, H Hartley Sweeten wrote:
>> Hello all,
>>
>> Does anyone know what the difference is between inb_p and inb?
>>
>> include/asm-generic/io.h has this:
>>
>> #define inb_p(addr) inb(addr)
>> #define inw_p(addr) in
> -Original Message-
> From: Greg KH (gre...@linuxfoundation.org)
> [mailto:gre...@linuxfoundation.org]
> Sent: Thursday, July 19, 2012 5:07 PM
> To: KY Srinivasan
> Cc: Paolo Bonzini; devel@linuxdriverproject.org; linux-ker...@vger.kernel.org;
> virtualizat...@lists.osdl.org
> Subject: R
On Thu, Jul 19, 2012 at 02:11:47AM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo
> > Bonzini
> > Sent: Friday, July 13, 2012 6:23 AM
> > To: KY Srinivasan
> > Cc: Greg KH; devel@linuxdriverproject.org; li
On 07/19/2012 09:41 PM, H Hartley Sweeten wrote:
> Hello all,
>
> Does anyone know what the difference is between inb_p and inb?
>
> include/asm-generic/io.h has this:
>
> #define inb_p(addr) inb(addr)
> #define inw_p(addr) inw(addr)
> #define inl_p(addr) inl(addr)
There might be a differ
The match function for vme_user is completely wrong. It will blindly bind
against the first VME slot on each bus (at this point that would be just the
first bus as the driver can only handle one bus).
The original intention (before some major subsystem changes) was that the
driver bind against the
Hello all,
Does anyone know what the difference is between inb_p and inb?
include/asm-generic/io.h has this:
#define inb_p(addr) inb(addr)
#define inw_p(addr) inw(addr)
#define inl_p(addr) inl(addr)
#define outb_p(x, addr) outb((x), (addr))
#define outw_p(x, addr) outw((x), (addr))
#
On Thursday, July 19, 2012 5:42 AM, Ian Abbott wrote:
> On 2012-07-19 03:05, H Hartley Sweeten wrote:
>> Use the hw_dev pointer in the comedi_device struct to hold the
>> pci_dev instead of carrying it in the private data.
>
> My reply to patch 86 has a knock-on effect for this patch...
>
>> /
Introduce a wrapper for to_pci_dev() to allow the comedi_pci_drivers
to store the pci_dev pointer in the comedi_device hw_dev variable and
retrieve it easily.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbot
Cc: Greg Kroah-Hartman
---
v2: Ian Abbott pointed out that the dev->hw_dev needs to be ch
On Thursday, July 19, 2012 9:32 AM, Dan Carpenter wrote:
> On Thu, Jul 19, 2012 at 11:20:52AM -0500, H Hartley Sweeten wrote:
>> On Thursday, July 19, 2012 2:23 AM, Ian Abbott wrote:
>>> That needs to be something like:
>>>
>>> return dev->hw_dev ? to_pci_dev(dev->hw_dev) : NULL;
>>
>> Hmm.. I
On Thursday, July 19, 2012 3:27 AM, Ian Abbott wrote:
> On 2012-07-19 11:10, Ian Abbott wrote:
>> On 2012-07-19 02:37, H Hartley Sweeten wrote:
>>> Use the hw_dev pointer in the comedi_device struct to hold the
>>> pci_dev instead of carrying it in the private data.
>>>
>>> Since the pci_dev is no
On Thursday, July 19, 2012 3:11 AM, Ian Abbott wrote:
> On 2012-07-19 02:37, H Hartley Sweeten wrote:
>> Use the hw_dev pointer in the comedi_device struct to hold the
>> pci_dev instead of carrying it in the private data.
>>
>> Since the pci_dev is no longer held in the provate data, we can
>> als
On Thursday, July 19, 2012 2:38 AM, Ian Abbott wrote:
> On 2012-07-19 02:30, H Hartley Sweeten wrote:
>> Use pci_is_enabled() in the "find pci device" function to determine if
>> the found pci device is not in use and move the comedi_pci_enable() call
>> into the attach.
>>
>> Signed-off-by: H Hart
The memcpy_fromio() and memcpy_toio() functions use the __memcpy() function,
at least on x86. This function carries out transfers smaller than 32 bits as
multiple 8 bit transfers, causing a single (aligned) 16 bit transfer to be
split into 2 8 bit transfers which may not be supported by the target
用工单 位如何应对派[遣合作争]议和劳动争 议.xls
Description: Binary data
___
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
On Thu, Jul 19, 2012 at 11:20:52AM -0500, H Hartley Sweeten wrote:
> On Thursday, July 19, 2012 2:23 AM, Ian Abbott wrote:
> > On 2012-07-19 02:24, H Hartley Sweeten wrote:
> >> Introduce a wrapper for to_pci_dev() to allow the comedi pci drivers
> >> to store the pci_dev pointer in the comedi_devi
On Thursday, July 19, 2012 2:23 AM, Ian Abbott wrote:
> On 2012-07-19 02:24, H Hartley Sweeten wrote:
>> Introduce a wrapper for to_pci_dev() to allow the comedi pci drivers
>> to store the pci_dev pointer in the comedi_device hw_dev variable and
>> retrieve it easily.
>>
>> Signed-off-by: H Hartle
> -Original Message-
> From: Borislav Petkov [mailto:b...@alien8.de]
> Sent: Thursday, July 19, 2012 11:30 AM
> To: KY Srinivasan
> Cc: Paolo Bonzini; Greg KH (gre...@linuxfoundation.org);
> devel@linuxdriverproject.org; linux-ker...@vger.kernel.org;
> virtualizat...@lists.osdl.org
> Subj
On Thu, Jul 19, 2012 at 02:11:47AM +, KY Srinivasan wrote:
> As I noted earlier, this is just a guest ID that needs to be
> registered with the hypervisor. Thanks for reporting this issue and
> on behalf of Microsoft, I would like to apologize for this offensive
> string. I have submitted a pat
Hello Anton Vorontsov,
This is a semi-automatic email about new static checker warnings.
The patch a694d1b5916a: "pstore/ram: Add ftrace messages handling"
from Jul 9, 2012, leads to the following Smatch complaint:
fs/pstore/ram.c:423 ramoops_probe()
error: we previously assumed 'cxt->
Hi Dan,
On Thu, Jul 19, 2012 at 6:20 PM, Dan Carpenter wrote:
> Cleanup means there are no behavior changes. This is a bug fix.
>
Thanks Dan, i will put a proper subject line in commit.
> On Thu, Jul 19, 2012 at 06:00:01PM +0530, Devendra Naga wrote:
>> a) if alloc_hdlcdev fails, we are goin
On Thursday 19 July 2012 17:55:10 wei_w...@realsil.com.cn wrote:
> +static int rtsx_pci_transfer_sglist_adma(struct rtsx_pdev *pdev,
> + struct scatterlist *sg, int num_sg, int read, int timeout)
> +{
> + struct completion trans_done;
> + u8 dir;
> + int buf_cnt, i;
> +
Cleanup means there are no behavior changes. This is a bug fix.
On Thu, Jul 19, 2012 at 06:00:01PM +0530, Devendra Naga wrote:
> a) if alloc_hdlcdev fails, we are going into the free_regions,
> and returning out the err (which is 0 by the prev call),
>return -ENOMEM if this function f
On Thursday 19 July 2012 17:55:18 wei_w...@realsil.com.cn wrote:
> +static void sd_normal_rw(struct realtek_sdmmc *host, struct mmc_request *mrq)
> +{
> + struct mmc_command *cmd = mrq->cmd;
> + struct mmc_data *data = mrq->data;
> + u8 _cmd[5], *buf;
> +
> + _cmd[0] = 0x40 | (u8)c
On 2012-07-19 03:05, H Hartley Sweeten wrote:
Use the hw_dev pointer in the comedi_device struct to hold the
pci_dev instead of carrying it in the private data.
My reply to patch 86 has a knock-on effect for this patch...
/* Get the physical address from PCI config */
- dev->iob
On 2012-07-19 03:04, H Hartley Sweeten wrote:
The 'got_regions' variable in the private data is used as a flag
for the detach to know if the pci device has been enabled.
Typically the dev->iobase variable is used to indicate this in
all the other comedi drivers. Do the same here for consistancy.
a) if alloc_hdlcdev fails, we are going into the free_regions,
and returning out the err (which is 0 by the prev call),
return -ENOMEM if this function fail.
b) setup_device also can fail, as it calls around the register_hdlc_dev
which
is again a macro of the register_netdev.
On 2012-07-19 02:58, H Hartley Sweeten wrote:
The 'phys_addr' variable in the private data is simply used as
a flag for the detach function to know that the pci device has
been enabled. Use the 'dev->iobase' variable instead as is more
typical for other comedi pci drivers.
I think dev->iobase i
On 2012-07-19 02:57, H Hartley Sweeten wrote:
The "find pci device" code for this driver was split between
two functions which could cause the driver to walk the pci
bus multiple times while looking for a match.
Actually the original version only walks through the PCI devices once
(due to the
On 2012-07-19 02:40, H Hartley Sweeten wrote:
Use the hw_dev pointer in the comedi_device struct to hold the
pci_dev instead of carrying it in the private data.
Since the pci_dev is no longer held in the provate data, we can
also cleanup the detach a bit. Remove the IS_ENABLED() tests in
the det
On 2012-07-19 11:30, Ian Abbott wrote:
On 2012-07-19 02:39, H Hartley Sweeten wrote:
Use the hw_dev pointer in the comedi_device struct to hold the
pci_dev instead of carrying it in the private data.
Since the pci_dev is no longer held in the provate data, we can
also cleanup the detach a bit.
On 2012-07-19 11:27, Ian Abbott wrote:
On 2012-07-19 11:10, Ian Abbott wrote:
On 2012-07-19 02:37, H Hartley Sweeten wrote:
Use the hw_dev pointer in the comedi_device struct to hold the
pci_dev instead of carrying it in the private data.
Since the pci_dev is no longer held in the provate data
On 2012-07-19 02:39, H Hartley Sweeten wrote:
Use the hw_dev pointer in the comedi_device struct to hold the
pci_dev instead of carrying it in the private data.
Since the pci_dev is no longer held in the provate data, we can
also cleanup the detach a bit. Remove the IS_ENABLED() tests in
the det
On 2012-07-19 11:10, Ian Abbott wrote:
On 2012-07-19 02:37, H Hartley Sweeten wrote:
Use the hw_dev pointer in the comedi_device struct to hold the
pci_dev instead of carrying it in the private data.
Since the pci_dev is no longer held in the provate data, we can
also cleanup the detach a bit.
On 2012-07-19 02:37, H Hartley Sweeten wrote:
Use the hw_dev pointer in the comedi_device struct to hold the
pci_dev instead of carrying it in the private data.
Since the pci_dev is no longer held in the provate data, we can
also cleanup the detach a bit. Remove the IS_ENABLED() tests in
the det
From: Wei WANG
Realtek card reader core driver is the bus driver for Realtek
driver-based card reader, which supplies adapter layer to
be used by lower-level pci/usb card reader and upper-level
sdmmc/memstick host driver.
Signed-off-by: Wei WANG
---
Documentation/misc-devices/realtek_cr.txt |
From: Wei WANG
Realtek SD/MMC card interface driver is used to access
SD/MMC card, with the help of Realtek card reader adapter driver.
Signed-off-by: Wei WANG
---
drivers/mmc/host/Kconfig |7 +
drivers/mmc/host/Makefile |2 +
drivers/mmc/host/rtsx_sdmmc.c | 354 +
On 2012-07-19 02:34, H Hartley Sweeten wrote:
This driver creates a linked list of all the pci devices in
the system while it's looking for a match. It's only use is
to determine if a device is "free" to use. The pci_is_enabled()
helper can give us the same information. Use that instead and
remov
On 2012-07-19 02:32, H Hartley Sweeten wrote:
Use pci_is_enabled() in the "find pci device" function to determine if
the found pci device is not in use and move the comedi_pci_enable() call
into the attach.
As mentioned in my reply to your equivalent patch for adv_pci1723, you
should remove th
On 2012-07-19 02:30, H Hartley Sweeten wrote:
Use pci_is_enabled() in the "find pci device" function to determine if
the found pci device is not in use and move the comedi_pci_enable() call
into the attach.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/s
On 2012-07-19 02:24, H Hartley Sweeten wrote:
Introduce a wrapper for to_pci_dev() to allow the comedi pci drivers
to store the pci_dev pointer in the comedi_device hw_dev variable and
retrieve it easily.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/sta
58 matches
Mail list logo
