Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-08-02 Thread wwang
于 2012年08月01日 22:31, Arnd Bergmann 写道: > > I understand where you are coming from, but IMHO a bus driver would > make more sense if the bus was a low-level abstraction that allows you > to add new high-level drivers (memstick, smartmedia, ...) without > having to modify the low-level drivers, which

Re: [PATCH 04/12] staging: bcm: print small buffers with %*ph

2012-08-02 Thread Kevin McKinney
On Thu, Aug 02, 2012 at 07:05:44PM +0300, Andy Shevchenko wrote: > Signed-off-by: Andy Shevchenko > Cc: Kevin McKinney > --- > drivers/staging/bcm/CmHost.c | 78 > +- > drivers/staging/bcm/Misc.c |5 ++- > 2 files changed, 36 insertions(+), 47 del

Re: [PATCH] isdnloop: fix and simplify isdnloop_init()

2012-08-02 Thread David Miller
From: Fengguang Wu Date: Thu, 2 Aug 2012 19:05:43 +0800 > Fix a buffer overflow bug by removing the revision transform code. > > [ 22.016214] isdnloop-ISDN-driver Rev 1.11.6.7 > [ 22.097508] isdnloop: (loop0) virtual card added > [ 22.174400] Kernel panic - not syncing: stack-protector: K

[PATCH 10/12] staging: vt6656: print small buffers with %*ph

2012-08-02 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko Cc: Forest Bond --- drivers/staging/vt6656/ioctl.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vt6656/ioctl.c b/drivers/staging/vt6656/ioctl.c index 5b9a84f..d67b29f 100644 --- a/drivers/staging/vt6656/ioctl.c +++ b

[PATCH 12/12] staging: xgifb: print small buffers via %*ph

2012-08-02 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko Cc: Aaro Koskinen --- drivers/staging/xgifb/XGI_main_26.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c index 64ffd70..0c859ae 100644 --- a/drivers/sta

[PATCH 08/12] staging: rts_pstor: use %*ph to dump buffers

2012-08-02 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko --- drivers/staging/rts_pstor/trace.h | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rts_pstor/trace.h b/drivers/staging/rts_pstor/trace.h index bc83b49..d7f4eb6 100644 --- a/drivers/staging/rts_pstor/trace.h ++

[PATCH 11/12] staging: wlan-ng: use %*phC to hexdump small buffers

2012-08-02 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko --- drivers/staging/wlan-ng/p80211wep.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211wep.c b/drivers/staging/wlan-ng/p80211wep.c index 80c2d3b..77e50a4 100644 --- a/drivers/staging/wlan-ng/p

[PATCH 09/12] staging: vt6655: print small buffers with %*ph

2012-08-02 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko Cc: Forest Bond --- drivers/staging/vt6655/ioctl.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vt6655/ioctl.c b/drivers/staging/vt6655/ioctl.c index ef197ef..ac15d38 100644 --- a/drivers/staging/vt6655/ioctl.c +++ b

[PATCH 05/12] staging: lirc: use %*ph to print small buffers

2012-08-02 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko Cc: Mauro Carvalho Chehab Cc: linux-me...@vger.kernel.org --- drivers/staging/media/lirc/lirc_igorplugusb.c |4 ++-- drivers/staging/media/lirc/lirc_zilog.c |3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/l

[PATCH 06/12] staging: nvec: use %*ph to dump small buffers

2012-08-02 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko Cc: Julian Andres Klode Cc: Marc Dietrich Cc: ac...@lists.launchpad.net --- drivers/staging/nvec/nvec.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c index 695ea35..3655d86 100644

[PATCH 04/12] staging: bcm: print small buffers with %*ph

2012-08-02 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko Cc: Kevin McKinney --- drivers/staging/bcm/CmHost.c | 78 +- drivers/staging/bcm/Misc.c |5 ++- 2 files changed, 36 insertions(+), 47 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHos

[PATCH 02/12] staging: csr: print mac address with %pM

2012-08-02 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko --- drivers/staging/csr/wext_events.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/csr/wext_events.c b/drivers/staging/csr/wext_events.c index d356887..9860ea3 100644 --- a/drivers/staging/csr/wext_events.c +++ b/dr

[PATCH 03/12] staging: csr: use %*ph[C] to hexdump small buffers

2012-08-02 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko --- drivers/staging/csr/csr_wifi_hip_send.c |9 ++--- drivers/staging/csr/sme_wext.c |4 ++-- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/staging/csr/csr_wifi_hip_send.c b/drivers/staging/csr/csr_wifi_hip_send.c index

[PATCH 01/12] staging: tidspbridge: eliminate uuid_uuid_to_string

2012-08-02 Thread Andy Shevchenko
There is native specificator for snprintf to get UUID in human readable format. Signed-off-by: Andy Shevchenko Cc: Omar Ramirez Luna --- drivers/staging/tidspbridge/gen/uuidutil.c | 21 .../tidspbridge/include/dspbridge/uuidutil.h | 20 ---

[PATCH 07/12] staging: rts5139: use *ph to dump buffers

2012-08-02 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko Cc: edwin_r...@realsil.com.cn --- drivers/staging/rts5139/trace.h | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rts5139/trace.h b/drivers/staging/rts5139/trace.h index 0584b8a..2895360 100644 --- a/drivers/sta

[PATCH] isdnloop: fix and simplify isdnloop_init()

2012-08-02 Thread Fengguang Wu
Fix a buffer overflow bug by removing the revision transform code. [ 22.016214] isdnloop-ISDN-driver Rev 1.11.6.7 [ 22.097508] isdnloop: (loop0) virtual card added [ 22.174400] Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: 83244972 [ 22.174400] [ 2

Re: [PATCH] isdnloop: fix and simplify isdnloop_init()

2012-08-02 Thread Fengguang Wu
On Thu, Aug 02, 2012 at 01:57:36PM +0300, Dan Carpenter wrote: > On Thu, Aug 02, 2012 at 06:44:56PM +0800, Fengguang Wu wrote: > > [Add more CC] > > > > That's not helpful... Resend the patch to netdev in a way that > applies. OK, sorry... ___ devel m

Re: [PATCH] isdnloop: fix and simplify isdnloop_init()

2012-08-02 Thread Dan Carpenter
On Thu, Aug 02, 2012 at 06:44:56PM +0800, Fengguang Wu wrote: > [Add more CC] > That's not helpful... Resend the patch to netdev in a way that applies. regards, dan carpenter ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxd

Re: [PATCH] isdnloop: fix and simplify isdnloop_init()

2012-08-02 Thread Greg KH
On Thu, Aug 02, 2012 at 06:44:56PM +0800, Fengguang Wu wrote: > [Add more CC] That's not going to do much, you just sent them a patch they can't apply without editing by hand :( ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdr

Re: [PATCH] isdnloop: fix and simplify isdnloop_init()

2012-08-02 Thread Fengguang Wu
[Add more CC] On Thu, Aug 02, 2012 at 12:01:58PM +0800, Fengguang Wu wrote: > Remove the non-sense isdnloop revision transform code, so as to fix: > > [ 22.016214] isdnloop-ISDN-driver Rev 1.11.6.7 > [ 22.097508] isdnloop: (loop0) virtual card added > [ 22.174400] Kernel panic - not syncin

Re: [PATCH] isdnloop: fix and simplify isdnloop_init()

2012-08-02 Thread Greg KH
On Thu, Aug 02, 2012 at 12:01:58PM +0800, Fengguang Wu wrote: > Remove the non-sense isdnloop revision transform code, so as to fix: > > [ 22.016214] isdnloop-ISDN-driver Rev 1.11.6.7 > [ 22.097508] isdnloop: (loop0) virtual card added > [ 22.174400] Kernel panic - not syncing: stack-protec