The *_bits information in the boardinfo is not used by the driver.
Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dyna_
The analog output channels on this board only support a single
range, 0-10V unipolar. This range is available as an exported
symbol from the comedi core and "range_unipolar10". Use that
instead of duplicating the range in this driver and remove
the information from the boardinfo.
Signed-off-by: H
The boardinfo code is not needed by this driver. Only one board
type is supported.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 38 ++-
1 file changed, 2 insertions(+), 36 deletions(-)
diff -
There is only one "boardtype" actually supported by this driver.
The second entry in the boardinfo is a dummy entry that would
result in an unusable device.
Remove the boardinfo fields and just use the open coded values
in the subdevice setup.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc:
This define is not used in the driver. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/dyna_pci10xx.c
b/drivers/staging/comedi/
These macros rely on local variables having a specific name. Replace
them with local variables where used. Use the comedi_board() helper
to get the thisboard pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 23 +
Convert this PCI driver to use the comedi PCI auto config attach
mechanism by adding an attach_pci callback function. Since the
driver does not require any external configuration options, disable
the legacy attach by making the attach simply return -ENOSYS. This
removes the need to walk the pci bus
Update the dyna_pci10xx driver to use the PCI Pnp auto config mechanism
of the comedi core and remove the unneeded boardinfo code.
H Hartley Sweeten (7):
staging: comedi: dnya_pci10xx: remove thisboard and devpriv macros
staging: comedi: dnya_pci10xx: use attach_pci callback
staging: comedi:
Hi Seth,
On Tue, Aug 14, 2012 at 05:18:57PM -0500, Seth Jennings wrote:
> On 07/27/2012 01:18 PM, Seth Jennings wrote:
> > zcache is the remaining piece of code required to support in-kernel
> > memory compression. The other two features, cleancache and frontswap,
> > have been promoted to mainli
On 07/27/2012 01:18 PM, Seth Jennings wrote:
> zcache is the remaining piece of code required to support in-kernel
> memory compression. The other two features, cleancache and frontswap,
> have been promoted to mainline in 3.0 and 3.5. This patchset
> promotes zcache from the staging tree to main
This driver uses the void *private variable in the comedi_subdevice
to pass the offset needed to read/write the appropriate register to
get/set the channels for the subdevice.
The adl_pci7x3x_do_insn_bits() and adl_pci7x3x_di_insn_bits() functions
were retrieving this offset by casting the s->priv
On Tuesday, August 14, 2012 1:59 AM, Ian Abbott wrote:
> On 2012-08-14 02:36, H Hartley Sweeten wrote:
>> On Monday, August 13, 2012 6:30 PM, Greg KH wrote:
>>> On Fri, Aug 03, 2012 at 10:28:18AM -0700, H Hartley Sweeten wrote:
Currently the ADLink PCI-7230 and PCI-7432 Isolated Digital
I
Eliminated remaining calls to strict_stroul() and replaced them with
strict_kstrtou8().
Signed-off-by: Johannes Thumshirn
---
drivers/staging/line6/variax.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/line6/variax.c b/drivers/staging/line6/variax.c
Please ignore this patch, sorry i screwed again, i will try with care!
On Tue, Aug 14, 2012 at 10:22 PM, Devendra Naga
wrote:
> as we do a strcpy(smdrv_ptr->fb_struct->fix->id, name), and the name here in
> sm7xxx_probe is not having any assignment, and which leads to copying of the
> garbage
as we do a strcpy(smdrv_ptr->fb_struct->fix->id, name), and the name here in
sm7xxx_probe is not having any assignment, and which leads to copying of the
garbage value
into the id field of the fix struct of fb interface struct. fix it by copying
the name before
calling alloc_fbinfo
Signed-off-by
> -Original Message-
> From: Ilya Shchepetkov [mailto:shchepet...@ispras.ru]
> Sent: Tuesday, August 14, 2012 6:29 AM
> To: KY Srinivasan
> Cc: Ilya Shchepetkov; Haiyang Zhang; David S. Miller;
> devel@linuxdriverproject.org; net...@vger.kernel.org; linux-
> ker...@vger.kernel.org; ldv-pr
Add helper macro IS_ISA_BOARD(board) to check if the driver supports ISA
boards and this is an ISA board, and IS_PCI_BOARD(board) to check if the
driver supports PCI boards and this is a PCI board.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/amplc_dio200.c | 11 +++
1
When detaching the device in dio200_detach() mirror the bus type checks
performed by dio200_attach(). The existing tests are safe but rely on
dev->iobase being 0 when comedi_to_pci_dev(dev) is NULL.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/amplc_dio200.c | 14 -
The IS_ENABLED(CONFIG_COMEDI_AMPLC_DIO200_ISA) and
IS_ENABLED(CONFIG_COMEDI_AMPLC_DIO200_PCI) macro calls are a bit
long-winded. Define a couple of macros DO_ISA and DO_PCI as
abbreviations for them.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/amplc_dio200.c | 31
A few changes to the amplc_dio200 driver. Patches 1 and 2 define a few
macros to make the code slightly easier to read. Patch 3 changes
dio200_detach() to use the same bus type tests as dio200_attach().
[PATCH 1/3] abbreviate IS_ENABLED()
[PATCH 2/3] add helper macros to check bus type
[PATCH 3/
Hi Boris:
Can you tell me the detailed information about your pc and the SD card? Do you
have ever tried to use another SD card?
I have tested all of the SD cards that we have in our company, and everything
runs smoothly. Maybe it is compatibilty issue and we have to debug it
specifically.
P
On Tue, Aug 14, 2012 at 06:40:36PM +0800, wei_w...@realsil.com.cn wrote:
> From: Wei WANG
>
> Support for Realtek PCI-Express driver-based card readers including rts5209
> and rts5229.
>
> Wei WANG (2):
> drivers/mfd: Add realtek pcie card reader driver
> drivers/mmc: Add realtek pcie sdmmc
On 2012-08-14 13:04, Dan Carpenter wrote:
On Tue, Aug 14, 2012 at 11:29:17AM +0100, Ian Abbott wrote:
Commit 3902a370281d2f2b130f141e8cf94eab40125769 by yours truly
Please give a human readable patch title as well.
Sorry. It's:
staging: comedi: refactor comedi_device_attach() a bit
author
On Tue, Aug 14, 2012 at 11:29:17AM +0100, Ian Abbott wrote:
> Commit 3902a370281d2f2b130f141e8cf94eab40125769 by yours truly
Please give a human readable patch title as well.
regards,
dan carpenter
___
devel mailing list
devel@linuxdriverproject.org
ht
For carrier detection to work properly when binding the driver with a
cable unplugged, netif_carrier_off() should be called after
register_netdev(), not before.
Calling netif_carrier_off() before register_netdev() was causing the
network interface to miss a linkwatch pending event leading to an
in
Am Dienstag, 14. August 2012, 09:04:45 schrieb Dan Carpenter:
> This is a static checker fix and not something I can test. The intent
> of the code here is to set some bit flags. For a logical OR the ">> 1"
> shift wouldn't make a difference. So it should be using a bitwise OR.
>
> Signed-off-b
From: Wei WANG
Realtek PCI-E SD/MMC card host driver is used to access SD/MMC card,
with the help of Realtek PCI-E card reader MFD driver.
Signed-off-by: Wei WANG
Reviewed-by: Arnd Bergmann
---
drivers/mmc/host/Kconfig |7 +
drivers/mmc/host/Makefile |2 +
drivers/mmc
From: Wei WANG
Support for Realtek PCI-Express driver-based card readers including rts5209 and
rts5229.
Wei WANG (2):
drivers/mfd: Add realtek pcie card reader driver
drivers/mmc: Add realtek pcie sdmmc host driver
drivers/mfd/Kconfig |9 +
drivers/mfd/Makefile
Commit 3902a370281d2f2b130f141e8cf94eab40125769 by yours truly
introduced an inverted logic bug in comedi_device_attach() for the case
where the driver expects the device to be configured by driver name
rather than board name. The result of a strcmp() is being tested
incorrectly. Fix it.
Thanks
于 2012年08月14日 17:32, Arnd Bergmann 写道:
> When you post a new version of patches, please add a version number in the
> subject line, like " [PATCH v3 1/2] drivers/mfd: Add realtek pcie card
> reader driver", to make it easier for people to know what has changed.
> It's also helpful to have a "[PATCH
On Tuesday 14 August 2012, wei_w...@realsil.com.cn wrote:
> From: Wei WANG
>
> Realtek PCI-E card reader driver adapts requests from upper-level
> sdmmc/memstick layer to the real physical card reader.
>
> Signed-off-by: Wei WANG
When you post a new version of patches, please add a version num
On 13/08/12 18:28, Justin P. Mattock wrote:
> From: "Justin P. Mattock"
>
> Signed-off-by: Justin P. Mattock
>
> ---
> Note:resend with minor adjustments.
> The below patch fixes typos found while reading through staging "vme"
>
> drivers/staging/vme/devices/vme_user.c |8
> 1 fi
On 2012-08-14 02:36, H Hartley Sweeten wrote:
On Monday, August 13, 2012 6:30 PM, Greg KH wrote:
On Fri, Aug 03, 2012 at 10:28:18AM -0700, H Hartley Sweeten wrote:
Currently the ADLink PCI-7230 and PCI-7432 Isolated Digital
I/O Boards are supported using two drivers (adl_pci7230 and
adl_pci7432
This is a static checker fix and not something I can test. The intent
of the code here is to set some bit flags. For a logical OR the ">> 1"
shift wouldn't make a difference. So it should be using a bitwise OR.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/xgifb/vb_init.c b/driver
34 matches
Mail list logo
