From: Wei Yongjun
The dereference should be moved below the NULL test.
spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun
---
drivers/staging/tidspbridge/core/chnl_sm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
On Thu, Sep 06, 2012 at 06:53:14PM +0200, Samuel Iglesias Gonsálvez wrote:
> On 09/06/2012 06:17 PM, Jens Taprogge wrote:
> > ~0 is not casted to u8. Instead of using the IPACK_ANY_ID for the
> > format field we introduce a new IPACK_ANY_FORMAT specifically for
> > that field and defined as 0xff.
In response to this RFC for zcache promotion, I've been asked to summarize
the concerns and objections which led me to NACK the previous zcache
promotion request. While I see great potential in zcache, I think some
significant design challenges exist, many of which are already resolved in
the new
From: Ben Hutchings
There is a new convention, used by systemd and supported by most
distributions, to put basic OS release information in /etc/os-release.
Added some additional error checking on strdup()
Signed-off-by: Ben Hutchings
Signed-off-by: K. Y. Srinivasan
---
tools/hv/hv_kvp_daemon.
On Thu, Sep 06 2012, Sebastian Andrzej Siewior wrote:
> This partly reverts 07a18bd7 ("usb gadget: don't save bind callback in
> struct usb_composite_driver") and fixes new drivers. The section missmatch
> problems was solved by whitelisting structs in question via __ref.
>
> Cc: de...@driverdev.os
On Thu, Sep 06 2012, Sebastian Andrzej Siewior wrote:
> The first item on the todo list is a new user interface. Put this
> information into Kconfig's help entry to people are not too confusing
> once an user API changes which does not happen in kernel otherwise.
>
> Cc: de...@driverdev.osuosl.org
On Wed, 5 Sep 2012, Devendra Naga wrote:
> as per Documentation/CodingStyle we dont need to cast the return of
> kmalloc
>
> Signed-off-by: Devendra Naga
> ---
> drivers/staging/rtl8192e/rtllib_softmac.c |3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/stag
Hi Devendra,
2012/9/6 Devendra Naga :
> a) put the device_get_options functions' opening brace below
> b) replace spaces with tabs
>
> Signed-off-by: Devendra Naga
> ---
> drivers/staging/vt6655/device_main.c | 48
> --
> 1 file changed, 23 insertions(+), 25 de
2012/9/6 Devendra Naga :
> a) replace spaces with tabs
> b) put the opening brace of get_chip_name below it
>
> Signed-off-by: Devendra Naga
> ---
> drivers/staging/vt6655/device_main.c | 21 +++--
> 1 file changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/stag
this is because it doesn't fail anywhere and returning a value
from it will be completely unnecesary.
Signed-off-by: Devendra Naga
---
drivers/staging/vt6655/device_main.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/vt6655/device_main.c
b/dri
when alloc_etherdev fails we should be returning ENOMEM, not ENODEV
Signed-off-by: Devendra Naga
---
drivers/staging/vt6655/device_main.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/device_main.c
b/drivers/staging/vt6655/device_main.c
index 4938
we are using spaces at the beginning of the line, we should use
tabs instead
Signed-off-by: Devendra Naga
---
drivers/staging/vt6655/device_main.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/vt6655/device_main.c
b/drivers/staging/vt6655/
a) put the device_get_options functions' opening brace below
b) replace spaces with tabs
Signed-off-by: Devendra Naga
---
drivers/staging/vt6655/device_main.c | 48 --
1 file changed, 23 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/vt6655/device_
a) replace spaces with tabs
b) put the opening brace of get_chip_name below it
Signed-off-by: Devendra Naga
---
drivers/staging/vt6655/device_main.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/vt6655/device_main.c
b/drivers/stagi
Hi Greg,
These patches fix the coding style problems, and some small
error path checks, and function prototyping problems.
each patch is compile tested.
Please consider applying them.
Thanks a lot!
Devendra Naga (5):
staing: vt6655: fix coding style warnings
staging: vt6655: fix coding sty
On Thu, Sep 06, 2012 at 11:16:18AM -0700, Greg KH wrote:
> On Thu, Sep 06, 2012 at 12:37:28PM -0500, H Hartley Sweeten wrote:
> > On Wednesday, September 05, 2012 8:07 PM, Greg KH wrote:
> > > On Wed, Sep 05, 2012 at 06:59:09PM -0700, H Hartley Sweeten wrote:
> > >> Convert the comedi_subdevice acc
On Thu, Sep 06, 2012 at 12:37:28PM -0500, H Hartley Sweeten wrote:
> On Wednesday, September 05, 2012 8:07 PM, Greg KH wrote:
> > On Wed, Sep 05, 2012 at 06:59:09PM -0700, H Hartley Sweeten wrote:
> >> Convert the comedi_subdevice access from pointer math to array
> >> access.
> >>
> >> Signed-off
The first item on the todo list is a new user interface. Put this
information into Kconfig's help entry to people are not too confusing
once an user API changes which does not happen in kernel otherwise.
Cc: de...@driverdev.osuosl.org
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/staging/
This partly reverts 07a18bd7 ("usb gadget: don't save bind callback in
struct usb_composite_driver") and fixes new drivers. The section missmatch
problems was solved by whitelisting structs in question via __ref.
Cc: de...@driverdev.osuosl.org
Signed-off-by: Sebastian Andrzej Siewior
---
drivers
This Android gadget includes a bunch of .c files. Fixing normal gadgets
is not the real problem but this gadget is not always fixable since the
problem here are fundumential / design.
*I* wanted to get this removed but other people want to keep it even
though there were reports that Android itself
On Wednesday, September 05, 2012 8:07 PM, Greg KH wrote:
> On Wed, Sep 05, 2012 at 06:59:09PM -0700, H Hartley Sweeten wrote:
>> Convert the comedi_subdevice access from pointer math to array
>> access.
>>
>> Signed-off-by: H Hartley Sweeten
>
> This patch causes a build warning. Care to send a
> From: Dan Carpenter
> Sent: Thursday, September 06, 2012 6:40 AM
> To: Greg Kroah-Hartman
> Cc: Dan Magenheimer; Konrad Rzeszutek Wilk; de...@driverdev.osuosl.org;
> linux...@kvack.org; kernel-
> janit...@vger.kernel.org
> Subject: [patch] staging: ramster: fix range checks in
> zcache_autocrea
> From: Dan Magenheimer
> Subject: RE: [patch] staging: ramster: fix range checks in
> zcache_autocreate_pool()
>
> > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org]
> > Subject: Re: [patch] staging: ramster: fix range checks in
> > zcache_autocreate_pool()
> >
> > On Thu, Sep 06, 2
Fix build warnings resulting from in-progress work that was
not entirely ifdef'd out.
Signed-off-by: Dan Magenheimer
---
drivers/staging/ramster/zcache-main.c | 12 +---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/ramster/zcache-main.c
b/drivers/stag
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/06/2012 06:17 PM, Jens Taprogge wrote:
> ~0 is not casted to u8. Instead of using the IPACK_ANY_ID for the
> format field we introduce a new IPACK_ANY_FORMAT specifically for
> that field and defined as 0xff.
>
> Reported-by: Dan Carpenter
>
On Thu, Sep 06, 2012 at 11:35:26AM -0500, H Hartley Sweeten wrote:
> On Thursday, September 06, 2012 9:11 AM, Greg KH wrote:
> > On Wed, Sep 05, 2012 at 06:11:41PM -0700, H Hartley Sweeten wrote:
> >> This is a repost of the big patch to remove all the subdevice pointer
> >> math. The big patch is
On Thursday, September 06, 2012 9:11 AM, Greg KH wrote:
> On Wed, Sep 05, 2012 at 06:11:41PM -0700, H Hartley Sweeten wrote:
>> This is a repost of the big patch to remove all the subdevice pointer
>> math. The big patch is now broken up into pieces that only change
>> single files.
>>
>> Let me k
> From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org]
> Subject: Re: [patch] staging: ramster: fix range checks in
> zcache_autocreate_pool()
>
> On Thu, Sep 06, 2012 at 03:40:20PM +0300, Dan Carpenter wrote:
> > If "pool_id" is negative then it leads to a read before the start of the
>
On Thu, Sep 06, 2012 at 03:40:20PM +0300, Dan Carpenter wrote:
> If "pool_id" is negative then it leads to a read before the start of the
> array. If "cli_id" is out of bounds then it leads to a NULL dereference
> of "cli". GCC would have warned about that bug except that we
> initialized the war
On Wed, Sep 05, 2012 at 06:11:41PM -0700, H Hartley Sweeten wrote:
> This is a repost of the big patch to remove all the subdevice pointer
> math. The big patch is now broken up into pieces that only change
> single files.
>
> Let me know if they should be combined into larger chuncks.
>
> The s6
If "pool_id" is negative then it leads to a read before the start of the
array. If "cli_id" is out of bounds then it leads to a NULL dereference
of "cli". GCC would have warned about that bug except that we
initialized the warning message away.
Also it's better to put the parameter names into th
Hello Jens Taprogge,
The patch 4aa09d47d45e: "Staging: ipack: Implement device matching on
the bus level." from Sep 4, 2012, leads to the following warning:
drivers/staging/ipack/ipack.c:34 ipack_match_one_device()
error: id->format is never equal to -1 (wrong type 0 - 255).
30 sta
USB autosuspend suspends vhci_hcd. In this process hcd_bus_suspend gets
executed which puts vhci_hcd in suspend state and calls vhci_hub_status.
vhci_hub_status function checks hub state and if it is in suspend state,
usb_hcd_resume_root_hub gets executed which resumes hub
and if hub is idle, aga
Btw, thanks for this. I've been basically offline for a bit so I
didn't say that before.
regards,
dan carpenter
___
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
34 matches
Mail list logo
