>
> diff --git a/drivers/staging/xgifb/vb_struct.h
> b/drivers/staging/xgifb/vb_struct.h
> index 22c8eb9..e2fa1ff 100644
> --- a/drivers/staging/xgifb/vb_struct.h
> +++ b/drivers/staging/xgifb/vb_struct.h
> @@ -137,10 +137,10 @@ struct XGI21_LVDSCapStruct {
> unsigned short LVDSVSYNC;
>
From: Wei WANG
Realtek PCI-E SD/MMC card host driver is used to access SD/MMC card,
with the help of Realtek PCI-E card reader MFD driver.
Signed-off-by: Wei WANG
Reviewed-by: Arnd Bergmann
Tested-by: Borislav Petkov
---
drivers/mmc/host/Kconfig |7 +
drivers/mmc/host/Makefile
From: Wei WANG
Realtek PCI-E Memstick card host driver is used to access Memstick
card, with the help of Realtek PCI-E card reader MFD driver.
Signed-off-by: Wei WANG
---
drivers/memstick/host/Kconfig | 10 +
drivers/memstick/host/Makefile |1 +
drivers/memstick/host/rtsx_pci_
From: Wei WANG
Support for Realtek PCI-Express driver-based card readers including rts5209 and
rts5229.
v2:
1. Using platform device to replace realtek slot bus
v3:
1. Fix a bug that DMA out of SW-IOMMU space in Lenovo Thinkpad x121e
2. Tested by Borislav Petkov
v4:
1. Fulfill power manageme
On Mon, 2012-09-10 at 20:44 -0700, Greg KH wrote:
> On Mon, Sep 10, 2012 at 08:40:11PM -0700, Joe Perches wrote:
> > On Mon, 2012-09-10 at 19:52 -0700, Greg KH wrote:
> > > On Tue, Sep 11, 2012 at 04:50:15AM +0200, Bruce Humphrey wrote:
> > > > Change 5 instances of printk(KERN_INFO, KERN_WARN and
On Mon, Sep 10, 2012 at 08:40:11PM -0700, Joe Perches wrote:
> On Mon, 2012-09-10 at 19:52 -0700, Greg KH wrote:
> > On Tue, Sep 11, 2012 at 04:50:15AM +0200, Bruce Humphrey wrote:
> > > Change 5 instances of printk(KERN_INFO, KERN_WARN and KERN_ERROR for the
> > > prefered pr_info, pr_warn and pr
On Mon, 2012-09-10 at 19:52 -0700, Greg KH wrote:
> On Tue, Sep 11, 2012 at 04:50:15AM +0200, Bruce Humphrey wrote:
> > Change 5 instances of printk(KERN_INFO, KERN_WARN and KERN_ERROR for the
> > prefered pr_info, pr_warn and pr_error
[]
> > diff --git a/drivers/staging/comedi/drivers/fl512.c
>
On Mon, Sep 10, 2012 at 06:49:47PM -0700, H Hartley Sweeten wrote:
> Remove the boardinfo and convert this driver to use the comedi attach_pci
> auto config mechanism.
>
> Use the 8253 helpers and remove the code for programming the timers.
>
> Remove a bunch of debug code and all the i/o macros.
On Tue, Sep 11, 2012 at 04:50:15AM +0200, Bruce Humphrey wrote:
> Change 5 instances of printk(KERN_INFO, KERN_WARN and KERN_ERROR for the
> prefered pr_info, pr_warn and pr_error
>
> Signed-off-by: Bruce Humphrey Ventura
> ---
> drivers/staging/comedi/drivers/fl512.c | 10 +-
> 1 fil
Change 5 instances of printk(KERN_INFO, KERN_WARN and KERN_ERROR for the
prefered pr_info, pr_warn and pr_error
Signed-off-by: Bruce Humphrey Ventura
---
drivers/staging/comedi/drivers/fl512.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/comed
Remove some obvious comments.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 41 ++--
1 file changed, 2 insertions(+), 39 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adl_pci9111.c
The comedi core always calls the 'do_cmdtest' function before it
calls the 'do_cmd' function. The 'do_cmdtest' for this driver calls
i8253_cascade_ns_to_timer_2div() to validate the cmd->convert_arg.
This call sets the dev_private 'div1' and 'div2' values needed to
program the 8254 timer. There is
Use the helper function cfc_check_trigger_is_unique.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 23 +--
1 file changed, 9 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/comedi/drive
"Step 2" of each do_cmdtest checks that the trigger sources are
unique by doing something like this for each trigger:
if (cmd->start_src != TRIG_TIMER &&
cmd->start_src != TRIG_FOLLOW &&
cmd->start_src != TRIG_EXT)
err++;
/* Test the remainin
If a single source trigger passes "step 1" of the do_cmdtest they
are already unique. There is no need to recheck them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 6 --
1 file changed, 6 deletions(-)
diff --git
Remove the pci9111_check_trigger_src macro and use the helper
function cfc_check_trigger_src instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 29 +++-
1 file changed, 11 insertions(+), 18
All of the comedi drivers that support the 'cmd' callback also
require a 'do_cmdtest' callback. The do_cmdtest validates the
comedi_cmd before it is executed.
"Step 1" of each do_cmdtest does a trivial validation of the
trigger sources by doing something like this for each trigger:
int er
The 'is_valid' variable in the private data is only used in the
detach of the board to determine if the pci9111_reset() function
can be called. That function only requires a valid dev->iobase
to work. Use that for the check instead and remove the unneeded
variable from the private data.
Signed-off
For aesthetic reasons, rename the symbols.
Remove the unnecessary () around the symbols in the calls to
i8253_cascade_ns_to_timer_2div().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 25 +++--
1 f
For aesthetic reasons, rename the symbol and fix the whitespace.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/comedi/d
Finish renaming the defines for the register map. Move the bit
defines so that they are associated with the register. Remove
the unneeded '0' bit defines.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 125 -
These macros rely on a local variable having a specific name.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 29 +++-
1 file changed, 16 insertions(+), 13 deletions(-)
diff --git a/drivers/stagi
This macro relies on a local variable having a specific name.
It's used multiple places so change it into a function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 34
1 file changed, 15 in
These macros rely on a local variable having a specific name.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 29 ++--
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/drivers/stagi
This macro relies on a local variable having a specific name.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/comedi/drivers/
This macro relies on a local variable having a specific name.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adl_p
These macros rely on a local variable having a specific name.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 30
1 file changed, 13 insertions(+), 17 deletions(-)
diff --git a/drivers/stagi
These macros rely on a local variable having a specific name.
The comedi code makes sure the channel number is valid so the mask
of PCI9111_CHANNEL_MASK can be remove.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 21
These macros rely on a local variable having a specific name.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 29 +---
1 file changed, 13 insertions(+), 16 deletions(-)
diff --git a/drivers/stagi
Simplify the chan/range in pci9111_ai_insn_read() by using local
variables for hold the values and by just passing insn->chanspec
to the CR_* macros instead of using (&insn->chanspec)[0].
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/
This debug output should be removed in the final driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adl_pci9111.c
b/drivers/stag
This debug output should be removed in the final driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 28
1 file changed, 28 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adl_p
Convert this PCI driver to use the comedi PCI auto config attach
mechanism by adding an 'attach_pci' callback function. Since the
driver does not require any external configuration options, and
the legacy 'attach' callback is now optional, remove it. The
boardinfo is also not needed now so remove i
These values are not used by the driver. Remove them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adl_pci9111.c
Remove the kernel messages about the io base/range for the pci
resources.
Move the board attach messages to the end of the attach and use
a simple/clean dev_info message for it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci91
The analog input subdevice is the same for all boards supported by
this driver. Remove the boardinfo just open-code the values in the
attach function.
Note: the only other board that could be supported by this driver is
the ADLink PCI-9111DG board. This board has 12-bit analog inputs
instead of th
The digital input and output subdevices are the same for all boards
supported by this driver. Remove the defines just open-code the values
in the attach function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 26 ++
The comedi core verifies that the chanlist elements are inrange for
the subdevice. Remove the redundant check in thie driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 8
1 file changed, 8 deletions(-)
di
The chanlist_len is validated by the comedi core before calling
the do_cmdtest function. Remove these redundant checks.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 10 --
1 file changed, 10 deletions(-)
diff
The analog output subdevice is the same for all boards supported
by this driver. Remove the boardinfo for it and just open-code
the values in the attach function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 23 ++
The shift, maxdata, and invert values, used to handle the 12-/16-bit
analog input differences, can be calculated based on the subdevice
maxdata value.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 19 +++---
These macros rely on a local variable having a specific name.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 23 ---
1 file changed, 8 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/com
The shift, maxdata, and invert values, used to handle the 12-/16-bit
analog input differences, can be calculated based on the subdevice
maxdata value.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 22 --
This debug output should be removed in the final driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adl_pci9111.c
b/dr
The 'ao_resolution' in the boardinfo is not used. Remove it.
Rename the 'ao_resolution_mask' to 'ao_maxdata', this information
is copied to the ao subdevice 'maxdata'.
Remove the PCI9111_AO_RESOLUTION* defines and just open-code the
maxdata in the boardinfo.
Remove the mask of the output data in
Remove the unnecessary comment.
Only the last data value written needs to be cached for
readback.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
d
Remove the unnecessary comments.
The readback value does not need to be masked.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/
This macro relies on a local variable having a specific name.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ad
Remove the unnecessary comments.
Cleanup the function to follow the comedi standard for digital
outputs. The 'mask' does not need to be checked, the comedi core
will make sure that it is valid based on the subdevice data.
The outputs only need to be updated if the 'mask' indicates
something is cha
Remove the unnecessary comments and remove the unneeded local variable.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 14 +++---
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/co
These macros rely on a local variable having a specific name.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/comedi/drivers/a
The timer on this board is a standard 8254 compatible counter/timer.
Instead of open-coding the 8254 timer io, use the helper functions
provided by 8253.h.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 53 -
These macros rely on a local variable having a specific name.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 65 ++--
1 file changed, 24 insertions(+), 41 deletions(-)
diff --git a/drivers/stagi
This macro relies on a local variable having a specific name.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 60 ++--
1 file changed, 29 insertions(+), 31 deletions(-)
diff --git a/drivers/stagi
This macro is an open-coded version of the kernels ARRAY_SIZE
macro. Use the kernel provided macro instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --
This macro relies on a local variable having a specific name.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 32
1 file changed, 23 insertions(+), 9 deletions(-)
diff --git a/drivers/stagin
Remove the boardinfo and convert this driver to use the comedi attach_pci
auto config mechanism.
Use the 8253 helpers and remove the code for programming the timers.
Remove a bunch of debug code and all the i/o macros.
Introduce two new helper functions to comedi_fc. These will be used
to help c
From: "Justin P. Mattock"
Signed-off-by: Justin P. Mattock
---
NOTE: Resend because the original created a new typo in the subject line.
The below patch fixes typos while reading through staging "wlags49_h2".
drivers/staging/wlags49_h2/README.ubuntu | 10 +-
drivers/staging/wlags49
Staging: silicom: Header cleanup of WD_STEP_COUNT_GET
Signed-off-by: Daniel Cotey
---
drivers/staging/silicom/bp_ioctl.h | 2 +-
drivers/staging/silicom/libbp_sd.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/silicom/bp_ioctl.h
b/drivers/staging/silicom/
Hi,
On Mon, Sep 10, 2012 at 11:31:42PM +0200, Peter Hüwe wrote:
> Am Montag, 10. September 2012, 23:15:18 schrieb Aaro Koskinen:
> > +#define XGI_CetLCD1400x1050Data XGI_CetLCD1280x1024Data
>
> Hi,
>
> why the define and not rewrite and maybe simplify the code?
> (that they use the same table)
Delete some redundant casts.
Signed-off-by: Aaro Koskinen
---
drivers/staging/xgifb/vb_setmode.c | 83 ---
1 files changed, 29 insertions(+), 54 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/staging/xgifb/vb_setmode.c
index ef8775e..e9
Am Montag, 10. September 2012, 23:15:18 schrieb Aaro Koskinen:
> Share the common data tables instead of having the same data in multiple
> tables.
>
> Signed-off-by: Aaro Koskinen
> ---
> drivers/staging/xgifb/vb_table.h | 37
> +++-- 1 files changed, 3 insertio
Use "else if" when possible to reduce nesting.
Signed-off-by: Aaro Koskinen
---
drivers/staging/xgifb/XGI_main_26.c |7 +-
drivers/staging/xgifb/vb_setmode.c | 164 +++
2 files changed, 74 insertions(+), 97 deletions(-)
diff --git a/drivers/staging/xgifb/XG
Mark some data tables as const.
Signed-off-by: Aaro Koskinen
---
drivers/staging/xgifb/vb_setmode.c |4 ++--
drivers/staging/xgifb/vb_table.h | 28 ++--
2 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/
Only table values 0..5 are ever used.
Signed-off-by: Aaro Koskinen
---
drivers/staging/xgifb/vb_setmode.c | 10 ++
1 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/staging/xgifb/vb_setmode.c
index a1ee4c1..c97e438 100644
--- a
Access some data tables directly instead of using pointers.
Signed-off-by: Aaro Koskinen
---
drivers/staging/xgifb/vb_setmode.c | 43 +++
drivers/staging/xgifb/vb_struct.h | 14 ---
2 files changed, 14 insertions(+), 43 deletions(-)
diff --git a/driv
Delete unneeded flag.
Signed-off-by: Aaro Koskinen
---
drivers/staging/xgifb/vb_init.c|2 --
drivers/staging/xgifb/vb_setmode.c |4 +---
drivers/staging/xgifb/vb_struct.h |1 -
3 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/xgifb/vb_init.c b/drive
There's a dangerous cast from XGI330_TVDataStruct to SiS_TVData. Use
SiS_TVData everywhere, also the data can be made const.
Signed-off-by: Aaro Koskinen
---
drivers/staging/xgifb/vb_setmode.c |9 +
drivers/staging/xgifb/vb_struct.h | 13 -
drivers/staging/xgifb/vb_tab
Delete an unused structure.
Signed-off-by: Aaro Koskinen
---
drivers/staging/xgifb/vb_struct.h |7 ---
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/xgifb/vb_struct.h
b/drivers/staging/xgifb/vb_struct.h
index 2eaeb26..3780a42 100644
--- a/drivers/staging
Replace DATAPTR numbers with a real pointer to make code simpler.
Signed-off-by: Aaro Koskinen
---
drivers/staging/xgifb/vb_setmode.c | 48 +---
drivers/staging/xgifb/vb_struct.h |2 +-
drivers/staging/xgifb/vb_table.h | 30 +++---
3 fil
Delete a flag which is never set.
Signed-off-by: Aaro Koskinen
---
drivers/staging/xgifb/vb_setmode.c | 14 --
drivers/staging/xgifb/vb_struct.h |1 -
2 files changed, 0 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/staging/xgifb/vb
All chip type values are covered by (chip >= XG20 || chip >= XG40).
Signed-off-by: Aaro Koskinen
---
drivers/staging/xgifb/vb_setmode.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/staging/xgifb/vb_setmode.c
index 3cba1
Use correct type to eliminate casting.
Signed-off-by: Aaro Koskinen
---
drivers/staging/xgifb/vb_setmode.c |6 +++---
drivers/staging/xgifb/vb_table.h |2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/staging/xgifb/vb_se
LCDLenList is redundant. It's only used for modifying a write-only stack
variable. Delete also related #defines.
Signed-off-by: Aaro Koskinen
---
drivers/staging/xgifb/vb_def.h | 10 --
drivers/staging/xgifb/vb_setmode.c | 11 +--
drivers/staging/xgifb/vb_table.h | 13
Delete unused Chrontel 7017 LCD data.
Signed-off-by: Aaro Koskinen
---
drivers/staging/xgifb/vb_setmode.c | 13 -
drivers/staging/xgifb/vb_table.h | 13 -
2 files changed, 0 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/s
IF_DEF_LCDA is always true.
Signed-off-by: Aaro Koskinen
---
drivers/staging/xgifb/vb_setmode.c | 102 +---
drivers/staging/xgifb/vb_struct.h |3 +-
2 files changed, 37 insertions(+), 68 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/driver
Only one TV data table is used by the driver, delete unneeded complexity.
Signed-off-by: Aaro Koskinen
---
drivers/staging/xgifb/vb_setmode.c | 150
1 files changed, 50 insertions(+), 100 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drive
Eliminate a trivial wrapper function.
Signed-off-by: Aaro Koskinen
---
drivers/staging/xgifb/vb_setmode.c | 39 +--
1 files changed, 6 insertions(+), 33 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/staging/xgifb/vb_setmode.c
index e81
Delete some unused #defines.
Signed-off-by: Aaro Koskinen
---
drivers/staging/xgifb/vb_def.h | 11 ---
1 files changed, 0 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/xgifb/vb_def.h b/drivers/staging/xgifb/vb_def.h
index 69078d9..609ab70 100644
--- a/drivers/staging/xgi
Delete unused Chrontel TV data.
Signed-off-by: Aaro Koskinen
---
drivers/staging/xgifb/vb_setmode.c |9 +++
drivers/staging/xgifb/vb_table.h | 45
2 files changed, 4 insertions(+), 50 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
Hi,
Continuing cleanups for xgifb deleting redundant code and some
refactoring.
No changes in functionality.
Static analysis done with checkpatch.pl (no errors/warnings), GCC 4.7.1
(no warnings), sparse 0.4.4 (no warnings).
Basic frame buffer console functionality tested with Z9/XG21 with LVDS
Document some delay values based on the comments in
XGI_XG21SetPanelDelay().
Signed-off-by: Aaro Koskinen
---
drivers/staging/xgifb/vb_struct.h |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/xgifb/vb_struct.h
b/drivers/staging/xgifb/vb_struct.h
i
Share the common data tables instead of having the same data in multiple
tables.
Signed-off-by: Aaro Koskinen
---
drivers/staging/xgifb/vb_table.h | 37 +++--
1 files changed, 3 insertions(+), 34 deletions(-)
diff --git a/drivers/staging/xgifb/vb_table.h b/driv
On Mon, Sep 10, 2012 at 10:51:39AM +0200, Samuel Iglesias Gonsálvez wrote:
> From: Jens Taprogge
>
> This saves us from a little pointer arithmetic and cleans up the code a bit.
>
> Signed-off-by: Jens Taprogge
> Signed-off-by: Samuel Iglesias Gonsálvez
> ---
> drivers/staging/ipack/bridges/t
Make some variables const:
1. bus oerations table
2. driver name
3. tpci control register table
Signed-off-by: Stephen Hemminger
---
Patch against current staging-next
drivers/staging/ipack/bridges/tpci200.c |6 ++
drivers/staging/ipack/ipack.c |4 ++--
drivers/stag
On Mon, Sep 10, 2012 at 09:04:26AM -0700, Justin P. Mattock wrote:
> From: "Justin P. Mattock"
>
> Signed-off-by: Justin P. Mattock
What's with the "NEXT" in the subject? That means I need to edit it by
hand :(
And, the main reason I'm rejecting this patch, you have a typo in your
subject lin
From: "Justin P. Mattock"
Signed-off-by: Justin P. Mattock
---
The below patch fixes typos while reading through staging "wlags49_h2".
drivers/staging/wlags49_h2/README.ubuntu | 10 +-
drivers/staging/wlags49_h2/TODO | 10 +-
drivers/staging/wlags49_h2/hcf.c
OR: "skb_put" [drivers/staging/ccg/g_ccg.ko] undefined!
ERROR: "eth_mac_addr" [drivers/staging/ccg/g_ccg.ko] undefined!
ERROR: "dev_get_stats" [drivers/staging/ccg/g_ccg.ko] undefined!
ERROR: "alloc_etherdev_mqs" [drivers/staging/ccg/g_ccg.ko] undefined!
Signed-off-by: Ra
On Mon 2012-09-03 08:06:02, Justin P. Mattock wrote:
> From: "Justin P. Mattock"
>
> Signed-off-by: Justin P. Mattock
ACK.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_
I just had a couple few style comments is all, nothing that couldn't
be fixed in a later patch.
On Mon, Sep 10, 2012 at 04:03:29PM +0800, wei_w...@realsil.com.cn wrote:
> +static int rts5209_extra_init_hw(struct rtsx_pcr *pcr)
> +{
> + return 0;
> +}
It would be nicer if the caller checked w
On Mon, Sep 10, 2012 at 05:25:43PM +0800, wwang wrote:
> 于 2012年09月10日 17:21, Dan Carpenter 写道:
> > These don't apply on top of linux-next. What do they apply on?
> >
> > regards,
> > dan carpenter
> >
> Hi Dan:
>
> These can be applied on torvalds's linux tree, tag v3.6-rc5, that is:
> http://gi
于 2012年09月10日 17:21, Dan Carpenter 写道:
> These don't apply on top of linux-next. What do they apply on?
>
> regards,
> dan carpenter
>
Hi Dan:
These can be applied on torvalds's linux tree, tag v3.6-rc5, that is:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=tag;h=refs/tags/v3.6-
These don't apply on top of linux-next. What do they apply on?
regards,
dan carpenter
___
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
From: Jens Taprogge
This way we do no longer need to keep a dangling pointer to struct
ipack_device in tpci200_slot after the device has been removed.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci200.c | 19 ---
As the IP module driver takes care of freeing its resources.
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci200.c |1 -
drivers/staging/ipack/ipack.h |3 ---
2 files changed, 4 deletions(-)
diff --git a/drivers/staging/ipack/bridges/tpci200.c
b
It is not needed as the IP module should free its IRQ using
tpci200_free_irq callback.
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci200.c | 24 +---
1 file changed, 1 insertion(+), 23 deletions(-)
diff --git a/drivers/staging/ipack/bridges
As the ipack_bus_unregister() takes care of unregistering the devices plugged
in the carrier, it is not needed to do it in the carrier driver.
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci200.c |7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff
Find the IP modules that are plugged to the carrier and unregister them.
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/ipack.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/staging/ipack/ipack.c b/drivers/staging/ipack/ipack.c
index b368a26..bf6
As the IRQ was requested by the driver, it should free it also.
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/devices/ipoctal.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/ipack/devices/ipoctal.c
b/drivers/staging/ipack/devices/ipoctal.c
index 2
The ipoctal devices can be uninstalled from the ipack_driver_unregister()
call as the device model calles the bus's .remove() function for each device
registered by the driver and it will execute the .remove() function of the
ipoctal driver.
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/s
1 - 100 of 117 matches
Mail list logo
