Replace printk(KERN_XXX with the appropiate dev_info, dev_warn, dev_dbg in
fl512.c
Signed-off-by: Bruce Humphrey Ventura
---
drivers/staging/comedi/drivers/fl512.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers/fl512.c
b/driver
Replace printk(KERN_XXX with dev_info, dev_warn, dev_dbg as appropiate in
dyna_pci10xx
Signed-off-by: Bruce Humphrey Ventura
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dyna
Commit 1b9f644dfeb638e0146ce54f4e48c87a2841a603 already got rid of
StringCopy and StringCmp, so remove the left over prototypes.
Signed-off-by: Davidlohr Bueso
---
drivers/staging/keucr/smcommon.h |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/keucr/smcommon.h b/drivers/
Add support for the Measurement Computing PCI-DIO96H board to the
generic 8255_pci driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/Kconfig| 3 ++-
drivers/staging/comedi/drivers/8255_pci.c | 8
2 files changed, 10 i
Move the support for the boards in the cb_pcidio driver to
the generic 8255_pci driver and remove the cb_pcidio driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/Kconfig | 11 +-
drivers/staging/comedi/drivers/8255_pci.c |
Due to the rename of this file, change all the adl_pci7296_* to
pci_8255_* so that everything has namespace associated with this
driver.
Also, fix the comedi description comment based on the rename of
the file. Remove the extra comment about the driver attach.
Modify the PCI_DEVICE_ID_* defines i
This driver will be used for all generic PCI based 8255 digital
i/o boards. Rename the driver accordingly..
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/Kconfig | 28 ++--
drivers/staging/comedi/drivers/8255_pci.c| 191 +++
Subject:
Make the adl_pci7296 driver into a generic pci based 8255 driver and
move the boards supported by the cb_pcidio driver into it.
H Hartley Sweeten (4):
staging: comedi: rename adl_pci7296 driver
staging: comedi: 8255_pci: fix namespace due to rename of driver
staging: comedi: remov
On embedded systems without a BIOS, the DRAM sizing register is 0 after
the boot, and the driver thinks we have only 1 MB video memory. On such
cases, use the PCI window size for the initial size. This information
is needed only to create the I/O mapping - the driver will later detect
and configure
The driver reconfigures DRAM size register to 8M (regardless what the
actual size was) once the init has been completed, overwriting the
correct value written during the early init. As a result if the driver
is unloaded and reloaded, the user will be limited to 8M video memory
and may lose some of
This is a resend of two remaining patches from previous series:
http://marc.info/?l=linux-driver-devel&m=134739997409387&w=2
The only change is that 1/2 has added #include . This
should resolve the build issue Greg was seeing on 64-bit. The build
error did not happen on 32-bit ARM which I
做�Na售要有�� 烈的企�D心―成功的欲s望.xls
Description: Binary data
___
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
On Wednesday 12 September 2012 10:26:00 Stephen Warren wrote:
> From: Stephen Warren
>
> Commit 6607bad "mfd: core: Push irqdomain mapping out into devices"
> added a new parameter to mfd_add_devices(), but missed updating the
> nvec driver in staging.
>
> Cc: Mark Brown
> Cc: Marc Dietrich
>
More define fixups
Signed-off-by: Daniel Cotey
---
drivers/staging/silicom/bp_mod.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/silicom/bp_mod.h b/drivers/staging/silicom/bp_mod.h
index 425085a..bc5ef43 100644
--- a/drivers/staging/silicom/bp_mo
Remove trailing spaces
Signed-off-by: Daniel Cotey
---
drivers/staging/silicom/libbp_sd.h | 54 +++---
1 file changed, 27 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/silicom/libbp_sd.h
b/drivers/staging/silicom/libbp_sd.h
index d223a6cf..8fc4006
Remove trailing spaces
Signed-off-by: Daniel Cotey
---
drivers/staging/silicom/bypass.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/silicom/bypass.h b/drivers/staging/silicom/bypass.h
index 28765f7..08fa7a0 100644
--- a/drivers/staging/silicom/bypass.h
More define fixups
Signed-off-by: Daniel Cotey
---
drivers/staging/silicom/bp_mod.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/silicom/bp_mod.h b/drivers/staging/silicom/bp_mod.h
index f59c061..b8275f5 100644
--- a/drivers/staging/silicom/bp_mo
More define fixups
Signed-off-by: Daniel Cotey
---
drivers/staging/silicom/bp_mod.h | 44
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/silicom/bp_mod.h b/drivers/staging/silicom/bp_mod.h
index 2862c57..f59c061 100644
---
More define fixups
Signed-off-by: Daniel Cotey
---
drivers/staging/silicom/bp_mod.h | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/silicom/bp_mod.h b/drivers/staging/silicom/bp_mod.h
index 3a97b2d..2862c57 100644
--- a/drive
More define fixups
Signed-off-by: Daniel Cotey
---
drivers/staging/silicom/bp_mod.h | 48
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/silicom/bp_mod.h b/drivers/staging/silicom/bp_mod.h
index 7b01f48..3a97b2d 100644
---
More define fixups
Signed-off-by: Daniel Cotey
---
drivers/staging/silicom/bp_mod.h | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/silicom/bp_mod.h b/drivers/staging/silicom/bp_mod.h
index a11b809..7b01f48 100644
--- a/drivers
More define fixups
Signed-off-by: Daniel Cotey
---
drivers/staging/silicom/bp_mod.h | 54
1 file changed, 27 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/silicom/bp_mod.h b/drivers/staging/silicom/bp_mod.h
index bc5ef43..a11b809 100644
---
More define fixups
Signed-off-by: Daniel Cotey
---
drivers/staging/silicom/bp_mod.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/silicom/bp_mod.h b/drivers/staging/silicom/bp_mod.h
index 61a12c2..425085a 100644
--- a/drivers/staging/silicom/bp_
Clean up spaces in defines
Signed-off-by: Daniel Cotey
---
drivers/staging/silicom/bp_mod.h | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/silicom/bp_mod.h b/drivers/staging/silicom/bp_mod.h
index 8c8cb95..61a12c2 100644
---
More define fixups
Signed-off-by: Daniel Cotey
---
drivers/staging/silicom/bp_mod.h | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/silicom/bp_mod.h b/drivers/staging/silicom/bp_mod.h
index c15d9d0..8c8cb95 100644
--- a/drivers/s
Fixup the define tabs and spaces
Signed-off-by: Daniel Cotey
---
drivers/staging/silicom/bp_mod.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/silicom/bp_mod.h b/drivers/staging/silicom/bp_mod.h
index 96c7780..c15d9d0 100644
--- a/drivers/s
This patch simplifies alloc_tx_struct and alloc_rx_struct in gdm_sdio.c
and gdm_usb.c by replacing kmalloc+memset with kzalloc and reorganizing
the code.
Signed-off-by: Ben Chan
---
drivers/staging/gdm72xx/gdm_sdio.c | 30
drivers/staging/gdm72xx/gdm_usb.c | 44
On Wed, Sep 12, 2012 at 10:57:33AM +0300, Dan Carpenter wrote:
> We don't need these to be world writable or group writable.
>
> Signed-off-by: Dan Carpenter
> ---
> This is linux-next stuff. The code in bp_proc.c is ifdefed out, and I
> wasn't able to compile it.
>
> diff --git a/drivers/stagi
On Wed, Sep 12, 2012 at 12:44:39AM +0300, Aaro Koskinen wrote:
> On embedded systems without a BIOS, the DRAM sizing register is 0 after
> the boot, and the driver thinks we have only 1 MB video memory. On such
> cases, use the PCI window size for the initial size. This information
> is needed only
From: Stephen Warren
Commit 6607bad "mfd: core: Push irqdomain mapping out into devices"
added a new parameter to mfd_add_devices(), but missed updating the
nvec driver in staging.
Cc: Mark Brown
Cc: Marc Dietrich
Signed-off-by: Stephen Warren
--
Samuel, I wonder if this patch should be squas
On 2012-09-12 03:00, Greg Kroah-Hartman (gre...@linuxfoundation.org) wrote:
On Tue, Sep 11, 2012 at 07:17:10PM -0500, H Hartley Sweeten wrote:
There are a couple comedi drivers for 8255 based I/O boards. They
are all virtually identical:
adl_pci7296.c supports 3 ADLink board types
cb_pcidio.c
From: Peter Senna Tschudin
Remove useless kfree() and clean up code related to the removal.
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
//
@r exists@
position p1,p2;
expression x;
@@
if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; }
@unchanged
From: Peter Senna Tschudin
Remove useless kfree() and clean up code related to the removal.
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
//
@r exists@
position p1,p2;
expression x;
@@
if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; }
@unchanged
On Wed, Sep 12, 2012 at 12:19:00PM +0300, Valentin, Eduardo wrote:
> Hello Dan,
>
> On Wed, Sep 12, 2012 at 11:26 AM, Dan Carpenter
> wrote:
> > On Wed, Sep 12, 2012 at 11:11:27AM +0300, Dan Carpenter wrote:
> >> On Tue, Sep 11, 2012 at 07:06:52PM +0300, Eduardo Valentin wrote:
> >> > From: J Kee
On Wed, Sep 12, 2012 at 04:36:19PM +0900, Toshiaki Yamane wrote:
> On Wed, Sep 12, 2012 at 4:08 AM, Greg Kroah-Hartman
> wrote:
> > On Tue, Sep 11, 2012 at 04:16:14PM +0900, Toshiaki Yamane wrote:
> >> The below checkpatch warnings was fixed,
> >>
> >> -WARNING: Prefer pr_info(... to printk(KERN_I
From: Jens Taprogge
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/devices/ipoctal.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/ipack/devices/ipoctal.c
b/drivers/staging/ipack/devices/ipoctal.c
index 4f79fad..0292
From: Jens Taprogge
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/bridges/tpci200.c | 10 +-
drivers/staging/ipack/bridges/tpci200.h |8
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/ipack
With the latest patches, the TODO file was outdated.
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/TODO | 25 ++---
1 file changed, 2 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/ipack/TODO b/drivers/staging/ipack/TODO
index b21d33a..ffa
The RX FIFO has a size of 3 characters. Check if when we are picking the
oldest one, we have more to read.
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/devices/ipoctal.c | 60 ++-
1 file changed, 36 insertions(+), 24 deletions(-)
diff --git a/
From: Jens Taprogge
Use tty_dev->dev's drdata to associate struct ipocal_channel to the
respective tty_struct.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/devices/ipoctal.c | 39 +++
1 file changed, 3 insertions
From: Jens Taprogge
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/devices/ipoctal.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ipack/devices/ipoctal.c
b/drivers/staging/ipack/devices/ipoctal.c
in
From: Jens Taprogge
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/devices/ipoctal.c |8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ipack/devices/ipoctal.c
b/drivers/staging/ipack/devices/ipoctal.c
From: Jens Taprogge
Make use of dev_set_drvdata() and dev_get_drvdata() to store and obtain
a pointer to the ipoctal struct corresponding to a struct dev.
Previously we relied on a private list of devices.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/stagi
From: Jens Taprogge
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/bridges/tpci200.c |2 +-
drivers/staging/ipack/bridges/tpci200.h |3 +--
drivers/staging/ipack/devices/ipoctal.c |2 +-
drivers/staging/ipack/ipack.h |4
From: Jens Taprogge
Now, all the interrupt related functions are next to each other.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/bridges/tpci200.c | 154 +++
1 file changed, 77 insertions(+), 77 deletions(-)
dif
From: Jens Taprogge
Minor cleanup. No functional changes.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/bridges/tpci200.c | 58 +--
1 file changed, 31 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/
From: Jens Taprogge
Rename __tpci_request_irq() to tpci_enable_irq() and __tpci_free_irq()
to tpci_disable_irq(). Change their second argument, move them above
tpci200_interrupt(), and use tpci_disable_irq() in the latter
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsalvez
-
From: Jens Taprogge
Previously the return value from tpci200_interrupt was not quite correct
if a slot had caused an interrupt but no handler was instellalled:
IRQ_NONE was returned. However in this case we react to the interrupt
by disabling the IPack device interrupt.
Basically there are two
From: Jens Taprogge
Split the IRQ service routing in TX part and RX part.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/devices/ipoctal.c | 188 ---
1 file changed, 97 insertions(+), 91 deletions(-)
diff --git a/d
From: Jens Taprogge
Some of the device registers are accessed from both interrupt and
non-interrupt context. To ensure proper read-modify-write modification
of these registers we can not use the "global" tpci200 mutex. Instead
a spin-lock is used.
Signed-off-by: Jens Taprogge
Signed-off-by:
From: Jens Taprogge
ipoctal_write_tty and ipoctal_write are merged.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/devices/ipoctal.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/ipack/dev
From: Jens Taprogge
In tpci200_request_irq as well as tpci200_free_irq we set and unset the
pointer to struct slot_irq. This pointer is accessed in
tpci200_interrupt. To ensure that the pointer is not freed after it has
been fetched in tpci200_interrupt() it is now protected through RCU.
Signe
From: Jens Taprogge
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/devices/ipoctal.c | 151 +--
1 file changed, 41 insertions(+), 110 deletions(-)
diff --git a/drivers/staging/ipack/devices/ipoctal.c
b/drivers/stag
From: Jens Taprogge
This way interrupt handling becomes independent of the channel number.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/devices/ipoctal.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff -
From: Jens Taprogge
By moving everything channel related into a separate struct we will be
able to clean up a lot of code. In the end tty->driver_data will no
longer need to point to ipoctal but instead can point to the respective
channel.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Igl
From: Jens Taprogge
Each tty's driver_data is now pointing to the channel it is talking to. struct
ipoctal_channel contains all the information the callbacks require to do their
work.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/devices/ipoc
From: Jens Taprogge
This also removes a possible bug in the unhandles_ints part when
slots[i] is not set.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/bridges/tpci200.c | 42 +--
1 file changed, 17 insertions(+),
From: Jens Taprogge
Use the __tpci200_{set,clear}_mask routines to access control
register. Do not overwrite flags unrelated to interrupt handling.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/bridges/tpci200.c | 31 ++-
From: Jens Taprogge
Convert tpci200_set_clockrate and tpci200_interrupt.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/bridges/tpci200.c | 49 ---
1 file changed, 32 insertions(+), 17 deletions(-)
diff --git a/dr
On Wed, 2012-09-12 at 14:28 +0200, Jens Taprogge wrote:
[...]
> Sam,
>
> can you please add the endianess-aware versions back? Patch attached.
>
> One of the earlier uses was not correct.
Done!
The patch will be submitted with the next batch.
Thanks,
Sam
signature.asc
Description: This i
On Wed, Sep 12, 2012 at 02:59:26PM +0300, Dan Carpenter wrote:
> On Wed, Sep 12, 2012 at 01:21:17PM +0200, Samuel Iglesias Gonsálvez wrote:
> > On Wed, 2012-09-12 at 14:13 +0300, Dan Carpenter wrote:
> > > On Wed, Sep 12, 2012 at 11:28:33AM +0200, Jens Taprogge wrote:
> > > > On Tue, Sep 11, 2012 a
On Wed, Sep 12, 2012 at 02:49:17PM +0300, Dan Carpenter wrote:
> > -static int download_image(struct usb_device *usbdev, struct file *filp,
> > - loff_t *pos, u32 img_len, u32 magic_num)
> > +static int download_image(struct usb_device *usbdev,
> > +
On Wed, Sep 12, 2012 at 01:21:17PM +0200, Samuel Iglesias Gonsálvez wrote:
> On Wed, 2012-09-12 at 14:13 +0300, Dan Carpenter wrote:
> > On Wed, Sep 12, 2012 at 11:28:33AM +0200, Jens Taprogge wrote:
> > > On Tue, Sep 11, 2012 at 11:47:02AM +0300, Dan Carpenter wrote:
> > > > > +static int tpci200_
On Wed, Sep 12, 2012 at 02:13:30PM +0300, Dan Carpenter wrote:
> On Wed, Sep 12, 2012 at 11:28:33AM +0200, Jens Taprogge wrote:
> > On Tue, Sep 11, 2012 at 11:47:02AM +0300, Dan Carpenter wrote:
> > > > +static int tpci200_get_clockrate(struct ipack_device *dev)
> > > > +{
> > > > + struct tp
On Wed, Sep 12, 2012 at 05:49:23PM +0800, Macpaul Lin wrote:
> 1. Replace file I/O of reading firmware by request_firmware().
> 2. Coding style clean up.
>
This should be two patches. It makes it easier to discuss the
parts. There is a bug in em_download_image() so these patches will
need to be
On Wed, 2012-09-12 at 14:13 +0300, Dan Carpenter wrote:
> On Wed, Sep 12, 2012 at 11:28:33AM +0200, Jens Taprogge wrote:
> > On Tue, Sep 11, 2012 at 11:47:02AM +0300, Dan Carpenter wrote:
> > > > +static int tpci200_get_clockrate(struct ipack_device *dev)
> > > > +{
> > > > + struct tpci200_b
On Wed, Sep 12, 2012 at 11:28:33AM +0200, Jens Taprogge wrote:
> On Tue, Sep 11, 2012 at 11:47:02AM +0300, Dan Carpenter wrote:
> > > +static int tpci200_get_clockrate(struct ipack_device *dev)
> > > +{
> > > + struct tpci200_board *tpci200 = check_slot(dev);
> > > + __le16 __iomem *addr;
> >
> >
gdm_usb.* coding style clean up.
Signed-off-by: Macpaul Lin
Cc: Paul Stewart
Cc: Ben Chan
Cc: Sage Ahn
Cc: Greg Kroah-Hartman
---
drivers/staging/gdm72xx/gdm_usb.c | 10 +-
drivers/staging/gdm72xx/gdm_usb.h | 16
2 files changed, 13 insertions(+), 13 deletions(-)
di
1. Replace file I/O of reading firmware by request_firmware().
2. Coding style clean up.
Signed-off-by: Macpaul Lin
Cc: Paul Stewart
Cc: Ben Chan
Cc: Sage Ahn
Cc: Greg Kroah-Hartman
---
drivers/staging/gdm72xx/usb_boot.c | 207 ++---
1 file changed, 99 inserti
On Tue, Sep 11, 2012 at 11:47:02AM +0300, Dan Carpenter wrote:
>
> I had a few style comments on this patchset. Nothing that couldn't
> be fixed later.
>
> On Mon, Sep 10, 2012 at 10:51:41AM +0200, Samuel Iglesias Gonsálvez wrote:
> > From: Jens Taprogge
> >
> > Provide get_clockrate, set_cloc
Hello Dan,
On Wed, Sep 12, 2012 at 11:26 AM, Dan Carpenter
wrote:
> On Wed, Sep 12, 2012 at 11:11:27AM +0300, Dan Carpenter wrote:
>> On Tue, Sep 11, 2012 at 07:06:52PM +0300, Eduardo Valentin wrote:
>> > From: J Keerthy
>> >
>> > Removes checkpatch warnings on omap-bandgap.c.
>> >
>>
>> Which c
On Wed, Sep 12, 2012 at 11:11:27AM +0300, Dan Carpenter wrote:
> On Tue, Sep 11, 2012 at 07:06:52PM +0300, Eduardo Valentin wrote:
> > From: J Keerthy
> >
> > Removes checkpatch warnings on omap-bandgap.c.
> >
>
> Which checkpatch.pl warnings?
>
> > + omap_bandgap_wri
On Tue, Sep 11, 2012 at 07:06:52PM +0300, Eduardo Valentin wrote:
> From: J Keerthy
>
> Removes checkpatch warnings on omap-bandgap.c.
>
Which checkpatch.pl warnings?
> + omap_bandgap_writel(bg_ptr,
> + rval->tshut_threshold,
> +
We don't need these to be world writable or group writable.
Signed-off-by: Dan Carpenter
---
This is linux-next stuff. The code in bp_proc.c is ifdefed out, and I
wasn't able to compile it.
diff --git a/drivers/staging/silicom/bp_proc.c
b/drivers/staging/silicom/bp_proc.c
index 4fe862d..6ad4b2
On Wed, Sep 12, 2012 at 4:08 AM, Greg Kroah-Hartman
wrote:
> On Tue, Sep 11, 2012 at 04:16:14PM +0900, Toshiaki Yamane wrote:
>> The below checkpatch warnings was fixed,
>>
>> -WARNING: Prefer pr_info(... to printk(KERN_INFO, ...
>> -WARNING: Prefer pr_warn(... to printk(KERN_WARNING, ...
>> -WARN
75 matches
Mail list logo
