If you tried to cat more than 255 characters (the last character is for
the terminator) to these proc files then it would corrupt kernel memory.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/silicom/bp_mod.c b/drivers/staging/silicom/bp_mod.c
index 6e999c7..1b3f5e7 100644
--- a/drive
Replace firmware upgrade API in em_download_image().
Signed-off-by: Macpaul Lin
Cc: Paul Stewart
Cc: Ben Chan
Cc: Sage Ahn
Cc: Greg Kroah-Hartman
Cc: Dan Carpenter
---
Changes for v2:
- Correction the procedure in em_download_image() and usb_emergency()
- keep "goto out" in em_download_i
On Wed, Sep 12, 2012 at 10:26:00AM -0600, Stephen Warren wrote:
> From: Stephen Warren
>
> Commit 6607bad "mfd: core: Push irqdomain mapping out into devices"
> added a new parameter to mfd_add_devices(), but missed updating the
> nvec driver in staging.
>
> Cc: Mark Brown
> Cc: Marc Dietrich
commit 6788d7dab6a5 ("Staging: bcm: Use udelay instead of msleep for
delays in nvm.c") replaces msleep with udelay values. udelay values
of more than 1000 should be replaced by mdelay instead.
This fixes following build error.
ERROR: "__bad_udelay" [drivers/staging/bcm/bcm_wimax.ko] undefined!
mak
On Fri, Sep 14, 2012 at 10:02:49AM +0800, Macpaul Lin wrote:
> Hi Ben,
>
> 2012/9/14 Ben Chan :
> > Hi Macpaul,
> >
> > Thanks for the patch. Some comments inlined.
> >
> > I briefly tested the patch on hardware and it seemed to work fine.
> >
> > - Ben
>
> Thanks for your comment and testing on
On Wed, Sep 12, 2012 at 08:10:11PM -0700, Daniel Cotey wrote:
> Fixup the define tabs and spaces
>
> Signed-off-by: Daniel Cotey
This patch doesn't apply properly, there's some fuzz, did you do it
against the right tree?
Also, all of your subjects need some work. What's with the "2", "3",
and
Hi Ben,
2012/9/14 Ben Chan :
> Hi Macpaul,
>
> Thanks for the patch. Some comments inlined.
>
> I briefly tested the patch on hardware and it seemed to work fine.
>
> - Ben
Thanks for your comment and testing on these patches.
I think Greg could pick up the previous 2 patches at first if there is
This patch converts INT to int in Transmit.c
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/Transmit.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm/Transmit.c b/drivers/staging/bcm/Transmit.c
index adf545f..27e8c89 100644
--- a/drivers/sta
This patch properly formats comments
as reported by checkpatch.pl.
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/Transmit.c | 92
1 file changed, 46 insertions(+), 46 deletions(-)
diff --git a/drivers/staging/bcm/Transmit.c b/drivers/staging/bc
This patch Remove initialization from
if statement in Transmit.c as reported
by checkpatch.pl.
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/Transmit.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/bcm/Transmit.c b/drivers/staging/bcm/Transmit.c
This patch cuddles braces as reported
by checkpatch.pl.
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/Transmit.c | 53 +---
1 file changed, 17 insertions(+), 36 deletions(-)
diff --git a/drivers/staging/bcm/Transmit.c b/drivers/staging/bcm/Transmit.
This patch fixes all white space issues
as reported by checkpatch.pl.
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/Transmit.c | 116 +++-
1 file changed, 56 insertions(+), 60 deletions(-)
diff --git a/drivers/staging/bcm/Transmit.c b/drivers/staging
On Thu, 2012-09-13 at 22:17 +0300, Dan Carpenter wrote:
> If it weren't in staging-next then, yeah, it probably would have
> been better to resend those two patches. You could send them by
> themselves without resending any of the others. But once they hit
> staging-next, it's too late.
>
> No
On Thu, Sep 13, 2012 at 08:43:46PM +0200, Jens Taprogge wrote:
> On Thu, Sep 13, 2012 at 11:19:17AM -0700, Joe Perches wrote:
> > On Thu, 2012-09-13 at 20:49 +0300, Dan Carpenter wrote:
> > > On Thu, Sep 13, 2012 at 08:43:12PM +0300, Dan Carpenter wrote:
> > > > On Wed, Sep 12, 2012 at 02:55:29PM +
Hi Macpaul,
Thanks for the patch. Some comments inlined.
I briefly tested the patch on hardware and it seemed to work fine.
- Ben
On Thu, Sep 13, 2012 at 3:11 AM, Macpaul Lin wrote:
>
> Replace firmware upgrade API in em_download_image().
>
> Signed-off-by: Macpaul Lin
> Cc: Paul Stewart
> C
last of the unstylistic pointers cleaned up
Signed-off-by: Daniel Cotey
---
drivers/staging/silicom/bp_mod.c | 70
1 file changed, 35 insertions(+), 35 deletions(-)
diff --git a/drivers/staging/silicom/bp_mod.c b/drivers/staging/silicom/bp_mod.c
index ad
More pointer style cleanup
Signed-off-by: Daniel Cotey
---
drivers/staging/silicom/bp_mod.c | 82
1 file changed, 41 insertions(+), 41 deletions(-)
diff --git a/drivers/staging/silicom/bp_mod.c b/drivers/staging/silicom/bp_mod.c
index ac5427d..adaa715 10
more checkpatch cleanups of pointers.
Signed-off-by: Daniel Cotey
---
drivers/staging/silicom/bp_mod.c | 66
1 file changed, 33 insertions(+), 33 deletions(-)
diff --git a/drivers/staging/silicom/bp_mod.c b/drivers/staging/silicom/bp_mod.c
index debe242.
More pointer style cleanup
Signed-off-by: Daniel Cotey
---
drivers/staging/silicom/bp_mod.c | 66
1 file changed, 33 insertions(+), 33 deletions(-)
diff --git a/drivers/staging/silicom/bp_mod.c b/drivers/staging/silicom/bp_mod.c
index 37e96d3..debe242 10
More notation fixes
Signed-off-by: Daniel Cotey
---
drivers/staging/silicom/bp_mod.c | 64
1 file changed, 32 insertions(+), 32 deletions(-)
diff --git a/drivers/staging/silicom/bp_mod.c b/drivers/staging/silicom/bp_mod.c
index 28d9595..37e96d3 100644
--
straighten up the pointer notation
Signed-off-by: Daniel Cotey
---
drivers/staging/silicom/bp_mod.c | 46
1 file changed, 23 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/silicom/bp_mod.c b/drivers/staging/silicom/bp_mod.c
index 70425c7..28
checkpatch fixups
Signed-off-by: Daniel Cotey
---
drivers/staging/silicom/bp_mod.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/silicom/bp_mod.c b/drivers/staging/silicom/bp_mod.c
index 0d96196..70425c7 100644
--- a/drivers/staging/silicom/bp_mod.c
+++
On Thu, Sep 13, 2012 at 11:19:17AM -0700, Joe Perches wrote:
> On Thu, 2012-09-13 at 20:49 +0300, Dan Carpenter wrote:
> > On Thu, Sep 13, 2012 at 08:43:12PM +0300, Dan Carpenter wrote:
> > > On Wed, Sep 12, 2012 at 02:55:29PM +0200, Samuel Iglesias Gonsalvez wrote:
> > > > From: Jens Taprogge
> >
Finish trailing spaces in libbp_sd.h
Signed-off-by: Daniel Cotey
---
drivers/staging/silicom/libbp_sd.h | 52 +++---
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/silicom/libbp_sd.h
b/drivers/staging/silicom/libbp_sd.h
index cba9
Whack all the line ending spaces so checkpatch.pl is happy.
Signed-off-by: Daniel Cotey
---
drivers/staging/silicom/libbp_sd.h | 142 ++---
1 file changed, 71 insertions(+), 71 deletions(-)
diff --git a/drivers/staging/silicom/libbp_sd.h
b/drivers/staging/silico
On Thu, 2012-09-13 at 20:49 +0300, Dan Carpenter wrote:
> On Thu, Sep 13, 2012 at 08:43:12PM +0300, Dan Carpenter wrote:
> > On Wed, Sep 12, 2012 at 02:55:29PM +0200, Samuel Iglesias Gonsalvez wrote:
> > > From: Jens Taprogge
> > >
> > > This way interrupt handling becomes independent of the chan
On Thu, Sep 13, 2012 at 08:43:12PM +0300, Dan Carpenter wrote:
> On Wed, Sep 12, 2012 at 02:55:29PM +0200, Samuel Iglesias Gonsalvez wrote:
> > From: Jens Taprogge
> >
> > This way interrupt handling becomes independent of the channel number.
> >
> > Signed-off-by: Jens Taprogge
> > Signed-off-
The following changes since commit fea7a08acb13524b47711625eebea40a0ede69a0:
Linux 3.6-rc3 (2012-08-22 13:29:06 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-3.6-rc6
for you to fetch changes up to 94254edc9c5b4
On Wed, Sep 12, 2012 at 02:55:29PM +0200, Samuel Iglesias Gonsalvez wrote:
> From: Jens Taprogge
>
> This way interrupt handling becomes independent of the channel number.
>
> Signed-off-by: Jens Taprogge
> Signed-off-by: Samuel Iglesias Gonsalvez
> ---
> @@ -213,7 +206,7 @@ static int ipoctal
The 8255 based boards in the ni_pcidio driver are all simple
memory mapped 8255 boards that don't require the dma support
provided by the mite driver.
Move the support for these boards from the ni_pcidio driver to
the generic 8255_pci driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc:
Some of the PCI based 8255 boards that can be supported by this driver
use memory mapped i/o. Add the code needed to support these boards.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/8255_pci.c | 46 +--
Add support to the 8255_pci driver for memory mapped i/o boards and
move the 8255 based ni_pcidio boards to this driver.
H Hartley Sweeten (2):
staging: comedi: 8255_pci: support memory mapped i/o boards
staging: comedi: 8255_pci: move ni_pcidio 8255 board support
drivers/staging/comedi/Kcon
the ccg_bind_function uses ret variable and a logic around the
ccg_bind_enabled_functions to return a value other than 0 if
bind function fail, other wise returns 0, this can be achieved
with just a return ccg_bind_enabled_functions(dev, c);
Signed-off-by: Devendra Naga
---
drivers/staging/ccg/c
we do class_create and call kmalloc to allocate dev pointer,
and if kmalloc fail we forget destoying class
Signed-off-by: Devendra Naga
---
drivers/staging/ccg/ccg.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ccg/ccg.c b/drivers/staging/ccg/ccg.c
in
This driver supports PCI boards from multiple vendors. It's
possible for boards from different vendors to have the same
device id.
Add the vendor id to the boardinfo so pci_8255_find_boardinfo()
matches the pci_dev to the correct boardinfo.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Gr
On Thursday, September 13, 2012 3:05 AM, Ian Abbott wrote:
> On 2012-09-12 23:37, H Hartley Sweeten wrote:
>> Move the support for the boards in the cb_pcidio driver to
>> the generic 8255_pci driver and remove the cb_pcidio driver.
>>
>> Signed-off-by: H Hartley Sweeten
>> Cc: Ian Abbott
>> Cc:
On Thu, Sep 13, 2012 at 04:46:02PM +0200, Bruce Humphrey wrote:
> Thanks for all the comments!
>
> My own answers are from the complete linux kernel newbie point of view!
> That's why I'm writing them even if they seem obvious, to make sure.
>
> > data[n] = 0;
> > > - p
Am 12.09.2012 17:06, schrieb Peter Senna Tschudin:
> From: Peter Senna Tschudin
>
> Remove useless kfree() and clean up code related to the removal.
>
> The semantic patch that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> //
> @r exists@
> position p1,p2;
> expression
Clear the BREAK flag from the ISR register. Doing that, we avoid to read
the same condition for the next character received.
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/devices/ipoctal.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/ipack/devices/i
Remove count_wr and the assigment of nb_bytes = 0 in that function as is
useless. Now it returns the count of the characters actually sent.
There is other nb_bytes = 0 deleted that has a duplicate a few lines before.
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/devices/ipo
On Thu, 2012-09-13 at 13:01 +0300, Dan Carpenter wrote:
> On Thu, Sep 13, 2012 at 11:46:26AM +0200, Samuel Iglesias Gonsalvez wrote:
> > From: Jens Taprogge
> >
> > The field irq currently is identical to the slot number. It does not seem
> > to
> > have any real use. The number is written to
From: Jens Taprogge
The field irq currently is identical to the slot number. It does not seem to
have any real use. The number is written to hardware in ipoctal but it seems
the value that is written does not matter.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsalvez
---
From: Jens Taprogge
This will allow us to correctly access the IPack INT space.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/bridges/tpci200.c | 29 +
drivers/staging/ipack/bridges/tpci200.h |2 ++
drivers/st
From: Jens Taprogge
Now the IPack device acknowledges its own IRQ.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/bridges/tpci200.c |4
drivers/staging/ipack/devices/ipoctal.c | 19 +--
drivers/staging/ipack/devices/s
Replace firmware upgrade API in em_download_image().
Signed-off-by: Macpaul Lin
Cc: Paul Stewart
Cc: Ben Chan
Cc: Sage Ahn
Cc: Greg Kroah-Hartman
Cc: Dan Carpenter
---
Changes for v2:
- Correction the procedure in em_download_image() and usb_emergency()
- keep "goto out" in em_download_i
Replace file I/O of reading firmware usb_boot()
by request_firmware().
Signed-off-by: Macpaul Lin
---
Changes for v2:
- Split coding style clean up into another patch.
- Split fixing for em_download_image() to another patch.
- Refine procedure in download_image() makes eaiser to be understa
1. Coding style re-formatting (tabs).
2. Remove unused MIN() marco.
Signed-off-by: Macpaul Lin
Cc: Paul Stewart
Cc: Ben Chan
Cc: Sage Ahn
Cc: Greg Kroah-Hartman
Cc: Dan Carpenter
---
drivers/staging/gdm72xx/usb_boot.c | 36 +---
1 file changed, 17 insertions(
On Thu, 2012-09-13 at 13:02 +0300, Dan Carpenter wrote:
> On Thu, Sep 13, 2012 at 11:46:27AM +0200, Samuel Iglesias Gonsalvez wrote:
> > Clear the BREAK flag from the ISR register.
> >
> > Signed-off-by: Samuel Iglesias Gonsalvez
>
> What are the user visible effects of this bugfix?
>
It clear
On 2012-09-12 23:37, H Hartley Sweeten wrote:
Move the support for the boards in the cb_pcidio driver to
the generic 8255_pci driver and remove the cb_pcidio driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/Kconfig | 11 +
On Thu, Sep 13, 2012 at 11:46:27AM +0200, Samuel Iglesias Gonsalvez wrote:
> Clear the BREAK flag from the ISR register.
>
> Signed-off-by: Samuel Iglesias Gonsalvez
What are the user visible effects of this bugfix?
regards,
dan carpenter
___
devel m
On Thu, Sep 13, 2012 at 11:46:26AM +0200, Samuel Iglesias Gonsalvez wrote:
> From: Jens Taprogge
>
> The field irq currently is identical to the slot number. It does not seem to
> have any real use. The number is written to hardware in ipoctal but it seems
> the value that is written does not m
From: Jens Taprogge
Now the IPack device acknowledges its own IRQ.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/bridges/tpci200.c |4
drivers/staging/ipack/devices/ipoctal.c | 19 +--
drivers/staging/ipack/devices/s
From: Jens Taprogge
This will allow us to correctly access the IPack INT space.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/bridges/tpci200.c | 29 +
drivers/staging/ipack/bridges/tpci200.h |2 ++
drivers/st
Clear the BREAK flag from the ISR register.
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/devices/ipoctal.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/ipack/devices/ipoctal.c
b/drivers/staging/ipack/devices/ipoctal.c
index 0fd0e01..5f4545a 100644
From: Jens Taprogge
The field irq currently is identical to the slot number. It does not seem to
have any real use. The number is written to hardware in ipoctal but it seems
the value that is written does not matter.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsalvez
---
Remove count_wr and the assigment of nb_bytes = 0 in that function as is
useless. Now it returns the count of the characters actually sent.
There is other nb_bytes = 0 deleted that has a duplicate a few lines before.
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/ipack/devices/ipo
this removes the remaining return which the function actually
wants to return, for that it used goto failed and failed lable
have the return statement at the end of function, which is all
unnecessary, remove this and make the function return at the
places where it does the goto failed
Signed-off-b
else is not required as such we can do with just with a single if
Signed-off-by: Devendra Naga
---
drivers/staging/wlan-ng/hfa384x_usb.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
b/drivers/staging/wlan-ng/hfa38
this file is having all unnecessary return statements at the end of functions
which return void, remove all of them.
some of the functions still uses the return for having the goto end,
which the label end defined at the end of the function which returns
void, this will be cleaned up in next chang
this is because this function does a deinit job and most of the
deinit functions are expected to return void. Also this function
doesn't fail anywhere..
Signed-off-by: Devendra Naga
---
drivers/staging/wlan-ng/p80211netdev.c |6 +-
drivers/staging/wlan-ng/p80211netdev.h |2 +-
2 file
On Thu, Sep 13, 2012 at 03:46:36AM +0200, Bruce Humphrey wrote:
> Replace printk(KERN_XXX with the appropiate dev_info, dev_warn, dev_dbg in
> fl512.c
>
> Signed-off-by: Bruce Humphrey Ventura
> ---
> drivers/staging/comedi/drivers/fl512.c | 12 +++-
> 1 file changed, 7 insertions(+),
On Thu, Sep 13, 2012 at 03:46:00AM +0200, Bruce Humphrey wrote:
> Replace printk(KERN_XXX with dev_info, dev_warn, dev_dbg as appropiate in
> dyna_pci10xx
>
> Signed-off-by: Bruce Humphrey Ventura
> ---
> drivers/staging/comedi/drivers/dyna_pci10xx.c | 14 ++
> 1 file changed, 6 i
62 matches
Mail list logo
