Re: [PATCH v6 0/3] Add modules to support realtek PCIE card reader

2012-10-25 Thread wwang
于 2012年10月26日 10:45, Greg KH 写道: On Fri, Oct 26, 2012 at 09:10:45AM +0800, wwang wrote: 于 2012年10月26日 02:50, Greg KH 写道: On Sat, Oct 20, 2012 at 06:46:15AM +0300, Dan Carpenter wrote: On Sat, Oct 06, 2012 at 03:23:56PM +0800, wwang wrote: We are still maintaining the SCSI driver for Realtek c

Re: [PATCH v6 0/3] Add modules to support realtek PCIE card reader

2012-10-25 Thread Greg KH
On Fri, Oct 26, 2012 at 09:10:45AM +0800, wwang wrote: > 于 2012年10月26日 02:50, Greg KH 写道: > > On Sat, Oct 20, 2012 at 06:46:15AM +0300, Dan Carpenter wrote: > >> On Sat, Oct 06, 2012 at 03:23:56PM +0800, wwang wrote: > >>> We are still maintaining the SCSI driver for Realtek card reader, > >>> and

Re: [PATCH v6 0/3] Add modules to support realtek PCIE card reader

2012-10-25 Thread wwang
于 2012年10月26日 02:50, Greg KH 写道: > On Sat, Oct 20, 2012 at 06:46:15AM +0300, Dan Carpenter wrote: >> On Sat, Oct 06, 2012 at 03:23:56PM +0800, wwang wrote: >>> We are still maintaining the SCSI driver for Realtek card reader, >>> and will release the latest source code in the Github in the future.

产权多元化和建立有效均衡的公司治理结构

2012-10-25 Thread B
devel@driverdev.osuosl.orgcdsjt2654n[¹É Ȩ ¼¤ Àø ²Ù ×÷ ʵ Îñ] eth2竞(争性行 业与传统制造业激)励方式的区别b1f.xls Description: Binary data ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

[PATCH 12/12] staging: comedi: dt3000: change return type of dt3k_send_cmd to void

2012-10-25 Thread H Hartley Sweeten
None of the callers check the return value. Just make it a void. Flip the status check at the end of the function to check for an error before outputing the dev_dbg(). Use __func__ for the function name in the message. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman ---

[PATCH 11/12] staging: comedi: dt3000: remove empty 'else' code

2012-10-25 Thread H Hartley Sweeten
There are a number of: } else { /* not supported */ } cases in this driver. Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt3000.c | 14 ++ 1 file changed, 2 insertions(+), 12

[PATCH 10/12] staging: comedi: dt3000: remove dev_dbg() noise

2012-10-25 Thread H Hartley Sweeten
Remove most of the dev_dbg() output from this driver. Most of it is just noise. For now I have left the dev_dbg() in the dt3k_send_cmd() function. I still have not quite figured out how the low-level i/o works in this driver... Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hart

[PATCH 09/12] staging: comedi: dt3000: add some whitespace to the subdevice init

2012-10-25 Thread H Hartley Sweeten
To improve the readability, add some whitespace to the subdevice init. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt3000.c | 67 - 1 file changed, 33 insertions(+), 34 deletions(-) diff --git a/driv

[PATCH 08/12] staging: comedi: dt3000: add a simple dev_info() when attached

2012-10-25 Thread H Hartley Sweeten
When the board is finished with the attach output a simple dev_info() message. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt3000.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/comedi/drivers/dt3000.c b/dri

[PATCH 07/12] staging: comedi: dt3000: cleanup the boardinfo

2012-10-25 Thread H Hartley Sweeten
Add some whitespace to make the code more readable. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt3000.c | 124 1 file changed, 62 insertions(+), 62 deletions(-) diff --git a/drivers/staging/comedi/

[PATCH 06/12] staging: comedi: dt3000: remove '0' entries in boardinfo

2012-10-25 Thread H Hartley Sweeten
These entries will default to '0'. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt3000.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/dt3000.c b/drivers/staging/comedi/drivers/dt3000.c index 28

[PATCH 05/12] staging: comedi: dt3000: remove forward declarations

2012-10-25 Thread H Hartley Sweeten
Move some of the functions to remove the need for the forward declarations. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt3000.c | 184 +++- 1 file changed, 87 insertions(+), 97 deletions(-) diff --git a

[PATCH 04/12] staging: comedi: dt3000: add defines for the PCI device ids

2012-10-25 Thread H Hartley Sweeten
The PCI device ids supported by this driver are used multiple places in the code. To improve maintainability, create #define's for them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt3000.c | 39 + 1

[PATCH 03/12] staging: comedi: dt3000: cleanup the range tables

2012-10-25 Thread H Hartley Sweeten
Use the BIP_RANGE() macro instead of the more generic RANGE() macro. Cleanup the whitespace. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt3000.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) d

[PATCH 02/12] staging: comedi: dt3000: convert driver to attach_pci

2012-10-25 Thread H Hartley Sweeten
Convert this driver to use the comedi PCI auto config mechanism by adding an attach_pci callback. Since this driver requires no extra configuration options, and the attach callback is now optional, remove it. Remove the kernel noise that is output when the attach fails for various reasons. Use t

[PATCH 01/12] staging: comedi: dt3000: remove this_board macro

2012-10-25 Thread H Hartley Sweeten
This macro relies on a local variable having a specific name. Remove it and use the comedi_board() helper to get the pointer. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt3000.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletio

[PATCH 00/12] staging: comedi: dt3000: cleanup the driver

2012-10-25 Thread H Hartley Sweeten
Start cleaning up this driver. H Hartley Sweeten (12): staging: comedi: dt3000: remove this_board macro staging: comedi: dt3000: convert driver to attach_pci staging: comedi: dt3000: cleanup the range tables staging: comedi: dt3000: add defines for the PCI device ids staging: comedi: dt3

给应聘者一个好印象:规范的企业面试流程

2012-10-25 Thread s
irf3任]职资格及薪]酬调整bje.xls Description: Binary data ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

RE: [PATCH 0/9] staging: comedi: update auto-attach mechanism

2012-10-25 Thread H Hartley Sweeten
On Thursday, October 25, 2012 10:03 AM, Ian Abbott wrote: > On 2012-10-25 17:19, Greg Kroah-Hartman wrote: >> On Thu, Oct 25, 2012 at 03:02:37PM +0100, Ian Abbott wrote: >>> Okay, I'm just looking for a final decision before redoing the >>> patches (if necessary). >>> >>> (1) Should drivers calling

RE: staging: comedi: me_daq: store the pci_dev in the comedi_device

2012-10-25 Thread H Hartley Sweeten
On Tuesday, October 23, 2012 7:04 AM, Dan Carpenter wrote: > > Hello H Hartley Sweeten, > > This is a semi-automatic email about new static checker warnings. > > The patch 27034e8ace5a: "staging: comedi: me_daq: store the pci_dev > in the comedi_device" from Jul 18, 2012, leads to the following

[PATCH 22/23] staging: comedi: me_daq: cleanup me_ai_insn_read()

2012-10-25 Thread H Hartley Sweeten
Fix the use of insn->chanspec with the CR_CHAN, CR_RANGE, and CR_AREF macros. insn->chanspec is an unsigned int not an array. Cleanup the comments when creating the 'val' to write to the channel list fifo so that the code is a bit more readable. Use the 'val' variable when getting the value from

[PATCH 23/23] staging: comedi: me_daq: remove some obvious comments

2012-10-25 Thread H Hartley Sweeten
These comments are just extra cruft. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/me_daq.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/drivers/staging/comedi/drivers/me_daq.c b/drivers/staging/comedi/drive

[PATCH 21/23] staging: comedi: me_daq: cleanup me_dio_insn_bits()

2012-10-25 Thread H Hartley Sweeten
This function only needs to update the output channel state when the 'mask' (data[0]) indicates that the state is changing. It's also supposed to return the state for all the input and output channels in data[1]. This function appears to work correctly but it's coded quite differently form the oth

[PATCH 20/23] staging: comedi: me_daq: fix me_dio_insn_config()

2012-10-25 Thread H Hartley Sweeten
Currently this function does not work like the comedi code expects. Fix the function so that it checks the instruction, data[0], and does the correct action based on it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/me_daq.c | 57 +++

[PATCH 19/23] staging: comedi: me_daq: simplify analog output boardinfo

2012-10-25 Thread H Hartley Sweeten
The boards supported by this driver either have analog outputs or don't have them. Add a new boardinfo value, 'has_ao', to indicate this. The boards that have analog outputs always have 4, 12-bit channels. Remove the unnecessary boardinfo and just open-code the values in the subdevice initializati

[PATCH 18/23] staging: comedi: me_daq: all boards have the same analog input specs

2012-10-25 Thread H Hartley Sweeten
All the boards supported by this driver have the same analog input specifications. Remove the unnecessary boardinfo and just open-code the values in the subdevice initialization. The boards also share the same analog input range capabilities. Remove one of the duplicate tables and rename the other

[PATCH 16/23] staging: comedi: me_daq: remove incomplete analog input command support

2012-10-25 Thread H Hartley Sweeten
The analog input subdevice functions me_ai_do_cmd_test() and me_ai_do_cmd() are only stubbed in. They both just return 0. The me_ai_cancel() function does have code to stop any running conversions but the me_ai_insn_read() function does that also. Just remove the incomplete functions and remove S

[PATCH 17/23] staging: comedi: me_daq: cleanup the copyright and comedi comments

2012-10-25 Thread H Hartley Sweeten
Reformat the copyright and driver description comments to follow the preferred block comment style. Reword the driver description to follow comedi style described in the skel driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/me_da

[PATCH 15/23] staging: comedi: me_daq: fix me_ao_insn_write()

2012-10-25 Thread H Hartley Sweeten
This function is supposed to write to a single analog output channel. The channel number is packed in insn->chanspec, which is an unsigned int, and unpacked using the CR_CHAN() macro. Currently this function is trying to use the chanspec as an array. This works only if a single value is written.

[PATCH 14/23] staging: comedi: me_daq: fix me_ao_insn_read()

2012-10-25 Thread H Hartley Sweeten
This function is supposed to return the analog output value for a specified channel. The channel number is packed in insn->chanspec, which is an unsigned int, and unpacked using the CR_CHAN() macro. Currently this function is trying to use the chanspec as an array. This works only if a single data

[PATCH 13/23] staging: comedi: me_daq: remove pci_dev_put() in detach

2012-10-25 Thread H Hartley Sweeten
This driver uses the comedi auto config mechanism and does not walk the pci bus to find the pci_dev. It should not be calling pci_dev_put() to decrement the ref count. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/me_daq.c | 1 - 1 fi

[PATCH 12/23] staging: comedi: me_daq: add some whitespace to the subdevice init

2012-10-25 Thread H Hartley Sweeten
To improve the readability, add some whitespace to the subdevice init. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/me_daq.c | 54 - 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/driv

[PATCH 11/23] staging: comedi: me_daq: cleanup the range tables

2012-10-25 Thread H Hartley Sweeten
Fix the whitespace. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/me_daq.c | 53 - 1 file changed, 25 insertions(+), 28 deletions(-) diff --git a/drivers/staging/comedi/drivers/me_daq.c b/drivers/stag

[PATCH 10/23] staging: comedi: me_daq: cleanup the boardinfo

2012-10-25 Thread H Hartley Sweeten
Rename the boardinfo variables so they are a bit more concise. Remove the unnecessary comments in the boardinfo. Add some whitespace to make the code more readable. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/me_daq.c | 67 +++

[PATCH 09/23] staging: comedi: me_daq: remove dio_channel_nbr from boardinfo

2012-10-25 Thread H Hartley Sweeten
All the boards supported by this driver have 32 dio channels. Remove the boardinfo and just open code the value in the attach. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/me_daq.c | 7 ++- 1 file changed, 2 insertions(+), 5 dele

[PATCH 08/23] staging: comedi: me_daq: remove {ao, ai}_resoultion_mask

2012-10-25 Thread H Hartley Sweeten
These values can be determined from the {ao,ai}_resolution. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/me_daq.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/comedi/drivers/me_daq.c b

[PATCH 07/23] staging: comedi: me_daq: remove '0' and 'NULL' entries in boardinfo

2012-10-25 Thread H Hartley Sweeten
These entries will default to '0' or 'NULL' as appropriate. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/me_daq.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/comedi/drivers/me_daq.c b/drivers/staging/come

[PATCH 03/23] staging: comedi: me_daq: replace 'result' and 'error' with 'ret'

2012-10-25 Thread H Hartley Sweeten
Two local variables are used in me_attach_pci() to check for errors when calling other functions, 'result' and 'error'. Remove both of them and just use a common 'ret' variable. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/me_daq.c |

[PATCH 06/23] staging: comedi: me_daq: analog output subdevice could be unused

2012-10-25 Thread H Hartley Sweeten
One of the boards supported by this driver does not have analog outputs. Fix the attach code to account for this. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/me_daq.c | 20 1 file changed, 12 insertions(+), 8 de

[PATCH 02/23] staging: comedi: me_daq: cleanup ioremap of PCI bar 2

2012-10-25 Thread H Hartley Sweeten
PCI bar 2 is the main i/o address for this driver. Currently the pci_resource_len of the bar is stored in the private data but it is never used. Remove 'me_regbase_size' from the private data. Also, remove the local variables used for the pci_resource_start and _len. Just pass the values directly

[PATCH 05/23] staging: comedi: me_daq: factor out the PLX bug workaround

2012-10-25 Thread H Hartley Sweeten
Factor out the code in me_attach_pci() that handles the PLX-Bug workaround to a separate function. This looks odd. It appears that the bug workaround either swaps PCI bars 0 and 5 or it modifies PCI bar 0. Shouldn't this happen before PCI bar 0 is ioremap'ed? Signed-off-by: H Hartley Sweeten Cc:

[PATCH 04/23] staging: comedi: me_daq: pass on the error from comedi_pci_enable()

2012-10-25 Thread H Hartley Sweeten
Instead of returning -EIO when comedi_pci_enable() fails, pass on the actual error code. Also, remove the kernel noise when the function fails. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/me_daq.c | 9 +++-- 1 file changed, 3 in

[PATCH 01/23] staging: comedi: me_daq: fix pointer dereference in me_detach()

2012-10-25 Thread H Hartley Sweeten
As pointed out by Dan Carpenter, dev_private could be NULL when it is checked before calling comedi_pci_disable(). The private data variable 'plx_regbase_size' is only used to see if the pci device has been enabled. Remove that variable from the private data and just use the unused dev->iobase var

[PATCH 00/23] staging: comedi: me_daq: cleanup the driver

2012-10-25 Thread H Hartley Sweeten
Cleanup some of the cruft... H Hartley Sweeten (23): staging: comedi: me_daq: fix pointer dereference in me_detach() staging: comedi: me_daq: cleanup ioremap of PCI bar 2 staging: comedi: me_daq: replace 'result' and 'error' with 'ret' staging: comedi: me_daq: pass on the error from comedi

[PATCH 5/5] staging: csr: remove all prototypes of not defined functions

2012-10-25 Thread Devendra Naga
these prototypes doesn't have function definitions in any of the c files Signed-off-by: Devendra Naga --- drivers/staging/csr/csr_framework_ext.h | 82 --- 1 file changed, 82 deletions(-) diff --git a/drivers/staging/csr/csr_framework_ext.h b/drivers/staging/csr/c

[PATCH 4/5] staging: csr: remove CsrMutexCreate function

2012-10-25 Thread Devendra Naga
nobody are calling this function in here, so remove this Signed-off-by: Devendra Naga --- drivers/staging/csr/csr_framework_ext.c | 26 -- drivers/staging/csr/csr_framework_ext.h | 16 2 files changed, 42 deletions(-) diff --git a/drivers/staging/csr

[PATCH 3/5] staging: csr: remove CsrMutexDestroy function

2012-10-25 Thread Devendra Naga
this function never gets called from anywhere, so remove this too. Signed-off-by: Devendra Naga --- drivers/staging/csr/csr_framework_ext.c | 15 --- drivers/staging/csr/csr_framework_ext.h | 13 - 2 files changed, 28 deletions(-) diff --git a/drivers/staging/csr/csr

[PATCH 2/5] staging: csr: remove CsrMutexUnlock function

2012-10-25 Thread Devendra Naga
Nobody is using this function inside the csr directory, so remove this function also Signed-off-by: Devendra Naga --- drivers/staging/csr/csr_framework_ext.c | 25 - drivers/staging/csr/csr_framework_ext.h | 30 -- 2 files changed, 55 dele

[PATCH 1/5] staging: csr: remove CsrMutexLock function

2012-10-25 Thread Devendra Naga
nobody inside the csr directory is calling this function, so remove this Signed-off-by: Devendra Naga --- drivers/staging/csr/csr_framework_ext.c | 28 drivers/staging/csr/csr_framework_ext.h | 15 --- 2 files changed, 43 deletions(-) diff --git a/dr

[PATCH RESEND 1/2] tools: hv: Return the full kernel version

2012-10-25 Thread K. Y. Srinivasan
Currently, we are returning the same string for both OSBuildNumber and OSVersion keys. Return the full uts string for the OSBuild key since Windows does not impose any restrictions on this. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang Reported-by: Claudio Latini --- tools/hv/hv_k

[PATCH RESEND 2/2] Tools: hv: Don't return loopback addresses

2012-10-25 Thread K. Y. Srinivasan
Don't return loopback addresses and further don't terminate the IP address strings with a semicolon. This is the current behavior of Windows guests. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang Reported-by: Claudio Latini --- tools/hv/hv_kvp_daemon.c | 13 + 1 files

[PATCH RESEND 0/2] Tools: hv: kvp_daemon

2012-10-25 Thread K. Y. Srinivasan
This patch-set makes KVP implementation track the implementation on Windows guests with regards to how IP addresses are returned. Additionally, we also returns more information for the OSBuild key. K. Y. Srinivasan (2): tools: hv: Return the full kernel version Tools: hv: Don't return loopb

[PATCH RESEND V1 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-25 Thread K. Y. Srinivasan
Add the basic balloon driver. Windows hosts dynamically manage the guest memory allocation via a combination memory hot add and ballooning. Memory hot add is used to grow the guest memory upto the maximum memory that can be allocatted to the guest. Ballooning is used to both shrink as well as expan

[PATCH RESEND V1 1/2] mm: Export vm_committed_as

2012-10-25 Thread K. Y. Srinivasan
The policy engine on the host expects the guest to report the committed_as. Since this variable is not exported, export this symbol. Signed-off-by: K. Y. Srinivasan --- mm/mmap.c |1 + mm/nommu.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/mm/mmap.c b/mm/mmap.c

[PATCH RESEND V1 0/2] Drivers: hv

2012-10-25 Thread K. Y. Srinivasan
Add a basic balloon driver to take advantage of the dynamic memory management functionality supported on Windows hosts. Windows requires the guests to support both memory hot add as well as ballooning. In this patch we are adding the basic balloon driver. Memory hot add will be added in a subsequen

staging patch queue caught up on

2012-10-25 Thread Greg KH
Hi all, I've caught up on my big pile of staging patches that were sent to me during the merge window (and a bit before). So if I haven't applied a patch that you sent me, consider it lost, so please resend. thanks, greg k-h ___ devel mailing list dev

Re: [PATCH] staging: Add ST-Ericsson CG2900 driver

2012-10-25 Thread Greg Kroah-Hartman
On Mon, Oct 22, 2012 at 11:37:27AM -0700, Greg Kroah-Hartman wrote: > On Thu, Oct 18, 2012 at 01:56:00PM +0200, Nitin DHINGRA wrote: > > > > > > > -Original Message- > > > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > > > Sent: Thursday, October 18, 2012 2:51 AM > > > To:

Re: [PATCH 0/9] staging: comedi: update auto-attach mechanism

2012-10-25 Thread Greg Kroah-Hartman
On Thu, Oct 25, 2012 at 06:02:47PM +0100, Ian Abbott wrote: > >That's trickier. I don't know enough about the comedi layer to answer > >this, but generally, I would stay away from having anyone except the > >driver that set the value, be the ones that can do anything with the > >value. In other w

Re: [PATCH] Staging: android: binder: Fixed multi-line strings

2012-10-25 Thread Greg KH
On Thu, Oct 25, 2012 at 01:36:47PM +0530, Anmol Sarma wrote: > Changed all user visible multi-line strings to single line. > Removed 'binder:' prefix on stings. > > Signed-off-by: Anmol Sarma > --- > drivers/staging/android/binder.c | 358 > +++--- > 1 file chan

Re: [PATCH] staging: csr: remove panic at locking the mutex

2012-10-25 Thread devendra.aaru
Hi Greg, On Thu, Oct 25, 2012 at 3:13 PM, Greg Kroah-Hartman wrote: > On Thu, Oct 25, 2012 at 12:12:32PM -0700, Greg Kroah-Hartman wrote: >> On Thu, Oct 25, 2012 at 01:50:58AM -0400, Devendra Naga wrote: >> > when down_interruptible fail, means a signal occur, or any other failure >> > we are pan

Re: [PATCH] staging: csr: remove panic at locking the mutex

2012-10-25 Thread Greg Kroah-Hartman
On Thu, Oct 25, 2012 at 12:12:32PM -0700, Greg Kroah-Hartman wrote: > On Thu, Oct 25, 2012 at 01:50:58AM -0400, Devendra Naga wrote: > > when down_interruptible fail, means a signal occur, or any other failure > > we are panicing, and it seems that we should not panic, instead we would > > have don

Re: [PATCH] staging: csr: remove panic at locking the mutex

2012-10-25 Thread Greg Kroah-Hartman
On Thu, Oct 25, 2012 at 01:50:58AM -0400, Devendra Naga wrote: > when down_interruptible fail, means a signal occur, or any other failure > we are panicing, and it seems that we should not panic, instead we would > have done a spinlock, but currently removing the panic call. > > Signed-off-by: Dev

Re: [PATCH] dgrp: remove unused including

2012-10-25 Thread Greg KH
On Sun, Oct 07, 2012 at 09:23:47PM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > Remove including that don't need it. > > dpatch engine is used to auto generate this patch. > (https://github.com/weiyj/dpatch) > > Signed-off-by: Wei Yongjun > --- > drivers/staging/dgrp/dgrp_sysfs.c | 1 -

Re: [PATCH v6 0/3] Add modules to support realtek PCIE card reader

2012-10-25 Thread Greg KH
On Sat, Oct 20, 2012 at 06:46:15AM +0300, Dan Carpenter wrote: > On Sat, Oct 06, 2012 at 03:23:56PM +0800, wwang wrote: > > We are still maintaining the SCSI driver for Realtek card reader, > > and will release the latest source code in the Github in the future. > > But maybe we won't push it to th

Re: [PATCH 0/9] staging: comedi: update auto-attach mechanism

2012-10-25 Thread Ian Abbott
On 2012-10-25 17:19, Greg Kroah-Hartman wrote: On Thu, Oct 25, 2012 at 03:02:37PM +0100, Ian Abbott wrote: On 2012-10-24 15:19, Ian Abbott wrote: On 2012-10-24 05:16, Greg Kroah-Hartman wrote: On Tue, Oct 23, 2012 at 10:53:22AM +0100, Ian Abbott wrote: On 2012-10-22 20:44, Greg Kroah-Hartman

Re: [PATCH 0/9] staging: comedi: update auto-attach mechanism

2012-10-25 Thread Greg Kroah-Hartman
On Thu, Oct 25, 2012 at 03:02:37PM +0100, Ian Abbott wrote: > On 2012-10-24 15:19, Ian Abbott wrote: > >On 2012-10-24 05:16, Greg Kroah-Hartman wrote: > >>On Tue, Oct 23, 2012 at 10:53:22AM +0100, Ian Abbott wrote: > >>>On 2012-10-22 20:44, Greg Kroah-Hartman wrote: > On Mon, Oct 15, 2012 at 01

Re: [PATCH 1/2] ipu-v3: ipu-common: Make it less verbose

2012-10-25 Thread Greg KH
On Thu, Oct 25, 2012 at 05:49:46PM +0200, Sascha Hauer wrote: > On Wed, Oct 24, 2012 at 09:36:46PM -0200, Fabio Estevam wrote: > > From: Fabio Estevam > > > > IPU Interrupt numbers and the various IPU submodules base addresses are > > more > > interesting for debugging purposes rather than norm

Re: [PATCH 1/2] ipu-v3: ipu-common: Make it less verbose

2012-10-25 Thread Sascha Hauer
On Wed, Oct 24, 2012 at 09:36:46PM -0200, Fabio Estevam wrote: > From: Fabio Estevam > > IPU Interrupt numbers and the various IPU submodules base addresses are more > interesting for debugging purposes rather than normal use, so use dev_dbg > instead. > > Signed-off-by: Fabio Estevam both:

Re: [patch] staging: r8712u: cleanup pointer type in r8712_setassocsta_cmd()

2012-10-25 Thread Larry Finger
On 10/25/2012 07:30 AM, Dan Carpenter wrote: This seems like a cut and paste bug. Smatch complains that we don't allocate enough memory for a set_stakey_rsp struct. In fact this is used as a set_assocsta_rsp struct throughout and that also matches the name of the function. Signed-off-by: Dan C

RE: [PATCH 3/3] Drivers: hv: Get rid of hv_ringbuffer_cleanup()

2012-10-25 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Wednesday, October 24, 2012 6:45 PM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; devel@linuxdriverproject.org; > o...@aepfle.de; > a...@canonical.com; jasow...@redhat.com > Subject: Re: [PATCH 3/3

Re: [PATCH 0/9] staging: comedi: update auto-attach mechanism

2012-10-25 Thread Ian Abbott
On 2012-10-24 15:19, Ian Abbott wrote: On 2012-10-24 05:16, Greg Kroah-Hartman wrote: On Tue, Oct 23, 2012 at 10:53:22AM +0100, Ian Abbott wrote: On 2012-10-22 20:44, Greg Kroah-Hartman wrote: On Mon, Oct 15, 2012 at 01:07:30PM +0100, Ian Abbott wrote: The auto-configuration/auto-attach mecha

RE: 3.7 RC1

2012-10-25 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Monday, October 22, 2012 7:34 PM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; devel@linuxdriverproject.org; > o...@aepfle.de; > a...@canonical.com; jasow...@redhat.com > Subject: Re: 3.7 RC1 > >

Re: [PATCH V4] drivers:staging:ced1401: fix a frame size warning, use smaller memory block is sufficient

2012-10-25 Thread Dan Carpenter
There are a couple issues with this patch. 1) It needs to be CC'd to Greg Smith. 2) It needs a Signed-off-by from Greg Smith. 3) It does not apply with `cat raw_email.txt | git am` 4) The comment is not updated. 5) If we are going to do that, then we should just remove the 1 element arrays and

[patch] staging: r8712u: cleanup pointer type in r8712_setassocsta_cmd()

2012-10-25 Thread Dan Carpenter
This seems like a cut and paste bug. Smatch complains that we don't allocate enough memory for a set_stakey_rsp struct. In fact this is used as a set_assocsta_rsp struct throughout and that also matches the name of the function. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/rtl8712

re: staging: sep: Basic infrastructure for SEP DMA access to non CPU regions

2012-10-25 Thread Dan Carpenter
[ This is sort of old, but apparently I didn't send it Feb ]. Hello Mark A. Allyn, This is a semi-automatic email about new static checker warnings. The patch aca58ec828af: "staging: sep: Basic infrastructure for SEP DMA access to non CPU regions" from Feb 10, 2012, leads to the following Smatch

[PATCH V4] drivers:staging:ced1401: fix a frame size warning, use smaller memory block is sufficient

2012-10-25 Thread Alois Schloegl
This code fixes a frame size warning. Unlike alternative patches, a smaller structure is used which avoids the use of kmalloc/kfree. This is faster than the original code. We never do anything other than use element 0, or no elements in linux. This was not the case in Windows, but we ain't in

Re: [PATCH 00/12] staging: comedi: cleanup the pci vendor ids

2012-10-25 Thread Ian Abbott
On 2012-10-25 03:42, Greg KH wrote: On Wed, Oct 24, 2012 at 06:10:31PM -0700, H Hartley Sweeten wrote: Move all the pci vendor id defines from the drivers to comedidev.h. Use the kernel provided vendor ids in pci_ids.h where appropriate. The jr3_pci and s626 drivers still have a private PCI_VEN

Re: [PATCH 10/12] staging: comedi: comedidev.h: add PCI_VENDOR_ID_AMCC

2012-10-25 Thread Ian Abbott
On 2012-10-25 02:14, H Hartley Sweeten wrote: Add a define for the Applied Micro Circuits Corp. PCI vendor id. Remove the duplicates in the drivers. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/comedidev.h | 1 + drivers/stagin

Re: [PATCH 04/19] staging: comedi: comedidev.h: add PCI_VENDOR_ID_CB

2012-10-25 Thread Ian Abbott
On 2012-10-25 00:29, H Hartley Sweeten wrote: Add a define for the ComputerBoards/Measurement Computing PCI vendor id. Remove the duplicates in the drivers. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/comedidev.h | 6 +++- dr

[PATCH] Staging: android: binder: Fixed multi-line strings

2012-10-25 Thread Anmol Sarma
Changed all user visible multi-line strings to single line. Removed 'binder:' prefix on stings. Signed-off-by: Anmol Sarma --- drivers/staging/android/binder.c | 358 +++--- 1 file changed, 143 insertions(+), 215 deletions(-) diff --git a/drivers/staging/android

[PATCH] Staging: csr: bh: fixing spaces coding style issues

2012-10-25 Thread Chihau Chau
Fixed some coding style issues replacing spaces for tab at the end of some lines Signed-off-by: Chihau Chau --- drivers/staging/csr/bh.c | 19 +-- 1 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/staging/csr/bh.c b/drivers/staging/csr/bh.c index addee05..

[PATCH] staging: slicoss: fix a leak when kzalloc fail

2012-10-25 Thread Devendra Naga
slic_card_locate does a kzalloc of physcard, and if it fails, in my previous patch i returned -ENOMEM, but left the driver leak the memory if card_hostid == SLIC_HOSTID_DEFAULT, fix this memory leak if the above condition is true Signed-off-by: Devendra Naga --- drivers/staging/slicoss/slicoss.

[PATCH] staging: csr: remove panic at locking the mutex

2012-10-25 Thread Devendra Naga
when down_interruptible fail, means a signal occur, or any other failure we are panicing, and it seems that we should not panic, instead we would have done a spinlock, but currently removing the panic call. Signed-off-by: Devendra Naga --- drivers/staging/csr/csr_framework_ext.c |1 - 1 file