oyd6如何有效调[岗调薪、解}雇辞退h8c.xls
Description: Binary data
___
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
Hi Chris, Samuel and Alex:
Can you help to review this patchset, please?
I have asked Greg to remove rts_pstor from the staging tree. So this
driver have to be merged into 3.8 kernel, or else Realtek'sPCI-E card
reader can not be accessed easily.
BR,
Wei WANG
___
This patch removes typedef for
stLocalSFAddIndicationAlt, changes the
name of the struct to bcm_add_indication_alt,
and removes a comments. In addition, any
calls to typedef stLocalSFAddIndicationAlt
are changed to call the struct directly.
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/B
This patch removes typedef
stLocalSFAddRequestAlt in CmHost.h.
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/CmHost.h | 13 -
1 file changed, 13 deletions(-)
diff --git a/drivers/staging/bcm/CmHost.h b/drivers/staging/bcm/CmHost.h
index cb51455..f357a0c 100644
--- a/driver
This patch removes typedef
stLocalSFChangeRequestAlt in CmHost.h.
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/CmHost.h | 22 --
1 file changed, 22 deletions(-)
diff --git a/drivers/staging/bcm/CmHost.h b/drivers/staging/bcm/CmHost.h
index 2b963de..5702ac7 100644
This patch removes typedef
stLocalSFAddConfirmationAlt in CmHost.h.
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/CmHost.h | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/bcm/CmHost.h b/drivers/staging/bcm/CmHost.h
index 5702ac7..8572def 100644
--- a/
This patch changes PVOID to void *
in CmHost.h.
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/CmHost.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm/CmHost.h b/drivers/staging/bcm/CmHost.h
index d1a8675..7dd0522 100644
--- a/drivers/stagin
This patch removes typedef
stLocalSFChangeConfirmationAlt
in CmHost.h.
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/CmHost.h | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/bcm/CmHost.h b/drivers/staging/bcm/CmHost.h
index 6e79e97..2b963de 100644
---
This patch removes typedef for
stLocalSFChangeIndicationAlt, changes the
name of the struct to bcm_change_indication,
and removes a comment. In addition, any
calls to typedef stLocalSFChangeIndicationAlt
are changed to call the struct directly.
Signed-off-by: Kevin McKinney
---
drivers/staging/b
This patch changes ULONG to unsigned
long in CmHost.h.
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/CmHost.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm/CmHost.h b/drivers/staging/bcm/CmHost.h
index 055d2e0..fd117e7 100644
--- a/drivers
This patch changes UINT to unsigned
int in CmHost.h.
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/CmHost.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/bcm/CmHost.h b/drivers/staging/bcm/CmHost.h
index fd117e7..d1a8675 100644
--- a/drivers/stagi
This patch changes INT to int
in CmHost.h.
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/CmHost.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm/CmHost.h b/drivers/staging/bcm/CmHost.h
index 6138f50..055d2e0 100644
--- a/drivers/staging/bcm
This patch changes B_UINT8 to u8
in CmHost.h.
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/CmHost.h | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/bcm/CmHost.h b/drivers/staging/bcm/CmHost.h
index e043a5b..613
This patch changes B_UINT16 to u16
in CmHost.h.
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/CmHost.h | 42 +-
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/bcm/CmHost.h b/drivers/staging/bcm/CmHost.h
index 4c33
This patch fixes all white space issues
in CmHost.h as reported by checkpatch.pl.
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/CmHost.h | 129 +++---
1 file changed, 57 insertions(+), 72 deletions(-)
diff --git a/drivers/staging/bcm/CmHost.h b/drive
This patch correctly formats comments
in CmHost.h as reported by checkpatch.pl.
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/CmHost.h | 102 +-
1 file changed, 51 insertions(+), 51 deletions(-)
diff --git a/drivers/staging/bcm/CmHost.h b/drivers
Dan,
With my next patch set it appears this structure "bcm_add_indication"
is in two places; in cntrl_SignalingInterface.h and CmHost.h. However
there are a few differences, but I think I can merge this structure. I
cleaned up the code in CmHost.h, but I did not remove this structure
yet because
The eeprom 'type' can be found from the boardinfo when needed.
Finding it when needed also makes it clearer what this value is.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../staging/comedi/drivers/addi-data/addi_eeprom.c | 24 +-
1 file chan
Fix the following checkpatch.pl issues:
ERROR: code indent should use tabs where possible
WARNING: please, no spaces at the start of a line
WARNING: line over 80 characters
This file is now checkpatch.pl clean.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
driver
Fix the whitespace in the defines. This also fixes a couple
checkpatch.pl issues.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/addi_eeprom.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --g
Reformat the driver description comment to use the preferred block
comment style.
The second driver comment block contains the same information as
the first one. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../staging/comedi/drivers/addi-data/addi_eep
Add namespace by renaming this CamelCase function to
addi_eeprom_read_info().
Remove the 'type' parameter. This parameter is a char pointer to the
string name of the eeprom type used on the board. This can be found
when needed using the dev pointer.
Change the parameter order so that the comedi_d
Use this function to set the private data instead of doing it in the
i_EepromReadMainHeader() function. Keep the eeprom read code #if 0'ed
out for now.
Add namespace by renaming this CamelCase function to
addi_eeprom_read_timer_info().
Remove the unused str_TimerMainHeader and str_TimerDetails st
Add namespace by renaming this CamelCase function to
addi_eeprom_read_ai_info().
Refactor the function so that it stores the data from the eeprom directly
in the private data instead of using the a struct to pass the data back
to i_EepromReadMainHeader(). This allows removing the str_AnalogInputHe
Add namespace by renaming this CamelCase function to
addi_eeprom_read_ao_info().
Refactor the function so that it stores the data from the eeprom directly
in the private data instead of using the a struct to pass the data back
to i_EepromReadMainHeader(). This allows removing the str_AnalogOutputH
Add namespace by renaming this CamelCase function to
addi_eeprom_read_do_info().
Refactor the function so that it stores the data from the eeprom directly
in the private data instead of using the a struct to pass the data back
to i_EepromReadMainHeader(). This allows removing the str_DigitalOutput
Add namespace by renaming this CamelCase function to
addi_eeprom_read_di_info().
Refactor the function so that it stores the data from the eeprom directly
in the private data instead of using the a struct to pass the data back
to i_EepromReadMainHeader(). This allows removing the str_DigitalInputH
Consolidate the two loops used to read the main header data and the
individual function header data from the eeprom.
The structs used to read the main header are not used outside this
function so remove them by reading the eeprom data into local
variables used in the loop.
Consolidate the 'timer'
On Sat, Oct 27, 2012 at 07:54:22PM +0100, Ceri James wrote:
> This is Version 2 of this patchset. Patchset now has 3 items in the set.
> Changes between V1 & V2:
> - Ensure function parameters are on the same line as the function call
> until they reach 80 character limit
> - Remove a comm
All the addi_eeprom_readw() calls have the offset to the start of user
data (0x100) as part of the address calculation. Create a define for this
constant and move it's addition to the address into addi_eeprom_readw().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.
Add namespace to the function by renaming the CamelCase function to
addi_eeprom_readw().
Rename the CamelCase parameters and local variables.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../staging/comedi/drivers/addi-data/addi_common.c | 2 +-
.../staging/come
Use the AMCC_OP_REG_* register offset defines for the magic numbers
used to read the nvram data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/addi_eeprom.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-
On Sun, Oct 28, 2012 at 10:28:30PM +, Mark Einon wrote:
> On Sat, Oct 27, 2012 at 07:01:53PM +0100, Mark Einon wrote:
> > The previous refactoring of nic_rx_pkts() changed the behaviour by no
> > longer zeroing rfd->len before exiting the function in one scenario.
> > Fix this by zeroing the le
Factor the code that reads the word from the nvram out of the
w_EepromReadWord() function.
Cleanup the factored out code so it's a bit more concise.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../staging/comedi/drivers/addi-data/addi_eeprom.c | 86 ++---
Add namespace to the function by renaming the CamelCase function to
addi_eeprom_nvram_wait().
Rename the CamelCase local variable.
Refactor the do {} while to make the code a bit more concise.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../staging/comedi/drive
Add namespace to the function by renaming the CamelCase function to
addi_eeprom_read_93c76().
Change the return type of the function to unsigned short and just
return the read value instead of passing it through a pointer.
Rename the CamelCase parameters and local variables.
Make addi_eeprom_cmd
Add namespace to the function by renaming the CamelCase function to
addi_eeprom_cmd_93c76().
Rename the CamelCase parameters and local variables.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../staging/comedi/drivers/addi-data/addi_eeprom.c | 26 +++-
Add namespace to the function by renaming the CamelCase function to
addi_eeprom_clk_93c76().
Rename the CamelCase parameter, dw_RegisterValue, to simply 'val'.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/addi_eeprom.c | 1
Define the magic values used for the clock, chip-select, data out,
and data in signals to the 93c76 eeprom.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../staging/comedi/drivers/addi-data/addi_eeprom.c | 31 ++
1 file changed, 14 insertions(+
This variable is the pointer to the string name of the eeprom type
found on the board. This name comes from the boardinfo of the
driver.
For aesthetic reasons, rename it to simply 'type'.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../staging/comedi/drivers/add
This variable is actually the PCI bar 0 i/o address of the device found
with pci_resource_start().
For aesthetic reasons, rename it to 'iobase' and change to type to an
unsigned long.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../staging/comedi/drivers/addi-da
None of the functions in this file are exported. Make them static and
remove the unnecessary forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/addi_eeprom.c | 16 ++--
1 file changed, 6 insertio
The functions used to read the eeprom header information blocks are
only used in this file. Move them to remove the need for the forward
declarations.
The i_EepromReadTimerHeader() function is currently not being used.
Block it out with and #if 0/#endif until it's determined if it should
be remove
The functions used to read the 93c76 eeprom are only used in this file.
Move them to remove the need for the forward declarations.
Also, remove some of the more obvious comments and fix a couple coding
style issues while moving the functions.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc:
This function is only used in this file. Move it to remove the need
for the forward declaration.
Also, remove the comment about an error in the data book. It's not
really an error just someones misunderstanding about doing a byte
read of a dword register.
Signed-off-by: H Hartley Sweeten
Cc: Ian
Remove the extra whitespace and the comment cruft in this file.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../staging/comedi/drivers/addi-data/addi_eeprom.c | 561 -
1 file changed, 561 deletions(-)
diff --git a/drivers/staging/comedi/drive
Cleanup this driver.
H Hartley Sweeten (27):
staging: comedi: addi_eeprom: remove extra whitespace and comment cruft
staging: comedi: addi_eeprom: make v_EepromWaitBusy() static
staging: comedi: addi_eeprom: make the 93c76 eeprom functions static
staging: comedi: addi_eeprom: make the eepr
None of the functions in this file are exported. Make all of them
static and remove the unnecessary forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/APCI1710_Ttl.c| 24 ++
.../comedi/driver
None of the functions in this file are exported. Make all of them
static and remove the unnecessary forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/APCI1710_Tor.c| 24 ++
.../comedi/driver
None of the functions in this file are exported. Make all of them
static and remove the unnecessary forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../staging/comedi/drivers/addi-data/APCI1710_Ssi.c| 18 --
.../staging/comed
None of the functions in this file are exported. Make all of them
static and remove the unnecessary forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/APCI1710_Inp_cpt.c| 24 ++---
.../comedi/drivers
None of the functions in this file are exported. Make all of them
static and remove the unnecessary forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/APCI1710_Dig_io.c | 24 ++
.../comedi/driver
None of the functions in this file are exported. Make all of them
static and remove the unnecessary forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/hwdrv_APCI1710.c | 10 +++---
1 file changed, 3 inse
None of the functions in this file are exported. Make all of them
static and remove the unnecessary forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/hwdrv_apci3501.c | 58 ++
.../comedi/driver
None of the functions in this file are exported. Make all of them
static and remove the unnecessary forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/hwdrv_apci2200.c | 50 ++
.../comedi/driver
None of the functions in this file are exported. Make all of them
static and remove the unnecessary forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/hwdrv_apci2032.c | 46 ++
.../comedi/driver
None of the functions in this file are exported. Make all of them
static and remove the unnecessary forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/hwdrv_apci16xx.c | 26 ++-
.../comedi/drivers/addi-
None of the functions in this file are exported. Make all of them
static and remove the unnecessary forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/hwdrv_apci2016.c | 38 ++
.../comedi/driver
None of the functions in this file are exported. Make all of them
static and remove the unnecessary forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 62 ++
.../comedi/driver
None of the functions in this file are exported. Make all of them
static and remove the unnecessary forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/hwdrv_apci1516.c | 50 ++
.../comedi/driver
Remove the unnecessary forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/hwdrv_apci1500.h | 49 --
1 file changed, 49 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_a
None of the functions in this file are exported. Make all of them
static and remove the unnecessary forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/hwdrv_apci1032.c | 20 +---
.../comedi/drivers
None of the functions in this file are exported. Make all of them
static and remove the unnecessary forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/hwdrv_apci035.c | 32 ++
.../comedi/driver
Move some of the functions in this file to remove the need for the
forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../staging/comedi/drivers/addi-data/addi_common.c | 68 +++---
.../staging/comedi/drivers/addi-data/addi_common.h
The individual addi-data files all define ADDIDATA_DRIVER_NAME. Remove
the #ifndef/#define for it in addi_common.c.
Remove the commented out MODULE_* stuff. The individual addi-data drivers
have this information.
Remove the, badly formatted, function comments. The functions are
obvious.
Signed-o
Move the MODULE_DEVICE_TABLE for each addi-data driver from addi_common.c
to the individual driver files. This removes the need #ifdef'ery.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../staging/comedi/drivers/addi-data/addi_common.c | 79 --
Move the addi-data specific #include's from addi_common.h to the
individual driver files.
The apci-1710, apci-3200, and apci-3300 drivers still have floating
point code in them and are currently disabled in the Kconfig and
Makefile. For now, move the fpu_{begin,end} functions from addi_common.c
to
This macro relies on a local variable having a specific name. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/addi_common.c| 8 ++--
drivers/staging/comedi/drivers/addi-data/addi_eeprom.c| 1 +
drivers/s
The addi-data drivers are all built by the main driver files including
addi-data/addi_common.c. That file then includes other files depending
on what driver is being compiled. This is makes the code quite messy
and hard to follow.
Start cleaning it up by removing the unneeded #include's in addi_co
Move the module_{init,exit} code and associated variables to the end
of the file.
Use module_comedi_pci_driver() to remove the module init boilerplate.
For aesthetic reasons, rename the comedi_driver and pci_driver from
driver_* to *_driver.
Remove the forward declarations for i_ADDI_{Attach,Det
The addi-data drivers are a bit of a mess and have a lot of bloat.
The source files listed in the Makefile do a bunch of #include's of
other c files to build the final drivers. This is a maintenance
nightmare and just makes the drivers difficult to follow.
Start breaking up the code by getting ri
On Fri, Oct 26, 2012 at 01:54:19PM +0530, Anmol Sarma wrote:
> if (vma == NULL) {
> - pr_err("binder: %d: binder_alloc_buf failed to "
> -"map pages in userspace, no vma\n", proc->pid);
> + pr_err("%d: binder_alloc_buf failed to map pages in userspa
On 10/29/2012 12:20 PM, Christian Lamparter wrote:
On Monday, October 29, 2012 05:39:28 PM Albert Pool wrote:
Can any of you help me identify the Realtek chip in this device so that the USB
ID can be added to the right driver?
It's a 802.11n USB nano dongle from ISY. I only have the dongle for
When compiling this driver I get these compile warnings:
ieee80211.h:1227:2: warning: '__f' is static but declared in inline
function 'ieee80211_is_empty_essid' which is not static [enabled by
default]
ieee80211.h:1233:3: warning: '__f' is static but declared in inline
function 'ieee80211_
When compiling this driver I get these compile warnings:
rtllib.h:2573:2: warning: '__f' is static but declared in inline
function 'rtllib_is_empty_essid' which is not static [enabled by
default]
rtllib.h:2579:3: warning: '__f' is static but declared in inline
function 'rtllib_is_empty_ess
Hi Julia and Fengguang,
On Sun, Oct 28, 2012 at 8:48 AM, Fengguang Wu wrote:
> Hi,
>
> On Sun, Oct 28, 2012 at 01:09:12AM +0800, Fengguang Wu wrote:
>> Hi Nitin,
>>
>> FYI, there are coccinelle warnings in
>>
>> tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux master
>> head:
Hi,
> --- /dev/null
> +++ b/include/linux/platform_data/omap_mailbox.h
> @@ -0,0 +1,105 @@
This file should only contain pure platform data needed
by the core omap code to pass to the mailbox driver.
The mailbox API header should be somewhere else,
like include/linux/mailbox/mailbox-omap.h or si
On Monday, October 29, 2012 05:39:28 PM Albert Pool wrote:
> Can any of you help me identify the Realtek chip in this device so that the
> USB ID can be added to the right driver?
> It's a 802.11n USB nano dongle from ISY. I only have the dongle for short
> time, so I may not be able to test it
>
On Monday, October 29, 2012 05:39:28 PM Albert Pool wrote:
> Hi,
>
> Can any of you help me identify the Realtek chip in this device so that the
> USB ID can be added to the right driver?
> It's a 802.11n USB nano dongle from ISY. I only have the dongle for short
> time, so I may not be able to
Convert these to bit shifts and cleanup the whitespace and comments.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.h | 18 +-
1 file changed, 5 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/comedi
Convert these to bit shifts and cleanup the whitespace and comments.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.h | 28
1 file changed, 12 insertions(+), 16 deletions(-)
diff --git a/drivers/sta
Fixes all the > 80 char checkpatch.pl issues with these defines.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.h | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/comedi/drivers/r
Fixes all the > 80 char checkpatch.pl issues with these defines.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.h | 35 -
1 file changed, 17 insertions(+), 18 deletions(-)
diff --git a/drivers/st
Fixes all the > 80 char checkpatch.pl issues with these defines.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.h | 167 +++-
1 file changed, 78 insertions(+), 89 deletions(-)
diff --git a/drivers/st
These register offset defines are not used. Remove them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/rtd520.h
b/drivers/staging/comedi
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/rtd520.c
b/drivers/staging/comedi/drivers/rtd520.c
index 6c694fb..e42bd6b 1
To improve the readability, add some whitespace to the subdevice
init.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.c | 59 -
1 file changed, 29 insertions(+), 30 deletions(-)
diff --git a/driv
This value is only used in the attach to determine which range
table the analog input subdevice uses. Remove this variable and
just pass the range table pointer in the boardinfo.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.c
All the boards supported by this driver have the same number of analog
input channels and resolution. Remove the boardinfo for this and just
open-code the values in the attach.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.c |
CC: Greg Kroah-Hartman
CC: de...@driverdev.osuosl.org
Signed-off-by: Omar Ramirez Luna
---
arch/arm/mach-omap2/mailbox.c |2 +-
arch/arm/plat-omap/include/plat/mailbox.h | 105
arch/arm/plat-omap/mailbox.c |2 +-
.
Interrupts ares only required for the ai subdevice command support.
Allow the driver to attach to the board even if request_irq() fails.
Only hook up the command support if the interrupt is available.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/c
This fixes all the remaining checkpatch.pl issues.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.c | 53 -
1 file changed, 32 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/comedi/d
This variable is cleared when an ai command is initiated and then
incremented with each interrupt. Other than that it's never used.
Just remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.c | 4
1 file changed, 4 del
These are all development debug messages. A lot of them are in
the interrupt routine and probably shouldn't be there. Some of
the others are actually commented out.
Just remove all of them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drive
All the #if 0'ed out code is either debug or incomplete. Just remove
it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.c | 41 +
1 file changed, 1 insertion(+), 40 deletions(-)
diff --git a/driv
Convert this driver to use the comedi PCI auto config mechanism
by adding an attach_pci callback.
Since this driver requires no extra configuration options, and
the attach callback is now optional, remove it.
Use the found 'dev->board_name' for the resource name passed to
comedi_pci_enable() and
Remove all the kernel noise that is output as the board is
attached. Leave a simple dev_info() after the attach is complete.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.c | 23 ---
1 file changed, 4 insert
It appears the dma code in this driver is seriously broken.
Enabling USE_DMA causes the driver to not even compile.
Just remove all the dma code for now.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.c | 343 --
Factor the common code that does the low-level reset of the board
out of rtd_init_board() and rtc_detach().
Fix the if test in rtd_detach() before doing the reset, devpriv->lcfg
could be NULL at this point.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/sta
Factor the code that does the low-level init of the board out of
rtd_attach().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.c | 61 ++---
1 file changed, 34 insertions(+), 27 deletions(-)
diff --gi
1 - 100 of 107 matches
Mail list logo