It's better to use more descriptive subjects on the patches.
This one could probably have been broken into smaller patches
[patch 4/x] Staging: winbond: wb35rx_s: fix white space
[patch 5/x] Staging: winbond: wb35rx_s: fix comments
[patch 6/x] Staging: winbond: wb35rx_s: allow header to be include
于 2012年11月08日 12:01, Alex Dubov 写道:
Hi,
Do you have any comment on the MEMSTICK part in this v7 patchset? Can
you help to merge the patch to the kernel tree?
I'm afraid that presently I don't have much time to look at the memstick
related stuff any further. Hopefully, somebody else can step i
>
>
> Hi Alex:
Hi,
>
> Do you have any comment on the MEMSTICK part in this v7 patchset? Can
> you help to merge the patch to the kernel tree?
I'm afraid that presently I don't have much time to look at the memstick
related stuff any further. Hopefully, somebody else can step in and take
于 2012年11月08日 03:41, Chris Ball 写道:
On Mon, Oct 29 2012, wwang wrote:
Hi Chris, Samuel and Alex:
Can you help to review this patchset, please?
I have asked Greg to remove rts_pstor from the staging tree. So this
driver have to be merged into 3.8 kernel, or else Realtek'sPCI-E card
reader can
Commit 6bd4a5d96c08dc2380f8053b1bd4f879f55cd3c9 changed the
ANDROID_ALARM_GET_TIME ioctls from IOW to IOR. While technically
correct, the _IOC_DIR bits are ignored by alarm_ioctl, so the
commit breaks a userspace ABI used by all existing Android devices
for a purely cosmetic reason. Revert it.
C
Hi,
On Mon, Oct 29 2012, wwang wrote:
> Hi Chris, Samuel and Alex:
>
> Can you help to review this patchset, please?
>
> I have asked Greg to remove rts_pstor from the staging tree. So this
> driver have to be merged into 3.8 kernel, or else Realtek'sPCI-E card
> reader can not be accessed easily.
fixed below checkpatch warning.
- WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then
pr_warn(... to printk(KERN_WARNING ...
Signed-off-by: YAMANE Toshiaki
---
drivers/staging/media/solo6x10/p2m.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/dr
fixed below checkpatch warnings.
- WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...
to printk(KERN_ERR ...
- WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then
pr_info(... to printk(KERN_INFO ...
Signed-off-by: YAMANE Toshiaki
---
drivers/staging/
fixed below checkpatch warning.
- WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then
pr_warn(... to printk(KERN_WARNING ...
Signed-off-by: YAMANE Toshiaki
---
drivers/staging/media/cxd2099/cxd2099.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
Hi,
On Wed, Oct 24, 2012 at 12:15 AM, Greg KH wrote:
> On Tue, Oct 23, 2012 at 03:41:08PM +0530, Adil Mujeeb wrote:
>> On Tue, Oct 23, 2012 at 2:04 AM, Greg KH wrote:
>> > On Fri, Oct 12, 2012 at 10:07:06PM +0530, Adil Mujeeb wrote:
>> >>
>> >> winbond directory files have lots of coding style i
Fixed checpatch.pl reported ERRORs (excluding WARNING of line over 80
characters)
Signed-off-by: Adil Mujeeb
---
drivers/staging/winbond/wb35rx_s.h | 62 ++--
1 file changed, 31 insertions(+), 31 deletions(-)
diff --git a/drivers/staging/winbond/wb35rx_s.h
b/
Removed printk tracing call
Signed-off-by: Adil Mujeeb
---
drivers/staging/winbond/mds.c |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/winbond/mds.c b/drivers/staging/winbond/mds.c
index 43990e8..faa93f0 100644
--- a/drivers/staging/winbond/mds.c
+++
Fixed checkpatch.pl reported ERRORs
Signed-off-by: Adil Mujeeb
---
drivers/staging/winbond/wb35rx_f.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/winbond/wb35rx_f.h
b/drivers/staging/winbond/wb35rx_f.h
index 1fdf65e..559bdca 100644
--- a/dr
Removed unnecessary printk and pr_debug tracing calls
Signed-off-by: Adil Mujeeb
---
drivers/staging/winbond/wbusb.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/winbond/wbusb.c b/drivers/staging/winbond/wbusb.c
index 48aa136..3fa1ae4 100644
--- a/drivers/
winbond directory files have lots of coding style issues.
The patch set tries to remove *most* (if not all) of the coding style issues.
checkpatch.pl script can still complain but major part of the serious coding
style issues have been rectified.
_
On Wed, Nov 7, 2012 at 3:21 AM, Greg Kroah-Hartman
wrote:
> Hi Muhammad, Linus forwarded me your email about this topic, hope that's
> ok. See the bottom for my comments, the entire email is quoted to get
> Kevin up to speed on this.
>
>> -- Forwarded message --
>> From: "Muhammad
On Mon, Nov 5, 2012 at 1:50 AM, Dan Carpenter wrote:
> On Sat, Nov 03, 2012 at 02:33:16PM -0400, Kevin McKinney wrote:
>> This patch fixes the following compile warning:
>> "cast to pointer from integer of different size
>> [-Wint-to-pointer-cast]" in CmHost.c. I am replacing
>> one statement with
fixed few error and warning messages as reported by checkpatch.pl
Signed-off-by: Kumar Amit Mehta
---
drivers/staging/comedi/drivers/jr3_pci.c |9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers/jr3_pci.c
b/drivers/staging/comedi/driver
Hi Muhammad, Linus forwarded me your email about this topic, hope that's
ok. See the bottom for my comments, the entire email is quoted to get
Kevin up to speed on this.
> -- Forwarded message --
> From: "Muhammad Minhazul Haque"
> Date: Nov 5, 2012 7:00 PM
> Subject: About Becee
19 matches
Mail list logo
