Re: [PATCH] bcm_wimax.ko - Modified supported device list [Correction]

2012-11-08 Thread Kevin McKinney
On Thu, Nov 8, 2012 at 10:27 AM, Muhammad Minhazul Haque wrote: > Mr. Kevin and everyone, > > There was a serious mistake in the previous message. I forgot to > attach the patch. Please ignore it. I am posting it again. > > I was never reported for that product id 0x0132. Yet you can continue > su

Re: [PATCH 1/2] mm: Export vm_committed_as

2012-11-08 Thread Andrew Morton
On Thu, 8 Nov 2012 14:14:35 -0800 (PST) David Rientjes wrote: > On Thu, 8 Nov 2012, Andrew Morton wrote: > > > > > I don't think you should export the symbol itself to modules but rather > > > > a > > > > helper function that returns s64 that just wraps > > > > percpu_counter_read_positive() wh

Re: [PATCH 1/2] mm: Export vm_committed_as

2012-11-08 Thread David Rientjes
On Thu, 8 Nov 2012, Andrew Morton wrote: > > > I don't think you should export the symbol itself to modules but rather a > > > helper function that returns s64 that just wraps > > > percpu_counter_read_positive() which your driver could use instead. > > > > > > (And why percpu_counter_read_positi

RE: [PATCH 1/2] mm: Export vm_committed_as

2012-11-08 Thread KY Srinivasan
> -Original Message- > From: Andrew Morton [mailto:a...@linux-foundation.org] > Sent: Thursday, November 08, 2012 5:05 PM > To: KY Srinivasan > Cc: David Rientjes; Greg KH; o...@aepfle.de; linux-ker...@vger.kernel.org; > a...@firstfloor.org; a...@canonical.com; devel@linuxdriverproject.or

Re: [PATCH 1/2] mm: Export vm_committed_as

2012-11-08 Thread Andrew Morton
On Thu, 8 Nov 2012 22:01:33 + KY Srinivasan wrote: > > > > -Original Message- > > From: David Rientjes [mailto:rient...@google.com] > > Sent: Monday, November 05, 2012 5:33 PM > > To: KY Srinivasan > > Cc: Andrew Morton; Greg KH; o...@aepfle.de; linux-ker...@vger.kernel.org; > > a..

RE: [PATCH 1/2] mm: Export vm_committed_as

2012-11-08 Thread KY Srinivasan
> -Original Message- > From: David Rientjes [mailto:rient...@google.com] > Sent: Monday, November 05, 2012 5:33 PM > To: KY Srinivasan > Cc: Andrew Morton; Greg KH; o...@aepfle.de; linux-ker...@vger.kernel.org; > a...@firstfloor.org; a...@canonical.com; devel@linuxdriverproject.org; linux

RE: [PATCH 1/2] mm: Export vm_committed_as

2012-11-08 Thread David Rientjes
On Thu, 8 Nov 2012, KY Srinivasan wrote: > > Thanks Michal. Yes, the kernel driver reports this metric to the host. > > Andrew, let me know how I should proceed here. > > Ping. > Could you respond to my email in this thread? ___ devel mailing list dev

[PATCH] staging/media: Use pr_ printks in lirc/lirc_serial.c

2012-11-08 Thread YAMANE Toshiaki
fixed below checkpatch warnings. - WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ... - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... - WARNING: Prefer netdev_info(netdev, ... then dev_

[PATCH] staging/media: Use dev_ or pr_ printks in lirc/lirc_imon.c

2012-11-08 Thread YAMANE Toshiaki
fixed below checkpatch warnings. - WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... and add pr_fmt. Signed-off-by: YAMANE Toshiaki ---

[PATCH] staging/media: Use pr_ printks in lirc/lirc_parallel.c

2012-11-08 Thread YAMANE Toshiaki
fixed below checkpatch warnings. - WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ... - WARNING: Prefer netdev_notice(netdev, ... then dev_notice(dev, ... then pr_notice(... to printk(KERN_NOTICE ... - WARNING: Prefer netdev_info(netdev, .

[PATCH] staging/media: Use pr_ printks in lirc/lirc_bt829.c

2012-11-08 Thread YAMANE Toshiaki
fixed below checkpatch warnings. - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... - WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... and add pr_fmt. Signed-off-by: YAMANE Toshiaki ---

[PATCH] staging/media: Use dev_ printks in lirc/igorplugusb.c

2012-11-08 Thread YAMANE Toshiaki
fixed below checkpatch warnings. - WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ... - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: YAMANE Toshiaki --- drivers/stagi

[PATCH] staging/media: Use pr_ printks in lirc/lirc_sir.c

2012-11-08 Thread YAMANE Toshiaki
fixed below checkpatch warnings. - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... - WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... and add pr_fmt. Signed-off-by: YAMANE Toshiaki ---

[PATCH] staging/media: Use dev_ or pr_ printks in lirc/lirc_sasem.c

2012-11-08 Thread YAMANE Toshiaki
fixed below checkpatch warnings. - WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... - WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ... - WARNING: Prefer netdev_err(netdev, ... then d

Re: [PATCH] staging: comedi: addi_apci_1032: check shared interrupt

2012-11-08 Thread Ian Abbott
On 2012/11/08 03:42 PM, Ian Abbott wrote: > In the interrupt service routine, check the device is asserting the > shared interrupt line and check that interrupts have been enabled. > > When attaching the device, disable interrupts before setting up the > interrupt handler to avoid handling spuriou

Re: [PATCH 09/29] staging: comedi: addi_apci_1032: simplify the PCI bar reading

2012-11-08 Thread Ian Abbott
On 2012/11/08 05:00 PM, Ian Abbott wrote: > On 2012/11/05 09:36 PM, H Hartley Sweeten wrote: >> This board has a 93c76 eeprom. Knowing this information allows >> simplifying the code that reads the PCI bars to get the iobase >> addresses used in the driver. >> >> Signed-off-by: H Hartley Sweeten >

Re: [PATCH 09/29] staging: comedi: addi_apci_1032: simplify the PCI bar reading

2012-11-08 Thread Ian Abbott
On 2012/11/05 09:36 PM, H Hartley Sweeten wrote: > This board has a 93c76 eeprom. Knowing this information allows > simplifying the code that reads the PCI bars to get the iobase > addresses used in the driver. > > Signed-off-by: H Hartley Sweeten > Cc: Ian Abbott > Cc: Greg Kroah-Hartman > ---

RE: [PATCH] Tools: hv: Fix for long file names from readdir

2012-11-08 Thread KY Srinivasan
> -Original Message- > From: Tomas Hozza [mailto:tho...@redhat.com] > Sent: Thursday, November 08, 2012 9:53 AM > To: Olaf Hering > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > devel@linuxdriverproject.org; a...@canonical.com; jasow...@redhat.com; KY > Srinivasan > Subj

[PATCH] staging: comedi: addi_apci_1032: check shared interrupt

2012-11-08 Thread Ian Abbott
In the interrupt service routine, check the device is asserting the shared interrupt line and check that interrupts have been enabled. When attaching the device, disable interrupts before setting up the interrupt handler to avoid handling spurious interrupts before the device is ready. Signed-off

Re: [PATCH] bcm_wimax.ko - Modified supported device list [Correction]

2012-11-08 Thread Muhammad Minhazul Haque
Mr. Kevin and everyone, There was a serious mistake in the previous message. I forgot to attach the patch. Please ignore it. I am posting it again. I was never reported for that product id 0x0132. Yet you can continue support for it if it is rare. In the meantime, we can add more devices to the h

[PATCH] bcm_wimax.ko - Modified supported device list

2012-11-08 Thread Muhammad Minhazul Haque
Mr. Kevin, I was never reported for that product id 0x0132. Yet you can continue support for it if it is rare. In the meantime, we can add more devices to the header and add those names to "usb_device_id" table in "InterfaceInit.c". I added a new product string "BCM_USB_PRODUCT_ID_ZTE_326" and als

Re: [PATCH] Tools: hv: Fix for long file names from readdir

2012-11-08 Thread Tomas Hozza
> > -char dev_id[256]; > > +char dev_id[512]; > > Shouldnt that be PATH_MAX or similar? dirent->d_name should be PATH_MAX, but it is mostly not guaranteed. And then the dev_id is concatenated with two strings so it can exceed 256 bytes. After discussion with K. Y. Srinivasan I j

Re: [PATCH] Tools: hv: Fix for long file names from readdir

2012-11-08 Thread Olaf Hering
On Thu, Nov 08, Tomas Hozza wrote: > kvp_get_if_name and kvp_mac_to_if_name copy strings into statically > sized buffers which could be too small to store really long names. > - char dev_id[256]; > + char dev_id[512]; Shouldnt that be PATH_MAX or similar? Olaf __

[PATCH] Tools: hv: Fix for long file names from readdir

2012-11-08 Thread Tomas Hozza
kvp_get_if_name and kvp_mac_to_if_name copy strings into statically sized buffers which could be too small to store really long names. Buffer sizes have been increased and length checks added via snprintf. Signed-off-by: Tomas Hozza --- tools/hv/hv_kvp_daemon.c | 25 - 1

RE: [PATCH 1/2] mm: Export vm_committed_as

2012-11-08 Thread KY Srinivasan
> -Original Message- > From: KY Srinivasan > Sent: Tuesday, November 06, 2012 7:53 AM > To: 'Michal Hocko' > Cc: Andrew Morton; Greg KH; o...@aepfle.de; linux-ker...@vger.kernel.org; > a...@firstfloor.org; a...@canonical.com; devel@linuxdriverproject.org; linux- > m...@kvack.org; Hiroyuki

Re: [PATCH v7 0/3] Add modules to support realtek PCIE card reader

2012-11-08 Thread gre...@linuxfoundation.org
On Thu, Nov 08, 2012 at 01:30:11PM +0800, wwang wrote: > 于 2012年11月08日 12:01, Alex Dubov 写道: > >Hi, > >>Do you have any comment on the MEMSTICK part in this v7 patchset? Can > >>you help to merge the patch to the kernel tree? > > > >I'm afraid that presently I don't have much time to look at the me

RE: [PATCH] tools: hv: Netlink source address validation allows DoS

2012-11-08 Thread KY Srinivasan
> -Original Message- > From: Tomas Hozza [mailto:tho...@redhat.com] > Sent: Thursday, November 08, 2012 4:53 AM > To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > devel@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@redhat.com; KY Srinivasan > Cc: To

Re: [PATCH v7 0/3] Add modules to support realtek PCIE card reade

2012-11-08 Thread Arnd Bergmann
On Thursday 08 November 2012, wwang wrote: > > 于 2012年11月08日 12:01, Alex Dubov 写道: > > Hi, > >> Do you have any comment on the MEMSTICK part in this v7 patchset? Can > >> you help to merge the patch to the kernel tree? > > > > I'm afraid that presently I don't have much time to look at the memstic

Re: [PATCH 4/4] Staging: winbond: wb35rx_s: Fixed coding style issue

2012-11-08 Thread Adil Mujeeb
On Thu, Nov 8, 2012 at 12:59 PM, Dan Carpenter wrote: > It's better to use more descriptive subjects on the patches. > > This one could probably have been broken into smaller patches > [patch 4/x] Staging: winbond: wb35rx_s: fix white space > [patch 5/x] Staging: winbond: wb35rx_s: fix comments >

[PATCH] tools: hv: Netlink source address validation allows DoS

2012-11-08 Thread Tomas Hozza
The source code without this patch caused hypervkvpd to exit when it processed a spoofed Netlink packet which has been sent from an untrusted local user. Now Netlink messages with a non-zero nl_pid source address are ignored and a warning is printed into the syslog. Signed-off-by: Tomas Hozza ---

Re: [PATCH v7 0/3] Add modules to support realtek PCIE card reader

2012-11-08 Thread Samuel Ortiz
Hi Wei, On Mon, Oct 29, 2012 at 01:49:28PM +0800, wei_w...@realsil.com.cn wrote: > From: Wei WANG > > Support for Realtek PCI-Express driver-based card readers including rts5209, > rts5229 and rtl8411. All 3 patches applied now, thanks a lot. I also fixed the Kconfig entry where you forgot to se

[PATCH -next] staging: comedi: usbduxfast: remove unused variable in usbduxfastsub_ai_Irq()

2012-11-08 Thread Wei Yongjun
From: Wei Yongjun The variable 'p' is initialized but never used otherwise, so remove the unused variable. dpatch engine is used to auto generate this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun --- drivers/staging/comedi/drivers/usbduxfast.c | 2 -- 1 file changed, 2

[PATCH -next] iio: isl29018: fix to return error or 0 in isl29018_write_raw()

2012-11-08 Thread Wei Yongjun
From: Wei Yongjun We had assigned the return value to 'ret' but ignored it when return from isl29018_write_raw(), it's better to return 'ret' instead of 0. dpatch engine is used to auto generate this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun --- drivers/staging/iio/l