[PATCH] Staging: comedi: drivers: replaced printk with dev_dbg

2012-11-09 Thread Arpith Easow Alexander
This is a patch to the vmk80xx.c file that replaces the printk with dev_dbg. This fixes the warnings found by the checkpatch.pl tool. Signed-off-by: Arpith Easow Alexander --- drivers/staging/comedi/drivers/vmk80xx.c | 30 ++ 1 file changed, 18 insertions(+), 12 del

[PATCH 3/4] staging/serqt_usb2: refactor qt_open() in serqt_usb2.c

2012-11-09 Thread YAMANE Toshiaki
Modified to eliminate the deep nesting. Signed-off-by: YAMANE Toshiaki --- drivers/staging/serqt_usb2/serqt_usb2.c | 51 --- 1 file changed, 27 insertions(+), 24 deletions(-) diff --git a/drivers/staging/serqt_usb2/serqt_usb2.c b/drivers/staging/serqt_usb2/serqt_u

[PATCH 4/4] staging/serqt_usb2: refactor qt_unthrottle() in serqt_usb2.c

2012-11-09 Thread YAMANE Toshiaki
Modified to eliminate the deep nesting. Signed-off-by: YAMANE Toshiaki --- drivers/staging/serqt_usb2/serqt_usb2.c | 39 ++- 1 file changed, 23 insertions(+), 16 deletions(-) diff --git a/drivers/staging/serqt_usb2/serqt_usb2.c b/drivers/staging/serqt_usb2/serqt_u

[PATCH 2/4] staging/serqt_usb2: refactor qt_read_bulk_callback() in serqt_usb2.c

2012-11-09 Thread YAMANE Toshiaki
Modified to eliminate the deep nesting and redundant description. Signed-off-by: YAMANE Toshiaki --- drivers/staging/serqt_usb2/serqt_usb2.c | 147 +-- 1 file changed, 80 insertions(+), 67 deletions(-) diff --git a/drivers/staging/serqt_usb2/serqt_usb2.c b/drivers/

[PATCH 1/4] staging/serqt_usb2: fixed line over issue in serqt_usb2.c

2012-11-09 Thread YAMANE Toshiaki
Fixed a description of the procedure call dev_dbg(). Signed-off-by: YAMANE Toshiaki --- drivers/staging/serqt_usb2/serqt_usb2.c | 59 +-- 1 file changed, 40 insertions(+), 19 deletions(-) diff --git a/drivers/staging/serqt_usb2/serqt_usb2.c b/drivers/staging/serqt

Re: [PATCH 0/4] Staging: winbond: wbusb: Fixed coding style issue

2012-11-09 Thread Pavel Machek
Hi! > winbond directory files have lots of coding style issues. > The patch set tries to remove *most* (if not all) of the coding style issues. > checkpatch.pl script can still complain but major part of the serious coding > style issues have been rectified. > Looks good. Acked-by: Pavel Mache

RE: [PATCH 3/3] tools/hv: Fix permissions of created directory and files

2012-11-09 Thread KY Srinivasan
> -Original Message- > From: Tomas Hozza [mailto:tho...@redhat.com] > Sent: Friday, November 09, 2012 9:01 AM > To: o...@aepfle.de; KY Srinivasan; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org; devel@linuxdriverproject.org; a...@canonical.com; > jasow...@redhat.com; b...@dec

RE: [PATCH 1/3] tools/hv: Fix /var subdirectory

2012-11-09 Thread KY Srinivasan
> -Original Message- > From: Tomas Hozza [mailto:tho...@redhat.com] > Sent: Friday, November 09, 2012 9:01 AM > To: o...@aepfle.de; KY Srinivasan; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org; devel@linuxdriverproject.org; a...@canonical.com; > jasow...@redhat.com; b...@dec

RE: [PATCH 2/3] tools/hv: Fix string types

2012-11-09 Thread KY Srinivasan
> -Original Message- > From: Tomas Hozza [mailto:tho...@redhat.com] > Sent: Friday, November 09, 2012 9:01 AM > To: o...@aepfle.de; KY Srinivasan; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org; devel@linuxdriverproject.org; a...@canonical.com; > jasow...@redhat.com; b...@dec

RE: [PATCH 3/3] tools/hv: Fix permissions of created directory and files

2012-11-09 Thread KY Srinivasan
> -Original Message- > From: Tomas Hozza [mailto:tho...@redhat.com] > Sent: Friday, November 09, 2012 9:01 AM > To: o...@aepfle.de; KY Srinivasan; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org; devel@linuxdriverproject.org; a...@canonical.com; > jasow...@redhat.com; b...@dec

Re: [PATCH v7 0/3] Add modules to support realtek PCIE card reader

2012-11-09 Thread Chris Ball
Hi, On Fri, Nov 09 2012, wwang wrote: > I have noticed that the file rtsx_pci_sdmmc.c in your mmc-next branch > is still v6 patch. In v7 patch, this MMC part has also been modified > to comply with my MFD portion. So please update to this version. > > And one more question. Samuel have merged al

[PATCH] Staging: rtl8187se: fixed some checkpatch warnings and errors in r8180_wx.c

2012-11-09 Thread Mehdi Maache
This is a patch to the r8180_wx.c file that fixes up some warnings and errors found by the checkpatch.pl tool - WARNING: line over 80 characters - ERROR: "(foo*)" should be "(foo *)" - ERROR: "foo* bar" should be "foo *bar" - ERROR: trailing whitespace - ERROR: that open brace { should be on the

Re: [PATCH v7 0/3] Add modules to support realtek PCIE card reader

2012-11-09 Thread wwang
于 11/08/2012 03:41 AM, Chris Ball 写道: Hi, On Mon, Oct 29 2012, wwang wrote: I'm happy with the MMC portion. I think we're mainly waiting for the MFD patch -- Samuel, do you have any remaining review comments that need to be fixed? Thanks, - Chris. Hi Chris: I have noticed that the file rts

Re: [PATCH] bcm_wimax.ko - Modified supported device list [Correction]

2012-11-09 Thread Kevin McKinney
On Thu, Nov 8, 2012 at 11:30 PM, Kevin McKinney wrote: > On Thu, Nov 8, 2012 at 10:27 AM, Muhammad Minhazul Haque > wrote: >> Mr. Kevin and everyone, Also, no need to call me "Mr." ; I am not that important :) >> There was a serious mistake in the previous message. I forgot to >> attach the pat

[PATCH 2/3] tools/hv: Fix string types

2012-11-09 Thread Tomas Hozza
Initial patch by Ben Hutchings Standard C strings are arrays of char, not __u8 (unsigned char). Declare variables and parameters accordingly, and add the necessary casts. Signed-off-by: Tomas Hozza --- tools/hv/hv_kvp_daemon.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) d

[PATCH 1/3] tools/hv: Fix /var subdirectory

2012-11-09 Thread Tomas Hozza
Initial patch by Ben Hutchings We will install this in /usr, so it must use /var/lib for its state. Only programs installed under /opt should use /var/opt. Signed-off-by: Tomas Hozza --- tools/hv/hv_kvp_daemon.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/too

[PATCH 3/3] tools/hv: Fix permissions of created directory and files

2012-11-09 Thread Tomas Hozza
From: Ben Hutchings It's silly to create directories without execute permission, or to give permissions to 'other' but not the group-owner. Write the permissions in octal and 'ls -l' format since these are much easier to read than the named macros. Signed-off-by: Ben Hutchings Signed-off-by: T

[PATCH] Tools: hv: Fix for long file names from readdir

2012-11-09 Thread Tomas Hozza
kvp_get_if_name and kvp_mac_to_if_name copy strings into statically sized buffers which could be too small to store really long names. Buffer sizes have been changed to PATH_MAX, include "limits.h" where PATH_MAX is defined was added and length checks ware added via snprintf. Signed-off-by: Tomas

[PATCH v2] staging: comedi: addi_apci_1032: check shared interrupt

2012-11-09 Thread Ian Abbott
In the interrupt service routine, check the device is asserting the shared interrupt line and check that interrupts have been enabled. When attaching the device, disable interrupts before setting up the interrupt handler to avoid handling spurious interrupts before the device is ready. Signed-off