- Original Message -
> On Thu, Nov 08, 2012 at 10:53:29AM +0100, Tomas Hozza wrote:
> > The source code without this patch caused hypervkvpd to exit when
> > it processed
> > a spoofed Netlink packet which has been sent from an untrusted
> > local user.
> > Now Netlink messages with a non-z
On Fri, 2012-11-16 at 00:43 +0100, Markus Grabner wrote:
> On Thursday 15 November 2012 14:12:31 Joe Perches wrote:
> > On Thu, 2012-11-15 at 22:03 +0100, Markus Grabner wrote:
> > > Am Mittwoch, 14. November 2012, 17:33:05 schrieb Dan Carpenter:
> > > > The reason this is hitting the 80 character
> -Original Message-
> From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org]
> Sent: Thursday, November 15, 2012 6:38 PM
> To: KY Srinivasan
> Cc: Tomas Hozza; o...@aepfle.de; linux-ker...@vger.kernel.org;
> devel@linuxdriverproject.org; a...@canonical.com; jasow...@redhat.
On Thursday 15 November 2012 14:12:31 Joe Perches wrote:
> On Thu, 2012-11-15 at 22:03 +0100, Markus Grabner wrote:
> > Am Mittwoch, 14. November 2012, 17:33:05 schrieb Dan Carpenter:
> > > The reason this is hitting the 80 character limit is because
> > > "LINE6_INDEX_PCM_ALSA_CAPTURE_STREAM" is 3
On Thu, Nov 08, 2012 at 10:53:29AM +0100, Tomas Hozza wrote:
> The source code without this patch caused hypervkvpd to exit when it processed
> a spoofed Netlink packet which has been sent from an untrusted local user.
> Now Netlink messages with a non-zero nl_pid source address are ignored
> and a
On Fri, Nov 09, 2012 at 03:56:14PM +, KY Srinivasan wrote:
> > -Original Message-
> > From: Tomas Hozza [mailto:tho...@redhat.com]
KY, there have been a few of these tools/hv patches floating by, and you
haven't acked all of them from what I can tell. I've applied some of
them, but
On Thu, Nov 15, 2012 at 05:45:32PM +0530, Kumar Amit Mehta wrote:
> Inspect the return value of put_user() and return -EFAULT on error.
>
> Signed-off-by: Kumar Amit Mehta
This no longer applies to my tree, care to refresh and try again?
thanks,
greg k-h
___
On Thu, Nov 15, 2012 at 09:57:42PM +0530, Arpith Easow Alexander wrote:
> On Tue, Nov 13, 2012 at 11:52:52AM -0800, Greg KH wrote:
> > On Sat, Nov 10, 2012 at 12:38:38PM +0530, Arpith Easow Alexander wrote:
> > > This is a patch to the vmk80xx.c file that replaces the printk with
> > > dev_dbg.
>
On Thu, Nov 15, 2012 at 02:34:42PM -0800, Andrew Morton wrote:
> On Thu, 15 Nov 2012 22:22:06 +
> KY Srinivasan wrote:
>
> >
> >
> > > -Original Message-
> > > From: Greg KH [mailto:gre...@linuxfoundation.org]
> > > Sent: Friday, November 02, 2012 7:37 PM
> > > To: KY Srinivasan
> >
On Thu, 15 Nov 2012 22:22:06 +
KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Greg KH [mailto:gre...@linuxfoundation.org]
> > Sent: Friday, November 02, 2012 7:37 PM
> > To: KY Srinivasan
> > Cc: linux-ker...@vger.kernel.org; devel@linuxdriverproject.org
> > Subject: Re:
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Friday, November 02, 2012 7:37 PM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; devel@linuxdriverproject.org
> Subject: Re: drivres/hv
>
> On Fri, Nov 02, 2012 at 03:11:23PM -0700, K. Y. Srinivasan
On Thu, 2012-11-15 at 22:03 +0100, Markus Grabner wrote:
> Am Mittwoch, 14. November 2012, 17:33:05 schrieb Dan Carpenter:
> > The reason this is hitting the 80 character limit is because
> > "LINE6_INDEX_PCM_ALSA_CAPTURE_STREAM" is 35 characters long. It
> > isn't even clear from the name what it
On Thu, Nov 15, 2012 at 10:03:27PM +0100, Markus Grabner wrote:
> Am Mittwoch, 14. November 2012, 17:33:05 schrieb Dan Carpenter:
> > On Sun, Nov 11, 2012 at 01:24:39PM +0100, Stefan Hajnoczi wrote:
> > > Signed-off-by: Stefan Hajnoczi
> > > ---
> > >
> > > drivers/staging/line6/capture.c | 13 +
Am Mittwoch, 14. November 2012, 17:33:05 schrieb Dan Carpenter:
> On Sun, Nov 11, 2012 at 01:24:39PM +0100, Stefan Hajnoczi wrote:
> > Signed-off-by: Stefan Hajnoczi
> > ---
> >
> > drivers/staging/line6/capture.c | 13 -
> > 1 file changed, 8 insertions(+), 5 deletions(-)
> >
> > d
On Fri, Nov 16, 2012 at 5:43 AM, Dan Carpenter wrote:
>
> Btw:
>> + dev_dbg(&port->dev, "Line status status.\n");
> ^^^
> These kind of debug statements which just tell which function is
> being called can be deleted. The function t
Btw:
> + dev_dbg(&port->dev, "Line status status.\n");
^^^
These kind of debug statements which just tell which function is
being called can be deleted. The function tracer already provides
that information.
> + fn = Pr
On Fri, Nov 16, 2012 at 5:18 AM, Dan Carpenter wrote:
> On Fri, Nov 16, 2012 at 05:01:55AM +0900, YAMANE Toshiaki wrote:
>> On Wed, Nov 14, 2012 at 9:41 PM, Dan Carpenter
>> wrote:
>> >
>> > Why can't we test whether i == (RxCount - 3) earlier and handle
>> > the errors there? That way we would
On Fri, Nov 16, 2012 at 05:01:55AM +0900, YAMANE Toshiaki wrote:
> On Wed, Nov 14, 2012 at 9:41 PM, Dan Carpenter
> wrote:
> >
> > Why can't we test whether i == (RxCount - 3) earlier and handle
> > the errors there? That way we wouldn't need to pass the limit
> > variable.
> >
> > In fact, this
On Wed, Nov 14, 2012 at 9:41 PM, Dan Carpenter wrote:
>
> Why can't we test whether i == (RxCount - 3) earlier and handle
> the errors there? That way we wouldn't need to pass the limit
> variable.
>
> In fact, this whole function is sort of nasty. We start by doing
> a switch (data[i + 2]) { th
Inspect the return value of register_netdev() in the driver probe routine and
return -ENODEV in case of error.
Signed-off-by: Kumar Amit Mehta
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl819
On Thursday, November 15, 2012 9:28 AM, Arpith Easow Alexander wrote:
> On Tue, Nov 13, 2012 at 11:52:52AM -0800, Greg KH wrote:
>> So a macro called dbgcm tests a variable called dbgcm? Gotta love c at
>> times...
>>
>> Just delete the macro, and the variable, and call dev_dbg() directly
>> plea
On Tue, Nov 13, 2012 at 11:52:52AM -0800, Greg KH wrote:
> On Sat, Nov 10, 2012 at 12:38:38PM +0530, Arpith Easow Alexander wrote:
> > This is a patch to the vmk80xx.c file that replaces the printk with dev_dbg.
> > This fixes the warnings found by the checkpatch.pl tool.
> >
> > Signed-off-by: Ar
On 15 November 2012 14:03, Dan Carpenter wrote:
> On Thu, Nov 15, 2012 at 01:27:21PM +, Mark Einon wrote:
>> Trivial Whitespace changes only. No checkpatch errors exist in et131x
>> after this change.
>>
>
> This breaks the build.
Hi Dan,
Thanks for pointing that out - due to a missing brack
On Thu, Nov 15, 2012 at 01:27:21PM +, Mark Einon wrote:
> Trivial Whitespace changes only. No checkpatch errors exist in et131x
> after this change.
>
This breaks the build.
regards,
dan carpenter
___
devel mailing list
devel@linuxdriverproject.or
On Thu, Nov 15, 2012 at 01:27:17PM +, Mark Einon wrote:
> This padding was used to align buffers to a 4k boundary when returned
> from dma_alloc_coherent(). As the buffers are already 4k aligned, and
> the alignment no longer performed, the padding is not needed.
>
> Signed-off-by: Mark Einon
On Thu, Nov 15, 2012 at 01:27:20PM +, Mark Einon wrote:
> for (rfdct = 0; rfdct < rx_ring->num_rfd; rfdct++) {
> - rfd = kmem_cache_alloc(rx_ring->recv_lookaside,
> - GFP_ATOMIC | GFP_DMA);
> + rfd = kcalloc(1, sizeo
Trivial Whitespace changes only. No checkpatch errors exist in et131x
after this change.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 43 +++
1 file changed, 26 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b
This padding was used to align buffers to a 4k boundary when returned
from dma_alloc_coherent(). As the buffers are already 4k aligned, and
the alignment no longer performed, the padding is not needed.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c |8 +++-
1 file changed,
The use of a kmem_cache was noted as being unusual in the TODO. Replace
the kmem_cache with kmalloc/kfree so that the code is less suprising.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/README |1 -
drivers/staging/et131x/et131x.c | 37 +
2 fi
A previous change removed code that aligned memory returned from
dma_alloc_coherent() to a 4k boundary, which was not necessary.
Some comments regarding this alignment still exist, so remove them
as they no longer apply.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 10 -
This change negates an 'if' statement, allowing a large block of code
to be un-indented, making the code more readable.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/drive
By negating a 'status' variable check in et131x_isr(), we can remove
the indenting of a large block of code, increasing the readability.
This patch does exactly that.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 295 +++
1 file changed, 14
Inspect the return value of put_user() and return -EFAULT on error.
Signed-off-by: Kumar Amit Mehta
---
drivers/staging/dgrp/dgrp_tty.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/dgrp/dgrp_tty.c b/drivers/staging/dgrp/dgrp_tty.c
index e125b03
33 matches
Mail list logo
