Re: [PATCH] zram: Prevent use of unmapped buffer

2012-11-27 Thread Minchan Kim
Hi Nitin, On Mon, Nov 26, 2012 at 11:26:07PM -0800, Nitin Gupta wrote: > The commit c8f2f0db1 ("zram: Fix handling of incompressible pages") > introduced a bug which caused a kunmap()'ed buffer to be used in case I got confused by the descripton. :( The descripton is not right. The problem is to

Re: [PATCH v4] drivers: staging: remove last usage of NIPQUAD and NIP6 in gdm72xx

2012-11-27 Thread Shan Wei
Greg KH said, at 2012/11/28 1:19: > On Tue, Nov 27, 2012 at 10:37:46AM +0800, Shan Wei wrote: >> From: Shan Wei >> >> commit cf4ca4874fc45 removed the definition of NIPQUAD and NIPQUAD_FMT, >> and NIP6 also is out of date. >> >> Because DEBUG_SDU is not defined in gdm_wimax.h, no error message whe

Re: [PATCH v2 1/1] staging: fwserial: Add TTY-over-Firewire serial driver

2012-11-27 Thread Peter Hurley
On Wed, 2012-11-28 at 00:58 +0100, Stefan Richter wrote: > On Nov 27 Peter Hurley wrote: > > > > Currently, firewire-net sets an arbitrary address handler length of > > > > 4096. This works because the largest AR packet size the current > > > > firewire-ohci driver handles is 4096 (value of MAX_ASY

Re: [PATCH -next] staging/fwserial: Fix build breakage when !CONFIG_BUG

2012-11-27 Thread Peter Hurley
On Tue, 2012-11-27 at 10:42 -0800, Randy Dunlap wrote: > On 11/26/2012 11:11 PM, Peter Hurley wrote: > > > Use WARN() as intended. > > > > Signed-off-by: Peter Hurley > > > Reported-by: Randy Dunlap > Acked-by: Randy Dunlap > > Thanks. Hi Randy, I blew this, sorry. First, I mistakenly se

Re: [PATCH v2 1/1] staging: fwserial: Add TTY-over-Firewire serial driver

2012-11-27 Thread Stefan Richter
On Nov 27 Peter Hurley wrote: > > > Currently, firewire-net sets an arbitrary address handler length of > > > 4096. This works because the largest AR packet size the current > > > firewire-ohci driver handles is 4096 (value of MAX_ASYNC_PAYLOAD) + > > > header/trailer. Note that firewire-ohci does

Re: [PATCH 2/8] mm: frontswap: lazy initialization to allow tmem backends to build/run as modules

2012-11-27 Thread Konrad Rzeszutek Wilk
On Mon, Nov 19, 2012 at 02:25:16PM -0800, Andrew Morton wrote: > On Mon, 19 Nov 2012 08:53:46 +0800 > Bob Liu wrote: > > > On Sat, Nov 17, 2012 at 7:16 AM, Andrew Morton > > wrote: > > > On Wed, 14 Nov 2012 13:57:06 -0500 > > > Konrad Rzeszutek Wilk wrote: > > > > > >> From: Dan Magenheimer >

Re: [PATCH 1/1] mm: Export a function to get vm committed memory

2012-11-27 Thread Konrad Rzeszutek Wilk
On Tue, Nov 13, 2012 at 01:07:30PM -0800, David Rientjes wrote: > On Tue, 13 Nov 2012, K. Y. Srinivasan wrote: > > > It will be useful to be able to access global memory commitment from device > > drivers. On the Hyper-V platform, the host has a policy engine to balance > > the available physical

Re: [PATCH 1/3] tools/hv: Fix for long file names from readdir

2012-11-27 Thread Ben Hutchings
On Tue, Nov 27, 2012 at 03:28:25PM -0500, Tomas Hozza wrote: > > > - Original Message - > > On Tue, 2012-11-27 at 08:56 +0100, Tomas Hozza wrote: > > > kvp_get_if_name and kvp_mac_to_if_name copy strings into statically > > > sized buffers which could be too small to store really long nam

Re: [PATCH 1/3] tools/hv: Fix for long file names from readdir

2012-11-27 Thread Tomas Hozza
- Original Message - > On Tue, 2012-11-27 at 08:56 +0100, Tomas Hozza wrote: > > kvp_get_if_name and kvp_mac_to_if_name copy strings into statically > > sized buffers which could be too small to store really long names. > > > > Buffer sizes have been changed to PATH_MAX, include "limits.h

Re: [PATCH -next] staging/fwserial: Fix build breakage when !CONFIG_BUG

2012-11-27 Thread Randy Dunlap
On 11/26/2012 11:11 PM, Peter Hurley wrote: > Use WARN() as intended. > > Signed-off-by: Peter Hurley Reported-by: Randy Dunlap Acked-by: Randy Dunlap Thanks. > --- > drivers/staging/fwserial/dma_fifo.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/

Re: [PATCH v2 1/1] staging: fwserial: Add TTY-over-Firewire serial driver

2012-11-27 Thread Peter Hurley
On Wed, 2012-11-14 at 02:25 +0100, Stefan Richter wrote: > On Nov 13 Peter Hurley wrote: > > On Tue, 2012-11-13 at 00:33 +0100, Stefan Richter wrote: > > > On Nov 02 Peter Hurley wrote: > > > > +2. MAX_ASYNC_PAYLOAD needs to be publicly exposed by core/ohci > > > > + - otherwise how will this dri

Re: staging: r8712u: Add the new driver to the mainline kernel

2012-11-27 Thread Larry Finger
On 11/24/2012 02:16 PM, Dan Carpenter wrote: Hello Larry Finger, The patch 2865d42c78a9: "staging: r8712u: Add the new driver to the mainline kernel" from Aug 20, 2010, leads to the following warning: drivers/staging/rtl8712/mlme_linux.c:161 r8712_report_sec_ie() error: buffer overflow

Re: [PATCH v3] drivers: staging: remove last usage of NIPQUAD and NIP6 in gdm72xx

2012-11-27 Thread Greg KH
On Tue, Nov 27, 2012 at 10:37:46AM +0800, Shan Wei wrote: > From: Shan Wei > > commit cf4ca4874fc45 removed the definition of NIPQUAD and NIPQUAD_FMT, > and NIP6 also is out of date. > > Because DEBUG_SDU is not defined in gdm_wimax.h, no error message when > compiling > this code. And remove c

Re: [PATCH 2/2] zram: reduce metadata overhead

2012-11-27 Thread Jerome Marchand
On 11/27/2012 08:26 AM, Nitin Gupta wrote: > For every allocated object, zram maintains the the handle, size, > flags and count fields. Of these, only the handle is required > since zsmalloc now provides the object size given the handle. > The flags field was needed only to mark a given page as zer

Re: [PATCH 1/3] tools/hv: Fix for long file names from readdir

2012-11-27 Thread Ben Hutchings
On Tue, 2012-11-27 at 08:56 +0100, Tomas Hozza wrote: > kvp_get_if_name and kvp_mac_to_if_name copy strings into statically > sized buffers which could be too small to store really long names. > > Buffer sizes have been changed to PATH_MAX, include "limits.h" where > PATH_MAX is defined was added a

RE: [PATCH 3/3] tools/hv: Fix permissions of created directory and files

2012-11-27 Thread KY Srinivasan
> -Original Message- > From: Tomas Hozza [mailto:tho...@redhat.com] > Sent: Tuesday, November 27, 2012 2:57 AM > To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > devel@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@redhat.com; KY Srinivasan; b...@dec

RE: [PATCH 2/3] tools/hv: Fix /var subdirectory

2012-11-27 Thread KY Srinivasan
> -Original Message- > From: Tomas Hozza [mailto:tho...@redhat.com] > Sent: Tuesday, November 27, 2012 2:57 AM > To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > devel@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@redhat.com; KY Srinivasan; b...@dec

RE: [PATCH 1/3] tools/hv: Fix for long file names from readdir

2012-11-27 Thread KY Srinivasan
> -Original Message- > From: Tomas Hozza [mailto:tho...@redhat.com] > Sent: Tuesday, November 27, 2012 2:57 AM > To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > devel@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@redhat.com; KY Srinivasan; b...@dec

Re: [PATCH] zram: Prevent use of unmapped buffer

2012-11-27 Thread Tomas M
Good work. The patch fixes a serious bug on 3.6.5, 3.6.6, 3.6.7 and 3.6.8 I hope it gets mainlined ASAP Tomas M slax.org On Tue, Nov 27, 2012 at 8:26 AM, Nitin Gupta wrote: > The commit c8f2f0db1 ("zram: Fix handling of incompressible pages") > introduced a bug which caused a kunmap()'ed buffer