Re: [PATCH] Staging: ft1000-usb: Fix call to obsolete function

2012-12-05 Thread Dan Carpenter
On Wed, Dec 05, 2012 at 02:14:55PM -0500, devendra.aaru wrote: > On Wed, Dec 5, 2012 at 2:03 PM, Kurt Kanzenbach wrote: > > strict_strtoul is obsolete and should be replaced with > > kstrto* function as reported by checkpatch.pl. > > pInfo->CardNumber is a u8. This is why kstrtou8 should be > > us

Re: [patch 2/2] staging: line6: use after free bug requesting version

2012-12-05 Thread Dan Carpenter
On Thu, Dec 06, 2012 at 06:18:02AM +0100, Stefan Hajnoczi wrote: > On Wed, Dec 5, 2012 at 7:44 PM, Dan Carpenter > wrote: > > diff --git a/drivers/staging/line6/driver.c b/drivers/staging/line6/driver.c > > index 8a5d89e..884e0d8 100644 > > --- a/drivers/staging/line6/driver.c > > +++ b/drivers/s

Re: [PATCH 3/6] staging/rtl8192u: indent with tabs, not spaces

2012-12-05 Thread Dan Carpenter
On Wed, Dec 05, 2012 at 09:40:20PM +0100, Sebastian Hahn wrote: > Converted staging/rtl8187se to use tabs instead of spaces for > indentation to fix the checkpatch error "code indent should use tabs > where possible". > > Signed-off-by: Sebastian Hahn > --- > drivers/staging/rtl8192u/ieee80211/i

Re: [patch 1/2] staging: line6: delete an unused function

2012-12-05 Thread Stefan Hajnoczi
On Wed, Dec 5, 2012 at 7:43 PM, Dan Carpenter wrote: > line6_send_sysex_message_async() isn't called from anywhere. > > Signed-off-by: Dan Carpenter Reviewed-by: Stefan Hajnoczi ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linu

Re: [patch 2/2] staging: line6: use after free bug requesting version

2012-12-05 Thread Stefan Hajnoczi
On Wed, Dec 5, 2012 at 7:44 PM, Dan Carpenter wrote: > diff --git a/drivers/staging/line6/driver.c b/drivers/staging/line6/driver.c > index 8a5d89e..884e0d8 100644 > --- a/drivers/staging/line6/driver.c > +++ b/drivers/staging/line6/driver.c > @@ -110,7 +110,7 @@ struct message { > */ > static v

Re: [PATCH 1/2] Staging: android: binder: Add support for 32bit binder calls in a 64bit kernel

2012-12-05 Thread Arve Hjønnevåg
On Wed, Dec 5, 2012 at 6:54 AM, Serban Constantinescu wrote: > On 05/12/12 00:26, Arve Hjønnevåg wrote: >> >> On Tue, Dec 4, 2012 at 2:44 AM, Serban Constantinescu >> wrote: >>> >>> Android's IPC, Binder, does not support calls from a 32-bit userspace >>> in a 64 bit kernel. This patch adds suppo

[PATCH 6/6] staging/rtl8192u: do not init statics to 0

2012-12-05 Thread Sebastian Hahn
Fix the checkpatch error "do not initialize statics to 0 or NULL" Signed-off-by: Sebastian Hahn --- .../staging/rtl8192u/ieee80211/ieee80211_softmac.c |2 +- .../rtl8192u/ieee80211/ieee80211_softmac_wx.c |2 +- drivers/staging/rtl8192u/r8192U_core.c | 14 +++ drive

[PATCH 5/6] staging/rtl8192u: use same indent for switch and case

2012-12-05 Thread Sebastian Hahn
Fix the checkpatch error "switch and case should be at the same indent" Signed-off-by: Sebastian Hahn --- .../staging/rtl8192u/ieee80211/ieee80211_softmac.c | 272 drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 32 +- drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c |

[PATCH 3/6] staging/rtl8192u: indent with tabs, not spaces

2012-12-05 Thread Sebastian Hahn
Converted staging/rtl8187se to use tabs instead of spaces for indentation to fix the checkpatch error "code indent should use tabs where possible". Signed-off-by: Sebastian Hahn --- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 14 +- drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c |

[PATCH 4/6] staging/rtl8192u: don't init globals to 0 or NULL

2012-12-05 Thread Sebastian Hahn
Fix a couple of instances where checkpatch complained about initializing globals with 0. Signed-off-by: Sebastian Hahn --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211

[PATCH 2/6] staging/rtl8192u: put { on same line as struct

2012-12-05 Thread Sebastian Hahn
From: Jennifer Naumann This fixes the checkpatch error "open brace '{' following struct go on the same line" in staging/rtl8192u Signed-off-by: Jennifer Naumann --- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 12 ++--- drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h |3 +- drive

[PATCH 0/6] staging:rtl8192u: begin cleanup of some checkpatch errors

2012-12-05 Thread Sebastian Hahn
Jennifer and I have started making the rtl8192u driver conform with the CodingStyle rules a little better. We started out with a cleanfile run, then did corrections for individual issues, grouped into patches by specific issue fixed. Note that this is in no way a complete cleanup, and since we con

Re: [PATCH] Staging: ft1000-usb: Fix call to obsolete function

2012-12-05 Thread devendra.aaru
On Wed, Dec 5, 2012 at 2:03 PM, Kurt Kanzenbach wrote: > strict_strtoul is obsolete and should be replaced with > kstrto* function as reported by checkpatch.pl. > pInfo->CardNumber is a u8. This is why kstrtou8 should be > used here. > > Signed-off-by: Kurt Kanzenbach > --- > drivers/staging/ft1

[PATCH] Staging: ft1000-usb: Fix call to obsolete function

2012-12-05 Thread Kurt Kanzenbach
strict_strtoul is obsolete and should be replaced with kstrto* function as reported by checkpatch.pl. pInfo->CardNumber is a u8. This is why kstrtou8 should be used here. Signed-off-by: Kurt Kanzenbach --- drivers/staging/ft1000/ft1000-usb/ft1000_hw.c |4 ++-- 1 file changed, 2 insertions(+)

[patch 2/2] staging: line6: use after free bug requesting version

2012-12-05 Thread Dan Carpenter
In line6_version_request_async() we set up an async message but we free the buffer with the version in it before the message has been sent. I've introduced a new function line6_async_request_sent_free_buffer() which frees the data after we are done with it. I've added a "free" parameter to the li

[patch 1/2] staging: line6: delete an unused function

2012-12-05 Thread Dan Carpenter
line6_send_sysex_message_async() isn't called from anywhere. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/line6/driver.h b/drivers/staging/line6/driver.h index f0be5a2..1dd768c2 100644 --- a/drivers/staging/line6/driver.h +++ b/drivers/staging/line6/driver.h @@ -208,8 +208,6 @@ exte

Re: Fwd: Re: [PATCH 1/2] Staging: android: binder: Add support for 32bit binder calls in a 64bit kernel

2012-12-05 Thread Greg KH
On Wed, Dec 05, 2012 at 04:39:49PM +, Serban Constantinescu wrote: > >I was wondering when someone would notice that this code was not going > >to work for this type of system, nice to see that you are working to fix > >it up. But, I'll reask Dan's question here, why not use the compat32 > >io

Fwd: Re: [PATCH 1/2] Staging: android: binder: Add support for 32bit binder calls in a 64bit kernel

2012-12-05 Thread Serban Constantinescu
Sorry for the disclaimer e-mail. On 04/12/12 16:17, Greg KH wrote: On Tue, Dec 04, 2012 at 10:44:13AM +, Serban Constantinescu wrote: Android's IPC, Binder, does not support calls from a 32-bit userspace in a 64 bit kernel. This patch adds support for syscalls coming from a 32-bit userspace

Re: [PATCH 1/2] Staging: android: binder: Add support for 32bit binder calls in a 64bit kernel

2012-12-05 Thread Greg KH
On Wed, Dec 05, 2012 at 02:31:02PM +, Serban Constantinescu wrote: > -- IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > cont

Re: [PATCH 1/2] Staging: android: binder: Add support for 32bit binder calls in a 64bit kernel

2012-12-05 Thread Serban Constantinescu
On 05/12/12 00:26, Arve Hjønnevåg wrote: On Tue, Dec 4, 2012 at 2:44 AM, Serban Constantinescu wrote: Android's IPC, Binder, does not support calls from a 32-bit userspace in a 64 bit kernel. This patch adds support for syscalls coming from a 32-bit userspace in a 64-bit kernel. It also seem

Re: [PATCH 1/2] Staging: android: binder: Add support for 32bit binder calls in a 64bit kernel

2012-12-05 Thread Serban Constantinescu
On 04/12/12 16:17, Greg KH wrote: On Tue, Dec 04, 2012 at 10:44:13AM +, Serban Constantinescu wrote: Android's IPC, Binder, does not support calls from a 32-bit userspace in a 64 bit kernel. This patch adds support for syscalls coming from a 32-bit userspace in a 64-bit kernel. Most of the

Re: [PATCH 2/2] Staging: android: ashmem: Add support for 32bit ashmem calls in a 64bit kernel

2012-12-05 Thread Serban Constantinescu
On 04/12/12 11:45, Dan Carpenter wrote: I don't understand this, and I'm going to embarrass myself by displaying my ignorance for all to see. Why is this code so different from all the other 32 bit compat code that we have in the kernel? On Tue, Dec 04, 2012 at 10:44:14AM +, Serban Constant

制定规 章制度、员工手 册的法定程序实 务操作技 巧

2012-12-05 Thread 17:46:25793603489449983
如)何预防规 章制)度违反法)律法 规的规定所带来的风)险.xls Description: Binary data ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Re: [PATCH] staging: rtl8712: avoid a useless call to memset().

2012-12-05 Thread walter harms
Hi Cyril, you patch is correct ..but being an advocate of defensive programming i would say the original version especially since the number of bytes is small. re, wh Am 05.12.2012 02:22, schrieb Cyril Roelandt: > In r8711_wx_get_wap(), make sure we do not call memcpy() on a memory area that > h