On Wed, Dec 05, 2012 at 02:14:55PM -0500, devendra.aaru wrote:
> On Wed, Dec 5, 2012 at 2:03 PM, Kurt Kanzenbach wrote:
> > strict_strtoul is obsolete and should be replaced with
> > kstrto* function as reported by checkpatch.pl.
> > pInfo->CardNumber is a u8. This is why kstrtou8 should be
> > us
On Thu, Dec 06, 2012 at 06:18:02AM +0100, Stefan Hajnoczi wrote:
> On Wed, Dec 5, 2012 at 7:44 PM, Dan Carpenter
> wrote:
> > diff --git a/drivers/staging/line6/driver.c b/drivers/staging/line6/driver.c
> > index 8a5d89e..884e0d8 100644
> > --- a/drivers/staging/line6/driver.c
> > +++ b/drivers/s
On Wed, Dec 05, 2012 at 09:40:20PM +0100, Sebastian Hahn wrote:
> Converted staging/rtl8187se to use tabs instead of spaces for
> indentation to fix the checkpatch error "code indent should use tabs
> where possible".
>
> Signed-off-by: Sebastian Hahn
> ---
> drivers/staging/rtl8192u/ieee80211/i
On Wed, Dec 5, 2012 at 7:43 PM, Dan Carpenter wrote:
> line6_send_sysex_message_async() isn't called from anywhere.
>
> Signed-off-by: Dan Carpenter
Reviewed-by: Stefan Hajnoczi
___
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linu
On Wed, Dec 5, 2012 at 7:44 PM, Dan Carpenter wrote:
> diff --git a/drivers/staging/line6/driver.c b/drivers/staging/line6/driver.c
> index 8a5d89e..884e0d8 100644
> --- a/drivers/staging/line6/driver.c
> +++ b/drivers/staging/line6/driver.c
> @@ -110,7 +110,7 @@ struct message {
> */
> static v
On Wed, Dec 5, 2012 at 6:54 AM, Serban Constantinescu
wrote:
> On 05/12/12 00:26, Arve Hjønnevåg wrote:
>>
>> On Tue, Dec 4, 2012 at 2:44 AM, Serban Constantinescu
>> wrote:
>>>
>>> Android's IPC, Binder, does not support calls from a 32-bit userspace
>>> in a 64 bit kernel. This patch adds suppo
Fix the checkpatch error "do not initialize statics to 0 or NULL"
Signed-off-by: Sebastian Hahn
---
.../staging/rtl8192u/ieee80211/ieee80211_softmac.c |2 +-
.../rtl8192u/ieee80211/ieee80211_softmac_wx.c |2 +-
drivers/staging/rtl8192u/r8192U_core.c | 14 +++
drive
Fix the checkpatch error "switch and case should be at the same indent"
Signed-off-by: Sebastian Hahn
---
.../staging/rtl8192u/ieee80211/ieee80211_softmac.c | 272
drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 32 +-
drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c |
Converted staging/rtl8187se to use tabs instead of spaces for
indentation to fix the checkpatch error "code indent should use tabs
where possible".
Signed-off-by: Sebastian Hahn
---
drivers/staging/rtl8192u/ieee80211/ieee80211.h | 14 +-
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c |
Fix a couple of instances where checkpatch complained about
initializing globals with 0.
Signed-off-by: Sebastian Hahn
---
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211
From: Jennifer Naumann
This fixes the checkpatch error "open brace '{' following struct go on the
same line" in staging/rtl8192u
Signed-off-by: Jennifer Naumann
---
drivers/staging/rtl8192u/ieee80211/ieee80211.h | 12 ++---
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h |3 +-
drive
Jennifer and I have started making the rtl8192u driver conform with the
CodingStyle rules a little better. We started out with a cleanfile run,
then did corrections for individual issues, grouped into patches by
specific issue fixed.
Note that this is in no way a complete cleanup, and since we con
On Wed, Dec 5, 2012 at 2:03 PM, Kurt Kanzenbach wrote:
> strict_strtoul is obsolete and should be replaced with
> kstrto* function as reported by checkpatch.pl.
> pInfo->CardNumber is a u8. This is why kstrtou8 should be
> used here.
>
> Signed-off-by: Kurt Kanzenbach
> ---
> drivers/staging/ft1
strict_strtoul is obsolete and should be replaced with
kstrto* function as reported by checkpatch.pl.
pInfo->CardNumber is a u8. This is why kstrtou8 should be
used here.
Signed-off-by: Kurt Kanzenbach
---
drivers/staging/ft1000/ft1000-usb/ft1000_hw.c |4 ++--
1 file changed, 2 insertions(+)
In line6_version_request_async() we set up an async message but we free
the buffer with the version in it before the message has been sent.
I've introduced a new function line6_async_request_sent_free_buffer()
which frees the data after we are done with it. I've added a "free"
parameter to the li
line6_send_sysex_message_async() isn't called from anywhere.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/line6/driver.h b/drivers/staging/line6/driver.h
index f0be5a2..1dd768c2 100644
--- a/drivers/staging/line6/driver.h
+++ b/drivers/staging/line6/driver.h
@@ -208,8 +208,6 @@ exte
On Wed, Dec 05, 2012 at 04:39:49PM +, Serban Constantinescu wrote:
> >I was wondering when someone would notice that this code was not going
> >to work for this type of system, nice to see that you are working to fix
> >it up. But, I'll reask Dan's question here, why not use the compat32
> >io
Sorry for the disclaimer e-mail.
On 04/12/12 16:17, Greg KH wrote:
On Tue, Dec 04, 2012 at 10:44:13AM +, Serban Constantinescu wrote:
Android's IPC, Binder, does not support calls from a 32-bit userspace
in a 64 bit kernel. This patch adds support for syscalls coming from a
32-bit userspace
On Wed, Dec 05, 2012 at 02:31:02PM +, Serban Constantinescu wrote:
> -- IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> cont
On 05/12/12 00:26, Arve Hjønnevåg wrote:
On Tue, Dec 4, 2012 at 2:44 AM, Serban Constantinescu
wrote:
Android's IPC, Binder, does not support calls from a 32-bit userspace
in a 64 bit kernel. This patch adds support for syscalls coming from a
32-bit userspace in a 64-bit kernel.
It also seem
On 04/12/12 16:17, Greg KH wrote:
On Tue, Dec 04, 2012 at 10:44:13AM +, Serban Constantinescu wrote:
Android's IPC, Binder, does not support calls from a 32-bit userspace
in a 64 bit kernel. This patch adds support for syscalls coming from a
32-bit userspace in a 64-bit kernel.
Most of the
On 04/12/12 11:45, Dan Carpenter wrote:
I don't understand this, and I'm going to embarrass myself by
displaying my ignorance for all to see. Why is this code so
different from all the other 32 bit compat code that we have in the
kernel?
On Tue, Dec 04, 2012 at 10:44:14AM +, Serban Constant
如)何预防规 章制)度违反法)律法 规的规定所带来的风)险.xls
Description: Binary data
___
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
Hi Cyril,
you patch is correct ..but being an advocate of defensive programming
i would say the original version especially since the number of bytes is small.
re,
wh
Am 05.12.2012 02:22, schrieb Cyril Roelandt:
> In r8711_wx_get_wap(), make sure we do not call memcpy() on a memory area that
> h
24 matches
Mail list logo