Hi Konrad,
On Fri, 2013-02-01 at 15:22 -0500, Konrad Rzeszutek Wilk wrote:
> From: Dan Magenheimer
>
> With the goal of allowing tmem backends (zcache, ramster, Xen tmem) to be
> built/loaded as modules rather than built-in and enabled by a boot parameter,
> this patch provides "lazy initializati
XGI_P3cc is unused and the assignment without side effects -> remove;
Data can be simply replaced by the Temp variable, which was changed to
temp in order to make checkpatch happy.
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/vb_setmode.c | 19 ---
1 files changed, 8 in
The code checks twice for if (pVBInfo->VBInfo & SetCRT2ToTV) without any
changes in between -> we can remove the second check.
And while at it we can also save the temp variable and use tempbx
directly.
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/vb_setmode.c | 34 ++--
Pindex and Pdata are unused -> remove
tempbx is unused -> remove
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/vb_setmode.c |7 +--
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/staging/xgifb/vb_setmode.c
index 10b9cb6
modeflag is unused in XGI_SetSeqRegs, XGI_GetTVInfo,
XGI_SetLCDRegs, XGI_GetRatePtrCRT2 -> remove
resinfo is unused in XGI_PreSetGroup1, XGI_SetGroup1, XGI_SetGroup2,
XGI_SetLCDRegs -> remove
push1,push2 are unused in XGI_SetLCDRegs -> remove
CRT1Index is unused in XGI_PreSetGroup1, XGI_SetL
Index is not used here -> remove.
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/vb_setmode.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/staging/xgifb/vb_setmode.c
index 53b5557..a7fb52f 100644
--- a/drivers/sta
The variables A,HBS and VBS are never read in XGIfb_mode_rate_to_ddata
and the assignment has no side effects -> so we can simply remove them.
Removing them causes VT, HT and cr_data3 to be unused -> remove them as well
and remove the assignmens to cr_data which are shadowed by a different
assignme
On Fri, 2013-02-01 at 09:13 -0600, Seth Jennings wrote:
> On 01/31/2013 07:39 PM, Simon Jeons wrote:
> > Hi Seth,
> > On Tue, 2013-01-29 at 15:40 -0600, Seth Jennings wrote:
>
> >> Performance, Kernel Building:
> >>
> >> Setup
> >>
> >> Gentoo w/ kernel v3.7-rc7
> >> Quad-core i5-2500 @ 3
On Sat, 2013-02-02 at 16:30 -0300, Ezequiel Garcia wrote:
> ptr = kmalloc(sizeof(foo));
> if (!ptr) {
> pr_err("Cannot allocate memory for foo\n");
> return -ENOMEM;
> }
> His argue against it was that kmalloc already takes care of
> reporting/printking
> a good deal of interesting
On Sat, Feb 02, 2013 at 09:11:38AM +, Ian Abbott wrote:
> On 01/02/13 22:07, Dan Carpenter wrote:
> >My nit-pick on this patch would be that the function comment should
> >be in the .c file and not the .h file.
>
> That comment is more of a hint for driver writers rather than a
> description o
On 01/02/13 22:07, Dan Carpenter wrote:
My nit-pick on this patch would be that the function comment should
be in the .c file and not the .h file.
That comment is more of a hint for driver writers rather than a
description of what the function does, so I considered it to be more
useful in the
11 matches
Mail list logo
