[PATCH 4/4 V2] Staging: bcm: Fix spelling error in PHSModule.c

2013-02-20 Thread Kevin McKinney
This patch fixes a spelling error in PHSModule.c Signed-off-by: Kevin McKinney --- drivers/staging/bcm/PHSModule.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c index 4837783..af5d22f 100644 --- a/drivers/

[PATCH 3/4 V2] Staging: bcm: Properly format comments in PHSModule.c

2013-02-20 Thread Kevin McKinney
This patch properly formats comments, and removes them as needed in PHSModule.c. Signed-off-by: Kevin McKinney --- drivers/staging/bcm/PHSModule.c | 543 --- 1 file changed, 272 insertions(+), 271 deletions(-) diff --git a/drivers/staging/bcm/PHSModule.c b/d

[PATCH 2/4 V2] Staging: bcm: Properly format braces in PHSModule.c

2013-02-20 Thread Kevin McKinney
This patch formats braces in PHSModule.c as reported by checkpatch.pl. Signed-off-by: Kevin McKinney --- drivers/staging/bcm/PHSModule.c | 433 +-- 1 file changed, 140 insertions(+), 293 deletions(-) diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/sta

[PATCH] staging: fix all sparse warnings in silicom/bypasslib/

2013-02-20 Thread Randy Dunlap
From: Randy Dunlap Fix all sparse warning in drivers/staging/silicom/bypasslib/, e.g.: drivers/staging/silicom/bypasslib/bypass.c:471:21: warning: non-ANSI function declaration of function 'init_lib_module' drivers/staging/silicom/bypasslib/bypass.c:478:25: warning: non-ANSI function declarat

[PATCHv6 6/8] mm: allow for outstanding swap writeback accounting

2013-02-20 Thread Seth Jennings
To prevent flooding the swap device with writebacks, frontswap backends need to count and limit the number of outstanding writebacks. The incrementing of the counter can be done before the call to __swap_writepage(). However, the caller must receive a notification when the writeback completes in

[PATCHv6 5/8] mm: break up swap_writepage() for frontswap backends

2013-02-20 Thread Seth Jennings
swap_writepage() is currently where frontswap hooks into the swap write path to capture pages with the frontswap_store() function. However, if a frontswap backend wants to "resume" the writeback of a page to the swap device, it can't call swap_writepage() as the page will simply reenter the backend

[PATCHv6 7/8] zswap: add swap page writeback support

2013-02-20 Thread Seth Jennings
This patch adds support for evicting swap pages that are currently compressed in zswap to the swap device. This functionality is very important and make zswap a true cache in that, once the cache is full or can't grow due to memory pressure, the oldest pages can be moved out of zswap to the swap d

[PATCHv6 2/8] zsmalloc: add documentation

2013-02-20 Thread Seth Jennings
This patch adds a documentation file for zsmalloc at Documentation/vm/zsmalloc.txt Signed-off-by: Seth Jennings --- Documentation/vm/zsmalloc.txt | 68 +++ 1 file changed, 68 insertions(+) create mode 100644 Documentation/vm/zsmalloc.txt diff --git a/Doc

[PATCHv6 3/8] debugfs: add get/set for atomic types

2013-02-20 Thread Seth Jennings
debugfs currently lack the ability to create attributes that set/get atomic_t values. This patch adds support for this through a new debugfs_create_atomic_t() function. Acked-by: Greg Kroah-Hartman Signed-off-by: Seth Jennings --- fs/debugfs/file.c | 42 ++

[PATCHv6 8/8] zswap: add documentation

2013-02-20 Thread Seth Jennings
This patch adds the documentation file for the zswap functionality Signed-off-by: Seth Jennings --- Documentation/vm/zswap.txt | 82 ++ 1 file changed, 82 insertions(+) create mode 100644 Documentation/vm/zswap.txt diff --git a/Documentation/vm/zswap

[PATCHv6 1/8] zsmalloc: add to mm/

2013-02-20 Thread Seth Jennings
= DO NOT MERGE, FOR REVIEW ONLY This patch introduces zsmalloc as new code, however, it already exists in drivers/staging. In order to build successfully, you must select EITHER to driver/staging version OR this version. Once zsmalloc is reviewed in this format (and hopefully accepted), I

[PATCHv6 4/8] zswap: add to mm/

2013-02-20 Thread Seth Jennings
zswap is a thin compression backend for frontswap. It receives pages from frontswap and attempts to store them in a compressed memory pool, resulting in an effective partial memory reclaim and dramatically reduced swap device I/O. Additionally, in most cases, pages can be retrieved from this compr

[PATCHv6 0/8] zswap: compressed swap caching

2013-02-20 Thread Seth Jennings
Changelog: v6: * fix access-after-free regression introduced in v5 (rb_erase() outside the lock) * fix improper freeing of rbtree (Cody) * fix comment typo (Ric) * add comments about ZS_MM_WO usage and page mapping mode (Joonsoo) * don't use page->object (Joonsoo) * remove DEBUG (Joonsoo) * reba

Re: [PATCHv5 4/8] zswap: add to mm/

2013-02-20 Thread Seth Jennings
On 02/18/2013 01:55 PM, Dan Magenheimer wrote: >> From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] >> Subject: Re: [PATCHv5 4/8] zswap: add to mm/ >> >> On 02/15/2013 10:04 PM, Ric Mason wrote: >>> On 02/14/2013 02:38 AM, Seth Jennings wrote: >> + * The statistics below are not protec

Re: [PATCH V3 1/1] staging: android: ashmem: get_name,set_name not to hold ashmem_mutex

2013-02-20 Thread Dan Carpenter
Look good. Acked-by: Dan Carpenter regards, dan carpenter ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

[PATCH V3 1/1] staging: android: ashmem: get_name,set_name not to hold ashmem_mutex

2013-02-20 Thread Shankar Brahadeeswaran
Problem: There exists a path in ashmem driver that could lead to acquistion of mm->mmap_sem, ashmem_mutex in reverse order. This could lead to deadlock in the system. For Example, assume that mmap is called on a ashmem region in the context of a thread say T1. sys_mmap_pgoff (1. acquires mm->mmap_

[PATCH V3 1/1] staging: android: ashmem: get_name,set_name not to

2013-02-20 Thread Shankar Brahadeeswaran
Hi Dan, Oh, now I got what you say. Thanks for your patience. I have done the necessary modifications. Re-submitting the patch here Shankar Brahadeeswaran (1): staging: android: ashmem: get_name,set_name not to hold ashmem_mutex drivers/staging/android/ashmem.c | 45 ++

Re: [PATCH 3/3] Staging: bcm: Properly format comments in PHSModule.c

2013-02-20 Thread Kevin McKinney
On Tue, Feb 19, 2013 at 11:48 PM, Gábor Stefanik wrote: > On Wed, Feb 20, 2013 at 5:25 AM, Kevin McKinney wrote: >> This patch properly formats comments, and removes >> them as needed in PHSModule.c. >> >> Signed-off-by: Kevin McKinney >> --- >> drivers/staging/bcm/PHSModule.c | 509 >> ++

Re: [PATCH V2 1/1] staging: android: ashmem: get_name,set_name not to hold ashmem_mutex

2013-02-20 Thread Dan Carpenter
On Wed, Feb 20, 2013 at 07:57:08PM +0530, Shankar Brahadeeswaran wrote: > --- a/drivers/staging/android/ashmem.c > +++ b/drivers/staging/android/ashmem.c > @@ -413,50 +413,66 @@ out: > > static int set_name(struct ashmem_area *asma, void __user *name) > { > - int ret = 0; > - > - mutex_

[PATCH V2 1/1] staging: android: ashmem: get_name,set_name not to hold ashmem_mutex

2013-02-20 Thread Shankar Brahadeeswaran
Problem: There exists a path in ashmem driver that could lead to acquistion of mm->mmap_sem, ashmem_mutex in reverse order. This could lead to deadlock in the system. For Example, assume that mmap is called on a ashmem region in the context of a thread say T1. sys_mmap_pgoff (1. acquires mm->mmap_

[PATCH V2 1/1] staging: android: ashmem: get_name,set_name not to hold ashmem_mutex

2013-02-20 Thread Shankar Brahadeeswaran
Hi Dan, Fixed the review comments and re-tested again. Hope the patch is clean atleast this time. Warm regards, Shankar Shankar Brahadeeswaran (1): staging: android: ashmem: get_name,set_name not to hold ashmem_mutex drivers/staging/android/ashmem.c | 56 ---

Re: [PATCH 1/1] staging: android: ashmem: get_name,set_name not to hold ashmem_mutex

2013-02-20 Thread Dan Carpenter
On Wed, Feb 20, 2013 at 05:53:59PM +0530, Shankar Brahadeeswaran wrote: > static int set_name(struct ashmem_area *asma, void __user *name) > { > int ret = 0; > - > - mutex_lock(&ashmem_mutex); > + char local_name[ASHMEM_NAME_LEN]; > > /* cannot change an existing mapping's n

[PATCH 1/1] staging: android: ashmem: get_name,set_name not to hold ashmem_mutex

2013-02-20 Thread Shankar Brahadeeswaran
Problem: There exists a path in ashmem driver that could lead to acquistion of mm->mmap_sem, ashmem_mutex in reverse order. This could lead to deadlock in the system. For Example, assume that mmap is called on a ashmem region in the context of a thread say T1. sys_mmap_pgoff (1. acquires mm->mmap_

[PATCH 1/1] staging: android: ashmem: get_name,set_name not to hold ashmem_mutex

2013-02-20 Thread Shankar Brahadeeswaran
Hi Greg, This patch is to fix a dead lock scenario that is created in ashmem driver. The inital patch for review was posted and I got some comments from Dan Carpeneter.I have incorporated the changes and re-tested the same. Submitting the final patch for your pursual. Warm Regards, Shankar Shanka

Re: [PATCH] staging: android: ashmem: get_name, set_name not to hold ashmem_mutex

2013-02-20 Thread Shankar Brahadeeswaran
Hi Dan, Thanks for the feedback. I have incorporated both your review comments and have re-tested the patch. I'll submit the patch for approval. Warm Regards, Shankar On Tue, Feb 19, 2013 at 7:08 PM, Dan Carpenter wrote: > Good job fixing the bug. :) > > My one concern would be that in set_nam