Re: [PATCH 09/49] staging: comedi: adv_pci1710: use the pci id_table 'driver_data'

2013-03-05 Thread Dan Carpenter
On Tue, Mar 05, 2013 at 09:59:29AM -0700, H Hartley Sweeten wrote: > Create an enum to the boardinfo and pass that enum in the pci_driver > id_table as the driver_data. > > Change the macro used to fill in the device table from PCI_DEVICE() to > PCI_VDEVICE(). This allows passing the enum as the n

Re: hyperv: is register a mandatory phase by hypervkvpd?

2013-03-05 Thread vaughan
于 2013年03月06日 01:02, Xitao Cao 写道: On Tue, Mar 5, 2013 at 11:42 PM, KY Srinivasan wrote: -Original Message- From: vaughan [mailto:vaughan@oracle.com] Sent: Tuesday, March 05, 2013 7:48 AM To: KY Srinivasan Cc: devel@linuxdriverproject.org; Haiyang Zhang; xitao@gmail.com Subje

Re: [PATCH 05/11] zcache: Make the debug code use pr_debug

2013-03-05 Thread Konrad Rzeszutek Wilk
On Mon, Mar 04, 2013 at 10:28:53AM -0800, Joe Perches wrote: > On Mon, 2013-03-04 at 13:18 -0500, Konrad Rzeszutek Wilk wrote: > > as if you are debugging this driver you would be using 'debug' > > on the command line anyhow - and this would dump the debug > > data on the proper loglevel. > > Plea

RE: [PATCH 01/01 v3] staging: comedi: adv_pci1724: new driver

2013-03-05 Thread H Hartley Sweeten
On Tuesday, March 05, 2013 12:58 PM, Ian Abbott wrote: > On 05/03/2013 17:17, Ian Abbott wrote: >> From: Frank Mori Hess >> >> New comedi driver for Advantech PCI-1724U with modifications by Ian >> Abbott . >> >> Signed-off-by: Ian Abbott >> --- >> v2: Fix missing `if (ret)` after call to `comedi

Re: [PATCH 01/01 v3] staging: comedi: adv_pci1724: new driver

2013-03-05 Thread Ian Abbott
On 05/03/2013 17:17, Ian Abbott wrote: From: Frank Mori Hess New comedi driver for Advantech PCI-1724U with modifications by Ian Abbott . Signed-off-by: Ian Abbott --- v2: Fix missing `if (ret)` after call to `comedi_alloc_subdevices()`. v3: Melded the 13 patches for v2 into a single patch.

[PATCH] staging: silicom: Remove redundant NULL check before kfree

2013-03-05 Thread Syam Sidhardhan
kfree on NULL pointer is a no-op. Signed-off-by: Syam Sidhardhan --- drivers/staging/silicom/bp_mod.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/silicom/bp_mod.c b/drivers/staging/silicom/bp_mod.c index 58c5f5c..b00769c 100644 --- a/drivers/stagi

Re: [PATCH 01/01 v3] staging: comedi: adv_pci1724: new driver

2013-03-05 Thread Frank Mori Hess
On Tue, Mar 5, 2013 at 12:17 PM, Ian Abbott wrote: > From: Frank Mori Hess > > New comedi driver for Advantech PCI-1724U with modifications by Ian > Abbott . > > Signed-off-by: Ian Abbott > --- > v2: Fix missing `if (ret)` after call to `comedi_alloc_subdevices()`. > v3: Melded the 13 patches fo

[PATCH 46/49] staging: comedi: addi_apci_1710: remove 'interrupt' from boardinfo

2013-03-05 Thread H Hartley Sweeten
Only one board type is supported by this driver. Remove the 'interrupt' field from the boardinfo and just call the function directly in v_ADDI_Interrupt(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/addi_apci_1710.c | 6 +- 1 f

[PATCH 49/49] staging: comedi: das08: remove 'id' from boardinfo

2013-03-05 Thread H Hartley Sweeten
With the bus specific code split out, the device id in the boardinfo is no longer needed. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das08.h | 1 - drivers/staging/comedi/drivers/das08_cs.c | 1 - drivers/staging/co

[PATCH 48/49] staging: comedi: addi_common: remove 'i_VendorId' and 'i_Device Id'

2013-03-05 Thread H Hartley Sweeten
The vendor/device ids in the boardinfo are not longer needed. Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- .../staging/comedi/drivers/addi-data/addi_common.h | 2 - drivers/staging/comedi/drivers/addi_apci_035.c | 2 - drivers/staging/comedi/dri

[PATCH 45/49] staging: comedi: addi_common: remove addi_find_boardinfo()

2013-03-05 Thread H Hartley Sweeten
All the users of the addi_common code now set the dev->board_ptr before calling addi_auto_attach(). Remove the unnecessary function that searches for the boardinfo. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- .../staging/comedi/drivers/addi-data/addi_common.c | 2

[PATCH 47/49] staging: comedi: addi_apci_1710: remove boardinfo

2013-03-05 Thread H Hartley Sweeten
This driver only uses the boardinfo to get the dev->board_name. Just use the dev->driver->driver_name and remove the unnecessary boardinfo completely. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/addi_apci_1710.c | 30 +--

[PATCH 44/49] staging: comedi: addi_apci_3xxx: use the pci id_table 'driver_data'

2013-03-05 Thread H Hartley Sweeten
Create an enum to the boardinfo and pass that enum in the pci_driver id_table as the driver_data. Change the macro used to fill in the device table from PCI_DEVICE() to PCI_VDEVICE(). This allows passing the enum as the next field. Set the dev->board_ptr before calling addi_auto_attach(). This re

[PATCH 43/49] staging: comedi: addi_apci_3200: use the pci id_table 'driver_data'

2013-03-05 Thread H Hartley Sweeten
Create an enum to the boardinfo and pass that enum in the pci_driver id_table as the driver_data. Change the macro used to fill in the device table from PCI_DEVICE() to PCI_VDEVICE(). This allows passing the enum as the next field. Set the dev->board_ptr before calling addi_auto_attach(). This re

[PATCH 42/49] staging: comedi: addi_apci_1564: set board_ptr before calling addi_auto_attach()

2013-03-05 Thread H Hartley Sweeten
This driver only supports a single PCI device. If we set the dev->board_ptr before calling addi_auto_attach() we remove the need for the common code to search for the boardinfo. Since the search is not done we can remove the unnecessary board information from the comedi_driver. Signed-off-by: H H

[PATCH 41/49] staging: comedi: addi_apci_1500: set board_ptr before calling addi_auto_attach()

2013-03-05 Thread H Hartley Sweeten
This driver only supports a single PCI device. If we set the dev->board_ptr before calling addi_auto_attach() we remove the need for the common code to search for the boardinfo. Since the search is not done we can remove the unnecessary board information from the comedi_driver. Signed-off-by: H H

[PATCH 40/49] staging: comedi: addi_apci_035: set board_ptr before calling addi_auto_attach()

2013-03-05 Thread H Hartley Sweeten
This driver only supports a single PCI device. If we set the dev->board_ptr before calling addi_auto_attach() we remove the need for the common code to search for the boardinfo. Since the search is not done we can remove the unnecessary board information from the comedi_driver. Signed-off-by: H H

[PATCH 39/49] staging: comedi: addi_common: allow driver to set the board_ptr

2013-03-05 Thread H Hartley Sweeten
The addi_apci_035, addi_apci_1500, addi_apci_1564, and addi_apci_3xxx drivers still use the addi_common code. Allow those drivers to set the dev->board_ptr before calling addi_auto_attach(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drive

[PATCH 38/49] staging: comedi: skel: cleanup the boardinfo

2013-03-05 Thread H Hartley Sweeten
For aesthetic reasons, add some whitespace to the boardinfo. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/skel.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/staging/comedi/drivers/

[PATCH 36/49] staging: comedi: skel: cleanup pci_driver declaration

2013-03-05 Thread H Hartley Sweeten
For aesthetic reasons, add some whitespace to the pci_driver declaration. Also, move the pci device table near the pci_driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/skel.c | 33 +++-- 1 file change

[PATCH 37/49] staging: comedi: skel: use the pci id_table 'driver_data'

2013-03-05 Thread H Hartley Sweeten
Create an enum to the boardinfo and pass that enum in the pci_driver id_table as the driver_data. Change the macro used to fill in the device table from PCI_DEVICE() to PCI_VDEVICE(). This allows passing the enum as the next field. This allows removing the 'devid' data from the boardinfo as well

[PATCH 35/49] staging: comedi: rtd520: use the pci id_table 'driver_data'

2013-03-05 Thread H Hartley Sweeten
Create an enum to the boardinfo and pass that enum in the pci_driver id_table as the driver_data. Change the macro used to fill in the device table from PCI_DEVICE() to PCI_VDEVICE(). This allows passing the enum as the next field. This allows removing the 'device_id' data from the boardinfo as w

[PATCH 34/49] staging: comedi: ni_pcimio: cleanup the boardinfo

2013-03-05 Thread H Hartley Sweeten
For aesthetic reasons, add some whitespace to the boardinfo. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_pcimio.c | 1663 +--- 1 file changed, 762 insertions(+), 901 deletions(-) diff --git a/drivers/stag

[PATCH 33/49] staging: comedi: ni_stc.h: remove n_ni_boards macro

2013-03-05 Thread H Hartley Sweeten
This macro is not used, remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_stc.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_stc.h b/drivers/staging/comedi/drivers/ni_stc.h index 36

[PATCH 32/49] staging: comedi: ni_stc.h: remove boardtype macro

2013-03-05 Thread H Hartley Sweeten
This macro relies on a local variable having a specific name and returns an object that variable points to. This object is the boardinfo used by the driver. The comedi core provides the comedi_board() helper to return a const pointer to the boardinfo. Remove the 'boardtype' macro and fix all the u

[PATCH 31/49] staging: comedi: ni_pcimio: use the pci id_table 'driver_data'

2013-03-05 Thread H Hartley Sweeten
Create an enum to the boardinfo and pass that enum in the pci_driver id_table as the driver_data. A couple of the entries in the boardinfo are #if 0'ed out due to unknown device ids. Add the enums for them also but comment them out. Change the macro used to fill in the device table from PCI_DEVICE

[PATCH 26/49] staging: comedi: ni_660x: cleanup the boardinfo

2013-03-05 Thread H Hartley Sweeten
For aesthetic reasons, add some whitespace to the boardinfo. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_660x.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/comedi

[PATCH 30/49] staging: comedi: ni_pcidio: remove this_board macro

2013-03-05 Thread H Hartley Sweeten
This macro relies on a local variable having a specific name and derives a pointer from that local variable. It's only used in the attach and we already have the local variable 'board' that has the same information. Use that instead. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroa

[PATCH 27/49] staging: comedi: ni_670x: use the pci id_table 'driver_data'

2013-03-05 Thread H Hartley Sweeten
Create an enum to the boardinfo and pass that enum in the pci_driver id_table as the driver_data. Change the macro used to fill in the device table from PCI_DEVICE() to PCI_VDEVICE(). This allows passing the enum as the next field. This allows removing the 'dev_id' data from the boardinfo as well

[PATCH 29/49] staging: comedi: ni_pcidio: remove n_ndio_boards macro

2013-03-05 Thread H Hartley Sweeten
This macro is not used in the driver. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_pcidio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ni_pcidio.c b/drivers/staging/comedi/drivers

[PATCH 28/49] staging: comedi: ni_pcidio: use the pci id_table 'driver_data'

2013-03-05 Thread H Hartley Sweeten
Create an enum to the boardinfo and pass that enum in the pci_driver id_table as the driver_data. Change the macro used to fill in the device table from PCI_DEVICE() to PCI_VDEVICE(). This allows passing the enum as the next field. This allows removing the 'dev_id' data from the boardinfo as well

[PATCH 01/01 v3] staging: comedi: adv_pci1724: new driver

2013-03-05 Thread Ian Abbott
From: Frank Mori Hess New comedi driver for Advantech PCI-1724U with modifications by Ian Abbott . Signed-off-by: Ian Abbott --- v2: Fix missing `if (ret)` after call to `comedi_alloc_subdevices()`. v3: Melded the 13 patches for v2 into a single patch. --- Frank, if you are happy with this, cou

[PATCH 00/01 v3] staging: comedi: new driver for Advantech PCI-1724U

2013-03-05 Thread Ian Abbott
Add a new comedi driver for the Advantech PCI-1724U originally submitted by Frank Mori Hess with modifications by Ian Abbott. Patch 01 is the series of 13 patches from v2 squashed into a single patch. Authorship of the overall patch has been assigned to Frank Mori Hess. (In v2, patch 01 was the

[PATCH 25/49] staging: comedi: ni_660x: use the pci id_table 'driver_data'

2013-03-05 Thread H Hartley Sweeten
Create an enum to the boardinfo and pass that enum in the pci_driver id_table as the driver_data. Change the macro used to fill in the device table from PCI_DEVICE() to PCI_VDEVICE(). This allows passing the enum as the next field. This allows removing the 'dev_id' data from the boardinfo as well

[PATCH 24/49] staging: comedi: ni_65xx: cleanup the boardinfo

2013-03-05 Thread H Hartley Sweeten
For aesthetic reasons, add some whitespace to the boardinfo. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_65xx.c | 159 +-- 1 file changed, 87 insertions(+), 72 deletions(-) diff --git a/drivers/stagin

[PATCH 23/49] staging: comedi: ni_65xx: remove n_ni_65xx_boards macro

2013-03-05 Thread H Hartley Sweeten
This macro is not used in the driver. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_65xx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_65xx.c b/drivers/staging/comedi/drivers/n

[PATCH 22/49] staging: comedi: ni_65xx: remove board() helper function

2013-03-05 Thread H Hartley Sweeten
This local helper function is a duplicate of the comedi core privided comedi_board() helper. Use that function instead and use a local variable to hold the boardinfo pointer instead of calling the helper each time the boardinfo is accessed. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Gre

[PATCH 21/49] staging: comedi: ni_65xx: use the pci id_table 'driver_data'

2013-03-05 Thread H Hartley Sweeten
Create an enum to the boardinfo and pass that enum in the pci_driver id_table as the driver_data. Change the macro used to fill in the device table from PCI_DEVICE() to PCI_VDEVICE(). This allows passing the enum as the next field. This allows removing the 'dev_id' data from the boardinfo as well

[PATCH 20/49] staging: comedi: ni_65xx: cleanup pci_driver declaration

2013-03-05 Thread H Hartley Sweeten
For aesthetic reasons, add some whitespace to the pci_driver declaration. Also, move the pci device table near the pci_driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_65xx.c | 61 1 file chan

[PATCH 19/49] staging: comedi: ni_6527: use the pci id_table 'driver_data'

2013-03-05 Thread H Hartley Sweeten
Create an enum to the boardinfo and pass that enum in the pci_driver id_table as the driver_data. Change the macro used to fill in the device table from PCI_DEVICE() to PCI_VDEVICE(). This allows passing the enum as the next field. This allows removing the 'dev_id' data from the boardinfo as well

[PATCH 18/49] staging: comedi: ni_6527: cleanup pci_driver declaration

2013-03-05 Thread H Hartley Sweeten
For aesthetic reasons, add some whitespace to the pci_driver declaration. Also, move the pci device table near the pci_driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_6527.c | 21 ++--- 1 file changed, 10 ins

[PATCH 17/49] staging: comedi: me_daq: use the pci id_table 'driver_data'

2013-03-05 Thread H Hartley Sweeten
Create an enum to the boardinfo and pass that enum in the pci_driver id_table as the driver_data. Change the macro used to fill in the device table from PCI_DEVICE() to PCI_VDEVICE(). This allows passing the enum as the next field. This allows removing the 'device_id' data from the boardinfo as w

[PATCH 16/49] staging: comedi: me4000: use the pci id_table 'driver_data'

2013-03-05 Thread H Hartley Sweeten
Create an enum to the boardinfo and pass that enum in the pci_driver id_table as the driver_data. Change the macro used to fill in the device table from PCI_DEVICE() to PCI_VDEVICE(). This allows passing the enum as the next field. This allows removing the 'device_id' data from the boardinfo as w

Re: hyperv: is register a mandatory phase by hypervkvpd?

2013-03-05 Thread Xitao Cao
On Tue, Mar 5, 2013 at 11:42 PM, KY Srinivasan wrote: > > > > > -Original Message- > > From: vaughan [mailto:vaughan@oracle.com] > > Sent: Tuesday, March 05, 2013 7:48 AM > > To: KY Srinivasan > > Cc: devel@linuxdriverproject.org; Haiyang Zhang; xitao@gmail.com > > Subject: hyperv:

[PATCH 15/49] staging: comedi: dt3000: use the pci id_table 'driver_data'

2013-03-05 Thread H Hartley Sweeten
Create an enum to the boardinfo and pass that enum in the pci_driver id_table as the driver_data. Change the macro used to fill in the device table from PCI_DEVICE() to PCI_VDEVICE(). This allows passing the enum as the next field. This allows removing the 'device_id' data from the boardinfo as w

[PATCH 14/49] staging: comedi: cb_pcidda: use the pci id_table 'driver_data'

2013-03-05 Thread H Hartley Sweeten
Create an enum to the boardinfo and pass that enum in the pci_driver id_table as the driver_data. Change the macro used to fill in the device table from PCI_DEVICE() to PCI_VDEVICE(). This allows passing the enum as the next field. This allows removing the 'device_id' data from the boardinfo as w

[PATCH 13/49] staging: comedi: cb_pcidas64: cleanup the boardinfo

2013-03-05 Thread H Hartley Sweeten
For aesthetic reasons, add some whitespace to the boardinfo. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidas64.c | 716 +-- 1 file changed, 358 insertions(+), 358 deletions(-) diff --git a/drivers/stag

[PATCH 12/49] staging: comedi: cb_pcidas64: use the pci id_table 'driver_data'

2013-03-05 Thread H Hartley Sweeten
Create an enum to the boardinfo and pass that enum in the pci_driver id_table as the driver_data. Change the macro used to fill in the device table from PCI_DEVICE() to PCI_VDEVICE(). This allows passing the enum as the next field. This allows removing the 'device_id' data from the boardinfo as w

[PATCH 11/49] staging: comedi: cb_pcidas: use the pci id_table 'driver_data'

2013-03-05 Thread H Hartley Sweeten
Create an enum to the boardinfo and pass that enum in the pci_driver id_table as the driver_data. Change the macro used to fill in the device table from PCI_DEVICE() to PCI_VDEVICE(). This allows passing the enum as the next field. This allows removing the 'device_id' data from the boardinfo as w

[PATCH 10/49] staging: comedi: adv_pci_dio: use the pci id_table 'driver_data'

2013-03-05 Thread H Hartley Sweeten
Create an enum to the boardinfo and pass that enum in the pci_driver id_table as the driver_data. Change the macro used to fill in the device table from PCI_DEVICE() to PCI_VDEVICE(). This allows passing the enum as the next field. This allows removing the 'vendor_id' and 'device_id' data from th

[PATCH 09/49] staging: comedi: adv_pci1710: use the pci id_table 'driver_data'

2013-03-05 Thread H Hartley Sweeten
Create an enum to the boardinfo and pass that enum in the pci_driver id_table as the driver_data. Change the macro used to fill in the device table from PCI_DEVICE() to PCI_VDEVICE(). This allows passing the enum as the next field. This allows removing the 'device_id' data from the boardinfo as w

[PATCH 07/49] staging: comedi: adl_pci6208: use the pci id_table 'driver_data'

2013-03-05 Thread H Hartley Sweeten
Create an enum to the boardinfo and pass that enum in the pci_driver id_table as the driver_data. Change the macro used to fill in the device table from PCI_DEVICE() to PCI_VDEVICE(). This allows passing the enum as the next field. This allows removing the 'dev_id' data from the boardinfo as well

[PATCH 08/49] staging: comedi: adl_pci7x3x: use the pci id_table 'driver_data'

2013-03-05 Thread H Hartley Sweeten
Create an enum to the boardinfo and pass that enum in the pci_driver id_table as the driver_data. Change the macro used to fill in the device table from PCI_DEVICE() to PCI_VDEVICE(). This allows passing the enum as the next field. This allows removing the 'device' data from the boardinfo as well

[PATCH 06/49] staging: comedi: addi_apci_3120: use the pci id_table 'driver_data'

2013-03-05 Thread H Hartley Sweeten
Create an enum to the boardinfo and pass that enum in the pci_driver id_table as the driver_data. Change the macro used to fill in the device table from PCI_DEVICE() to PCI_VDEVICE(). This allows passing the enum as the next field. This allows removing the 'i_VendorId' and 'i_DeviceId' data from

[PATCH 05/49] staging: comedi: addi_apci_16xx: remove the boardinfo from the comedi_driver

2013-03-05 Thread H Hartley Sweeten
This driver uses the comedi auto attach mechanism and does not need to supply the 'num_names', 'board_name', and 'offset' fields so that the comedi core can search the boardinfo. These fields are only used for the legacy attach. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hart

[PATCH 03/49] staging: comedi: addi_apci_1516: use the pci id_table 'driver_data'

2013-03-05 Thread H Hartley Sweeten
Create an enum to the boardinfo and pass that enum in the pci_driver id_table as the driver_data. Change the macro used to fill in the device table from PCI_DEVICE() to PCI_VDEVICE(). This allows passing the enum as the next field. This allows removing the 'device' data from the boardinfo as well

[PATCH 04/49] staging: comedi: addi_apci_16xx: use the pci id_table 'driver_data'

2013-03-05 Thread H Hartley Sweeten
Create an enum to the boardinfo and pass that enum in the pci_driver id_table as the driver_data. Change the macro used to fill in the device table from PCI_DEVICE() to PCI_VDEVICE(). This allows passing the enum as the next field. This allows removing the 'vendor' and 'device' data from the boar

[PATCH 02/49] staging: comedi: 8255_pci: use the pci id_table 'driver_data'

2013-03-05 Thread H Hartley Sweeten
Create an enum to the boardinfo and pass that enum in the pci_driver id_table as the driver_data. Change the macro used to fill in the device table from PCI_DEVICE() to PCI_VDEVICE(). This allows passing the enum as the next field. This allows removing the 'vendor' and 'device' data from the boar

[PATCH 01/49] staging: comedi: comedi_pci: change the comedi_pci_auto_config() 'context'

2013-03-05 Thread H Hartley Sweeten
The comedi_pci_auto_config() function is used to allow the PCI driver (*probe) function to automatically call the comedi driver (*auto_attach). This allows the comedi driver to be part of the PnP process when the PCI device is detected. Currently the comedi_pci_auto_config() always passes a 'conte

[PATCH 00/49] staging: comedi: cleanup pci device detection

2013-03-05 Thread H Hartley Sweeten
Make use of the 'context' in the comedi auto config by passing the pci_device_id 'driver_data' as the 'context'. Modify all the comedi_driver pci drivers so that the 'driver_data' is an enum to the boardinfo entries. This removes the need for the helper functions that matched the pci vendor/device

Re: [PATCH 00/13] staging: comedi: new driver for Advantech PCI-1724U

2013-03-05 Thread Ian Abbott
On 2013-03-05 14:01, Dan Carpenter wrote: On Tue, Mar 05, 2013 at 11:36:22AM +, Ian Abbott wrote: I was thinking of squashing these 13 patches (including the two v2 patches) into a single patch, since adding 13 patches for a single new driver seems a bit much. Is that a good idea or not? T

RE: hyperv: is register a mandatory phase by hypervkvpd?

2013-03-05 Thread KY Srinivasan
> -Original Message- > From: vaughan [mailto:vaughan@oracle.com] > Sent: Tuesday, March 05, 2013 7:48 AM > To: KY Srinivasan > Cc: devel@linuxdriverproject.org; Haiyang Zhang; xitao@gmail.com > Subject: hyperv: is register a mandatory phase by hypervkvpd? > > I guess I found a bu

Re: [PATCH 11/11] zcache/zbud: Add incremental accessory counters

2013-03-05 Thread Konrad Rzeszutek Wilk
On Tue, Mar 05, 2013 at 04:44:53PM +0800, Greg KH wrote: > On Mon, Mar 04, 2013 at 01:18:21PM -0500, Konrad Rzeszutek Wilk wrote: > > that are going to be used for debug fs entries. > > what debugfs entries? > > > > > Acked-by: Dan Magenheimer > > Signed-off-by: Konrad Rzeszutek Wilk > > --- >

Re: [PATCH 00/13] staging: comedi: new driver for Advantech PCI-1724U

2013-03-05 Thread Dan Carpenter
On Tue, Mar 05, 2013 at 11:36:22AM +, Ian Abbott wrote: > I was thinking of squashing these 13 patches (including the two v2 > patches) into a single patch, since adding 13 patches for a single > new driver seems a bit much. Is that a good idea or not? Thanks. It's a pretty normal thing to d

[PATCH] staging: comedi: dt9812: use CR_CHAN() for channel number

2013-03-05 Thread Ian Abbott
As pointed out by Dan Carpenper in , the dt9812 comedi driver's use of the `chanspec` member of `struct comedi_insn` as a channel number is incorrect. Change it to use `CR_CHAN(insn->chanspec)` as the channel number

hyperv: is register a mandatory phase by hypervkvpd?

2013-03-05 Thread vaughan
I guess I found a bug -- hypervkvpd running alone without hv_utils loaded encounters segfault when service cgred start on RHEL6.4. It occurs with both 0.8 and 0.9, regardless of i686 or x86_64. I read in hv_kvp_daemon.c that the user mode componet should first registers with the kernel component.

Re: [PATCH 00/13] staging: comedi: new driver for Advantech PCI-1724U

2013-03-05 Thread Ian Abbott
On 2013-02-19 13:59, Ian Abbott wrote: On 2013-02-19 13:09, Ian Abbott wrote: Add a new comedi driver for the Advantech PCI-1724U submitted by Frank Mori Hess. Patch 01 is the driver more or less as submitted by Frank, but with checkpatch fixes and fixes to make it compile against Greg's curren

Re: [PATCH] drivers/staging/zcache: using strlcpy instead of strncpy

2013-03-05 Thread Greg KH
On Sun, Feb 17, 2013 at 10:30:01AM +0800, Chen Gang wrote: > > for NUL terminated string, need alway set '\0' in the end. > > Signed-off-by: Chen Gang > --- > drivers/staging/zcache/zcache-main.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/

Re: [PATCH 11/11] zcache/zbud: Add incremental accessory counters

2013-03-05 Thread Greg KH
On Mon, Mar 04, 2013 at 01:18:21PM -0500, Konrad Rzeszutek Wilk wrote: > that are going to be used for debug fs entries. what debugfs entries? > > Acked-by: Dan Magenheimer > Signed-off-by: Konrad Rzeszutek Wilk > --- > drivers/staging/zcache/zbud.c | 58 > +--