[PATCH] staging: comedi_pci: pass comedi_device to comedi_pci_enable()

2013-03-12 Thread H Hartley Sweeten
Make comedi_pci_enable() use the same parameter type as comedi_pci_disable(). This also allows comedi_pci_enable to automatically determine the resource name passed to pci_request_regions(). Make sure the errno value returned is passed on instead of assuming an errno. Also, remove any kernel noise

RE: [PATCH] staging: comedi: ni_atmio: fix build errors

2013-03-12 Thread H Hartley Sweeten
On Tuesday, March 12, 2013 11:45 AM, Greg Kroah-Hartman wrote: > On Tue, Mar 12, 2013 at 10:53:11AM -0700, H Hartley Sweeten wrote: >> The following commits introduced a couple build errors in this driver >> due to the removal of some macros in ni_stc.h. >> >> commit: f5a1d92b "staging: comedi: ni

[PATCH] staging: comedi_pci: make comedi_pci_disable() safe to always call

2013-03-12 Thread H Hartley Sweeten
Currently all the comedi PCI drivers need to do some checking in their (*detach) before calling comedi_pci_disable() in order to make sure the PCI device has actually be enabled. Change the parameter passed to comedi_pci_disable() from a struct pci_dev pointer to a comedi_device pointer and have c

Re: [PATCH] staging: comedi: adv_pci_dio: restore PCI-1753E support

2013-03-12 Thread Ian Abbott
On 12/03/13 17:12, Ian Abbott wrote: Advantech has their own Linux (non-Comedi) driver for the PCI-1753 which detects whether the PCI-1753E expansion card is connected to the PCI-1753 by fiddling with the control register of an emulated 8255 chip in the address space of the expansion card. The t

Re: [-next] staging/comedi regressions

2013-03-12 Thread Greg Kroah-Hartman
On Tue, Mar 12, 2013 at 11:13:50PM +0100, Geert Uytterhoeven wrote: > m68k/allmodconfig: > > drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_isapnp_find_board’: > drivers/staging/comedi/drivers/ni_atmio.c:353: error: ‘n_ni_boards’ > undeclared (first use in this function) > drivers/stag

[-next] staging/comedi regressions

2013-03-12 Thread Geert Uytterhoeven
m68k/allmodconfig: drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_isapnp_find_board’: drivers/staging/comedi/drivers/ni_atmio.c:353: error: ‘n_ni_boards’ undeclared (first use in this function) drivers/staging/comedi/drivers/ni_atmio.c:353: error: (Each undeclared identifier is reporte

RE: [PATCH 1/1] Drivers: hv: Add a new driver to support host initiated backup

2013-03-12 Thread KY Srinivasan
> -Original Message- > From: Olaf Hering [mailto:o...@aepfle.de] > Sent: Tuesday, March 12, 2013 2:49 PM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > devel@linuxdriverproject.org; a...@canonical.com; jasow...@redhat.com; > Evgeniy Polyakov > Subjec

Re: [PATCH 1/1] Drivers: hv: Add a new driver to support host initiated backup

2013-03-12 Thread Olaf Hering
On Tue, Mar 12, K. Y. Srinivasan wrote: > +static int vss_operate(int operation) > +{ > + char *fs_op; > + char cmd[512]; > + char buf[512]; > + FILE *file; > + char *p; > + char *x; > + int error; > + > + switch (operation) { > + case VSS_OP_FREEZE: > +

Re: [PATCH] staging: comedi: ni_atmio: fix build errors

2013-03-12 Thread Greg Kroah-Hartman
On Tue, Mar 12, 2013 at 10:53:11AM -0700, H Hartley Sweeten wrote: > The following commits introduced a couple build errors in this driver > due to the removal of some macros in ni_stc.h. > > commit: f5a1d92b "staging: comedi: ni_stc.h: remove n_ni_boards macro" > commit: 6293e357 "staging: comedi

[PATCH 1/1] Drivers: hv: Add a new driver to support host initiated backup

2013-03-12 Thread K. Y. Srinivasan
This driver supports host initiated backup of the guest. On Windows guests, the host can generate application consistent backups using the Windows VSS framework. On Linux, we ensure that the backup will be file system consistent. This driver allows the host to initiate a "Freeze" operation on all

RE: [PATCH 1/1] Drivers: hv: Add a new driver to support host initiated backup

2013-03-12 Thread KY Srinivasan
> -Original Message- > From: K. Y. Srinivasan [mailto:k...@microsoft.com] > Sent: Tuesday, March 12, 2013 2:29 PM > To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > devel@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@redhat.com > Cc: KY Srinivasan >

[PATCH 1/1] Drivers: hv: Add a new driver to support host initiated backup

2013-03-12 Thread K. Y. Srinivasan
This driver supports host initiated backup of the guest. On Windows guests, the host can generate application consistent backups using the Windows VSS framework. On Linux, we ensure that the backup will be file system consistent. This driver allows the host to initiate a "Freeze" operation on all

[PATCH] staging: comedi: ni_atmio: fix build errors

2013-03-12 Thread H Hartley Sweeten
The following commits introduced a couple build errors in this driver due to the removal of some macros in ni_stc.h. commit: f5a1d92b "staging: comedi: ni_stc.h: remove n_ni_boards macro" commit: 6293e357 "staging: comedi: ni_stc.h: remove boardtype macro" The n_ni_boards macro is an open coded v

[PATCH RESEND 1/6] Drivers: hv: balloon: Do not request completion notification

2013-03-12 Thread K. Y. Srinivasan
There is no need to request completion notification; get rid of it. Signed-off-by: K. Y. Srinivasan --- drivers/hv/hv_balloon.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c index 3787321..7fb72dd 100644 --- a/driv

[PATCH RESEND 5/6] Drivers: hv: balloon: Implement hot-add functionality

2013-03-12 Thread K. Y. Srinivasan
Implement the memory hot-add functionality. With this, Linux guests can fully participate in the Dynamic Memory protocol implemented in the Windows hosts. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/hv/Kconfig |2 +- drivers/hv/hv_balloon.c | 393 +++

[PATCH RESEND 2/6] Drivers: hv: balloon: Execute balloon inflation in a separate context

2013-03-12 Thread K. Y. Srinivasan
Execute the balloon inflation operation in a separate work context. This allows us to decouple the pressure reporting activity from the ballooning activity. Testing has shown that this decoupling makes the guest more reponsive. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- driv

[PATCH RESEND 6/6] Drivers: hv: vmbus: Handle channel rescind message correctly

2013-03-12 Thread K. Y. Srinivasan
Properly cleanup the channel state on receipt of the "offer rescind" message. Starting with ws2012, the host requires that the channel "relid" be properly cleaned up when the offer is rescinded. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/hv/channel_mgmt.c | 11

[PATCH RESEND 4/6] Drivers: hv: balloon: Make the balloon driver not unloadable

2013-03-12 Thread K. Y. Srinivasan
The balloon driver is stateful. For instance, it needs to keep track of pages that have been ballooned out to properly post pressure reports. This state cannot be re-constructed if the driver were to be unloaded and subsequently loaded. Furthermore, as we support memory hot-add as part of this dri

[PATCH RESEND 3/6] Drivers: hv: balloon: Execute hot-add code in a separate context

2013-03-12 Thread K. Y. Srinivasan
Execute the hot-add operation in a separate work context. This allows us to decouple the pressure reporting activity from the "hot-add" activity. Testing has shown that this makes the guest more responsive to hot add requests. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drive

[PATCH RESEND 0/6] Drivers: hv

2013-03-12 Thread K. Y. Srinivasan
This patch set enhances the balloon driver functionality to add support for memory "hot-add". Windows hosts use a combination of ballooning and hot-add to dynamically balance the available memory across competing virtual machines. With this, Linux guests can fully participate in the Windows Dynamic

Re: [PATCH] staging: comedi: adv_pci_dio: restore PCI-1753E support

2013-03-12 Thread Ian Abbott
On 2013-03-12 17:12, Ian Abbott wrote: +unsigned long pci_dio_detect_pci1753e(struct pci_dev *pcidev, + unsigned long cardtype) Whoops, that should really be declared static. I'll hang on a day for any more comments and then I'll post a v2 patch to replace

[PATCH] staging: comedi: adv_pci_dio: restore PCI-1753E support

2013-03-12 Thread Ian Abbott
Back in the old days (before "staging") when Comedi only supported manual configuration of devices, the "adv_pci_dio" driver supported both PCI-1753 ("pci1753") and PCI-1753E ("pci1753e"). In actual fact, "pci1753e" is just a PCI-1753 connected by a ribbon cable to a PCI-1753E expansion card, whic

RE: [PATCH v3] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-03-12 Thread Haiyang Zhang
> -Original Message- > From: linux-fbdev-ow...@vger.kernel.org [mailto:linux-fbdev- > ow...@vger.kernel.org] On Behalf Of Haiyang Zhang > Sent: Friday, March 08, 2013 4:46 PM > To: florianschandi...@gmx.de; linux-fb...@vger.kernel.org > Cc: Haiyang Zhang; KY Srinivasan; o...@aepfle.de; ja

Re: [PATCH 1/1 v4] staging: comedi: adv_pci1724: new driver

2013-03-12 Thread Dan Carpenter
On Tue, Mar 12, 2013 at 11:42:32AM +, Ian Abbott wrote: > From: Frank Mori Hess > > New comedi driver for Advantech PCI-1724U with modifications by Ian > Abbott . > I normally don't comment on patches unless I'm complaining about something but I just wanted to say that comedi drivers make m

RE: [PATCH 5/6] Drivers: hv: balloon: Implement hot-add functionality

2013-03-12 Thread KY Srinivasan
> -Original Message- > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, March 12, 2013 12:07 PM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; devel@linuxdriverproject.org; > o...@aepfle.de; > a...@canonical.com; jasow...@redhat.com > Subject

Re: [PATCH 5/6] Drivers: hv: balloon: Implement hot-add functionality

2013-03-12 Thread gre...@linuxfoundation.org
On Tue, Mar 12, 2013 at 02:54:23AM +, KY Srinivasan wrote: > > > > -Original Message- > > From: K. Y. Srinivasan [mailto:k...@microsoft.com] > > Sent: Friday, March 08, 2013 5:16 PM > > To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > > devel@linuxdriverproject.org; o..

[PATCH] staging: comedi: adv_pci1710: restore PCI-1710HG support

2013-03-12 Thread Ian Abbott
The Advantech PCI-1710HG is similar to the PCI-1710 but has a different set of ranges for analog input (HG = high gain). Because they share the same PCI vendor and device ID, the adv_pci1710 driver does not currently distinguish them. This is more of a problem since auto-configuration code was ad

[PATCH 1/1 v4] staging: comedi: adv_pci1724: new driver

2013-03-12 Thread Ian Abbott
From: Frank Mori Hess New comedi driver for Advantech PCI-1724U with modifications by Ian Abbott . Signed-off-by: Ian Abbott Cc: Frank Mori Hess --- v2: Fix missing `if (ret)` after call to `comedi_alloc_subdevices()`. v3: Melded the 13 patches for v2 into a single patch. v4: Updated call to `

[PATCH 0/1 v4] staging: comedi: new driver for Advantech PCI-1724U

2013-03-12 Thread Ian Abbott
Add a new comedi driver for the Advantech PCI-1724U originally submitted by Frank Mori Hess with modifications by Ian Abbott. v4 updates the call to comedi_pci_auto_config() due to the addition of a context parameter. It also fixes a compiler warning in setup_subdevices(). It also uses specific

Re: [PATCH v3 0/4] Cosmetic changes to the android binder proc release code

2013-03-12 Thread Dan Carpenter
On Tue, Mar 12, 2013 at 11:41:58AM +0100, Mirsal Ennaime wrote: > Changes from v2 > > * kept arguments aligned with parentesis (Following >Arve Hjønnevåg's review) > * added a fourth patch which removes function names from string litterals >in favor __func__ (Following Dan Carpenter's re

[PATCH v3 1/4] drivers: android: binder: Move the node release code to a separate function

2013-03-12 Thread Mirsal Ennaime
The binder_deferred_release() function has many levels of indentation which makes it difficult to read. This patch moves the code which deals with disposing of a binder node to a separate binder_node_release() function, thus removing one level of indentation and allowing the code to fit in 80 colum

[PATCH v3 2/4] drivers: android: binder: Fix code style in binder_deferred_release

2013-03-12 Thread Mirsal Ennaime
* Use tabs where applicable * Remove a few "80-columns" checkpatch warnings * Separate code paths with empty lines for readability Signed-off-by: Mirsal Ennaime --- drivers/staging/android/binder.c | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) dif

[PATCH v3 0/4] Cosmetic changes to the android binder proc release code

2013-03-12 Thread Mirsal Ennaime
Hello, These are cleanup patches related to the binder_deferred_release function in the android binder staging driver which improve readability while removing checkpatch and compiler warnings. drivers/staging/android/binder.c | 138 +--- 1 file changed, 84 insertions(+),

[PATCH v3 3/4] drivers: android: binder: Remove excessive indentation

2013-03-12 Thread Mirsal Ennaime
Remove one level of indentation from the binder proc page release code by using slightly different control semantics. Signed-off-by: Mirsal Ennaime --- drivers/staging/android/binder.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/staging/

[PATCH v3 4/4] drivers: android: binder: Use __func__ in debug messages

2013-03-12 Thread Mirsal Ennaime
Debug messages sent in binder_deferred_release begin with "binder_release:" which is a bit misleading as binder_release is not directly part of the call stack. Use __func__ instead for debug messages in binder_deferred_release. Signed-off-by: Mirsal Ennaime --- drivers/staging/android/binder.c |

Re: [PATCH v2 3/3] drivers: android: binder: Remove excessive indentation

2013-03-12 Thread mirsal
On Mon, 2013-03-11 at 17:04 -0700, Joe Perches wrote: > On Tue, 2013-03-12 at 00:26 +0100, Mirsal Ennaime wrote: > > Remove one level of indentation from the binder proc page release code > > by using slightly different control semantics. > > > > This is a cosmetic patch which removes checkpatch "

Re: [PATCH v2 2/3] drivers: android: binder: Fix code style

2013-03-12 Thread mirsal
On Mon, 2013-03-11 at 16:57 -0700, Arve Hjønnevåg wrote: > On Mon, Mar 11, 2013 at 4:26 PM, Mirsal Ennaime wrote: > > * Use tabs > > * Remove a few "80-columns" checkpatch warnings > > * Separate code paths with empty lines for readability > > > > Signed-off-by: Mirsal Ennaime > > --- > > dri