[PATCH 1/1] staging: ste_rmi4: Make synaptics_rmi4_touchpad_config symbol static

2013-03-18 Thread Sachin Kamat
'synaptics_rmi4_touchpad_config' is used only in this file. Make it static. Silences the following sparse warning: drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c:652:5: warning: symbol 'synaptics_rmi4_touchpad_config' was not declared. Should it be static? Signed-off-by: Sachin Kamat Cc: Naveen Ku

Re: [PATCH 1/3] staging: vt6656: removed usage of custom Ethernet header

2013-03-18 Thread Dan Carpenter
On Tue, Mar 19, 2013 at 06:31:51AM +, Malcolm Priestley wrote: > On Tue, 2013-03-19 at 08:17 +0300, Dan Carpenter wrote: > > On Mon, Mar 18, 2013 at 08:33:49PM -0500, Andres More wrote: > > > Removed struct tagSEthernetHeader, replacing with struct ethhdr. > > > Not all checkpatch errors and wa

Re: [PATCH 1/3] staging: vt6656: removed usage of custom Ethernet header

2013-03-18 Thread Malcolm Priestley
On Tue, 2013-03-19 at 08:17 +0300, Dan Carpenter wrote: > On Mon, Mar 18, 2013 at 08:33:49PM -0500, Andres More wrote: > > Removed struct tagSEthernetHeader, replacing with struct ethhdr. > > Not all checkpatch errors and warnings were removed. > > > > Joe Perches just sent a patch that redoes th

Re: [PATCH v2] drivers: staging: davinci_vpfe: use resource_size()

2013-03-18 Thread Prabhakar Lad
Hi Wei, Thanks for the patch! I'll queue it up for v3.10 On Tue, Mar 19, 2013 at 12:36 AM, Silviu-Mihai Popescu wrote: > This uses the resource_size() function instead of explicit computation. > > Signed-off-by: Silviu-Mihai Popescu Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad > --- >

Re: [PATCH 1/3] staging: vt6656: removed usage of custom Ethernet header

2013-03-18 Thread Dan Carpenter
On Mon, Mar 18, 2013 at 08:33:49PM -0500, Andres More wrote: > Removed struct tagSEthernetHeader, replacing with struct ethhdr. > Not all checkpatch errors and warnings were removed. > Joe Perches just sent a patch that redoes the whitespace on all these files. regards, dan carpenter __

[PATCH 5/6] staging: vt6655: Fix macro definitions

2013-03-18 Thread Joe Perches
Macros should be able to be used in if/else without braces. Convert macros to use do {} while (0) instead of bare braces where appropriate. Convert macros to use single line macro definitions where appropriate. Signed-off-by: Joe Perches --- drivers/staging/vt6655/baseband.h | 8 +- driver

[PATCH 4/6] staging: vt6655: Remove commented out if()s

2013-03-18 Thread Joe Perches
Commented out code is just noise. Remove them. Signed-off-by: Joe Perches --- drivers/staging/vt6655/bssdb.c | 12 drivers/staging/vt6655/device_main.c | 9 -- drivers/staging/vt6655/dpc.c | 1 - drivers/staging/vt6655/iwctl.c | 3 -- drivers/staging/vt6655/m

[PATCH 3/6] staging: vt6655: Remove unnecessary parentheses from returns

2013-03-18 Thread Joe Perches
Returns aren't functions, remove the parentheses to be more kernel style like. Signed-off-by: Joe Perches --- drivers/staging/vt6655/IEEE11h.c | 12 drivers/staging/vt6655/baseband.c | 4 +-- drivers/staging/vt6655/bssdb.c| 8 +++--- drivers/staging/vt6655/card.c | 58 +++

[PATCH 1/6] staging: vt6655: Remove commented out printks

2013-03-18 Thread Joe Perches
These are just noise in the code so remove them. Signed-off-by: Joe Perches --- drivers/staging/vt6655/baseband.c| 27 ++--- drivers/staging/vt6655/bssdb.c | 8 drivers/staging/vt6655/channel.c | 7 --- drivers/staging/vt6655/device.h | 4 --

[PATCH 0/6] staging: vt6655: code neatening

2013-03-18 Thread Joe Perches
Some more style cleanups Joe Perches (6): staging: vt6655: Remove commented out printks staging: vt6655: Convert to kernel brace style staging: vt6655: Remove unnecessary parentheses from returns staging: vt6655: Remove commented out if()s staging: vt6655: Fix macro definitions staging

How to assign sockaddr_nl->nl_groups when using connector

2013-03-18 Thread vaughan
Hi Evgeniy, I am not quite sure how to assign nl_groups when using connector. You Documentation/connector/connector.txt don't explain it very clearly. I thought it's a bitmask representing only 32 groups. If I just want to subscribe only one group such as CN_KVP_IDX, what shall I do? Which one bel

[PATCH 2/3] staging: vt6656: removed custom 802.11 header usage

2013-03-18 Thread Andres More
Removed struct tagS802_11Header, switching to struct ieee80211_hdr instead. Checkpatch warnings and errors were not resolved. Signed-off-by: Andres More --- drivers/staging/vt6656/aes_ccmp.c | 18 drivers/staging/vt6656/dpc.c | 80 drivers/stagi

[PATCH 1/3] staging: vt6656: removed usage of custom Ethernet header

2013-03-18 Thread Andres More
Removed struct tagSEthernetHeader, replacing with struct ethhdr. Not all checkpatch errors and warnings were removed. Signed-off-by: Andres More --- drivers/staging/vt6656/device.h |6 +-- drivers/staging/vt6656/dpc.c| 28 +-- drivers/staging/vt6656/rxtx.c | 102

[PATCH V2 3/3] Drivers: hv: Notify the host of permanent hot-add failures

2013-03-18 Thread K. Y. Srinivasan
If memory hot-add fails with the error -EEXIST, then this is a permanent failure. Notify the host of this information, so the host will not attempt hot-add again. If the failure were a transient failure, host will attempt a hot-add after some delay. In this version of the patch, I have added some

[PATCH V2 1/3] mm: Export split_page()

2013-03-18 Thread K. Y. Srinivasan
This symbol would be used in the Hyper-V balloon driver to support 2M allocations. In this version of the patch, based on feedback from Michal Hocko , I have updated the patch description. Signed-off-by: K. Y. Srinivasan --- mm/page_alloc.c |1 + 1 files changed, 1 insertions(+), 0 deletion

[PATCH V2 2/3] Drivers: hv: balloon: Support 2M page allocations for ballooning

2013-03-18 Thread K. Y. Srinivasan
On Hyper-V it will be very efficient to use 2M allocations in the guest as this makes the ballooning protocol with the host that much more efficient. Hyper-V uses page ranges (start pfn : number of pages) to specify memory being moved around and with 2M pages this encoding can be very efficient. Ho

[PATCH V2 0/3] Drivers: hv: balloon

2013-03-18 Thread K. Y. Srinivasan
Support 2M page allocations when memory is ballooned out of the guest. Hyper-V Dynamic Memory protocol is optimized around the ability to move memory in 2M chunks. I have also included a patch to properly notify the host of permanent hot-add failures. In this version of the patches, I have added

Re: [PATCH 2/8] staging: omap-thermal: use spin_lock_irqsave inside IRQ handler

2013-03-18 Thread Dan Carpenter
On Mon, Mar 18, 2013 at 03:38:38PM -0400, Eduardo Valentin wrote: > On 18-03-2013 15:16, Dan Carpenter wrote: > >On Mon, Mar 18, 2013 at 10:59:10AM -0400, Eduardo Valentin wrote: > >>Even if the IRQ is not firing because it is ONE_SHOT and disable > >>at INTC level, the IRQ handler must use spin_lo

Re: [PATCH 2/8] staging: omap-thermal: use spin_lock_irqsave inside IRQ handler

2013-03-18 Thread Eduardo Valentin
On 18-03-2013 15:16, Dan Carpenter wrote: On Mon, Mar 18, 2013 at 10:59:10AM -0400, Eduardo Valentin wrote: Even if the IRQ is not firing because it is ONE_SHOT and disable at INTC level, the IRQ handler must use spin_lock_irqsave. It is necessary to disable IRQs from the current CPU while it is

Re: [PATCH 4/8] staging: rename omap-thermal driver to ti-soc-thermal

2013-03-18 Thread Dan Carpenter
On Mon, Mar 18, 2013 at 10:59:12AM -0400, Eduardo Valentin wrote: > Because this driver will support also OMAP derivatives, > this patch does a big rename inside this driver, so it > better fits its usage. > It would be better to do a minimal move patch which just renames the files and updated th

Re: [PATCH 2/8] staging: omap-thermal: use spin_lock_irqsave inside IRQ handler

2013-03-18 Thread Dan Carpenter
On Mon, Mar 18, 2013 at 10:59:10AM -0400, Eduardo Valentin wrote: > Even if the IRQ is not firing because it is ONE_SHOT and disable > at INTC level, the IRQ handler must use spin_lock_irqsave. > It is necessary to disable IRQs from the current > CPU while it is holding a spin_lock which is need. >

Re: [PATCH] drivers: staging: davinci_vpfe: use resource_size()

2013-03-18 Thread Silviu Popescu
On Sun, Mar 17, 2013 at 3:38 PM, Prabhakar Lad wrote: > Hi, > > Thanks for the patch! > > did you build test this patch ? the above header file(ioport.h) is not > required in all the > above files which you included. > > Cheers, > --Prabhakar Lad Hi, It would seem I was a bit overzealous. Indeed

[PATCH v2] drivers: staging: davinci_vpfe: use resource_size()

2013-03-18 Thread Silviu-Mihai Popescu
This uses the resource_size() function instead of explicit computation. Signed-off-by: Silviu-Mihai Popescu --- drivers/staging/media/davinci_vpfe/dm365_ipipe.c |2 +- drivers/staging/media/davinci_vpfe/dm365_isif.c|4 ++-- drivers/staging/media/davinci_vpfe/dm365_resizer.c |2

[PATCH 42/42] staging:vt6655:wroute: Whitespace cleanups

2013-03-18 Thread Joe Perches
Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/staging/vt6655/wroute.c | 398 drivers/staging/vt6655/wroute.h | 2 +- 2 files changed, 200 insertions(+), 200 deletions(-) rewrite drivers/staging/vt6655/wroute.c

[PATCH 41/42] staging:vt6655:wpactl: Whitespace cleanups

2013-03-18 Thread Joe Perches
Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/staging/vt6655/wpactl.c | 1992 +++ drivers/staging/vt6655/wpactl.h |2 +- 2 files changed, 997 insertions(+), 997 deletions(-) rewrite drivers/staging/vt6655/wpactl.

[PATCH 40/42] staging:vt6655:wpa2: Whitespace cleanups

2013-03-18 Thread Joe Perches
Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/staging/vt6655/wpa2.c | 728 +- drivers/staging/vt6655/wpa2.h | 28 +- 2 files changed, 378 insertions(+), 378 deletions(-) rewrite drivers/staging/vt6655/wpa2.c (78

[PATCH 39/42] staging:vt6655:wpa: Whitespace cleanups

2013-03-18 Thread Joe Perches
Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/staging/vt6655/wpa.c | 632 +-- drivers/staging/vt6655/wpa.h | 22 +- 2 files changed, 327 insertions(+), 327 deletions(-) rewrite drivers/staging/vt6655/wpa.c (73%)

[PATCH 37/42] staging:vt6655:wctl: Whitespace cleanups

2013-03-18 Thread Joe Perches
Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/staging/vt6655/wctl.c | 500 +- drivers/staging/vt6655/wctl.h | 218 +- 2 files changed, 359 insertions(+), 359 deletions(-) rewrite drivers/staging/v

[PATCH 35/42] staging:vt6655:vntwifi: Whitespace cleanups

2013-03-18 Thread Joe Perches
Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/staging/vt6655/vntwifi.c | 1610 +++--- drivers/staging/vt6655/vntwifi.h | 258 +++--- 2 files changed, 934 insertions(+), 934 deletions(-) rewrite drivers/staging/vt6655/vn

[PATCH 29/42] staging:vt6655:srom: Whitespace cleanups

2013-03-18 Thread Joe Perches
Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/staging/vt6655/srom.c | 254 +- drivers/staging/vt6655/srom.h | 58 +- 2 files changed, 156 insertions(+), 156 deletions(-) diff --git a/drivers/staging/vt66

[PATCH 34/42] staging:vt6655:upc: Whitespace cleanups

2013-03-18 Thread Joe Perches
Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/staging/vt6655/upc.h | 332 +-- 1 file changed, 166 insertions(+), 166 deletions(-) rewrite drivers/staging/vt6655/upc.h (61%) diff --git a/drivers/staging/vt6655/up

[PATCH 33/42] staging:vt6655:ttype: Whitespace cleanups

2013-03-18 Thread Joe Perches
Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/staging/vt6655/ttype.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vt6655/ttype.h b/drivers/staging/vt6655/ttype.h index be223bd..114ac30 100644 --- a/dri

[PATCH 32/42] staging:vt6655:tkip: Whitespace cleanups

2013-03-18 Thread Joe Perches
Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/staging/vt6655/tkip.c | 544 +- drivers/staging/vt6655/tkip.h | 12 +- 2 files changed, 278 insertions(+), 278 deletions(-) rewrite drivers/staging/vt6655/tkip.c (67

[PATCH 30/42] staging:vt6655:tcrc: Whitespace cleanups

2013-03-18 Thread Joe Perches
Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/staging/vt6655/tcrc.c | 396 +- 1 file changed, 198 insertions(+), 198 deletions(-) rewrite drivers/staging/vt6655/tcrc.c (60%) diff --git a/drivers/staging/vt6655/t

[PATCH 31/42] staging:vt6655:tether: Whitespace cleanups

2013-03-18 Thread Joe Perches
Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/staging/vt6655/tether.c | 46 - drivers/staging/vt6655/tether.h | 34 +++--- 2 files changed, 40 insertions(+), 40 deletions(-) diff --git a/d

[PATCH 26/42] staging:vt6655:rc4: Whitespace cleanups

2013-03-18 Thread Joe Perches
Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/staging/vt6655/rc4.c | 78 ++-- drivers/staging/vt6655/rc4.h | 6 ++-- 2 files changed, 42 insertions(+), 42 deletions(-) diff --git a/drivers/staging/vt6655/rc4.c b

[PATCH 25/42] staging:vt6655:power: Whitespace cleanups

2013-03-18 Thread Joe Perches
Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/staging/vt6655/power.c | 824 - drivers/staging/vt6655/power.h | 30 +- 2 files changed, 427 insertions(+), 427 deletions(-) rewrite drivers/staging/vt6655/power.c (

[PATCH 24/42] staging:vt6655:michael: Whitespace cleanups

2013-03-18 Thread Joe Perches
Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/staging/vt6655/michael.c | 166 +++ drivers/staging/vt6655/michael.h | 6 +- 2 files changed, 86 insertions(+), 86 deletions(-) diff --git a/drivers/staging/vt6655/mich

[PATCH 17/42] staging:vt6655:iocmd: Whitespace cleanups

2013-03-18 Thread Joe Perches
Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/staging/vt6655/iocmd.h | 200 - 1 file changed, 100 insertions(+), 100 deletions(-) diff --git a/drivers/staging/vt6655/iocmd.h b/drivers/staging/vt6655/iocmd.h index

[PATCH 19/42] staging:vt6655:iowpa: Whitespace cleanups

2013-03-18 Thread Joe Perches
Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/staging/vt6655/iowpa.h | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/staging/vt6655/iowpa.h b/drivers/staging/vt6655/iowpa.h index 3

[PATCH 18/42] staging:vt6655:ioctl: Whitespace cleanups

2013-03-18 Thread Joe Perches
Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/staging/vt6655/ioctl.c | 16 drivers/staging/vt6655/ioctl.h | 12 ++-- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/vt6655/ioctl.c b/drivers/stagi

[PATCH 16/42] staging:vt6655:hostap: Whitespace cleanups

2013-03-18 Thread Joe Perches
Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/staging/vt6655/hostap.c | 1714 +++ 1 file changed, 857 insertions(+), 857 deletions(-) rewrite drivers/staging/vt6655/hostap.c (60%) diff --git a/drivers/staging/vt6655

[PATCH 13/42] staging:vt6655:device_cfg: Whitespace cleanups

2013-03-18 Thread Joe Perches
Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/staging/vt6655/device_cfg.h | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/vt6655/device_cfg.h b/drivers/staging/vt6655/device_cfg.h index 408

[PATCH 12/42] staging:vt6655:device: Whitespace cleanups

2013-03-18 Thread Joe Perches
Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/staging/vt6655/device.h | 1802 +++ 1 file changed, 901 insertions(+), 901 deletions(-) rewrite drivers/staging/vt6655/device.h (61%) diff --git a/drivers/staging/vt6655

[PATCH 11/42] staging:vt6655:desc: Whitespace cleanups

2013-03-18 Thread Joe Perches
Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/staging/vt6655/desc.h | 482 +- 1 file changed, 241 insertions(+), 241 deletions(-) diff --git a/drivers/staging/vt6655/desc.h b/drivers/staging/vt6655/desc.h index 0

[PATCH 10/42] staging:vt6655:datarate: Whitespace cleanups

2013-03-18 Thread Joe Perches
Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/staging/vt6655/datarate.c | 874 +++--- drivers/staging/vt6655/datarate.h | 42 +- 2 files changed, 458 insertions(+), 458 deletions(-) rewrite drivers/staging/vt6655/datara

[PATCH 09/42] staging:vt6655:country: Whitespace cleanups

2013-03-18 Thread Joe Perches
Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/staging/vt6655/country.h | 324 +++ 1 file changed, 162 insertions(+), 162 deletions(-) rewrite drivers/staging/vt6655/country.h (62%) diff --git a/drivers/staging/vt665

[PATCH 04/42] staging:vt6655:aes_ccmp: Whitespace cleanups

2013-03-18 Thread Joe Perches
Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/staging/vt6655/aes_ccmp.c | 804 +++--- 1 file changed, 402 insertions(+), 402 deletions(-) rewrite drivers/staging/vt6655/aes_ccmp.c (82%) diff --git a/drivers/staging/vt66

[PATCH 03/42] staging:vt6655:IEEE11h: Whitespace cleanups

2013-03-18 Thread Joe Perches
Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/staging/vt6655/IEEE11h.c | 104 +++ drivers/staging/vt6655/IEEE11h.h | 6 +-- 2 files changed, 55 insertions(+), 55 deletions(-) diff --git a/drivers/staging/vt6655/IEE

[PATCH 01/42] staging:vt6655:80211hdr: Whitespace cleanups

2013-03-18 Thread Joe Perches
Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/staging/vt6655/80211hdr.h | 44 +++ 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/vt6655/80211hdr.h b/drivers/staging/vt6655/80211hdr.h

[PATCH 00/42] staging:vt6655: Whitespace cleanups

2013-03-18 Thread Joe Perches
Just a nearly completely scripted pass to convert the vt6655 sources to something more kernel like. No lines added or removed. git diff -w shows no differences. Compilation allyesconfig, allmodconfig shows no object/module differences. Joe Perches (42): staging:vt6655:80211hdr: Whitespace clea

[PATCH 01/12] staging: comedi: amplc_dio200: split dio200_boards[] into ISA & PCI

2013-03-18 Thread Ian Abbott
Split `dio200_boards[]` into `dio200_isa_boards[]` for ISA cards and `dio200_pci_boards[]` for PCI cards. Only initialize the board-name look-up members of `struct comedi_driver amplc_dio200_driver` if the ISA part of the driver is enabled in the kernel config (`CONFIG_COMEDI_AMPLC_DIO200_ISA`) us

Re: [PATCH 1/8] staging: omap-thermal: fix return value

2013-03-18 Thread Eduardo Valentin
Dan, On 18-03-2013 12:39, Dan Carpenter wrote: Thanks. Acked-by: Dan Carpenter regards, dan carpenter Thanks for taking the time to check this code. Eduardo ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject

[PATCH 08/12] staging: comedi: amplc_dio200: remove DIO200_DRIVER_NAME

2013-03-18 Thread Ian Abbott
Remove the `DIO200_DRIVER_NAME` macro which expands to the driver name "amplc_dio200". Use the board name from our `struct dio200_board` when requesting resources. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_dio200.c | 16 +++- 1 file changed, 7 insertions(+),

[PATCH 03/12] staging: comedi: amplc_dio200: Simplify PCI board look-up

2013-03-18 Thread Ian Abbott
Set the `driver_data` member of each element (apart from the sentinel) of our PCI device table `dio200_pci_table[]` to the index of the corresponding element of our private PCI board details `dio200_pci_boards[]`. This index appears in the context parameter of our auto_attach routine `dio200_auto_

[PATCH 11/12] staging: comedi: amplc_dio200: refactor dio200_handle_read_intr()

2013-03-18 Thread Ian Abbott
Refactor `dio200_handle_read_intr()` to fix checkpatch warning about too many leading tabs. Factor out the part that puts the scan data into the asynchronous command data buffer and checks for end of acquisition into new function `dio200_read_scan_intr()`. Signed-off-by: Ian Abbott --- drivers/

[PATCH 05/12] staging: comedi: amplc_dio200: shrink struct dio200_subdev_intr

2013-03-18 Thread Ian Abbott
Shave a few bytes off the size of `struct dio200_subdev_intr` by rearranging members and changing two of them to bit-fields. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_dio200.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/stag

[PATCH 10/12] staging: comedi: amplc_dio200: don't check bus-type in dio200_common_attach()

2013-03-18 Thread Ian Abbott
The "amplc_dio200" driver is going to be split into separate drivers for ISA and PCI cards with a common module containing most of the code. We don't want the common module code to depend on whether ISA boards, PCI boards, or both are supported. Currently, `dio200_common_attach()` and `dio200_det

[PATCH 09/12] staging: comedi: amplc_dio200: remove dio200_report_attach()

2013-03-18 Thread Ian Abbott
`dio200_report_attach()` is called from `dio200_common_attach()` to report the successful attachment of a supported board. It includes various information about the board. Replace the function with a simple acknowledgement that the attachment completed successfully. The `dio200_attach()` and `di

[PATCH 07/12] staging: comedi: amplc_dio200: set board_name before common attach

2013-03-18 Thread Ian Abbott
`dio200_common_attach()` is called from `dio200_attach()` for ISA boards and from `dio200_auto_attach()` for PCI boards. `dio200_auto_attach()` assigns `dev->board_name` (where `dev` is the `struct comedi_device *` under consideration) before calling `dio200_common_attach()`. Do the same in `dio2

[PATCH 06/12] staging: comedi: amplc_dio200: dio200_common_attach() return 0

2013-03-18 Thread Ian Abbott
Change the successful return value of `dio200_common_attach()` from 1 to 0. This is propagated as the return value from the driver's "attach" (`dio200_attach()`) or "auto_attach" (`dio200_auto_attach()`) handler. Any non-negative value will do, but 0 is more conventional than 1. Signed-off-by: Ia

[PATCH 00/12] staging: comedi: split amplc_dio200 driver

2013-03-18 Thread Ian Abbott
Split the "amplc_dio200" driver into separate drivers for ISA boards and PCI boards. The original "amplc_dio200" module is split into 3 modules: amplc_dio200: this now only handles ISA boards. The old name is retained to hopefully not break scripts that modprobe the module. amplc_dio200_pci: th

[PATCH 04/12] staging: comedi: amplc_dio200: embed board layout in board structure

2013-03-18 Thread Ian Abbott
The amplc_dio200 driver supports both ISA and PCI boards, some of which are quite similar. The driver takes advantage of this by defining a "board layout" structure `struct dio200_layout` along with an array of this structure `dio200_layouts[]` and an enumerated type for the indices into this arra

[PATCH 02/12] staging: comedi: amplc_dio200: don't check bus type in attach

2013-03-18 Thread Ian Abbott
Since the legacy attach routine `dio200_attach()` is only called for board names matching an entry in our array of ISA boards `dio200_isa_boards[]`, and it is reasonable to expect all elements of `dio200_isa_boards[]` to have their `bustype` member initialized correctly to `isa_bustype`, don't both

RE: [PATCH 1/1] Drivers: hv: Notify the host of permanent hot-add failures

2013-03-18 Thread KY Srinivasan
> -Original Message- > From: K. Y. Srinivasan [mailto:k...@microsoft.com] > Sent: Sunday, March 17, 2013 11:08 PM > To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > devel@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@redhat.com > Cc: KY Srinivasan >

Re: [PATCH 1/8] staging: omap-thermal: fix return value

2013-03-18 Thread Dan Carpenter
Thanks. Acked-by: Dan Carpenter regards, dan carpenter ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Re: [PATCH 2/2] Drivers: hv: balloon: Support 2M page allocations for ballooning

2013-03-18 Thread Michal Hocko
On Mon 18-03-13 15:08:36, KY Srinivasan wrote: > What is your recommendation with regards which tree the mm patch needs > to go through; the Hyper-V balloon driver patch will go through Greg's > tree. I would say via Andrew but there are dependencies between those two so a single tree would be les

RE: [PATCH 2/2] Drivers: hv: balloon: Support 2M page allocations for ballooning

2013-03-18 Thread KY Srinivasan
> -Original Message- > From: Michal Hocko [mailto:mho...@suse.cz] > Sent: Monday, March 18, 2013 10:13 AM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > devel@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > a...@firstfloor.org; a...@lin

[PATCH 8/8] staging: ti-soc-thermal: fix several kernel-doc warnings and error

2013-03-18 Thread Eduardo Valentin
This patch updates the documentation to remove all warnings and errors reported by scripts/kernel-doc. Most are missing arguments due to wrong format. Cc: Nishanth Menon Signed-off-by: Eduardo Valentin diff --git a/drivers/staging/ti-soc-thermal/ti-bandgap.c b/drivers/staging/ti-soc-thermal/t

[PATCH 7/8] stating: ti-soc-thermal: use sizeof(*pointer) while allocating

2013-03-18 Thread Eduardo Valentin
Follow Documentation/CodingStyle and use sizeof(*pointer) instead of sizeof(struct type). Signed-off-by: Eduardo Valentin diff --git a/drivers/staging/ti-soc-thermal/ti-bandgap.c b/drivers/staging/ti-soc-thermal/ti-bandgap.c index b74e847..4382c0c 100644 --- a/drivers/staging/ti-soc-thermal/ti-

[PATCH 6/8] staging: ti-soc-thermal: split writable data from readonly data

2013-03-18 Thread Eduardo Valentin
This patch changes the data structures of this driver so that readonly data can reside only in the conf pointer. Now each register has a struct to hold its configuration info, to be used base on chip version for instance, and a struct of values to be written, like register shadow and priv data. Si

[PATCH 5/8] staging: ti-soc-thermal: make unexported functions local

2013-03-18 Thread Eduardo Valentin
Move _ti_bandgap_write_threshold and _ti_bandgap_read_threshold to static area, as they are local functions. Signed-off-by: Eduardo Valentin diff --git a/drivers/staging/ti-soc-thermal/ti-bandgap.c b/drivers/staging/ti-soc-thermal/ti-bandgap.c index 6a0b1ac..c850e13 100644 --- a/drivers/staging

[PATCH 3/8] staging: omap-thermal: rename bg_ptr to bgp

2013-03-18 Thread Eduardo Valentin
Use a shorter name to bandgap pointer. Cc: Benoit Signed-off-by: Eduardo Valentin diff --git a/drivers/staging/omap-thermal/omap-bandgap.c b/drivers/staging/omap-thermal/omap-bandgap.c index a4ac06c..89361fe 100644 --- a/drivers/staging/omap-thermal/omap-bandgap.c +++ b/drivers/staging/omap-t

[PATCH 2/8] staging: omap-thermal: use spin_lock_irqsave inside IRQ handler

2013-03-18 Thread Eduardo Valentin
Even if the IRQ is not firing because it is ONE_SHOT and disable at INTC level, the IRQ handler must use spin_lock_irqsave. It is necessary to disable IRQs from the current CPU while it is holding a spin_lock which is need. Cc: Dan Carpenter Signed-off-by: Eduardo Valentin diff --git a/drivers

[PATCH 1/8] staging: omap-thermal: fix return value

2013-03-18 Thread Eduardo Valentin
Return the proper error value in _omap_bandgap_read_threshold. Cc: Dan Carpenter Signed-off-by: Eduardo Valentin diff --git a/drivers/staging/omap-thermal/omap-bandgap.c b/drivers/staging/omap-thermal/omap-bandgap.c index 33bfe3b..cb7aa35 100644 --- a/drivers/staging/omap-thermal/omap-bandgap

[PATCH 0/8] staging: [omap,ti-soc]-thermal: fixes and renaming

2013-03-18 Thread Eduardo Valentin
Hi Greg, I am sending extra patches on omap-thermal driver, under staging. There are couple of fixes based on Dan Carpenter's review on the last patch set I sent. On top of these, there are some changes on the naming convention for this driver. This rename is based on previous review cycles that

Re: [PATCH 00/50] staging: omap-thermal: several code refactoring

2013-03-18 Thread Eduardo Valentin
Greg, Dan, On 16-03-2013 12:16, Greg KH wrote: On Sat, Mar 16, 2013 at 08:46:03AM -0400, Eduardo Valentin wrote: Hello Dan, On 16-03-2013 05:05, Dan Carpenter wrote: I've reviewed this set. I hate to make people redo whole patchset sets, and I hate re-reviewing code. Obviously, I don't real

Re: [PATCH 2/2] Drivers: hv: balloon: Support 2M page allocations for ballooning

2013-03-18 Thread Michal Hocko
On Mon 18-03-13 13:44:05, KY Srinivasan wrote: > > > > -Original Message- > > From: Michal Hocko [mailto:mho...@suse.cz] > > Sent: Monday, March 18, 2013 6:53 AM > > To: KY Srinivasan > > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > > devel@linuxdriverproject.org; o...@

RE: [PATCH 2/2] Drivers: hv: balloon: Support 2M page allocations for ballooning

2013-03-18 Thread KY Srinivasan
> -Original Message- > From: Michal Hocko [mailto:mho...@suse.cz] > Sent: Monday, March 18, 2013 6:53 AM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > devel@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > a...@firstfloor.org; a...@linu

RE: [PATCH 1/2] mm: Export split_page()

2013-03-18 Thread KY Srinivasan
> -Original Message- > From: Michal Hocko [mailto:mho...@suse.cz] > Sent: Monday, March 18, 2013 7:04 AM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > devel@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > a...@firstfloor.org; a...@linu

Re: [PATCH 1/2] mm: Export split_page()

2013-03-18 Thread Michal Hocko
On Sat 16-03-13 14:42:04, K. Y. Srinivasan wrote: > The split_page() function will be very useful for balloon drivers. On Hyper-V, > it will be very efficient to use 2M allocations in the guest as this (a) makes > the ballooning protocol with the host that much more efficient and (b) moving > memor

Re: [PATCH 2/2] Drivers: hv: balloon: Support 2M page allocations for ballooning

2013-03-18 Thread Michal Hocko
On Mon 18-03-13 11:52:57, Michal Hocko wrote: > On Sat 16-03-13 14:42:05, K. Y. Srinivasan wrote: > > While ballooning memory out of the guest, attempt 2M allocations first. > > If 2M allocations fail, then go for 4K allocations. In cases where we > > have performed 2M allocations, split this 2M pa

Re: [PATCH 2/2] Drivers: hv: balloon: Support 2M page allocations for ballooning

2013-03-18 Thread Michal Hocko
On Sat 16-03-13 14:42:05, K. Y. Srinivasan wrote: > While ballooning memory out of the guest, attempt 2M allocations first. > If 2M allocations fail, then go for 4K allocations. In cases where we > have performed 2M allocations, split this 2M page so that we can free this > page at 4K granularity (