better to treate them as NUL terminated string.
Signed-off-by: Chen Gang
---
drivers/staging/media/go7007/go7007-v4l2.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/go7007/go7007-v4l2.c
b/drivers/staging/media/go7007/go7007-v4l2.c
index cb
for NUL terminated string, need always set '\0' in the end.
Signed-off-by: Chen Gang
---
drivers/staging/media/go7007/snd-go7007.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/go7007/snd-go7007.c
b/drivers/staging/media/go7007/snd-go7007
On Tuesday, March 19, 2013 6:09 PM, H Hartley Sweeten wrote:
>
> The subdev_8255_init() function can fail. Check for failure and
> return the errno.
>
> Consolidate the mmio/ioport calls to subdev_8255_init(). The callback
> function can be added with a simple ? : test and the cast of the iobase
>
For aesthetic reasons, rename the 'command*_bits' and 'status*_bits'
variables in the private data in order to shorten some of the long
lines.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc.c | 272 ++--
Update the MODULE_DESCRIPTION for the ni_labpc drivers. Also, use the
correct author for MODULE_AUTHOR.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc.c | 4 ++--
drivers/staging/comedi/drivers/ni_labpc_cs.c | 2 +-
drive
For aesthetic reasons, rename the local variable 'thisboard' to
'board'.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc.c | 56 +--
drivers/staging/comedi/drivers/ni_labpc_isa.c | 4 +-
2 files cha
Introduce a helper function to determine if a range selection is
bipolar or unipolar.
This allows removing the static data 'labpc_range_is_unipolar' and
'labpc_plus_is_unipolar' as well as the boardinfo 'ai_range_is_unipolar'.
For consistency, also use the helper in labpc_ao_insn_write() when
che
As indicated by checkpatch.pl, "WARNING: Use of volatile is usually
wrong: ...". The variables in the private data that are marked
volatile don't need to be. Remove the volatile.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc.
For aesthetic reasons, rename the (*insn_read) and (*insn_write)
functions to help with greps.
Add some whitespace to the subdevice init.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc.c | 48 +--
The subdev_8255_init() function can fail. Check for failure and
return the errno.
Consolidate the mmio/ioport calls to subdev_8255_init(). The callback
function can be added with a simple ? : test and the cast of the iobase
is not necessary.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: G
Rename the boardinfo 'memory_mapped_io' to 'has_mmio'.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc.c | 6 +++---
drivers/staging/comedi/drivers/ni_labpc.h | 2 +-
drivers/staging/comedi/drivers/ni_labpc_pci.c | 2 +-
Each comedi_subdevice uses one of the minors allocated to the
comedi subsystem. The devices used with this driver need a minimum
of 2 and a maximum of 5 subdevices.
Only allocate and initialize the number of subdevices actually needed
by the device.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbot
For aesthetic reasons, rename the (*insn_read) and (*insn_write)
functions to help with greps.
Add some whitespace to the subdevice init. Change the 'maxdata'
value to hex as this is more common in comedi drivers.
Remove the unnecessary comment about adding command support.
Signed-off-by: H Hart
An interrupt is required for command support to work with the
analog input subdevice. When used with the ISA driver, enabling
the interrupt is optional. Fix the subdevice init so that command
support is only enabled if the irq is available.
For aesthetic reasons, rename the (*insn_read) function t
The PCMCIA support for the National Instruments Lab-PC DAQCard-1200
is already handled by a separate module, ni_labpc_cs. Split the bus
specific ISA and PCI code out of this driver and create two new
drivers, ni_labpc_isa and ni_labpc_pci. This allows the ni_labpc
module to be a standalone module w
With the bus specific code split out of the ni_labpc driver, the
device_id and bustype fields in the boardinfo are no longer used.
Remove them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc.h | 3 ---
drivers/staging/come
In labpc_ai_cmd(), the thisboard->bustype check when determining the
method used to transfer the data is unnecessary. Only the "isa_bustype"
allocates a dma_chan so if the dma_chan is valid the isa_dma_transfer
will work.
Remove the unnecessary check.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abb
This driver uses the comedi auto config mechanism to attach to PCI
boards. The "dummy" entry in the boardinfo table is not needed.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc.c | 5 -
1 file changed, 5 deletions(-)
dif
For aesthetic reasons, add some whitespace to the boardinfo.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc.c | 82 +++
1 file changed, 40 insertions(+), 42 deletions(-)
diff --git a/drivers/stagin
It's not necessary to initialize the boardinfo data that is set
to '0'.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_labpc.c
b/driv
Tidy up all the tables used to indicate the bipolar/unipolar
type of the range. the gain bits used to set the range, and the
comedi_lrange.
Remove a couple unnecessary #define's used to indicate the size
of the tables as well as some unnecessary comments.
Signed-off-by: H Hartley Sweeten
Cc: Ian
Move the analog input support functions to remove the need for the
remaining forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc.c | 612 +++---
1 file changed, 303 insertions(+), 309 d
For aesthetic reasons, move the analog output support functions.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc.c | 108 +++---
1 file changed, 54 insertions(+), 54 deletions(-)
diff --git a/drivers/st
Move the interrupt/dma support functions to remove the need for
some of the forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc.c | 424 +++---
1 file changed, 209 insertions(+), 215 de
For aesthetic reasons, add some whitespace to the comedi_driver and
pci_driver as well as the pci device table declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc.c | 26 +-
1 file changed, 13
Move the eeprom/caldac support functions to remove the need for
some of the forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc.c | 168 ++
1 file changed, 81 insertions(+), 87 dele
Move the comedi_driver (*attach), (*auto_attach), and (*detach)
functions as well as a couple of the attach helper functions to
remove the need for a number of the forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni
The 'thisboard' macro relies on a local variable having a specific
name and yields a pointer derived from that local variable.
Replace the macro with a local variable and use the comedi_board()
helper to get the const pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartm
For aesthetic reasons, rename labpc_board_struct to labpc_boardinfo.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc.c| 10 +-
drivers/staging/comedi/drivers/ni_labpc.h| 2 +-
drivers/staging/comedi/drivers/ni_
Cleanup the driver and split the bus specific support out to separate
drivers.
H Hartley Sweeten (26):
staging: comedi: ni_labpc: rename labpc_board_struct
staging: comedi: ni_labpc: remove thisboard macro
staging: comedi: ni_labpc: add some whitespace to the *_driver declarations
staging:
> -Original Message-
> From: Michal Hocko [mailto:mho...@suse.cz]
> Sent: Tuesday, March 19, 2013 10:13 AM
> To: KY Srinivasan
> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> devel@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> a...@firstfloor.org; a...@li
On 10:54-20130319, Eduardo Valentin wrote:
> This patch updates the documentation to remove
> all warnings and errors reported by scripts/kernel-doc.
> Most are missing arguments due to wrong format.
>
> Cc: Nishanth Menon
>
> Signed-off-by: Eduardo Valentin
> ---
&
Powerball Lotto
2013 Email Promotion
Winning Notification-75210
This is to inform you that your email has won for you $1,500,000 in Powerball
Lotto 2013 new year Promo.
You did not purchase any ticket to enter for it, as an internet user your email
address was randomly selected
and you are one o
While writing talert thresholds, propagate the error code from
ti_bandgap_update_alert_threshold to the caller of
_ti_bandgap_write_threshold.
Signed-off-by: Eduardo Valentin
---
drivers/staging/ti-soc-thermal/ti-bandgap.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a
Wrong threshold cold values may be written with current implementation.
This patch fixes the threshold update function by simplifying the
bitfield manipulation sequence.
Signed-off-by: Eduardo Valentin
---
drivers/staging/ti-soc-thermal/ti-bandgap.c |8
1 files changed, 4 insertions
While updating talert thresholds, threshold cold must
always be lower than threshold hot. This patch fixes
the function ti_bandgap_update_alert_threshold to only
change the thresholds by applying a hysteresis when
they violate this condition.
Signed-off-by: Eduardo Valentin
---
drivers/staging/t
This patch updates the documentation to remove
all warnings and errors reported by scripts/kernel-doc.
Most are missing arguments due to wrong format.
Cc: Nishanth Menon
Signed-off-by: Eduardo Valentin
---
drivers/staging/ti-soc-thermal/ti-bandgap.c | 56 +-
drivers/s
Follow Documentation/CodingStyle and use sizeof(*pointer)
instead of sizeof(struct type).
Signed-off-by: Eduardo Valentin
---
drivers/staging/ti-soc-thermal/ti-bandgap.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ti-soc-thermal/ti-bandgap.c
b/driv
This patch changes the data structures of this driver so
that readonly data can reside only in the conf pointer.
Now each register has a struct to hold its configuration info,
to be used base on chip version for instance, and a
struct of values to be written, like register shadow and priv data.
Si
Move _ti_bandgap_write_threshold and _ti_bandgap_read_threshold to static
area, as they are local functions.
Signed-off-by: Eduardo Valentin
---
drivers/staging/ti-soc-thermal/ti-bandgap.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ti-soc-ther
This patch renames the Kconfig options to cope with
the new naming convention.
Cc: Santosh Shilimkar
Cc: Benoit
Cc: Nishanth Menon
Cc: Dan Carpenter
Signed-off-by: Eduardo Valentin
---
drivers/staging/Makefile|2 +-
drivers/staging/ti-soc-thermal/Kconfig | 14
Because this driver will support also OMAP derivatives,
this patch does a big rename inside this driver, so it
better fits its usage.
This patch only renames the directory, file names,
includes, Makefiles and Kconfig includes.
Cc: Santosh Shilimkar
Cc: Benoit
Cc: Nishanth Menon
Cc: Dan Carpent
Use a shorter name to bandgap pointer.
Cc: Benoit
Cc: Dan Carpenter
Signed-off-by: Eduardo Valentin
---
drivers/staging/omap-thermal/omap-bandgap.c| 562 ++--
drivers/staging/omap-thermal/omap-bandgap.h| 28 +-
drivers/staging/omap-thermal/omap-thermal-commo
> -Original Message-
> From: Michal Hocko [mailto:mho...@suse.cz]
> Sent: Tuesday, March 19, 2013 10:46 AM
> To: KY Srinivasan
> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> devel@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> a...@firstfloor.org; a...@li
Return the proper error value in _omap_bandgap_read_threshold.
Acked-by: Dan Carpenter
Signed-off-by: Eduardo Valentin
---
drivers/staging/omap-thermal/omap-bandgap.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/omap-thermal/omap-bandgap.c
b/drivers
Hello Greg,
This is version 2 of this series to rename omap-thermal driver
inside staging tree. V1 is found here:
http://lkml.org/lkml/2013/3/18/357
The idea of the series is the same. It includes several fixes, but
the major change is that now the driver will be named ti-soc-thermal,
because it
On Mon 18-03-13 13:51:37, K. Y. Srinivasan wrote:
> On Hyper-V it will be very efficient to use 2M allocations in the guest as
> this
> makes the ballooning protocol with the host that much more efficient. Hyper-V
> uses page ranges (start pfn : number of pages) to specify memory being moved
> aro
Hello Greg,
On 18-03-2013 10:59, Eduardo Valentin wrote:
Hi Greg,
I am sending extra patches on omap-thermal driver, under staging.
There are couple of fixes based on Dan Carpenter's review on
the last patch set I sent. On top of these, there are some
changes on the naming convention for this
On Mon 18-03-13 13:51:36, K. Y. Srinivasan wrote:
> This symbol would be used in the Hyper-V balloon driver to support 2M
> allocations.
>
> In this version of the patch, based on feedback from Michal Hocko
> , I have updated the patch description.
I guess this part is not necessary ;)
>
> Sign
On Sat, Mar 16, 2013 at 02:02:36PM +0200, Silviu-Mihai Popescu wrote:
> The objects allocated by devm_* APIs are managed by devres and are freed
> when the device is detached. There is no need to use kfree() explicitly.
Not only 'no need', it's simply wrong.
>
> Signed-off-by: Silviu-Mihai Popes
No change in the logic of the driver
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/sb105x/sb_pci_mp.c | 974 +---
1 file changed, 449 insertions(+), 525 deletions(-)
diff --git a/drivers/staging/sb105x/sb_pci_mp.c
b/drivers/staging/sb105x/sb_pci_
Driver logic is not being modified
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/sb105x/sb_mp_register.h |7 +-
drivers/staging/sb105x/sb_pci_mp.c | 390 ++-
drivers/staging/sb105x/sb_pci_mp.h | 165 ++---
drivers/staging/sb105x/
Now the build finishes without any errors
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/sb105x/Kconfig |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sb105x/Kconfig b/drivers/staging/sb105x/Kconfig
index 245e784..58cc52e 100644
--- a/drivers
No need to have a definition of inline. It doesn't harm anything if explicitly
specify
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/sb105x/sb_pci_mp.c | 24
drivers/staging/sb105x/sb_pci_mp.h |9 -
2 files changed, 12 insertions(+), 21 delet
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/sb105x/sb_pci_mp.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/sb105x/sb_pci_mp.c
b/drivers/staging/sb105x/sb_pci_mp.c
index 9e30a0c..cb27fb6 100644
--- a/drive
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/sb105x/TODO |6 ++
1 file changed, 6 insertions(+)
create mode 100644 drivers/staging/sb105x/TODO
diff --git a/drivers/staging/sb105x/TODO b/drivers/staging/sb105x/TODO
new file mode 100644
index 000..518346f
--- /dev/null
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/sb105x/sb_pci_mp.c | 20
1 file changed, 20 deletions(-)
diff --git a/drivers/staging/sb105x/sb_pci_mp.c
b/drivers/staging/sb105x/sb_pci_mp.c
index 4c88bfc..7196412 100644
--- a/drivers/staging/sb105x/sb_pci_mp.
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/sb105x/sb_pci_mp.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/sb105x/sb_pci_mp.c
b/drivers/staging/sb105x/sb_pci_mp.c
index 7196412..9e30a0c 100644
--- a/drivers/staging/s
Hello all,
I have been working in a batch of patches to make the driver sb105x
compile-able with latest source code base.
I have not tested the patches in real HW as I don't have it. Hopefully, I
didn't break anything.
The driver has a lot of coding style issues, lack of tty_port support, a lot
Use struct tty_port wherever is needed, fixing compilation errors.
Signed-off-by: Samuel Iglesias Gonsalvez
---
drivers/staging/sb105x/sb_pci_mp.c | 18 +++---
drivers/staging/sb105x/sb_ser_core.h |1 +
2 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers/s
After splitting support for PCI cards out of the "amplc_dio200" module
into "amplc_dio200_pci", the help text needs updating.
Signed-off-by: Ian Abbott
---
Sorry for the 13/12 - I forgot about changing the help text!
---
drivers/staging/comedi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 de
- Original Message -
> 于 2013年03月19日 16:58, Tomas Hozza 写道:
> > - Original Message -
> >>> -Original Message-
> >>> From: Tomas Hozza [mailto:tho...@redhat.com]
> >>> Sent: Monday, March 18, 2013 11:39 AM
> >>> To: KY Srinivasan
> >>> Cc: Jason Wang
> >>> Subject: Re: Can Hy
于 2013年03月19日 16:58, Tomas Hozza 写道:
- Original Message -
-Original Message-
From: Tomas Hozza [mailto:tho...@redhat.com]
Sent: Monday, March 18, 2013 11:39 AM
To: KY Srinivasan
Cc: Jason Wang
Subject: Re: Can HyperV KVP daemon detect if running under Windows
Server
- Origin
- Original Message -
> > -Original Message-
> > From: Tomas Hozza [mailto:tho...@redhat.com]
> > Sent: Monday, March 18, 2013 11:39 AM
> > To: KY Srinivasan
> > Cc: Jason Wang
> > Subject: Re: Can HyperV KVP daemon detect if running under Windows
> > Server
> >
> > - Original M
2013/3/7 Richard Genoud :
> 2013/3/6 Haiyang Zhang :
>> I have found a simple way to reproduce this kind of warning:
>> 1) reboot the VM (because this warning can be displayed only once.)
>> 2) login to the host and open the VM [Settings]
>> 3) Temporarily change the Network adapter's option [Virtu
On Mon, Mar 18, 2013 at 08:33:51PM -0500, Andres More wrote:
> Removed comments from coding template.
> sed -i '/^\/\*---/d' drivers/staging/vt6656/*.[ch]
>
I wish you would delete all the blank lines as well. We shouldn't
have two blanks in a row.
But otherwise this is fine.
Reviewed-by: Dan
On Mon, Mar 18, 2013 at 08:33:50PM -0500, Andres More wrote:
> Removed struct tagS802_11Header, switching to struct ieee80211_hdr instead.
> Checkpatch warnings and errors were not resolved.
>
Great.
Reviewed-by: Dan Carpenter
The goodness of this is that now we can find all the endian bugs
ve
On Mon, Mar 18, 2013 at 08:33:49PM -0500, Andres More wrote:
> Removed struct tagSEthernetHeader, replacing with struct ethhdr.
> Not all checkpatch errors and warnings were removed.
>
Looks great.
Reviewed-by: Dan Carpenter
regards,
dan carpenter
_
68 matches
Mail list logo
