[PATCH v2 4/4] rtl8192u: fix printk calls in r8192U_core.c

This patch fixes the following checkpatch warning: WARNING: printk() should include KERN_ facility level by replacing calls to printk with their corresponding calls to pr_ (fmt, ...), defined in include/linux/printk.h, and netdev_ (dev, fmt, ...) defined in include/linux/netdevice.h. Signed-off-b

Re: [PATCH 4/4] rtl8192u: fix printk calls in r8192U_core.c

On Thu, May 23, 2013 at 05:14:49AM +0300, Xenia Ragiadakou wrote: > This patch fixes the following checkpatch warning: > WARNING: printk() should include KERN_ facility level > and also replaces calls to printk(KERN_ fmt, ...) with > their corresponding calls to pr_ (fmt, ...), defined in > include

[PATCH 4/4] rtl8192u: fix printk calls in r8192U_core.c

This patch fixes the following checkpatch warning: WARNING: printk() should include KERN_ facility level and also replaces calls to printk(KERN_ fmt, ...) with their corresponding calls to pr_ (fmt, ...), defined in include/linux/printk.h, to save space. Signed-off-by: Xenia Ragiadakou --- drive

[PATCH 3/4] rtl8192u: replace __FUNCTION__ with __func__ in r8192U_core.c

This patch fixes the following checkpatch warning: WARNING: __func__ should be used instead of gcc specific __FUNCTION__ Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r8192U_core.c | 64 1 file changed, 32 insertions(+), 32 deletions(-) diff --g

[PATCH 2/4] rtl8192u: add space after '}' in r8192U_core.c

This patch fixes the following checkpatch error: ERROR: space required after that close brace '}' Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r8192U_core.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8192u/r81

[PATCH 1/4] rtl8192u: remove space between function name and '(' in r8192U_core.c

This patch fixes the following checkpatch warning: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r8192U_core.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/

Re: [PATCHv11 2/4] zbud: add to mm/

Hi Mel & Seth, On 05/21/2013 04:10 PM, Mel Gorman wrote: > On Mon, May 20, 2013 at 10:42:25AM -0500, Seth Jennings wrote: >> On Mon, May 20, 2013 at 02:54:39PM +0100, Mel Gorman wrote: >>> On Sun, May 19, 2013 at 03:52:19PM -0500, Seth Jennings wrote: My first guess is that the external fragm

Re: [PATCH] staging: speakup: fix warnings by adding __user annotations

Emil Goode, le Wed 22 May 2013 20:53:09 +0200, a écrit : > This patch fixes the following sparse warnings by adding > __user annotations. > > drivers/staging/speakup/speakup_soft.c:248:34: warning: > incorrect type in argument 1 (different address spaces) > drivers/staging/speakup/

[PATCH] staging: speakup: fix warnings by adding __user annotations

This patch fixes the following sparse warnings by adding __user annotations. drivers/staging/speakup/speakup_soft.c:248:34: warning: incorrect type in argument 1 (different address spaces) drivers/staging/speakup/speakup_soft.c:248:34: expected void [noderef] *dst d

Re: [PATCH] MIPS: OCTEON: Rename Kconfig CAVIUM_OCTEON_REFERENCE_BOARD to CAVIUM_OCTEON_SOC

On Wed, May 22, 2013 at 09:13:50AM -0700, David Daney wrote: > Can you take v2 instead? It has the missing watchdog adjustment > that is not in v1. Done. Ralf ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.or

Re: [PATCH] MIPS: OCTEON: Rename Kconfig CAVIUM_OCTEON_REFERENCE_BOARD to CAVIUM_OCTEON_SOC

On 05/22/2013 05:22 AM, Ralf Baechle wrote: On Tue, May 21, 2013 at 03:07:23PM -0700, David Daney wrote: config USB_OCTEON_OHCI bool "Octeon on-chip OHCI support" - depends on CPU_CAVIUM_OCTEON + depends on CAVIUM_OCTEON_SOC Just a minor comment, here the extra whitespa

[PATCH v2] MIPS: OCTEON: Rename Kconfig CAVIUM_OCTEON_REFERENCE_BOARD to CAVIUM_OCTEON_SOC

From: David Daney CAVIUM_OCTEON_SOC most place we used to use CPU_CAVIUM_OCTEON. This allows us to CPU_CAVIUM_OCTEON in places where we have no OCTEON SOC. Remove CAVIUM_OCTEON_SIMULATOR as it doesn't really do anything, we can get the same configuration with CAVIUM_OCTEON_SOC. Signed-off-by:

[PATCH v3 4/4] tools: hv: Fix file descriptor leaks

Close "fd" file descriptor when is goes out of scope so it does not leak. Signed-off-by: Tomas Hozza --- tools/hv/hv_kvp_daemon.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c index 5b8f28f..d55ce40 100644 --- a/tools

[PATCH v3 3/4] tools: hv: Check retrun value of strchr call

Check return value of strchr call and dereference it only if it is not NULL. Signed-off-by: Tomas Hozza --- tools/hv/hv_kvp_daemon.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c index 81cbb6e..5b8f28f 100644 --- a/tool

[PATCH v3 2/4] tools: hv: Check return value of poll call

Check return value of poll call and if it fails print error to the system log. If errno is EINVAL then exit with non-zero value otherwise continue the while loop and call poll again. Signed-off-by: Tomas Hozza --- tools/hv/hv_kvp_daemon.c | 11 ++- 1 file changed, 10 insertions(+), 1 del

[PATCH v3 1/4] tools: hv: Check return value of setsockopt call

Check return value of setsockopt call and if it fails print error to the system log and exit with non-zero value. Signed-off-by: Tomas Hozza --- tools/hv/hv_kvp_daemon.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c

[PATCH v3 0/4] Fixes for defects found by static analysis

Previous patches 1/4 and 2/4 contained an error (missing comma) that prevented the patched source to be built. Patches are based on linux-next (20130522) tree. Tomas Hozza (4): tools: hv: Check return value of setsockopt call tools: hv: Check return value of poll call tools: hv: Check

Re: [PATCH] MIPS: OCTEON: Rename Kconfig CAVIUM_OCTEON_REFERENCE_BOARD to CAVIUM_OCTEON_SOC

On Tue, May 21, 2013 at 03:07:23PM -0700, David Daney wrote: > >> config USB_OCTEON_OHCI > >>bool "Octeon on-chip OHCI support" > >>- depends on CPU_CAVIUM_OCTEON > >>+ depends on CAVIUM_OCTEON_SOC > > > >Just a minor comment, here the extra whitespace after "depends on" > >could be elim

Re: [PATCH 4/6] Staging: speakup/main: Use NULL instead of 0

On 22 May 2013 14:59, Santosh Y wrote: > On Wed, May 22, 2013 at 2:37 PM, Sachin Kamat wrote: >> Use NULL instead of 0 for pointers. >> >> Signed-off-by: Sachin Kamat >> --- >> drivers/staging/speakup/main.c |4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/driv

[PATCH v2 4/6] Staging: speakup/main: Use NULL instead of 0

Use NULL instead of 0 for pointers. Signed-off-by: Sachin Kamat --- Changes since v1: Used (!key_info) instead of (key_info == NULL) --- drivers/staging/speakup/main.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/main.c b/drivers/staging/spea

[PATCH 2/2] Staging: ced1401: Staticize local symbols

Symbols referenced only in this file are made static. Signed-off-by: Sachin Kamat --- drivers/staging/ced1401/ced_ioc.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401/ced_ioc.c index a31adb3..2dbaf39 100644

[PATCH 1/2] Staging: ced1401: Use NULL instead of 0 for pointers

Use NULL instead of 0 for pointer variables. Signed-off-by: Sachin Kamat --- drivers/staging/ced1401/ced_ioc.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401/ced_ioc.c index 6784240..a31adb3 1

Re: [PATCH 4/6] Staging: speakup/main: Use NULL instead of 0

On Wed, May 22, 2013 at 2:37 PM, Sachin Kamat wrote: > Use NULL instead of 0 for pointers. > > Signed-off-by: Sachin Kamat > --- > drivers/staging/speakup/main.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speak

Re: [PATCH 6/6] Staging: speakup/main: Staticize local symbols

Sachin Kamat, le Wed 22 May 2013 14:37:25 +0530, a écrit : > Symbols referenced only in this file are made static. > > Signed-off-by: Sachin Kamat Acked-by: Samuel Thibault ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriv

[PATCH 6/6] Staging: speakup/main: Staticize local symbols

Symbols referenced only in this file are made static. Signed-off-by: Sachin Kamat --- drivers/staging/speakup/main.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c index f547250..209b90f 100644 -

[PATCH 5/6] Staging: speakup/kobjects: Use NULL instead of 0

Use NULL instead of 0 for pointers. Signed-off-by: Sachin Kamat --- drivers/staging/speakup/kobjects.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c index 5c93bb3..51bdea3 100644 --- a/drivers/stagi

[PATCH 4/6] Staging: speakup/main: Use NULL instead of 0

Use NULL instead of 0 for pointers. Signed-off-by: Sachin Kamat --- drivers/staging/speakup/main.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c index 4769c89..f547250 100644 --- a/drivers/staging/speaku

[PATCH 3/6] Staging: speakup/speakup_keypc: Return NULL instead of 0

The function returns a pointer. Hence return NULL instead of 0. Signed-off-by: Sachin Kamat --- drivers/staging/speakup/speakup_keypc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/speakup_keypc.c b/drivers/staging/speakup/speakup_keypc.c index

[PATCH 2/6] Staging: speakup/speakup_dtlk: Return NULL instead of 0

The function returns a pointer. Hence return NULL instead of 0. Signed-off-by: Sachin Kamat --- drivers/staging/speakup/speakup_dtlk.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/speakup_dtlk.c b/drivers/staging/speakup/speakup_dtlk.c index a96

[PATCH 1/6] Staging: speakup/speakup_acntpc: Return NULL instead of 0

The function returns a pointer. Hence return NULL instead of 0. Signed-off-by: Sachin Kamat --- drivers/staging/speakup/speakup_acntpc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/speakup_acntpc.c b/drivers/staging/speakup/speakup_acntpc.c ind