Re: [PATCH 7/9] staging: csr: Reformat pointer type casts

2013-06-01 Thread Lisa Nguyen
On Sat, Jun 1, 2013 at 1:31 AM, Dan Carpenter wrote: > > On Fri, May 31, 2013 at 10:23:07PM -0700, Lisa Nguyen wrote: > > Reformatted pointer type casts to resolve errors generated > > by checkpatch.pl and meet kernel coding standards in > > sme_userspace.c > > > > Signed-off-by: Lisa Nguyen > >

Re: [PATCH] clean up scary strncpy(dst, src, strlen(src)) uses

2013-06-01 Thread Rafael J. Wysocki
On Friday, May 31, 2013 09:18:07 AM Kees Cook wrote: > Fix various weird constructions of strncpy(dst, src, strlen(src)). Length > limits should be about the space available in the destination, not > repurposed as a method to either always include or always exclude > a trailing NULL byte. Either th

Re: [PATCH 1/3] rtl8192e cleanups

2013-06-01 Thread Dan Carpenter
On Fri, May 31, 2013 at 09:48:09PM -0400, Sean MacLennan wrote: > > > +#if 0 > > > struct phy_ofdm_rx_status_rxsc_sgien_exintfflag { > > > u8 reserved:4; > > > u8 rxsc:2; > > > u8 sgi_en:1; > > > u8 ex_intf

Re: [RFC 5/5] rtl8192u: fix identation in r8192U_core.c

2013-06-01 Thread Dan Carpenter
On Sat, Jun 01, 2013 at 04:00:51AM +0300, Xenia Ragiadakou wrote: > In the 5/5 patch there are the following changes: > > - priv->TxPowerLevelOFDM24G[i] = priv->EEPROMTxPowerLevelOFDM24G[0]; > + priv->TxPowerLevelCCK[i] = priv->EEPROMTxPowerLevelOFDM24G[0] + > (priv->EEPROMTxPowerLevelCCK - priv-

Re: [PATCH 01/23] staging/lustre/clio: don't ignore layout on writeback

2013-06-01 Thread Dan Carpenter
What's going on with your email client? Could you fix it so we can see which is quoted text? regards, dan carpenter ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

[PATCH] HID: hyperv: Cocci spatch "memdup.spatch"

2013-06-01 Thread Thomas Meyer
Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c --- a/drivers/hid/hid-hyperv.c +++ b/drivers/hid/hid-hyperv.c @@ -199,13 +199,11 @@ static void mousevsc_on_receive_device_i if (desc->bLength == 0) goto cleanup; - in

Re: [PATCH 9/9] staging: csr: Move else keyword up to follow after }

2013-06-01 Thread Dan Carpenter
On Fri, May 31, 2013 at 10:23:52PM -0700, Lisa Nguyen wrote: > Resolved a closing brace issue generated by checkpatch.pl to > meet kernel coding standards in sme_userspace.c > > Signed-off-by: Lisa Nguyen > --- > drivers/staging/csr/sme_userspace.c | 3 +-- > 1 file changed, 1 insertion(+), 2 de

Re: [PATCH 8/9] staging: csr: Move open brace to previous line

2013-06-01 Thread Dan Carpenter
On Fri, May 31, 2013 at 10:23:37PM -0700, Lisa Nguyen wrote: > @@ -232,8 +231,7 @@ unifi_ta_indicate_protocol(void *ospriv, > direction, > *src_addr); > } > -else > -{ > +else { } else { regards, dan carpenter _

Re: [PATCH 7/9] staging: csr: Reformat pointer type casts

2013-06-01 Thread Dan Carpenter
On Fri, May 31, 2013 at 10:23:07PM -0700, Lisa Nguyen wrote: > Reformatted pointer type casts to resolve errors generated > by checkpatch.pl and meet kernel coding standards in > sme_userspace.c > > Signed-off-by: Lisa Nguyen > --- > drivers/staging/csr/sme_userspace.c | 6 +++--- > 1 file chang

Re: [PATCH 2/9] staging: csr: Add space before open parenthesis

2013-06-01 Thread Dan Carpenter
Can you resend [patch 1/9]? regards, dan carpenter ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Re: [RFC v2 5/5] rtl8192u: fix identation in r8192U_core.c

2013-06-01 Thread Dan Carpenter
On Sat, Jun 01, 2013 at 05:57:02AM +0300, Xenia Ragiadakou wrote: > This patch fixes identation and alignment in r8192U_core.c. > Also, removes spaces from idents when applicable. > All five: Reviewed-by: Dan Carpenter regards, dan carpenter ___ dev