[PATCH v2 2/2] staging: gdm72xx: fix typos in Kconfig

2013-06-03 Thread Ben Chan
Signed-off-by: Ben Chan Cc: Sage Ahn --- drivers/staging/gdm72xx/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gdm72xx/Kconfig b/drivers/staging/gdm72xx/Kconfig index dd47bd1..dd8a391 100644 --- a/drivers/staging/gdm72xx/Kconfig +++ b/drivers

[PATCH v2 1/2] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC

2013-06-03 Thread Ben Chan
interface, either USB or MMC, is built as a module. This patch enforces that in the WIMAX_GDM72XX_USB and WIMAX_GDM72XX_SDIO dependency. Reported-by: Alan Stern Signed-off-by: Ben Chan Cc: Sage Ahn --- drivers/staging/gdm72xx/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

Re: [PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC

2013-06-03 Thread Ben Chan
No worries. I've attached a revised patch to the original email thread, which includes Alan. Thanks again, Ben ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Re: [PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC

2013-06-03 Thread Ben Chan
Nope... I didn't resend the patch but replied to the thread. Ben On Mon, Jun 3, 2013 at 11:18 AM, Ben Chan wrote: > Sorry, I meant to send the revised patch but got the wrong file. > > I'll add the Reported-by field. > > Thanks, > Ben > __

[PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC

2013-06-03 Thread Ben Chan
The gdm72xx driver needs to have either the USB or SDIO implementation enabled to provide useful functionalities, so the driver should depend on either USB or MMC. Signed-off-by: Ben Chan Cc: Sage Ahn --- drivers/staging/gdm72xx/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC

2013-06-03 Thread Ben Chan
Sorry, I meant to send the revised patch but got the wrong file. I'll add the Reported-by field. Thanks, Ben On Mon, Jun 3, 2013 at 10:48 AM, Greg Kroah-Hartman wrote: > On Mon, Jun 03, 2013 at 10:23:45AM -0700, Ben Chan wrote: >> The gdm72xx driver needs to have either t

Re: Kernel v3.2 used in SlackWare 14.00 please, backport all needed patches Re: [PATCH net, 1/2] hyperv: Fix a kernel warning from netvsc_linkstatus_callback()

2013-05-27 Thread Ben Hutchings
k Slackware might do better to backport the Hyper-V drivers from Linux 3.4, as Debian and Ubuntu have done with 3.2-based kernels. But that sort of large backport isn't allowed on kernel.org stable branches. Ben. -- Ben Hutchings If at first you don't

Re: [PATCH] linux-firmware: Add firmware files for mtk mt7630/mt7650 chipsets

2013-05-27 Thread Ben Hutchings
On Sat, 2013-05-25 at 14:58 +0800, Jay Hung wrote: > Hi ben/dwwm2, > > > For below patch, can apply to upstream? > > Any concern to let me know. thanks Sorry for the delay. I've applied this, but: [...] > --- /dev/null > +++ b/LICENCE.ralin

[PATCH staging] vt6656: Fix inconsistent structure packing

2013-01-13 Thread Ben Hutchings
k(1) directives and adds __packed to the structure definitions for which packing appears to have been intended. Reported-and-tested-by: Malcolm Priestley Signed-off-by: Ben Hutchings Cc: sta...@vger.kernel.org --- --- a/drivers/staging/vt6656/bssdb.h +++ b/drivers/staging/vt6656/bssdb.h @@ -90,7 +

Re: [PATCH 1/3] tools/hv: Fix for long file names from readdir

2012-12-18 Thread Ben Hutchings
n > > > case. > > > > You are claiming two contradictory things: sprintf() may overrun the > > buffer, so we need the length check provided by snprintf(), but there > > is no need to check for truncation because we know the length is > > sufficient. > > S

Re: [PATCH 1/3] tools/hv: Fix for long file names from readdir

2012-11-27 Thread Ben Hutchings
n > > value and handle the truncation case somehow. > > By using PATH_MAX sized buffer there is no need for handling the truncation > case. You are claiming two contradictory things: sprintf() may overrun the buffer, so we need the length check provided by snprintf(), but

Re: [PATCH 1/3] tools/hv: Fix for long file names from readdir

2012-11-27 Thread Ben Hutchings
. So I think this is entirely unnecessary. Using snprintf() is a good idea, but you need to check the return value and handle the truncation case somehow. Ben. -- Ben Hutchings Never attribute to conspiracy what can adequately be explained by stupidity. signature.asc Description: This is a

[PATCH] staging: gdm72xx: fix unused variable warning in gdm_usb_send

2012-11-26 Thread Ben Chan
This patch fixes an unused variable warning in gdm_usb_send (when CONFIG_WIMAX_GDM72XX_K_MODE=n), which was introduced in commit 1a276b80466bbd195cf94ec7178f68f2ab351467 (staging: gdm72xx: protect access of rx / tx structs). Signed-off-by: Ben Chan --- drivers/staging/gdm72xx/gdm_usb.c |5

[PATCH] staging: gdm72xx: protect access of rx / tx structs

2012-11-24 Thread Ben Chan
om [<8004a43c>] (kthread+0x9c/0xa8) <5>[ 4996.815270] [<8004a43c>] (kthread+0x9c/0xa8) from [<8000f160>] (kernel_thread_exit+0x0/0x8) <0>[ 4996.815295] Code: e92d4000 e8bd4000 e2800020 eb4ab9a1 (e5905000) Signed-off-by: Ben Chan Signed-off-by: Sameer Nanda --- drivers/stag

Re: [PATCH] drivers/staging/gdm72xx/gdm_sdio.c: Replace kmalloc+memset for kzalloc

2012-09-17 Thread Ben Chan
FYI, a similar patch has already been applied: "staging: gdm72xx: simplify alloc_tx_struct and alloc_rx_struct (commit 129575f2a8958a1e90780b0d5b80702bb45b5aac)" Thanks, Ben On Mon, Sep 17, 2012 at 6:45 AM, Peter Senna Tschudin wrote: > Replace kmalloc+memset for kzalloc and cl

[PATCH] staging: speakup_soft: Fix reading of init string

2012-09-15 Thread Ben Hutchings
x27;t change, which seems to be the case. Really, the string and position belong together in a per-file private struct.) Tested-by: Samuel Thibault Signed-off-by: Ben Hutchings --- drivers/staging/speakup/speakup_soft.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff

Re: [PATCH v2 3/3] staging/gdm72xx: usb_boot: replace firmware upgrade API in em_download

2012-09-13 Thread Ben Chan
Hi Macpaul, Thanks for the patch. Some comments inlined. I briefly tested the patch on hardware and it seemed to work fine. - Ben On Thu, Sep 13, 2012 at 3:11 AM, Macpaul Lin wrote: > > Replace firmware upgrade API in em_download_image(). > > Signed-off-by: Macpaul Lin > C

[PATCH] staging: gdm72xx: simplify alloc_tx_struct and alloc_rx_struct

2012-09-12 Thread Ben Chan
This patch simplifies alloc_tx_struct and alloc_rx_struct in gdm_sdio.c and gdm_usb.c by replacing kmalloc+memset with kzalloc and reorganizing the code. Signed-off-by: Ben Chan --- drivers/staging/gdm72xx/gdm_sdio.c | 30 drivers/staging/gdm72xx/gdm_usb.c | 44

Re: [3.0.y, 3.2.y, 3.4.y, 3.5.y] Staging: speakup: fix an improperly-declared variable.

2012-09-09 Thread Ben Hutchings
On Mon, 2012-09-03 at 01:11 -0700, Jonathan Nieder wrote: > Hi Ben and Greg, > > Please consider > > 4ea418b8b2fa Staging: speakup: fix an improperly-declared variable > > for application to the 3.0.y, 3.2.y, 3.4.y, and 3.5.y stable > trees. Samuel Thibault (cc-ed) w

Re: [PATCH V3 08/14] Tools: hv: Gather DNS information

2012-08-17 Thread Ben Hutchings
On Fri, Aug 17, 2012 at 08:27:21PM +0200, Olaf Hering wrote: > On Fri, Aug 17, Ben Hutchings wrote: > > > On Fri, Aug 17, 2012 at 09:51:09AM -0700, Greg KH wrote: > > > On Thu, Aug 16, 2012 at 06:32:19PM -0700, K. Y. Srinivasan wrote: > > > > Now, gather DNS infor

Re: [PATCH V3 08/14] Tools: hv: Gather DNS information

2012-08-17 Thread Ben Hutchings
On Fri, Aug 17, 2012 at 10:38:37AM -0700, Greg KH wrote: > On Fri, Aug 17, 2012 at 06:32:09PM +0100, Ben Hutchings wrote: > > On Fri, Aug 17, 2012 at 09:51:09AM -0700, Greg KH wrote: > > > On Thu, Aug 16, 2012 at 06:32:19PM -0700, K. Y. Srinivasan wrote: > > > > Now,

Re: [PATCH V3 08/14] Tools: hv: Gather DNS information

2012-08-17 Thread Ben Hutchings
everywhere, but it seems to cover the same simple cases that this hypervisor-guest interface allows for. Ben. -- Ben Hutchings We get into the habit of living before acquiring the habit of thinking. - Albert Camus

Re: [PATCH V2 18/18] Tools: hv: Properly manage open streams

2012-08-13 Thread Ben Hutchings
On Mon, 2012-08-13 at 10:07 -0700, K. Y. Srinivasan wrote: > Close the open streams properly. > > Signed-off-by: K. Y. Srinivasan > Reviewed-by: Haiyang Zhang > Reviewed-by: Olaf Hering > Reviewed-by: Ben Hutchings This isn't reviewed by me, I'm the auth

Re: [PATCH V2 02/18] Drivers: hv: Add KVP definitions for IP address injection

2012-08-13 Thread Ben Hutchings
The registration operation code should have been defined as a sufficiently high value to avoid collision. However, since the daemon will always send one of the registration operations at start of day (and then never again), it seems that the driver can avoid

Re: [PATCH V2 06/18] Tools: hv: Further refactor kvp_get_ip_address()

2012-08-13 Thread Ben Hutchings
On Mon, 2012-08-13 at 10:06 -0700, K. Y. Srinivasan wrote: > In preparation for making kvp_get_ip_address() more generic, factor out > the code for handling IP addresses. > > Signed-off-by: K. Y. Srinivasan > Reviewed-by: Haiyang Zhang > Reviewed-by: Olaf Hering > Revie

Re: [PATCH v2] staging: gdm72xx: fix reference counting in gdm_wimax_event_init

2012-08-10 Thread Ben Chan
, remove A - insert A, insert B, remove A, remove B - insert A, insert B, remove B, remove A - insert A, insert B, remove A, remove B - insert A, insert B, remove B, insert B, remove B, remove A Thanks, Ben On Thu, Aug 9, 2012 at 11:28 PM, Dan Carpenter wrote: > Ben, I'm confused. Do you ha

Re: [PATCH v2] staging: gdm72xx: fix reference counting in gdm_wimax_event_init

2012-08-08 Thread Ben Chan
Hi, Does patch v2 make sense? Thanks, Ben On Wed, Jul 25, 2012 at 6:53 AM, Ben Chan wrote: > Hi Devendra, > > Thanks for cleaning up the driver. If I understand the code > correctly, the original author wanted to initialize wm_event once and > reuse it for multiple devices, and

Re: Bug#680762: [stable 2.6.36+] lirc_sir: make device registration work

2012-08-05 Thread Ben Hutchings
On Sun, 2012-08-05 at 19:28 -0400, Jarod Wilson wrote: > On Aug 5, 2012, at 3:52 PM, Ben Hutchings wrote: > > > On Wed, 2012-08-01 at 15:51 +0200, Stefan Lippers-Hollmann wrote: > >> Hi > >> > >> Please consider adding "[media] lirc_sir: ma

Re: Bug#680762: [stable 2.6.36+] lirc_sir: make device registration work

2012-08-05 Thread Ben Hutchings
, major 251 > lirc_sir: module is from the staging directory, the quality is unknown, you > have been warned. > lirc_register_driver: dev pointer not filled in! > lirc_sir: init_chrdev() failed. [...] It looks like lirc_register_driver() really ought to be renamed... Ben. -- Ben Hut

Re: [PATCH 13/17] Tools: hv: Implement the KVP verb - KVP_OP_SET_IP_INFO

2012-07-30 Thread Ben Hutchings
not recognise some parts of the configuration. This would be logged and/or reported back to the hypervisor. (This is separate from the issue of constant configuration lines; for some distributions the script might recognise but ignore them because they have no use on

Re: [PATCH 03/17] Drivers: hv: kvp: Cleanup error handling in KVP

2012-07-25 Thread Ben Hutchings
On Wed, Jul 25, 2012 at 02:10:05PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Ben Hutchings [mailto:b...@decadent.org.uk] > > Sent: Tuesday, July 24, 2012 9:11 PM > > To: KY Srinivasan > > Cc: gre...@linuxfoundation.org; lin

Re: [PATCH v2] staging: gdm72xx: fix reference counting in gdm_wimax_event_init

2012-07-25 Thread Ben Chan
could be disposed even when there is an active device). Thanks, Ben On Tue, Jul 24, 2012 at 9:50 PM, devendra.aaru wrote: > On Tue, Jul 24, 2012 at 8:34 PM, Ben Chan wrote: >> This patch fixes the commit "staging/gdm72xx: cleanup little at >>

Re: [PATCH 13/17] Tools: hv: Implement the KVP verb - KVP_OP_SET_IP_INFO

2012-07-24 Thread Ben Hutchings
} > + > + error = kvp_write_file(file, "HWADDR", NULL, mac_addr); > + if (error) > + goto setval_error; > + > + error = kvp_write_file(file, "ONBOOT", NULL, "yes"); > + if (error) > + goto setval_error; &g

Re: [PATCH 08/17] Tools: hv: Gather subnet information

2012-07-24 Thread Ben Hutchings
ip_buffer->sub_net, > + length, > + &sn_offset); [...] This is barely readable; why don't you indent the arguments by just one extra tab? Ben. -- Ben Hutc

Re: [PATCH 03/17] Drivers: hv: kvp: Cleanup error handling in KVP

2012-07-24 Thread Ben Hutchings
error = *((int *)(&message->kvp_hdr.operation)); [...] What's with the casting (repeated in many other places)? Wouldn't it be better to redefine struct hv_kvp_msg to start with something like: union { struct hv_kvp_hdr request;

Re: [PATCH 11/17] Tools: hv: Gather DNS information

2012-07-24 Thread Ben Hutchings
e only disallowed characters are / and whitespace. Also, the external script will not be useful to anything other than hv_kvp_daemon, so it probably belongs somewhere under /usr/share. Ben. -- Ben Hutchings We get into the habit of living before acq

[PATCH v2] staging: gdm72xx: fix reference counting in gdm_wimax_event_init

2012-07-24 Thread Ben Chan
This patch fixes the commit "staging/gdm72xx: cleanup little at gdm_wimax_event_rcv" (8df858ea76b76dde9a39d4edd9aaded983582cfe), which mishandles the reference counting of wm_event. Signed-off-by: Ben Chan --- Fixed the commit message as suggested by Dan Carpenter. drivers/stagi

[PATCH] staging: gdm72xx: fix reference counting in gdm_wimax_event_init

2012-07-23 Thread Ben Chan
This patch fixes commit 8df858ea76b76dde9a39d4edd9aaded983582cfe, which mishandles the reference counting of wm_event. Signed-off-by: Ben Chan --- drivers/staging/gdm72xx/gdm_wimax.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/staging/gdm72xx

Re: [PATCH 00/13] drivers: hv: kvp

2012-07-21 Thread Ben Hutchings
On Tue, 2012-07-03 at 15:24 +, KY Srinivasan wrote: > > > -Original Message- > > From: Ben Hutchings [mailto:b...@decadent.org.uk] > > Sent: Monday, July 02, 2012 3:57 PM > > To: KY Srinivasan > > Cc: Olaf Hering; Greg KH; a...@canonical.

RE: [PATCH net,1/1] hyperv: Add support for setting MAC from within guests

2012-07-10 Thread Ben Hutchings
On Tue, 2012-07-10 at 17:03 +, Haiyang Zhang wrote: > > > -Original Message- > > From: Ben Hutchings [mailto:bhutchi...@solarflare.com] > > Sent: Friday, July 06, 2012 8:19 PM > > To: Haiyang Zhang > > Cc: da...@davemloft.net; net...@vger.kernel.org;

Re: [PATCH net,1/1] hyperv: Add support for setting MAC from within guests

2012-07-06 Thread Ben Hutchings
_msg.msg.set_complete; > + if (set_complete->status != RNDIS_STATUS_SUCCESS) > + ret = -EINVAL; [...] Is there a specific error code that indicates the hypervisor is configured not to allow MAC address changes? If so, shouldn't that be translated to return EPERM rather than

Re: [PATCH 00/13] drivers: hv: kvp

2012-07-02 Thread Ben Hutchings
ocol information in a distro independent > fashion. > > On the SET side, I need to persistently store the settings in an appropriate > configuration > file and flush these settings down so that the interface is appropriately > configured. It is here > that I am struggling

Re: [PATCH 3.2.y 3.3.y] staging:rts_pstor:Fix possible panic by NULL pointer dereference

2012-06-21 Thread Ben Hutchings
tor in later transfer operation. It is corrupted and > passed to dma_unmap_sg, thus causing fatal unmap of some erroneous address. > Fix it by duplicating *sg_ptr for iterating. [...] Added to the queue for 3.2, thanks. Ben. -- Ben Hutchings Every program is either trivial or els

Re: [PATCH] staging: zsmalloc: Finish conversion to a separate module

2012-06-19 Thread Ben Hutchings
On Tue, 2012-06-19 at 20:46 -0500, Jonathan Nieder wrote: > (+cc: devel@driverdev) > Hi Ben, > > Ben Hutchings wrote: > > > ZSMALLOC is tristate, but the code has no MODULE_LICENSE and since it > > depends on GPL-only symbols it cannot be loaded as a module. This in

[PATCH] staging: gdm72xx: Release netlink socket properly

2012-06-14 Thread Ben Chan
e8 17 e1 ff ff 49 89 c1 48 8b 00 a8 80 75 15 49 f7 01 00 c0 00 00 75 02 <0f> 0b 4c 89 cf e8 b8 b4 fd ff eb 4f 4c 8b 55 08 49 8b 79 30 48 RIP [] kfree+0x67/0xca RSP Signed-off-by: Ben Chan Cc: Sage Ahn --- drivers/staging/gdm72xx/netlink_k.c |2 +- 1 files changed, 1 inse

[PATCH] staging: gdm72xx: Simplify spinlock fix for gdm_usb_send_complete

2012-06-12 Thread Ben Chan
This patch simplifies the previous patch (commit dd13c86b0dae86efdde98119ffd7348e80719ade) for fixing the spinlock recursion issue on several call sites of gdm_usb_send_complete. Signed-off-by: Ben Chan Cc: Sage Ahn --- drivers/staging/gdm72xx/gdm_usb.c | 26 ++ 1

[PATCH v2] staging: gdm72xx: Fix spinlock recursion on gdm_usb_send_complete

2012-06-12 Thread Ben Chan
This patch fixes a spinlock recursion bug on several call sites of gdm_usb_send_complete by not calling spin_lock_irqsave on urb->context->tx_cxt->lock when the lock has already been acquired. Signed-off-by: Ben Chan Cc: Sage Ahn --- This revised patch simplifies the previous patch.

[PATCH] staging: gdm72xx: Fix spinlock recursion on gdm_usb_send_complete

2012-06-06 Thread Ben Chan
This patch fixes a spinlock recursion bug on several call sites of gdm_usb_send_complete by not calling spin_lock_irqsave on urb->context->tx_cxt->lock when the lock has already been acquired. Signed-off-by: Ben Chan Cc: Sage Ahn --- drivers/staging/gdm72xx/gdm_usb

[PATCH] staging: gdm72xx: Set up parent link in sysfs for gdm72xx devices

2012-05-17 Thread Ben Chan
From: Paul Stewart This patch uses SET_NETDEV_DEV to set up a 'device' parent link in sysfs (e.g. /sys/class/net/wm0/device) for a gdm72xx device. Signed-off-by: Paul Stewart Signed-off-by: Ben Chan Cc: Sage Ahn --- drivers/staging/gdm72xx/gdm_sdio.c |2 +- drivers/stagi

Re: [3.2.y] staging: r8712u: Fix regression caused by commit 8c213fa

2012-05-08 Thread Ben Hutchings
> > >> Tested-by: Alberto Lago Ballesteros > >> Tested-by: Adrian > >> Signed-off-by: Larry Finger > >> Signed-off-by: Greg Kroah-Hartman > > > > Accordingly, the fix described above was included in 3.3.4. > > > > a5ee652 was merge

Re: [PATCH 1/1] net/hyperv: Add flow control based on hi/low watermark

2012-03-28 Thread Ben Hutchings
frame control but I don't think that's applicable. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. __

Re: [PATCH 3.0.y 0/4] Re: lirc_serial spuriously claims assigned port and irq to be in use

2012-03-07 Thread Ben Hutchings
On Wed, Mar 07, 2012 at 12:04:07PM -0800, Greg Kroah-Hartman wrote: > On Fri, Mar 02, 2012 at 02:39:13PM -0600, Jonathan Nieder wrote: > > Ben Hutchings wrote: > > > On Thu, 2012-03-01 at 21:45 -0600, Jonathan Nieder wrote: > > > > >> Would some of these patch

Re: [PATCH 1/5] staging: lirc_serial: Fix init/exit order

2012-03-01 Thread Ben Hutchings
rom > kernel.org? Assuming they haven't caused any regressions, I think everything except 9b98d6067971 (4/5) would be appropriate. Ben. -- Ben Hutchings One of the nice things about standards is that there are so many of them. signature.asc Description: This is a digitally signed message

Re: [PATCH linux-firmware 1/2] usbdux: Assume as31 is already installed

2012-02-19 Thread Ben Hutchings
tp://packages.debian.org/squeeze/as31>. And yes, it does have your patch to support the include directive. New releases are coming from <http://wiki.erazor-zone.de/wiki:projects:linux:as31>. Ben. -- Ben Hutchings Every program is either trivial or else contains at least one bug sig

[PATCH linux-firmware 2/2] usbdux: Rebuild firmware in the correct directory

2012-02-18 Thread Ben Hutchings
The source for usbdux firmware is in a subdirectory but the binaries are not. This is weird but not worth changing. Adjust the makefile to rebuild the binaries at the top-level. Signed-off-by: Ben Hutchings --- This is not quite right; the clean rule needs to be updated too. Ben. usbdux

[PATCH linux-firmware 1/2] usbdux: Assume as31 is already installed

2012-02-18 Thread Ben Hutchings
Don't try to build the as31 assembler in a subdirectory. A suitable version may be installed separately; for example it is packaged in Debian. Update the README accordingly. Signed-off-by: Ben Hutchings --- usbdux/Makefile_dux | 18 -- usbdux/README.dux |

[PATCH linux-firmware 0/2] Clean up usbdux makefile

2012-02-18 Thread Ben Hutchings
I've been trying to ensure we have simple working makefiles for building all the free firmware in the linux-firmware repository. These changes would make usbdux more consistent with the others. Ben. Ben Hutchings (2): usbdux: Assume as31 is already installed usbdux: Rebuild firmware i

[PATCH 5/5] staging: lirc_serial: Do not assume error codes returned by request_irq()

2011-11-15 Thread Ben Hutchings
lirc_serial_probe() must fail if request_irq() returns an error, even if it isn't EBUSY or EINVAL, Signed-off-by: Ben Hutchings --- drivers/staging/media/lirc/lirc_serial.c | 21 + 1 files changed, 9 insertions(+), 12 deletions(-) diff --git a/drivers/staging/media

[PATCH 4/5] staging: lirc_serial: Fix bogus error codes

2011-11-15 Thread Ben Hutchings
Device not found? ENODEV, not EINVAL. Write to read-only device? EPERM, not EBADF. Invalid argument? EINVAL, not ENOSYS. Unsupported ioctl? ENOIOCTLCMD, not ENOSYS. Another function returned an error code? Use that, don't replace it. Signed-off-by: Ben Hutchings --- drivers/staging/

[PATCH 3/5] staging: lirc_serial: Fix deadlock on resume failure

2011-11-15 Thread Ben Hutchings
A resume function cannot remove the device it is resuming! Signed-off-by: Ben Hutchings --- I haven't seen any report of this deadlock, but it seems pretty obvious. Ben. drivers/staging/media/lirc/lirc_serial.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --

[PATCH 2/5] staging: lirc_serial: Free resources on failure paths of lirc_serial_probe()

2011-11-15 Thread Ben Hutchings
Failure to allocate the I/O region leaves the IRQ allocated. A later failure leaves them both allocated. Reported-by: Torsten Crass References: http://bugs.debian.org/645811 Signed-off-by: Ben Hutchings --- drivers/staging/media/lirc/lirc_serial.c | 19 --- 1 files changed

[PATCH 1/5] staging: lirc_serial: Fix init/exit order

2011-11-15 Thread Ben Hutchings
tion. The module exit function removes the platform device before the character device that provides access to it. Change it to reverse the order of initialisation. Signed-off-by: Ben Hutchings --- The down-side of this is that module insertion now succeeds even if the device can't be prob

Re: [PATCH] staging iio: Replace kmalloc with local variable

2011-06-07 Thread Ben Dooks
> ret = i2c_master_send(client, tx_buf, 2); > > - kfree(tx_buf); > > > > return (ret > 0) ? 0 : ret; > > } > > -- > To unsubscribe from this list: send the line "unsubscribe linux-i2c" in >

[PATCH 1/1] Staging: tty: epca: fixing return code-style issue

2011-06-04 Thread Aviv Ben-Yosef
Fixed a coding-style issue, ``return'' with parens. Signed-off-by: Aviv Ben-Yosef --- drivers/staging/tty/epca.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/tty/epca.c b/drivers/staging/tty/epca.c index 7f1369e..2a4ba10 100644 --- a/drive

Professional CAD Drafting Services

2011-05-30 Thread Ben
esign AutoCAD Conversion AutoCAD Drawings AutoCAD Engineering Solid Words Design 2D to 3D conversions Architectural renderings Raster to vector conversion Architectural drawings GIS conversion CNC programming Logo vectorization Digitizing maps Legacy drawing conversion Best regards, Ben Benjaminfansice Au

Professional CAD Drafting Services

2011-05-24 Thread Ben
esign AutoCAD Conversion AutoCAD Drawings AutoCAD Engineering Solid Words Design 2D to 3D conversions Architectural renderings Raster to vector conversion Architectural drawings GIS conversion CNC programming Logo vectorization Digitizing maps Legacy drawing conversion Best regards, Ben Benjaminfansice Au

Professional CAD Drafting Services

2011-05-06 Thread Ben
esign AutoCAD Conversion AutoCAD Drawings AutoCAD Engineering Solid Words Design 2D to 3D conversions Architectural renderings Raster to vector conversion Architectural drawings GIS conversion CNC programming Logo vectorization Digitizing maps Legacy drawing conversion Best regards, Ben Benjaminfansice Au

Professional CAD Drafting Services

2011-01-27 Thread Ben
esign AutoCAD Conversion AutoCAD Drawings AutoCAD Engineering 2D to 3D conversions Architectural renderings Raster to vector conversion Architectural drawings GIS conversion Logo vectorization Digitizing maps Legacy drawing conversion Best regards, Ben Benynameas AutoCAD Solutions Contact: ibauto...@yea

Professional CAD Drafting Services

2011-01-24 Thread Ben
esign AutoCAD Conversion AutoCAD Drawings AutoCAD Engineering Solid Words Design 2D to 3D conversions Architectural renderings Raster to vector conversion Architectural drawings GIS conversion CNC programming Logo vectorization Digitizing maps Legacy drawing conversion Best regards, Ben Benjaminfansice Au

Professional CAD Drafting Services

2011-01-16 Thread Ben
esign AutoCAD Conversion AutoCAD Drawings AutoCAD Engineering 2D to 3D conversions Architectural renderings Raster to vector conversion Architectural drawings GIS conversion Logo vectorization Digitizing maps Legacy drawing conversion Best regards, Ben Benynameas AutoCAD Solutions Contact: ibauto...@yea

Professional CAD Drafting Services

2010-12-30 Thread Ben
esign AutoCAD Conversion AutoCAD Drawings AutoCAD Engineering Solid Words Design 2D to 3D conversions Architectural renderings Raster to vector conversion Architectural drawings GIS conversion CNC programming Logo vectorization Digitizing maps Legacy drawing conversion Best regards, Ben Benjaminfansice Au

Re: [PATCH] econet: Move to staging; remove from defconfig

2010-11-28 Thread Ben Hutchings
On Sat, 2010-11-27 at 22:38 -0800, David Miller wrote: > From: Ben Hutchings > Date: Sun, 28 Nov 2010 01:53:35 + > > > On Sat, 2010-11-27 at 17:26 -0800, David Miller wrote: > >> From: Greg KH > >> Date: Sat, 27 Nov 2010 16:21:35 -0800 > >> &g

Re: [PATCH] econet: Move to staging; remove from defconfig

2010-11-27 Thread Ben Hutchings
re of security > > holes in econet he fixed them within a few days. Which is > > much better than I can say for some of the other protocols > > and filesystems in the tree. > > > > Moving this into staging, is therefore not appropriate. > > Agreed. > >

Re: [PATCH] econet: Move to staging; remove from defconfig

2010-11-27 Thread Ben Hutchings
g, is therefore not appropriate. Oh well, it's not enough as if many distributions bothered to build it anyway, and we've learned our lesson now. Whether it's labelled as staging or not, it's dead, Jim. Ben. -- Ben Hutchings Once a job is fouled up, anything done to improv

[PATCH] econet: Move to staging; remove from defconfig

2010-11-27 Thread Ben Hutchings
progressed beyond 'experimental' status. This protocol generally should not be enabled by distributions, since the cost of a security flaw affecting all installed systems presumably outweighs the benefit to the few (if any) legitimate users. Signed-off-by: Ben Hutchings --- As requ

[PATCH 3/3] x25: Move to staging

2010-11-22 Thread Ben Hutchings
progressed beyond 'experimental' status. This protocol generally should not be enabled by distributions, since the cost of a security flaw affecting all installed systems presumably outweighs the benefit to the few (if any) legitimate users. Signed-off-by: Ben Hutchings --- I'm some

[PATCH 2/3] econet: Move to staging

2010-11-22 Thread Ben Hutchings
'experimental' status. This protocol generally should not be enabled by distributions, since the cost of a security flaw affecting all installed systems presumably outweighs the benefit to the few (if any) legitimate users. Signed-off-by: Ben Hutchings --- drivers/staging/Kconfig |

[PATCH 1/3] decnet: Move to staging

2010-11-22 Thread Ben Hutchings
fixes for bugs found by inspection. This protocol generally should not be enabled by distributions, since the cost of a security flaw affecting all installed systems presumably outweighs the benefit to the few (if any) legitimate users. Signed-off-by: Ben Hutchings --- drivers/staging/Kconfig |2

[PATCH 5/5] Staging: ath6kl: Update segment limit checking

2010-11-07 Thread Ben Hutchings
Commit a36274e0184193e393fb82957925c3981a6b0477 ("mmc: Remove distinction between hw and phys segments") changed the segment limit fields of struct mmc_host but did not update this driver. Signed-off-by: Ben Hutchings --- Compile-tested only. This should be 2.6.37 material. Ben.

[PATCH 4/5] Staging: solo6x10: Pass new parameter to videobuf_queue_dma_contig_init()

2010-11-07 Thread Ben Hutchings
Commit 08bff03ed697a583612b62a6ac566bd5bce98012 ("V4L/DVB: videobuf: add ext_lock argument to the queue init functions") added a parameter to this function but did not update this driver. Signed-off-by: Ben Hutchings --- Compile-tested only. This should be 2.6.37 material. Ben.

[PATCH 3/5] Staging: Update parameters for cfg80211 key management operation

2010-11-07 Thread Ben Hutchings
Commit e31b82136d1adc7a599b6e99d3321e5831841f5a ("cfg80211/mac80211: allow per-station GTKs") changed the signatures of these operations but did not update the staging drivers. Signed-off-by: Ben Hutchings --- Compile-tested only. This should be 2.6.37 material. Ben. drive

[PATCH 2/5] Staging: brcmfmac: Fix MAC header lookup on 64-bit architectures

2010-11-07 Thread Ben Hutchings
Fix direct use of sk_buff::mac_header which is an offset rather than a pointer on 64-bit architectures. Signed-off-by: Ben Hutchings --- Compile-tested only. This should be 2.6.37 material. Ben. drivers/staging/brcm80211/brcmfmac/dhd_linux.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH 1/5] Staging: ath6kl: Fix pointer casts on 64-bit architectures

2010-11-07 Thread Ben Hutchings
Remove unnecessary cast of firmware base address to integer before adding an offset. Fix direct use of sk_buff::network_header which is an offset rather than a pointer on 64-bit architectures. Signed-off-by: Ben Hutchings --- Compile-tested only. This should be 2.6.37 material. Ben. drivers

[PATCH] rt2870sta: Add more device IDs from vendor drivers

2010-08-28 Thread Ben Hutchings
Taken from DPO_RT3070_LinuxSTA_V2.3.0.4_20100604.tar.bz2 and 2010_0709_RT2870_Linux_STA_v2.4.0.1.tar.bz2, with duplicates removed. Signed-off-by: Ben Hutchings --- I have no idea whether any of these devices work with the current code, except that 083a:a702 is reported as at least partly working

[PATCH 2/2] Staging: rtl8192u_usb: Add LG device ID 043e:7a01

2010-06-24 Thread Ben Hutchings
Add another device ID as listed in the vendor driver version 0003.0825.2009. Signed-off-by: Ben Hutchings --- drivers/staging/rtl8192u/r8192U_core.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u

[PATCH 1/2] rtl8192s_usb: Remove duplicate device ID

2010-06-24 Thread Ben Hutchings
Signed-off-by: Ben Hutchings --- drivers/staging/rtl8192su/r8192U_core.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/staging/rtl8192su/r8192U_core.c b/drivers/staging/rtl8192su/r8192U_core.c index 15e9579..b69e198 100644 --- a/drivers/staging/rtl8192su

Re: Bug#584945: [PATCH 1/2] Staging: rtl8192s_usb: Fix device ID table

2010-06-23 Thread Ben Hutchings
On Tue, 2010-06-22 at 15:34 -0700, Greg KH wrote: > On Fri, Jun 18, 2010 at 01:00:35AM +0100, Ben Hutchings wrote: > > The rtl8192s_usb driver was claiming a number of device IDs which are > > actually supported by the code in the rtl8192u_usb driver. Remove > > them from

[PATCH 2/2] Staging: rtl8192u_usb: Add LG device ID 043e:7a01

2010-06-17 Thread Ben Hutchings
Add another device ID as listed in the vendor driver version 0003.0825.2009. Signed-off-by: Ben Hutchings --- Again, I don't know whether this device actually works. Ben. drivers/staging/rtl8192u/r8192U_core.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dr

[PATCH 1/2] Staging: rtl8192s_usb: Fix device ID table

2010-06-17 Thread Ben Hutchings
The rtl8192s_usb driver was claiming a number of device IDs which are actually supported by the code in the rtl8192u_usb driver. Remove them from rtl8192s_usb, and add more device IDs as listed in the vendor driver version 0003.0825.2009. Signed-off-by: Ben Hutchings --- I don't know wh

Re: [PATCH] Drivers: Staging: Moved one brace to its proper place.

2010-06-17 Thread Ben Collins
is list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Bluecherry: http://www.bluecherrydvr.com/ SwissDisk :

rtl8192s_usb vs rtl8192u_usb device IDs

2010-06-07 Thread Ben Hutchings
plain the failure Guy reported. I think the device IDs listed in rtl8192u_usb should be removed from rtl8192s_usb. Ben. -- Ben Hutchings Once a job is fouled up, anything done to improve it makes it worse. signature.asc Description: This is a digitally signed message part _

[PATCH 2/2] rtl8192su: Fix procfs code for interfaces not named wlan0

2010-05-24 Thread Ben Hutchings
n try, and always uses "wlan0"! Since the name of a proc_dir_entry is embedded in it, use that when removing it. Add a netdev notifier to catch interface renaming, and remove and re-add the directory at this point. Signed-off-by: Ben Hutchings --- This is compile-tested only. All thi

[PATCH 1/2] rtl8192su: Clean up in case of an error in module initialisation

2010-05-24 Thread Ben Hutchings
Currently various resources may be leaked in case of an error. Signed-off-by: Ben Hutchings --- This is compile-tested only. Ben. drivers/staging/rtl8192su/r8192U_core.c | 43 ++- 1 files changed, 36 insertions(+), 7 deletions(-) diff --git a/drivers/staging