[PATCH v2 2/2] staging: gdm72xx: fix typos in Kconfig

Signed-off-by: Ben Chan Cc: Sage Ahn --- drivers/staging/gdm72xx/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gdm72xx/Kconfig b/drivers/staging/gdm72xx/Kconfig index dd47bd1..dd8a391 100644 --- a/drivers/staging/gdm72xx/Kconfig +++ b/drivers

[PATCH v2 1/2] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC

interface, either USB or MMC, is built as a module. This patch enforces that in the WIMAX_GDM72XX_USB and WIMAX_GDM72XX_SDIO dependency. Reported-by: Alan Stern Signed-off-by: Ben Chan Cc: Sage Ahn --- drivers/staging/gdm72xx/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

Re: [PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC

No worries. I've attached a revised patch to the original email thread, which includes Alan. Thanks again, Ben ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Re: [PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC

Nope... I didn't resend the patch but replied to the thread. Ben On Mon, Jun 3, 2013 at 11:18 AM, Ben Chan wrote: > Sorry, I meant to send the revised patch but got the wrong file. > > I'll add the Reported-by field. > > Thanks, > Ben > __

[PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC

The gdm72xx driver needs to have either the USB or SDIO implementation enabled to provide useful functionalities, so the driver should depend on either USB or MMC. Signed-off-by: Ben Chan Cc: Sage Ahn --- drivers/staging/gdm72xx/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC

Sorry, I meant to send the revised patch but got the wrong file. I'll add the Reported-by field. Thanks, Ben On Mon, Jun 3, 2013 at 10:48 AM, Greg Kroah-Hartman wrote: > On Mon, Jun 03, 2013 at 10:23:45AM -0700, Ben Chan wrote: >> The gdm72xx driver needs to have either t

[PATCH] staging: gdm72xx: fix unused variable warning in gdm_usb_send

This patch fixes an unused variable warning in gdm_usb_send (when CONFIG_WIMAX_GDM72XX_K_MODE=n), which was introduced in commit 1a276b80466bbd195cf94ec7178f68f2ab351467 (staging: gdm72xx: protect access of rx / tx structs). Signed-off-by: Ben Chan --- drivers/staging/gdm72xx/gdm_usb.c |5

[PATCH] staging: gdm72xx: protect access of rx / tx structs

om [<8004a43c>] (kthread+0x9c/0xa8) <5>[ 4996.815270] [<8004a43c>] (kthread+0x9c/0xa8) from [<8000f160>] (kernel_thread_exit+0x0/0x8) <0>[ 4996.815295] Code: e92d4000 e8bd4000 e2800020 eb4ab9a1 (e5905000) Signed-off-by: Ben Chan Signed-off-by: Sameer Nanda --- drivers/stag

Re: [PATCH] drivers/staging/gdm72xx/gdm_sdio.c: Replace kmalloc+memset for kzalloc

FYI, a similar patch has already been applied: "staging: gdm72xx: simplify alloc_tx_struct and alloc_rx_struct (commit 129575f2a8958a1e90780b0d5b80702bb45b5aac)" Thanks, Ben On Mon, Sep 17, 2012 at 6:45 AM, Peter Senna Tschudin wrote: > Replace kmalloc+memset for kzalloc and cleanup related code

Re: [PATCH v2 3/3] staging/gdm72xx: usb_boot: replace firmware upgrade API in em_download

c: Paul Stewart > Cc: Ben Chan > Cc: Sage Ahn > Cc: Greg Kroah-Hartman > Cc: Dan Carpenter > --- > Changes for v2: > - Correction the procedure in em_download_image() and usb_emergency() > - keep "goto out" in em_download_image because release_firmware is

[PATCH] staging: gdm72xx: simplify alloc_tx_struct and alloc_rx_struct

This patch simplifies alloc_tx_struct and alloc_rx_struct in gdm_sdio.c and gdm_usb.c by replacing kmalloc+memset with kzalloc and reorganizing the code. Signed-off-by: Ben Chan --- drivers/staging/gdm72xx/gdm_sdio.c | 30 drivers/staging/gdm72xx/gdm_usb.c | 44

Re: [PATCH v2] staging: gdm72xx: fix reference counting in gdm_wimax_event_init

Hi Dan, I manually walked through the driver code and spotted the issue. But this morning I was able to get an extra module to verify my patch on hardware. I tested the following patterns using two identical modules, and checked the creation/destruction/ref_cnt of wm_event: - insert module A, rem

Re: [PATCH v2] staging: gdm72xx: fix reference counting in gdm_wimax_event_init

Hi, Does patch v2 make sense? Thanks, Ben On Wed, Jul 25, 2012 at 6:53 AM, Ben Chan wrote: > Hi Devendra, > > Thanks for cleaning up the driver. If I understand the code > correctly, the original author wanted to initialize wm_event once and > reuse it for multiple devices, and

Re: [PATCH v2] staging: gdm72xx: fix reference counting in gdm_wimax_event_init

could be disposed even when there is an active device). Thanks, Ben On Tue, Jul 24, 2012 at 9:50 PM, devendra.aaru wrote: > On Tue, Jul 24, 2012 at 8:34 PM, Ben Chan wrote: >> This patch fixes the commit "staging/gdm72xx: cleanup little at >>

[PATCH v2] staging: gdm72xx: fix reference counting in gdm_wimax_event_init

This patch fixes the commit "staging/gdm72xx: cleanup little at gdm_wimax_event_rcv" (8df858ea76b76dde9a39d4edd9aaded983582cfe), which mishandles the reference counting of wm_event. Signed-off-by: Ben Chan --- Fixed the commit message as suggested by Dan Carpenter. drivers/stagi

[PATCH] staging: gdm72xx: fix reference counting in gdm_wimax_event_init

This patch fixes commit 8df858ea76b76dde9a39d4edd9aaded983582cfe, which mishandles the reference counting of wm_event. Signed-off-by: Ben Chan --- drivers/staging/gdm72xx/gdm_wimax.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/staging/gdm72xx

[PATCH] staging: gdm72xx: Release netlink socket properly

e8 17 e1 ff ff 49 89 c1 48 8b 00 a8 80 75 15 49 f7 01 00 c0 00 00 75 02 <0f> 0b 4c 89 cf e8 b8 b4 fd ff eb 4f 4c 8b 55 08 49 8b 79 30 48 RIP [] kfree+0x67/0xca RSP Signed-off-by: Ben Chan Cc: Sage Ahn --- drivers/staging/gdm72xx/netlink_k.c |2 +- 1 files changed, 1 inse

[PATCH] staging: gdm72xx: Simplify spinlock fix for gdm_usb_send_complete

This patch simplifies the previous patch (commit dd13c86b0dae86efdde98119ffd7348e80719ade) for fixing the spinlock recursion issue on several call sites of gdm_usb_send_complete. Signed-off-by: Ben Chan Cc: Sage Ahn --- drivers/staging/gdm72xx/gdm_usb.c | 26 ++ 1

[PATCH v2] staging: gdm72xx: Fix spinlock recursion on gdm_usb_send_complete

This patch fixes a spinlock recursion bug on several call sites of gdm_usb_send_complete by not calling spin_lock_irqsave on urb->context->tx_cxt->lock when the lock has already been acquired. Signed-off-by: Ben Chan Cc: Sage Ahn --- This revised patch simplifies the previous patch.

[PATCH] staging: gdm72xx: Fix spinlock recursion on gdm_usb_send_complete

This patch fixes a spinlock recursion bug on several call sites of gdm_usb_send_complete by not calling spin_lock_irqsave on urb->context->tx_cxt->lock when the lock has already been acquired. Signed-off-by: Ben Chan Cc: Sage Ahn --- drivers/staging/gdm72xx/gdm_usb

[PATCH] staging: gdm72xx: Set up parent link in sysfs for gdm72xx devices

From: Paul Stewart This patch uses SET_NETDEV_DEV to set up a 'device' parent link in sysfs (e.g. /sys/class/net/wm0/device) for a gdm72xx device. Signed-off-by: Paul Stewart Signed-off-by: Ben Chan Cc: Sage Ahn --- drivers/staging/gdm72xx/gdm_sdio.c |2 +- drivers/stagi