[PATCH 5/6] staging: octeon-usb: check return value of platform_device_register_simple

the return value is a pointer having an error set. we have to check for IS_ERR and return PTR_ERR when appropriate Cc: Aaro Koskinen Cc: David Daney Signed-off-by: Devendra Naga --- drivers/staging/octeon-usb/octeon-hcd.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH 3/6] staging: octeon-usb: more checkpatch fixes

place the opening brace right after the if,else, else if,switch statements. Cc: Aaro Koskinen Cc: David Daney Signed-off-by: Devendra Naga --- drivers/staging/octeon-usb/cvmx-usb.c | 87 --- 1 file changed, 29 insertions(+), 58 deletions(-) diff --git a

[PATCH 2/6] staging: octeon-usb: fix checkpatch error

this places the opening braces just after the if, else, elseif, switch statements Cc: Aaro Koskinen Cc: David Daney Signed-off-by: Devendra Naga --- drivers/staging/octeon-usb/cvmx-usb.c | 234 -- 1 file changed, 78 insertions(+), 156 deletions(-) diff --git a

[PATCH 4/6] staging: octeon-usb: fix more checkpatch errors/warns

place the opening brace right after the if, else, else if, switch statements. Cc: Aaro Koskinen Cc: David Daney Signed-off-by: Devendra Naga --- drivers/staging/octeon-usb/octeon-hcd.c | 122 +++- 1 file changed, 40 insertions(+), 82 deletions(-) diff --git a

[PATCH 6/6] staging: octeon-usb: call device_unregister when platform_device_register_simple fails

device_register is called before platform_device_register_simple gets called. unregister and reset the octeon_usb_registered variable Cc: Aaro Koskinen Cc: David Daney Signed-off-by: Devendra Naga --- drivers/staging/octeon-usb/octeon-hcd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH 1/6] staging: octeon-usb: place opening braces of structs, enums on top

: Aaro Koskinen Cc: David Daney Signed-off-by: Devendra Naga --- drivers/staging/octeon-usb/cvmx-usb.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/drivers/staging/octeon-usb/cvmx-usb.c b/drivers/staging/octeon-usb/cvmx-usb.c index 08ee4ab..04a9ba3

[PATCH 5/5] staging: netlogic: free up irq and unregister mdio bus if xlr_mii_probe fail

the irq pointer and mdio bus should be freed/unregistered in error path, as they are previously allocated/have reference to other subsystems Cc: Ganesan Ramalingam Cc: Jayachandran Chandrashekaran Nair Signed-off-by: Devendra Naga --- drivers/staging/netlogic/xlr_net.c | 2 ++ 1 file changed

[PATCH 2/5] staging: netlogic: free_netdev while devm_request_ioremap fail

in probe if devm_request_ioremap fail, we are not freeing the netdev which is allocated at the beginning. Cc: Ganesan Ramalingam Cc: Jayachandran Chandrashekaran Nair Signed-off-by: Devendra Naga --- drivers/staging/netlogic/xlr_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[PATCH 4/5] staging: netlogic: free up the irq pointer if mdio_register fail

mdio register can fail, and unregisters the mdio bus, but forgets freeing up the irq variable which is allocated before Cc: Ganesan Ramalingam Cc: Jayachandran Chandrashekaran Nair Signed-off-by: Devendra Naga --- drivers/staging/netlogic/xlr_net.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 3/5] staging: netlogic: fix a null dereference if kmalloc fail

no checks are performed on the return from kmalloc, should check for valid pointer Cc: Ganesan Ramalingam Cc: Jayachandran Chandrashekaran Nair Signed-off-by: Devendra Naga --- drivers/staging/netlogic/xlr_net.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging

[PATCH 1/5] staging: netlogic: fix spelling mistake

s/standred/standard Cc: Ganesan Ramalingam Cc: Jayachandran Chandrashekaran Nair Signed-off-by: Devendra Naga --- drivers/staging/netlogic/TODO | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/netlogic/TODO b/drivers/staging/netlogic/TODO index 08e6d52

[PATCH] staging: btmtk_usb: use GFP_KERNEL inplace of GFP_ATOMIC in _probe path

the _probe function doesn't run in interrupt context, so no need to use the GFP_ATOMIC allocations, instead driver can request for GFP_KERNEL Signed-off-by: Devendra Naga --- drivers/staging/btmtk_usb/btmtk_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

[PATCH] staging: btmtk_usb: cancel work when disconnect called

when disconnect calls (driver unloads) the work that is scheduled is still be present in kernel global workqueue, calling cancel_ work_sync makes it remove from the global workqueue. Signed-off-by: Devendra Naga --- drivers/staging/btmtk_usb/btmtk_usb.c | 1 + 1 file changed, 1 insertion

[PATCH] staging: btmtk_usb: check for a valid io_buf pointer

assigned to retval of kmalloc but not checked whether the allocation failed or not, fail the registering if allocation fail Signed-off-by: Devendra Naga --- Hello, Seems that kmalloc is called with GFP_ATOMIC flag which is in registering stage, as since there wont be any interrupt context in

[PATCH V2] staging: ced1401: kfree the pdx at err path and remove callback

leak introduced since pdx is not freed, free it at err path and at remove callback Signed-off-by: Devendra Naga --- V2: replace pdf with pdx drivers/staging/ced1401/usb1401.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/ced1401/usb1401.c b/drivers/staging/ced1401

[PATCH] staging: ced1401: kfree the pdx at err path and remove callback

leak introduced since pdx is not freed, free it at err path and at remove callback Signed-off-by: Devendra Naga --- drivers/staging/ced1401/usb1401.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/ced1401/usb1401.c b/drivers/staging/ced1401/usb1401.c index 254131d

[PATCH] staging: gdm72xx: cancel work when driver unloads

cancel the work function at driver unload stage and remove the function from the queue Cc: Ben Chan Signed-off-by: Devendra Naga --- drivers/staging/gdm72xx/gdm_sdio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/gdm72xx/gdm_sdio.c b/drivers/staging/gdm72xx/gdm_sdio.c

[PATCH] et131x: cancel_work when module gets unloaded

the work item has been added to the queue using INIT_WORK and scheduled in interrupt handler. when module unloads that work item has not been removed from the queue. remove and stop its further execution when the module unloaded cc: Mark Einon Signed-off-by: Devendra Naga --- drivers/staging

[PATCH 4/6] vt6655: remove return statement in BSSvClearBSSList

remove the return statement at the end of the BSSvClearBSSList as it returns nothing Signed-off-by: Devendra Naga --- drivers/staging/vt6655/bssdb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/vt6655/bssdb.c b/drivers/staging/vt6655/bssdb.c index fe57fb8..da9d69a 100644

[PATCH 5/6] vt6655: remove return statement at the end of functions in bssdb.c

remove the return statement at the end of function which are returning nothing (void). Signed-off-by: Devendra Naga --- drivers/staging/vt6655/bssdb.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/vt6655/bssdb.c b/drivers/staging/vt6655/bssdb.c index da9d69a

[PATCH 6/6] vt6655: remove return statements at the end of functions in power.c

remove return at the end of all void functions Signed-off-by: Devendra Naga --- drivers/staging/vt6655/power.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/vt6655/power.c b/drivers/staging/vt6655/power.c index 661d534..e118b63 100644 --- a/drivers/staging/vt6655

[PATCH 3/6] vt6655: follow kernel coding style rules in SROMbyReadEmbedded function

tab spacing 8 and tabs instead of spacing, no code change is made just the style changes Signed-off-by: Devendra Naga --- drivers/staging/vt6655/srom.c | 60 +-- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/drivers/staging/vt6655/srom.c

[PATCH 2/6] vt6655: fix compiler warnings in iwctl_siwrts

drivers/staging/vt6655/iwctl.c: In function ‘iwctl_siwrts’: drivers/staging/vt6655/iwctl.c:1101:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable] fix it by returning rc Signed-off-by: Devendra Naga --- drivers/staging/vt6655/iwctl.c | 2 +- 1 file changed, 1 insertion

[PATCH 1/6] vt6655: remove unnecessary return at the end of the function

this function returns nothing, i.e. void type, and has a return statement at the end of the function, remove it Signed-off-by: Devendra Naga --- drivers/staging/vt6655/datarate.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/vt6655/datarate.c b/drivers/staging/vt6655

[PATCH 2/2] staging: tidspbridge: rmgr: proc.c: fix checkpatch errors

space prohibited after that '*' (ctx:ExW) + * hnotification) ^ ERROR: "foo * bar" should be "foo *bar" +int proc_get_processor_id(void *proc, u32 * proc_id) Signed-off-by: Devendra Naga --- drivers/staging/tidspbr

[PATCH 1/2] staging:tidspbridge: rmgr: fix checkpatch errors

space prohibited after that '*' (ctx:ExW) + * hnotification) ^ Signed-off-by: Devendra Naga --- drivers/staging/tidspbridge/rmgr/strm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/

[PATCH] staging: olpc_dcon: return NOTIFY_DONE instead of the 0.

return a valid macro instead of 0 (as #define NOTIFY_DONE 0) in the reboot callback Signed-off-by: Devendra Naga --- drivers/staging/olpc_dcon/olpc_dcon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon

[PATCH] staging: csr: fix compilation warning in unifi_siwscan

got the warnings drivers/staging/csr/sme_wext.c: In function ‘unifi_siwscan’: drivers/staging/csr/sme_wext.c:1276:9: warning: variable ‘scantype’ set but not used [-Wunused-but-set-variable] fixed by removing the variable Signed-off-by: Devendra Naga --- drivers/staging/csr/sme_wext.c | 3

[PATCH staging] staging: et131x: fix invalid fail after the call to eeprom_wait_ready

should be err < 0 instead of if (err) which actually the read register value can be a positive number Acked-by: Mark Einon Signed-off-by: Devendra Naga --- Hello Greg, This applies to staging-linus branch of yours. Thanks, drivers/staging/et131x/et131x.c | 4 ++-- 1 file changed

[PATCH] staging: et131x: fix invalid fail after the call to eeprom_wait_ready

should be err < 0 instead of if (err) which actually the read register value can be a positive number Signed-off-by: Devendra Naga --- drivers/staging/et131x/et131x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et1

[PATCH] staging: sep: remove assignment to i and j in sep_crypto_setup

the i and j are used in for loop and they assigned to zeros in the for loop, so no need to assign them to zeros again. Signed-off-by: Devendra Naga --- drivers/staging/sep/sep_crypto.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/sep/sep_crypto.c b/drivers/staging

[PATCH] staging: dgrp: check for a valid proc dir entry pointer

while proc_create fails, the register_proc_table can do a derefernce of the null pointer causing to oops the system, instead check for a valid pointer at register and unregister Signed-off-by: Devendra Naga --- drivers/staging/dgrp/dgrp_specproc.c |4 +++- 1 file changed, 3 insertions(+), 1

[PATCH 3/4] staging: vt6655: s/kmalloc + memset / kzalloc

replace kmalloc and subsequent memset with kzalloc and drop the null checks and casts and clean the coding style a bit too Signed-off-by: Devendra Naga --- drivers/staging/vt6655/device.h | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/staging/vt6655

[PATCH 4/4] staging: vt6655: no braces needed for single statement if , for blocks

there is only one line inside the if and for blocks, so the braces are not needed Signed-off-by: Devendra Naga --- drivers/staging/vt6655/channel.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vt6655/channel.c b/drivers/staging/vt6655

[PATCH 2/4] staging: vt6655: checkpatch fixes

put opening brace in a new line 4 ---> 8 spaces Signed-off-by: Devendra Naga --- drivers/staging/vt6655/device.h |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h index 1a077f9..64d923c 100644 --

[PATCH 1/4] staging: vt6655: s/kmalloc + memset/kzalloc in alloc_rd_info

replace kmalloc and memset if the pointer is valid with kzalloc, and remove the check around the null pointer cases as we dont need it. Signed-off-by: Devendra Naga --- drivers/staging/vt6655/device.h |9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/staging

[PATCH 2/2] staging: ft1000: remove assigments of ret and initialise it in beginning

as ret is every time assigned to EINVAL in fail cases, initialise it at the beginning. Signed-off-by: Devendra Naga --- drivers/staging/ft1000/ft1000-usb/ft1000_proc.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_proc.c b

[PATCH 1/2] staging: ft1000: replace some spaces with tabs

there are spaces at the starting of the line, replace with tabs Signed-off-by: Devendra Naga --- drivers/staging/ft1000/ft1000-usb/ft1000_proc.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_proc.c b/drivers

[PATCH 9/9] staging: csr: csr_wifi_nme_task.h: remove function prototypes

there are function definitions missing for these prototypes, so remove all 3 function protos. Signed-off-by: Devendra Naga --- drivers/staging/csr/csr_wifi_nme_task.h |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/csr/csr_wifi_nme_task.h b/drivers/staging/csr

[PATCH 8/9] staging: csr: csr_wifi_nme_ap_lib.h: remove the function prototypes

these function prototypes are missing the function definition, remove them all. Signed-off-by: Devendra Naga --- drivers/staging/csr/csr_wifi_nme_ap_lib.h | 18 -- 1 file changed, 18 deletions(-) diff --git a/drivers/staging/csr/csr_wifi_nme_ap_lib.h b/drivers/staging/csr

[PATCH 7/9] staging: csr: csr_wifi_nme_lib.h: remove function prototypes

the function definitions are missing for these prototypes, so remove all these. Signed-off-by: Devendra Naga --- drivers/staging/csr/csr_wifi_nme_lib.h | 54 1 file changed, 54 deletions(-) diff --git a/drivers/staging/csr/csr_wifi_nme_lib.h b/drivers

[PATCH 6/9] staging: csr: sme_blocking.c: add missing check for return of sme_wait_for_reply

sme_ap_config misses a check of the return of the sme_wait_for_reply as all other functions do here, for the return of sme_wait_for_reply add the check and fail if it returns other than 0. Signed-off-by: Devendra Naga --- drivers/staging/csr/sme_blocking.c |2 ++ 1 file changed, 2

[PATCH 5/9] staging: csr: sme_blocking.c: remove braces around single statement blocks

remove the braces around single statement if blocks Signed-off-by: Devendra Naga --- drivers/staging/csr/sme_blocking.c | 219 1 file changed, 74 insertions(+), 145 deletions(-) diff --git a/drivers/staging/csr/sme_blocking.c b/drivers/staging/csr

[PATCH 4/9] staging: csr: sme_blocking.c: replace spaces with the tabs in sme_mgt_tspec

replace spaces at start of line with tabs in sme_mgt_tspec Signed-off-by: Devendra Naga --- drivers/staging/csr/sme_blocking.c | 38 ++-- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/staging/csr/sme_blocking.c b/drivers/staging/csr

[PATCH 3/9] staging: csr: sme_blocking.c: replace spaces with tabs

replace spaces at the beginning of the line with tabs in sme_mgt_packet_filter_set Signed-off-by: Devendra Naga --- drivers/staging/csr/sme_blocking.c | 48 ++-- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/drivers/staging/csr/sme_blocking.c

[PATCH 2/9] staging: csr: inet.c: replaces spaces with tabs

replace spaces with tabs at the start of line Signed-off-by: Devendra Naga --- drivers/staging/csr/inet.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/csr/inet.c b/drivers/staging/csr/inet.c index 8506206..b3ef818 100644 --- a/drivers/staging

[PATCH 1/9] staging: csr: inet.c: single statement if blocks doesn't need braces

remove braces to single statement if blocks Signed-off-by: Devendra Naga --- drivers/staging/csr/inet.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/csr/inet.c b/drivers/staging/csr/inet.c index b4acb54..8506206 100644 --- a/drivers/staging/csr

[PATCH 7/7] staging: csr: remove a bunch of function protos

all protos that are removed does not have a function definition so remove all of them together Signed-off-by: Devendra Naga --- drivers/staging/csr/csr_log_configure.h | 87 --- 1 file changed, 87 deletions(-) diff --git a/drivers/staging/csr/csr_log_configure.h

[PATCH 6/7] staging: csr: remove csr_lib.h

remove this header file as no struct or no function is defined else where in csr. Signed-off-by: Devendra Naga --- drivers/staging/csr/csr_lib.h | 180 .../staging/csr/csr_serialize_primitive_types.c|1 - 2 files changed, 181 deletions

[PATCH 5/7] staging: csr: remove braces around single statement blocks

remove all braces around single statement if blocks Signed-off-by: Devendra Naga --- drivers/staging/csr/os.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/staging/csr/os.c b/drivers/staging/csr/os.c index 0d9842a..37ec59d 100644 --- a/drivers

[PATCH 3/7] staging: csr: replace spaces with tabs in uf_destroy_device_nodes

replace spaces at the start of line with tabs Signed-off-by: Devendra Naga --- drivers/staging/csr/drv.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/csr/drv.c b/drivers/staging/csr/drv.c index 52344d5..4780c32 100644 --- a/drivers/staging/csr

[PATCH 4/7] staging: csr: remove col variable

theres no point in checking the col variable, its always zero, and wont print a new line, actually its better to have a new line after a set of characters printed, instead of confusing with the concatenated characters when called multiple times at a time. Signed-off-by: Devendra Naga

[PATCH 2/7] staging: csr: replace spaces with tabs in drv c file

replace spaces at the start of the line with tabs Signed-off-by: Devendra Naga --- drivers/staging/csr/drv.c | 53 ++--- 1 file changed, 26 insertions(+), 27 deletions(-) diff --git a/drivers/staging/csr/drv.c b/drivers/staging/csr/drv.c index e92c8d2

[PATCH 1/7] staging: csr: replace spaces with tabs

replace the spaces with the tabs at the start of line Signed-off-by: Devendra Naga --- drivers/staging/csr/io.c | 86 +++--- 1 file changed, 43 insertions(+), 43 deletions(-) diff --git a/drivers/staging/csr/io.c b/drivers/staging/csr/io.c index

[PATCH] staging: sep: return -EFAULT on copy_from_user failure

copy_from_user() returns the number of bytes remaining to be copied, and it fails if user pointer is invalid, so return -EFAULT so that the user gets a FAULT. Signed-off-by: Devendra Naga --- drivers/staging/sep/sep_main.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 3/3] staging: csr: remove func_exit_r macro

this macro is used for debugging purposes, it actually defined as if (unifi_debug >= 5) { printk("unifi: <= %s %d\n", __FUNCTION__, (int)rc); } which produces too many of those prints if the unifi_debug is >=5. remove these calls and the macro itself altogether Sign

[PATCH 2/3] staging: csr: remove func_exit macro

this macro is used for debugging purposes, it actually defined as if (unifi_debug >= 5) { printk("unifi: <= %s\n", __FUNCTION__); } which produces too many of those prints if the unifi_debug is >=5. remove these calls and the macro itself altogether Signed-of

[PATCH 1/3] staging: csr: remove func_enter macro

this macro is used for debugging purposes, it actually defined as if (unifi_debug >= 5) { printk("unifi => %s\n", __FUNCTION__); } which produces too many of those prints if the unifi_debug is >=5. remove these calls and the macro itself altogether Signed-of

[PATCH 0/3] remove func_(enter/exit/exit_r) macros

9f drivers/staging/csr/built-in.o after the 3 patches: size drivers/staging/csr/built-in.o textdata bss dec hex filename 466357 17016 185528 668901 a34e5 drivers/staging/csr/built-in.o thanks, Devendra Naga (3): staging: csr: remove func_enter macro staging: c

[PATCH 2/2] staging: csr: remove unused macros and prototypes

this file includes prototypes that doesnt have a function for them, and some macros which are never used, remove them instead Signed-off-by: Devendra Naga --- drivers/staging/csr/csr_wifi_vif_utils.h | 73 -- 1 file changed, 73 deletions(-) diff --git a/drivers

[PATCH 1/2] staging: csr: remove unused macros/ prototypes in csr_sched.h

there are macros and functions that are not used, or their function is missing, so remove them. Signed-off-by: Devendra Naga --- drivers/staging/csr/csr_sched.h | 114 --- 1 file changed, 114 deletions(-) diff --git a/drivers/staging/csr/csr_sched.h b

[PATCH] staging: csr: remove csrPanic and CSR_LOG_ASSERT and CSR_LOG_ASSERT_ENABLE

these are not called at anypoint or enabled at anyplace in the code, remove them Signed-off-by: Devendra Naga --- drivers/staging/csr/Makefile |3 +- drivers/staging/csr/csr_framework_ext.c |1 - drivers/staging/csr/csr_log.h| 13 drivers/staging/csr

[PATCH 5/5] staging: csr: remove all prototypes of not defined functions

these prototypes doesn't have function definitions in any of the c files Signed-off-by: Devendra Naga --- drivers/staging/csr/csr_framework_ext.h | 82 --- 1 file changed, 82 deletions(-) diff --git a/drivers/staging/csr/csr_framework_ext.h b/drivers/stagin

[PATCH 4/5] staging: csr: remove CsrMutexCreate function

nobody are calling this function in here, so remove this Signed-off-by: Devendra Naga --- drivers/staging/csr/csr_framework_ext.c | 26 -- drivers/staging/csr/csr_framework_ext.h | 16 2 files changed, 42 deletions(-) diff --git a/drivers/staging

[PATCH 3/5] staging: csr: remove CsrMutexDestroy function

this function never gets called from anywhere, so remove this too. Signed-off-by: Devendra Naga --- drivers/staging/csr/csr_framework_ext.c | 15 --- drivers/staging/csr/csr_framework_ext.h | 13 - 2 files changed, 28 deletions(-) diff --git a/drivers/staging/csr

[PATCH 2/5] staging: csr: remove CsrMutexUnlock function

Nobody is using this function inside the csr directory, so remove this function also Signed-off-by: Devendra Naga --- drivers/staging/csr/csr_framework_ext.c | 25 - drivers/staging/csr/csr_framework_ext.h | 30 -- 2 files changed, 55

[PATCH 1/5] staging: csr: remove CsrMutexLock function

nobody inside the csr directory is calling this function, so remove this Signed-off-by: Devendra Naga --- drivers/staging/csr/csr_framework_ext.c | 28 drivers/staging/csr/csr_framework_ext.h | 15 --- 2 files changed, 43 deletions(-) diff --git a

[PATCH] staging: slicoss: fix a leak when kzalloc fail

slic_card_locate does a kzalloc of physcard, and if it fails, in my previous patch i returned -ENOMEM, but left the driver leak the memory if card_hostid == SLIC_HOSTID_DEFAULT, fix this memory leak if the above condition is true Signed-off-by: Devendra Naga --- drivers/staging/slicoss

[PATCH] staging: csr: remove panic at locking the mutex

when down_interruptible fail, means a signal occur, or any other failure we are panicing, and it seems that we should not panic, instead we would have done a spinlock, but currently removing the panic call. Signed-off-by: Devendra Naga --- drivers/staging/csr/csr_framework_ext.c |1 - 1

[PATCH 2/2] staging: csr: remove the function prototypes

remove some of the function prototypes , they dont have a definition of the function Signed-off-by: Devendra Naga --- drivers/staging/csr/csr_sched.h | 85 --- 1 file changed, 85 deletions(-) diff --git a/drivers/staging/csr/csr_sched.h b/drivers/staging

[PATCH 1/2] staging: csr: remove the CsrTime typedef altogether

remove CsrTime typedef and replace all the users with the u32 Signed-off-by: Devendra Naga --- drivers/staging/csr/csr_log.h |2 +- drivers/staging/csr/csr_sched.h| 12 ++-- drivers/staging/csr/csr_time.c |8 drivers/staging/csr

[PATCH 2/2] staging: csr: remove some prototypes of functions

remove some of the function prototypes , they dont have a definition of the function Signed-off-by: Devendra Naga --- drivers/staging/csr/csr_sched.h | 85 --- 1 file changed, 85 deletions(-) diff --git a/drivers/staging/csr/csr_sched.h b/drivers/staging

[PATCH 1/2] staging: csr: remove the CsrTime typedef

remove CsrTime typedef and replace all the users with the u32 Signed-off-by: Devendra Naga --- drivers/staging/csr/csr_log.h |2 +- drivers/staging/csr/csr_sched.h| 12 ++-- drivers/staging/csr/csr_time.c |8 drivers/staging/csr

[PATCH 1/2] staging: csr: remove the CsrTime typedef

remove CsrTime typedef and replace all the users with the u32 Signed-off-by: Devendra Naga --- drivers/staging/csr/csr_log.h |2 +- drivers/staging/csr/csr_sched.h| 12 ++-- drivers/staging/csr/csr_time.c |8 drivers/staging/csr

[RFC 3/3] staging: csr: remove some prototypes of functions

remove some of the function prototypes , they dont have a definition of the function Signed-off-by: Devendra Naga --- drivers/staging/csr/csr_sched.h | 85 --- 1 file changed, 85 deletions(-) diff --git a/drivers/staging/csr/csr_sched.h b/drivers/staging

[RFC 1/3] staging: csr: remove the typedef of CsrTime

Signed-off-by: Devendra Naga --- drivers/staging/csr/csr_log.h |2 +- drivers/staging/csr/csr_sched.h| 12 ++-- drivers/staging/csr/csr_time.c |8 drivers/staging/csr/csr_time.h | 15 +-- drivers/staging

[RFC 2/3] staging: csr: remove csr_util.c

there is no code present except the module info, and header inclusions remove this unneeded file Signed-off-by: Devendra Naga --- drivers/staging/csr/Makefile |1 - drivers/staging/csr/csr_util.c | 15 --- 2 files changed, 16 deletions(-) delete mode 100644 drivers/staging

[RFC 0/3] csr cleanup

These are the patches that remove the typedefs all over the csr tree. there is one .c that is not needed and has no code. and also there are some more function prototypes that are defined in the header but there is no function definition for those prototypes. Devendra Naga (3): staging: csr

[PATCH 3/3] staging: slicoss: get rid of slic_cmdqmem_init function

this function memset's the cmdqmem, instead do it in slic_cmdq_init. Signed-off-by: Devendra Naga --- drivers/staging/slicoss/slicoss.c |9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c

[PATCH 2/3] staging: slicoss: remove default case in irqhandler

this default statement does nothing in the irqhandler, so remove it Signed-off-by: Devendra Naga --- drivers/staging/slicoss/slicoss.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index f6af3fe..86c8c8e 100644

[PATCH 1/3] staging: slicoss: return -ENOMEM if kzalloc fail

this takes up the error path cleanup, fixes a crash too due to null deref Signed-off-by: Devendra Naga --- drivers/staging/slicoss/slicoss.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index 9454280..f6af3fe

[PATCH 2/2] staging: slicoss: remove ASSERT macro altogether

remove ASSERT and remove all its callers altogether in the code Signed-off-by: Devendra Naga --- drivers/staging/slicoss/slicoss.c | 140 + 1 file changed, 2 insertions(+), 138 deletions(-) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging

[PATCH 1/2] staging: slicoss: fail out if we dont have a valid firmware file

fail instead calling request_firmware with filename as a null string and return -ENOENT Signed-off-by: Devendra Naga --- drivers/staging/slicoss/slicoss.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss

[PATCH V3] staging: ced1401: fix a frame size warning

gcc/sparse complain about the following: drivers/staging/ced1401/ced_ioc.c:931:1: warning: the frame size of 4144 bytes is larger than 2048 bytes [-Wframe-larger-than=] Fix it by dynamically allocating it. Signed-off-by: Devendra Naga --- V3: fix a memory leak pointed by Dan Carpenter V2

[PATCH V2 4/4] staging: ced1401: remove kernel version ifdef 's

We dont need these kernel versioning checks anyways. Signed-off-by: Devendra Naga --- drivers/staging/ced1401/usb1401.c | 24 1 file changed, 24 deletions(-) diff --git a/drivers/staging/ced1401/usb1401.c b/drivers/staging/ced1401/usb1401.c index 226b893..88e2cc0

[PATCH V2 3/4] staging: ced1401: fix some style warnings

this fixes: comments to in kernel comment style the opening brace of if statement must be beside the if not below to it Signed-off-by: Devendra Naga --- drivers/staging/ced1401/usb1401.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/ced1401/usb1401.c

[PATCH V2 2/4] staging: ced1401: remove an obvious commit about the minor number

in disconnect we assign the device minor number from the interface pointer to the localvarible minor, and then print it at the end, this code seems self explanatory so remove the comment of assigning the minor number to a local variable. Signed-off-by: Devendra Naga --- drivers/staging/ced1401

[PATCH V2 1/4] staging: ced1401: fix a frame size warning

gcc/sparse complain about the following: drivers/staging/ced1401/ced_ioc.c:931:1: warning: the frame size of 4144 bytes is larger than 2048 bytes [-Wframe-larger-than=] Fix it by dynamically allocating it. Signed-off-by: Devendra Naga --- V2: take care of Dan Carpenter's comments dr

[PATCH 4/4] staging: ced1401: remove kernel version ifdef 's

We dont need these kernel versioning checks anyways. Signed-off-by: Devendra Naga --- drivers/staging/ced1401/usb1401.c | 24 1 file changed, 24 deletions(-) diff --git a/drivers/staging/ced1401/usb1401.c b/drivers/staging/ced1401/usb1401.c index 8198268..a8e3498

[PATCH 3/4] staging: ced1401: fix some style warnings

this fixes: comments to in kernel comment style the opening brace of if statement must be beside the if not below to it Signed-off-by: Devendra Naga --- drivers/staging/ced1401/usb1401.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/ced1401/usb1401.c

[PATCH 2/4] staging: ced1401: remove an obvious commit about the minor number

in disconnect we assign the device minor number from the interface pointer to the localvarible minor, and then print it at the end, this code seems self explanatory so remove the comment of assigning the minor number to a local variable. Signed-off-by: Devendra Naga --- drivers/staging/ced1401

[PATCH 1/4] staging: ced1401: fix a frame size warning

gcc/sparse complain about the following: drivers/staging/ced1401/ced_ioc.c:931:1: warning: the frame size of 4144 bytes is larger than 2048 bytes [-Wframe-larger-than=] fix it by using a pointer of the TGET_TX_BLOCK struct Signed-off-by: Devendra Naga --- drivers/staging/ced1401/ced_ioc.c

[RFC] staging: slicoss: remove assert macro

remove the ASSERT() macro and all of its calls altogether, there is a minor problem, that i fixed too in this patch. the problem is we try to request_firmware a file name "", which fail eventually, instead we should fail at the default case returning -ENOENT. Signed-off-by: Dev

[PATCH] staging: crystalhd: fix a style warning

we dont need braces around a single statement blocks style WARNINGS: drivers/staging/crystalhd/crystalhd_cmds.c:311: WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Devendra Naga --- drivers/staging/crystalhd/crystalhd_cmds.c |4 ++-- 1 file changed, 2

[PATCH 3/3] staging: rtl8712: fix foo* bar (foo*) errors reported by checkpatch

: ERROR: "foo * bar" should be "foo *bar" drivers/staging/rtl8712/rtl871x_security.c:1371: ERROR: "(foo*)" should be "(foo *)" Signed-off-by: Devendra Naga --- drivers/staging/rtl8712/rtl871x_security.c |8 1 files changed, 4 insertions(+), 4 deletion

[PATCH 2/3] staging: rtl8712: fix a foo * bar errors reported by checkpatch

fixes the following error: drivers/staging/rtl8712/rtl8712_xmit.c:379: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Devendra Naga --- drivers/staging/rtl8712/rtl8712_xmit.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dri

[PATCH 1/3] staging: rtl8712: remove assignment of 0 to a static global variable

fixes the following checkpatch warning: drivers/staging/rtl8712/os_intfs.c:99: ERROR: do not initialise statics to 0 or NULL as statics are always initialised to 0. Signed-off-by: Devendra Naga --- drivers/staging/rtl8712/os_intfs.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

[PATCH] staging:ced1401: remove read write callbacks from fops

As the driver says that read and writes should not be performed and instead the user to kernel transactions are performed through ioctl interface, remove these functions as they are not required Signed-off-by: Devendra Naga --- drivers/staging/ced1401/usb1401.c | 20 1

[PATCH] staging:ced1401: use module_usb_driver macro

the module init and exit functions that are doing usb_register and usb_deregister respectively can be replaced with module_usb_driver code Signed-off-by: Devendra Naga --- drivers/staging/ced1401/usb1401.c | 16 +--- 1 files changed, 1 insertions(+), 15 deletions(-) diff --git a

[PATCH V3] staging: sbe-2t3e3: use -ve error return codes in dc_init_descriptor_list

dc_init_descriptor_list static as its never called anywhere except in this file and move the function prototype from the headerfile into the c file as its referred only in this c file. Signed-off-by: Devendra Naga --- V3: Address Dan's comments about the u32 return type (should be int as w

  1   2   3   >